[Freeciv-Dev] [bug #18835] Make many diplomacy dialogs easier to manage (e.g. using vertical tabs)

Update of bug #18835 (project freeciv): Status: Ready For Test => Fixed Open/Closed:Open => Closed ___ Follow-up Comment #63: after the gtk3 ve

[Freeciv-Dev] [bug #18835] Make many diplomacy dialogs easier to manage (e.g. using vertical tabs)

Follow-up Comment #56, bug #18835 (project freeciv): > > Likely unrelated, but as this patch dropped mnemonics in a few places, why is it > > still calling gtk_image_menu_item_new_with_mnemonic or setting > > "use-underline" there ? > > I will check this. Fixed in the new file (3). I will co

[Freeciv-Dev] [bug #18835] Make many diplomacy dialogs easier to manage (e.g. using vertical tabs)

Follow-up Comment #55, bug #18835 (project freeciv): I did found an small bug in the patch - there is an unused variable, which is fixed in this updated version of the 3rd file. > Likely unrelated, but as this patch dropped mnemonics in a few places, why is it > still calling gtk_image_menu_item

[Freeciv-Dev] [bug #18835] Make many diplomacy dialogs easier to manage (e.g. using vertical tabs)

Follow-up Comment #54, bug #18835 (project freeciv): Likely unrelated, but as this patch dropped mnemonics in a few places, why is it still calling gtk_image_menu_item_new_with_mnemonic or setting "use-underline" there ? As for the gtk3 warnings, initially I thought it's something regarding the

[Freeciv-Dev] [bug #18835] Make many diplomacy dialogs easier to manage (e.g. using vertical tabs)

Update of bug #18835 (project freeciv): Planned Release:2.4.0, 2.3.2 => 2.4.0, 2.3.2, 2.5.0 ___ Follow-up Comment #53: commited to S2_3, S2_4 and trunk; the ticket is not closed as the gtk3 version is missing. It

[Freeciv-Dev] [bug #18835] Make many diplomacy dialogs easier to manage (e.g. using vertical tabs)

Follow-up Comment #43, bug #18835 (project freeciv): version for gtk3 (it does apply; not compile tested) - only patch 1 had to be changed (gtk2 => gtk3 in strings) (file #14575, file #14576, file #14577) ___ Additional Item Attachment:

[Freeciv-Dev] [bug #18835] Make many diplomacy dialogs easier to manage (e.g. using vertical tabs)

Follow-up Comment #42, bug #18835 (project freeciv): > Can these patches be applied to gtk3 I would have tested if it compiles, but patch doesn't even apply to (S2_4) gtk3-client. ___ Reply to this item at:

[Freeciv-Dev] [bug #18835] Make many diplomacy dialogs easier to manage (e.g. using vertical tabs)

Update of bug #18835 (project freeciv): Severity:1 - Wish => 3 - Normal Planned Release: 2.4.0, 2.3.2? => 2.4.0, 2.3.2 ___ Follow-up Comment #41: updated patch fil

[Freeciv-Dev] [bug #18835] Make many diplomacy dialogs easier to manage (e.g. using vertical tabs)

Follow-up Comment #40, bug #18835 (project freeciv): > Can't break it now; thanks. OK; this will be commited as soon as 2.3.1 is released ___ Reply to this item at: _

[Freeciv-Dev] [bug #18835] Make many diplomacy dialogs easier to manage (e.g. using vertical tabs)

Follow-up Comment #39, bug #18835 (project freeciv): Can't break it now; thanks. ___ Reply to this item at: ___ Message sent via/by Gna! http://gna.org/ ___

[Freeciv-Dev] [bug #18835] Make many diplomacy dialogs easier to manage (e.g. using vertical tabs)

Follow-up Comment #38, bug #18835 (project freeciv): Thanks for testing; here are two small fixes on top of the last patches: > New bug (may have existed in previous patch): clicking the "x" > button on the overall "Diplomacy [N]" tab has no effect. It's new bug - I did change the handling of th

[Freeciv-Dev] [bug #18835] Make many diplomacy dialogs easier to manage (e.g. using vertical tabs)

Follow-up Comment #37, bug #18835 (project freeciv): Thanks for the detailed description! I will have time to test this on Sunday evening. ___ Reply to this item at:

[Freeciv-Dev] [bug #18835] Make many diplomacy dialogs easier to manage (e.g. using vertical tabs)

Follow-up Comment #36, bug #18835 (project freeciv): I've tested the latest patches on trunk r20527. Results: * Closing individual meeting tab with ESC trouble (comment #26) is fixed * Detaching individual meeting tab trouble (comment #30) is fixed * Detaching overall "Diplomacy [N]" tab from mai

[Freeciv-Dev] [bug #18835] Make many diplomacy dialogs easier to manage (e.g. using vertical tabs)

Follow-up Comment #35, bug #18835 (project freeciv): I think this patch set is working fine and an improvement if playing with a large number of nations. Now to the question: there and when should this patch be applied? * S2_3: Not for 2.3.1 but for the next release - so after 2.3.1 has taged.

[Freeciv-Dev] [bug #18835] Make many diplomacy dialogs easier to manage (e.g. using vertical tabs)

Follow-up Comment #34, bug #18835 (project freeciv): and the patch file missing in comment #32 (file #14456) ___ Additional Item Attachment: File name: 0004-gtk2-redo-layout-of-the-diplomacy-dialog-vertical.patch Size:19 KB

[Freeciv-Dev] [bug #18835] Make many diplomacy dialogs easier to manage (e.g. using vertical tabs)

Follow-up Comment #33, bug #18835 (project freeciv): and a screenshoot - I hope there a no bug left! Any further ideas? On problem is that the count (Diplomacy [x]) will not be updated if a meeting tab is detached. But I think this will not be used often. (file #14455) _

[Freeciv-Dev] [bug #18835] Make many diplomacy dialogs easier to manage (e.g. using vertical tabs)

Follow-up Comment #32, bug #18835 (project freeciv): updated version (includes patches from comment #31): [gtk2] redo layout of the diplomacy dialog (vertical) see gna bug #18835 (part 3) changes 20111029: - put content of the diplomatic tab into a scroll window else the height of the window

[Freeciv-Dev] [bug #18835] Make many diplomacy dialogs easier to manage (e.g. using vertical tabs)

Follow-up Comment #31, bug #18835 (project freeciv): Could you test the two attached patches on top of the patches listed in comment #24? 0005-gtk2-fix-short-keys-in-diplotic-dialog.patch => fix keyboard shortcuts; (Re)add buttons for each meetings dialog (ineeded if it is separated) 0006-gtk2-

[Freeciv-Dev] [bug #18835] Make many diplomacy dialogs easier to manage (e.g. using vertical tabs)

Follow-up Comment #30, bug #18835 (project freeciv): For the avoidance of doubt: in coment #25 I was talking about detaching the whole "Diplomacy [N]" tab from the main tab notebook by double-clicking on "Diplomacy [N]". It hadn't even occurred to me that the tabs for individual meetings could b

[Freeciv-Dev] [bug #18835] Make many diplomacy dialogs easier to manage (e.g. using vertical tabs)

Follow-up Comment #29, bug #18835 (project freeciv): > Er, and I meant to say, it looks fine to me in all those > layouts. Thanks for testing this! About the bugs: > If I detach the "Diplomacy [N]" tab as a separate window and > then close it: > > Unlike other tabs, it doesn't go back into the

[Freeciv-Dev] [bug #18835] Make many diplomacy dialogs easier to manage (e.g. using vertical tabs)

Follow-up Comment #28, bug #18835 (project freeciv): Er, and I meant to say, it looks fine to me in all those layouts. ___ Reply to this item at: ___ Message se

[Freeciv-Dev] [bug #18835] Make many diplomacy dialogs easier to manage (e.g. using vertical tabs)

Follow-up Comment #27, bug #18835 (project freeciv): > Please also check differen screen layouts as part 4 changes the > rrangement of the elements. Does it is OK for small screens, > widescreens, etc. Here are some screenshots with various layout options. In each case, the window is shrunk as

[Freeciv-Dev] [bug #18835] Make many diplomacy dialogs easier to manage (e.g. using vertical tabs)

Additional Item Attachment, bug #18835 (project freeciv): File name: big-merged.png Size:70 KB File name: big-separate.png Size:97 KB File name: big-split.png Size:103 KB File name: detached.png Size:61 KB

[Freeciv-Dev] [bug #18835] Make many diplomacy dialogs easier to manage (e.g. using vertical tabs)

Additional Item Attachment, bug #18835 (project freeciv): File name: small-merged.png Size:64 KB File name: small-separate.png Size:111 KB File name: small-split.pngSize:109 KB ___ Reply to this i

[Freeciv-Dev] [bug #18835] Make many diplomacy dialogs easier to manage (e.g. using vertical tabs)

Follow-up Comment #26, bug #18835 (project freeciv): > (I think I've got into a situation with symptom 2 but without > the segfault for new meetings, as well, but I don't know how I > did that.) Figured it out. Pressing "Esc" while on the "Diplomacy [N]" tab closes the current meeting and chang

[Freeciv-Dev] [bug #18835] Make many diplomacy dialogs easier to manage (e.g. using vertical tabs)

Update of bug #18835 (project freeciv): Planned Release: 2.4.0, 2.3.1? => 2.4.0, 2.3.2? ___ Follow-up Comment #25: Playing with the patch, it looks good. I think it could go to S2_3, but at this point I think

[Freeciv-Dev] [bug #18835] Make many diplomacy dialogs easier to manage (e.g. using vertical tabs)

Update of bug #18835 (project freeciv): Status: In Progress => Ready For Test ___ Follow-up Comment #24: update the last part of the patch - part 1: file #14294 - part 2: file #14295 - part 3: new

[Freeciv-Dev] [bug #18835] Make many diplomacy dialogs easier to manage (e.g. using vertical tabs)

Follow-up Comment #23, bug #18835 (project freeciv): have to say the vertical thing is *much* preferable to the horizontal tabs for large numbers of nations. the vertical scroll thing is slightly annoying, but if playing with a mouse is tolerable. (I don't think the UI has enough room for a secon

[Freeciv-Dev] [bug #18835] Make many diplomacy dialogs easier to manage (e.g. using vertical tabs)

Follow-up Comment #22, bug #18835 (project freeciv): Thanks for the link to bug #18781, i'm now cc'd. I'll download the patch and try it out today. ___ Reply to this item at: ___

[Freeciv-Dev] [bug #18835] Make many diplomacy dialogs easier to manage (e.g. using vertical tabs)

Update of bug #18835 (project freeciv): Status: Ready For Test => In Progress ___ Follow-up Comment #21: > By the way, saving that freeciv save file i notice that it > truncates out everything after

[Freeciv-Dev] [bug #18835] Make many diplomacy dialogs easier to manage (e.g. using vertical tabs)

Follow-up Comment #20, bug #18835 (project freeciv): By the way, saving that freeciv save file i notice that it truncates out everything after the first '.'. Is that a known bug, or should i open a ticket? (the original name was freeciv2.3.0-hacked) __

[Freeciv-Dev] [bug #18835] Make many diplomacy dialogs easier to manage (e.g. using vertical tabs)

Follow-up Comment #19, bug #18835 (project freeciv): Looks like the debian patch regarding unity was the cause. switched your new patch to the top of the patch que, disabled the unity patch and it built. And works :) It looks good, just wondering if what i'm seeing is specific to my screen. I'v

[Freeciv-Dev] [bug #18835] Make many diplomacy dialogs easier to manage (e.g. using vertical tabs)

Follow-up Comment #18, bug #18835 (project freeciv): I did had a look into the debian patches - they do not change much. The attched file is for 2.3.0 and tested ... Please report how it works / looks like in non-default settings (small screen, ...) (file #14360) ___

[Freeciv-Dev] [bug #18835] Make many diplomacy dialogs easier to manage (e.g. using vertical tabs)

Follow-up Comment #17, bug #18835 (project freeciv): I added it last in the patch series the 2.3.0 debian patches have. (Its entirely possible one of those is buggering things up, as we have various patches applied to the client UIs). http://anonscm.debian.org/gitweb/?p=pkg-games/freeciv.git;a=t

[Freeciv-Dev] [bug #18835] Make many diplomacy dialogs easier to manage (e.g. using vertical tabs)

Follow-up Comment #16, bug #18835 (project freeciv): > Unfortunately the UI doesn't appear to have changed. Did i need > to apply other patches too? I did check if the patch applies to the current S2_3 branch. You have a plain 2.3.0 source tarball? __

[Freeciv-Dev] [bug #18835] Make many diplomacy dialogs easier to manage (e.g. using vertical tabs)

Follow-up Comment #15, bug #18835 (project freeciv): Based on the debian 2.3.0 packaging I tried to build a package with the all in one dipl patch applied. I've had to modify the patch to cityrep.c diff a little, but it compiled up with the changes. Unfortunately the UI doesn't appear to have cha

[Freeciv-Dev] [bug #18835] Make many diplomacy dialogs easier to manage (e.g. using vertical tabs)

Follow-up Comment #14, bug #18835 (project freeciv): > Re comment #9: off-hand, I don't see why this would need to be > optional. But I haven't checked all layout variants. I'm not sure about all the possible layout variants; especially as we did lot to support small screens. But if it is working

[Freeciv-Dev] [bug #18835] Make many diplomacy dialogs easier to manage (e.g. using vertical tabs)

Update of bug #18835 (project freeciv): Summary: please support vertical tabs => Make many diplomacy dialogs easier to manage (e.g. using vertical tabs) ___ Reply to this item at: