[Freeciv-Dev] [bug #21507] Finer controll of ZoC

Update of bug #21507 (project freeciv): Status: Ready For Test => Fixed Open/Closed:Open => Closed ___ Follow-up Comment #28: Your patch is now

[Freeciv-Dev] [bug #21507] Finer controll of ZoC

Follow-up Comment #26, bug #21507 (project freeciv): New version * generated help text: "has no zone of control" -> "imposes no zone of control" as Jacob suggested * generated help text: Specify that it imposes no zone of control on its adjacent tiles to avoid confusion. (file #20089) __

[Freeciv-Dev] [bug #21507] Finer controll of ZoC

Follow-up Comment #25, bug #21507 (project freeciv): Well whatever I give up on this semantic. ___ Reply to this item at: ___ Message sent via/by Gna! http://g

[Freeciv-Dev] [bug #21507] Finer controll of ZoC

Follow-up Comment #24, bug #21507 (project freeciv): > However, would "This unit imposes no zone of control" be clearer? I think it sounds better. > All cells around unit have controll, as they are all cells, thus no zones. You have the same problem with plural. A user that is told that a unit ha

[Freeciv-Dev] [bug #21507] Finer controll of ZoC

Follow-up Comment #23, bug #21507 (project freeciv): Calling whole map spanning non contiguos cells as single zone of controll seems to be a strech. As most often there are multiple disjoint sets of cells "under controll by certain player" I do not see how singular is appropriate here. Also this i

[Freeciv-Dev] [bug #21507] Finer controll of ZoC

Follow-up Comment #22, bug #21507 (project freeciv): I like to contradict here. First of all, it's zone, not zones. Every and each player (representing a nation) has one zone of control, which is imposed by his units and cities. So, neither units have their own zones of control nor has unit zones

[Freeciv-Dev] [bug #21507] Finer controll of ZoC

Follow-up Comment #21, bug #21507 (project freeciv): _So, in the help message "This unit has no zone of control, [...]" I think the singular is appropriate. _ I would argue that since unit does not affect single cell, but all cells around it plural is more appropriate. Since singulare can create

[Freeciv-Dev] [bug #21507] Finer controll of ZoC

Follow-up Comment #20, bug #21507 (project freeciv): I think it's as Sveinung said in comment #13: each unit has a zone of control (comprising all the tiles around it). Most existing usage of the term is correctly plural because it's talking about other units' zones effect on your unit. So, in th

[Freeciv-Dev] [bug #21507] Finer controll of ZoC

Follow-up Comment #19, bug #21507 (project freeciv): > I would suggest consulting with jtn (as he is native english speaker) Great idea. jtn: Any comment on (unit has) "zone of control" vs "zones of control"? ___ Reply to this item at:

[Freeciv-Dev] [bug #21507] Finer controll of ZoC

Follow-up Comment #18, bug #21507 (project freeciv): I would suggest consulting with jtn (as he is native english speaker) on '"zones of control" => "zone of control"' becaus really zones seems more approporiate and consistent with "ignores zones of controll".

[Freeciv-Dev] [bug #21507] Finer controll of ZoC

Update of bug #21507 (project freeciv): Status: In Progress => Ready For Test ___ Follow-up Comment #17: The status of this patch just changed to "Ready for test". It can therefore be committed in 36

[Freeciv-Dev] [bug #21507] Finer controll of ZoC

Follow-up Comment #16, bug #21507 (project freeciv): > (...) the way I understood HasZOC was my own brainfart following from the knowing internal workings of the code too well. Reading your feed back caused me to assume the existence of some foreign language with a mapping of the English term "has

[Freeciv-Dev] [bug #21507] Finer controll of ZoC

Follow-up Comment #15, bug #21507 (project freeciv): To be honest, it now seems that the way I understood HasZOC was my own brainfart following from the knowing internal workings of the code too well. Player is the owner of the ZOC, so literal ZOC ownership for the unit didn't register to me at al

[Freeciv-Dev] [bug #21507] Finer controll of ZoC

Follow-up Comment #14, bug #21507 (project freeciv): Seems like I sent my previous comment a bit early. Sorry. > The unit has a zone of control that includes all the tiles it controls. But do I realize you could argue that one tile is one zone. > The other lines have a tab. A tab between the nam

[Freeciv-Dev] [bug #21507] Finer controll of ZoC

Follow-up Comment #13, bug #21507 (project freeciv): > And it is used like this in most places The unit has a zone of control that includes all the tiles it controls. One enemy unit has a zone of control. Many enemy units have zones of control. A unit with IgZoc ignore the zones of control of all

[Freeciv-Dev] [bug #21507] Finer controll of ZoC

Update of bug #21507 (project freeciv): Category:rulesets => general Planned Release: => 2.6.0 ___ Reply to this item at:

[Freeciv-Dev] [bug #21507] Finer controll of ZoC

Follow-up Comment #12, bug #21507 (project freeciv): One style nitpick: is_my_zoc() has no empty line between variable declarations (only ounit there) and functional code. ___ Reply to this item at:

[Freeciv-Dev] [bug #21507] Finer controll of ZoC

Follow-up Comment #11, bug #21507 (project freeciv): _In the auto generated help text: "zones of control" => "zone of control"_ No just a line above: _Ignores zone*s* of control._ And it is used like this in most places, if you still do not agree you can chage it. _In the auto generated help text

[Freeciv-Dev] [bug #21507] Finer controll of ZoC

Follow-up Comment #10, bug #21507 (project freeciv): > Has and Causes, same as Ignores and NotAffected are almost > identical with regards to clarity (besides neve ever I head > such use "causes zones of control", not affected is less odd, > but still totaly clear in my opinion), only second ones

[Freeciv-Dev] [bug #21507] Finer controll of ZoC

Follow-up Comment #9, bug #21507 (project freeciv): _I think Windows users are actually our biggest end-user group nowadays. And for casual Windows user notepad and wordpad are the only ASCII editors._ First I would find quite unlikelly that casual user would be editing rulesets, second even assu

[Freeciv-Dev] [bug #21507] Finer controll of ZoC

Follow-up Comment #8, bug #21507 (project freeciv): > review of file #20018 I missed one. Sorry: * data/helpdata.txt should be updated ___ Reply to this item at: ___

[Freeciv-Dev] [bug #21507] Finer controll of ZoC

Follow-up Comment #7, bug #21507 (project freeciv): Review of file #20018 * Marko is right that the flag name could be clearer. * In the auto generated help text: "zones of control" => "zone of control" * In the auto generated help text: missing space between "it" (before your line break) and "

[Freeciv-Dev] [bug #21507] Finer controll of ZoC

Follow-up Comment #6, bug #21507 (project freeciv): > You mean changing the rulesets, or is there something missing in ruleset format level? I don't know what he meant but zoc creation has a hard coded rule that ignores the zoc if the source tile or the target tile is_ocean_tile(). See common/mov

[Freeciv-Dev] [bug #21507] Finer controll of ZoC

Follow-up Comment #5, bug #21507 (project freeciv): > and not ms notepad or such I think Windows users are actually our biggest end-user group nowadays. And for casual Windows user notepad and wordpad are the only ASCII editors. Maybe changing the flag name to something that makes it obvious w

[Freeciv-Dev] [bug #21507] Finer controll of ZoC

Update of bug #21507 (project freeciv): Status:None => In Progress Assigned to:None => sveinung ___ Follow-up Comment #4: > I added new patch

[Freeciv-Dev] [bug #21507] Finer controll of ZoC

Follow-up Comment #3, bug #21507 (project freeciv): I added new patch with comments reidented, and included rescription in "all" rulesets. I also have some comments, suggestions: why use inconsistent indentation in code and rulesets (code -> spaces over tabs, ruleset tabs over spaces)? I see no

[Freeciv-Dev] [bug #21507] Finer controll of ZoC

Follow-up Comment #2, bug #21507 (project freeciv): Thank you for your patch, Edgaras. I had a superficial look at it. I was planning to go in depth before giving feed back. Since I haven't done that yet I figured it was better to list the issues I was able to spot so you at least got some feed ba

Re: [Freeciv-Dev] [bug #21507] Finer controll of ZoC

Edgaras Šeputis wrote on Jan 18, 13:30 (+0100): > I find it very annoying how accidentaly or not your early settlers can be > pined down by exploerer. I see no reason why workers, settlers and exploerers > should have ZoC, but nether any reason why they should ignore it when it comes > from milita

[Freeciv-Dev] [bug #21507] Finer controll of ZoC

Follow-up Comment #1, bug #21507 (project freeciv): I created patches for this feature. Firs one is implementation of feature itself. Second one is change to experimental ruleset, I added this new flag HasNoZOC to units for which I think it is approporiate. Though description of the tag in ruleset

[Freeciv-Dev] [bug #21507] Finer controll of ZoC

URL: Summary: Finer controll of ZoC Project: Freeciv Submitted by: morphles Submitted on: Sat Jan 18 12:30:02 2014 Category: rulesets Severity: 3 - Normal Priori