Update of patch #2019 (project freeciv):
Planned Release: 2.3.0 = 2.4.0
___
Follow-up Comment #20:
update target to freeciv 2.4.0
___
Update of patch #2019 (project freeciv):
Status: In Progress = Ready For Test
___
Follow-up Comment #18:
cleanup patch:
* remove changes to shared.(ch); they are included in bug #16887
(file
Follow-up Comment #19, patch #2019 (project freeciv):
update due to changes in bug #16887
(file #10849)
___
Additional Item Attachment:
File name: 20101020.1-09-trunk--mapimg-map-image-support-for-the-client.patch
Size:51 KB
Follow-up Comment #17, patch #2019 (project freeciv):
There is a small bug in the implementation of the new dialogs.
If one does not clicks 'save' but hits enter in the file name
text box, the client crashs. I did add an assert (see
error.diff) and pdialog is NULL at this point...
My
Follow-up Comment #11, patch #2019 (project freeciv):
updated patch; changes:
* include gui changes by pepeto (save dialog)
* rename some functions as mapimg_*()
* display only files in the current directory
It reads the files from the save directories, but saves them
in the current
Update of patch #2019 (project freeciv):
Status: In Progress = Ready For Test
Depends on: = bugs #16887
___
Reply to this item at:
Follow-up Comment #12, patch #2019 (project freeciv):
Patch attached:
Thanks for sorting out the different 'save as' dialogs!
___
Reply to this item at:
http://gna.org/patch/?2019
___
Follow-up Comment #13, patch #2019 (project freeciv):
There is a small bug in the implementation of the new dialogs. If one does
not clicks 'save' but hits enter in the file name text box, the client
crashs. I did add an assert (see error.diff) and pdialog is NULL at this
point ...
(file
Follow-up Comment #14, patch #2019 (project freeciv):
display only files in the current directory.
Should the client only read and write on the current directory? I doubt this
is the expected behaviour. I should probably used the save dirs? Or implement
a image directory handler?
Update of patch #2019 (project freeciv):
Status: Ready For Test = In Progress
___
Follow-up Comment #15:
Should the client only read and write on the current
directory? I doubt this is the
Follow-up Comment #10, patch #2019 (project freeciv):
Patch attached:
* Use client_is_global_observer() instead of client_is_observer() when needed
because client_is_observer() also handle connection observing a single player
(TRUE == pconn-observer NULL != pconn-playing).
* Fixed the usage of
Follow-up Comment #7, patch #2019 (project freeciv):
(Have a look to the newly-written modules: vote bar, and
reports notably).
I will check it but it will need time; The mapimg patch series can be applied
without this patch. Thus, only the possibility to save a map image from the
client
Follow-up Comment #8, patch #2019 (project freeciv):
I also can propose you to work on it next saturday.
___
Reply to this item at:
http://gna.org/patch/?2019
___
Message posté via/par
Follow-up Comment #9, patch #2019 (project freeciv):
I also can propose you to work on it next saturday.
I would appreciate this. I could try to code the dialogs but I don't think I
can get the quality of your code.
The function to request the creation of a map image would be 'bool
Follow-up Comment #1, patch #2019 (project freeciv):
updated version
(file #10746)
___
Additional Item Attachment:
File name: 20101012-09-trunk-map-image-support-for-the-client.patch Size:29
KB
Follow-up Comment #2, patch #2019 (project freeciv):
I really don't like the gtk2 style used like a static module. I have rewrite
the most of the report using very more flexible ways, this is a step behind.
___
Reply to this item at:
Follow-up Comment #3, patch #2019 (project freeciv):
I really don't like the gtk2 style used like a static module.
I have rewrite the most of the report using very more flexible
ways, this is a step behind.
Could you explain that you mean? I'm not familiar with gtk2 (or any of the
other
Follow-up Comment #4, patch #2019 (project freeciv):
You are sharing static datas in the files that are not needed. A good design
would be to only use one only reference (probably in mapimg_dialog_popup())
to a GtkWidget. mapimg_dialog_new() should return the created GtkWidget, not
sharing
Follow-up Comment #5, patch #2019 (project freeciv):
Thanks for the hints. I will try to rewrite the code. At the moment it is a
copy of the code for the 'Save as' dialog ...
___
Reply to this item at:
http://gna.org/patch/?2019
Follow-up Comment #6, patch #2019 (project freeciv):
(Have a look to the newly-written modules: vote bar, and reports notably).
___
Reply to this item at:
http://gna.org/patch/?2019
___
URL:
http://gna.org/patch/?2019
Summary: [mapimg] map image support for the client
Project: Freeciv
Submitted by: syntron
Submitted on: Sonntag 03.10.2010 um 18:40
Category: client
Priority: 5 - Normal
21 matches
Mail list logo
