Update of patch #2061 (project freeciv):
Status: Ready For Test = Done
Open/Closed:Open = Closed
___
Reply to this item at:
Update of patch #2061 (project freeciv):
Status: In Progress = Ready For Test
___
Follow-up Comment #34:
got a working version - not nicebut working ...
* fix xaw client: create_sprite() function
*
Follow-up Comment #35, patch #2061 (project freeciv):
go ahead with the commit, I will look into it if there are any breaks.
currently busy with the office work :(
___
Reply to this item at:
http://gna.org/patch/?2061
Follow-up Comment #36, patch #2061 (project freeciv):
add dummy create_sprite() function to qt client
go ahead with the commit, I will look into it if there are any
breaks.
currently busy with the office work :(
Thanks for the heads up - I tested it quit carefully. It should work but
Follow-up Comment #37, patch #2061 (project freeciv):
add dummy create_sprite() function to qt client
As this is expected to be non-mangled symbol it should be added to
qtg_cside.c, not to C++ code in sprite.cpp.
FYI I'm going to commit Qt sprite implementation patch #2388 in a couple of
Follow-up Comment #38, patch #2061 (project freeciv):
As this is expected to be non-mangled symbol it should be added
to qtg_cside.c, not to C++ code in sprite.cpp.
Done
(file #12096)
___
Additional Item Attachment:
File name:
Follow-up Comment #33, patch #2061 (project freeciv):
I would like to commit this patch set - but it breaks the xaw client. How
should I proceed?
___
Reply to this item at:
http://gna.org/patch/?2061
Follow-up Comment #32, patch #2061 (project freeciv):
I did try again yesterday but I do not get it. With only patch #2060 the xaw
client is working while this patch results in a crash (sdl and gtk work). The
only xaw specific change is the added function create_sprite but the error
seems to be
Follow-up Comment #29, patch #2061 (project freeciv):
this new patch is not crashing... did anything change?
___
Reply to this item at:
http://gna.org/patch/?2061
___
Message sent via/by
Follow-up Comment #31, patch #2061 (project freeciv):
this new patch is not crashing... did anything change?
I still have the same crash (trunk + patch #2060 + this one + patch #2313)
___
Reply to this item at:
Follow-up Comment #26, patch #2061 (project freeciv):
I found again some time - the create_sprite() function I created for xaw
seems to be the cause for the crash. If it is deactivated the client starts.
Perhaps you can write a better function which creates a pixmap of the default
size with the
Follow-up Comment #27, patch #2061 (project freeciv):
can you rebase this patch again, I am unable to apply it and compile with the
recent server changes.
___
Reply to this item at:
http://gna.org/patch/?2061
Follow-up Comment #28, patch #2061 (project freeciv):
rebased to current trunk
(file #11873)
___
Additional Item Attachment:
File name: 20110114-mapimg02-define-player-colors-in-the-ruleset.patch
Size:61 KB
Follow-up Comment #20, patch #2061 (project freeciv):
somehow this seems to be a sprite loading issue with the xaw client.
With the amplio tile set its problem with the ocean.png
With trident tile set its problem with the units.png
We need to investigate this one, completely weird issue.
Follow-up Comment #21, patch #2061 (project freeciv):
havent tested it yet, and with patch 3 try to compile the sdl.
There might be issue with SDL client
Could it be bug #17475? Marko Lindqvist posted a bug fix for it. A similar
one is also include in this patch.
somehow this seems to be a
Follow-up Comment #22, patch #2061 (project freeciv):
We need to investigate the load_sprite function.
Its failing in that for the given sprites, I also have to see the changes
introduced in this patch set.
If you could commit the patch 03 would be great.
I will try to remove the patch 03 and
Follow-up Comment #23, patch #2061 (project freeciv):
I prefer to commit patch #2060, this patch and patch #2313 in one step as the
first two change a lot of capabilities (network, ruleset and tileset) and the
last one changes the capability strings.
Compiling with mapimg03 (patch #2060) should
Follow-up Comment #24, patch #2061 (project freeciv):
The function load_sprite() (in ./client/tilespec.c:1869) is used by all
clients. Also it is not modified by this patch and not called within the xaw
specific code. What could be the reason for this function to fail after the
patch?
# ./civ
Follow-up Comment #25, patch #2061 (project freeciv):
for the terrain patch issues, attach the bug reports to the corresponding
patch. I shall look into them. I will try to fix those errors first. The
player colors patch will continously be tested
Follow-up Comment #19, patch #2061 (project freeciv):
havent tested it yet, and with patch 3 try to compile the sdl.
There might be issue with SDL client
___
Reply to this item at:
http://gna.org/patch/?2061
Update of patch #2061 (project freeciv):
Summary: [mapimg] define player colors in the ruleset =
[mapimg04] define player colors in the ruleset
___
Follow-up Comment #17:
rebased patch
(file #11334)
21 matches
Mail list logo
