Re: [Freecol-developers] Patch for bug #2506

2013-02-10 Thread Jonathan Simona
Hmm this is strange, my newest patch should have had a highly reduced number of variables in the formula but still, much of what you said is true. For the most part, the formula for my calculations should look something like this: "tileY = (y / tileSize * MIN_TILE_SIZE);" rather than that admitted

Re: [Freecol-developers] Desktop entry file

2013-02-10 Thread Pedro Rodrigues
On Sat, Feb 9, 2013 at 8:33 AM, Michael Vehrs wrote: > > However, I don't know whether I will be able to actually test Windows > features. > I can test them. -- Free Next-Gen Firewall Hardware Offer Buy your Sophos next-g

Re: [Freecol-developers] Patch for bug #2506

2013-02-10 Thread Pedro Rodrigues
On Sun, Feb 10, 2013 at 12:18 AM, Jonathan Simona wrote: > I think that I finally solved, well pretty much solved, the minimap bug. I > cut down much of the formula to just the bare minimum but still had to keep > 1 magic number because it was part of the original code. My patch > acceptance is du

Re: [Freecol-developers] Patch for bug #2506

2013-02-10 Thread Michael Vehrs
On 10.02.2013 01:18, Jonathan Simona wrote: > I think that I finally solved, well pretty much solved, the minimap > bug. I cut down much of the formula to just the bare minimum but still > had to keep 1 magic number because it was part of the original code. > My patch acceptance is due this Mond

[Freecol-developers] Generalized production element

2013-02-10 Thread Michael Vehrs
I have committed a change that introduces a new generalized production element, but does not yet make use of its new features. I tried to preserve compatibility as far as possible. However, this might be a good time to standardize all elements that wrap AbstractGoods in some way or other. Any o