Re: [Freecol-developers] First Successful Merge Request completed

2015-04-06 Thread Caleb Williams
Excellent point and one i had not considered. From an Anglocentric point of view, it makes sense, but perhaps not in other languages. I can look at the sting file later on and see what there is to see there. Best, Caleb On Apr 7, 2015 1:31 AM, wrote: > > Hi, > > just saw you wrote something whi

Re: [Freecol-developers] First Successful Merge Request completed

2015-04-06 Thread winter
Hi,   just saw you wrote something while I was working on your merge requests. In terms of internationalization it is bad to programmatically change any string, because different languages have different, sometimes strange rules. How will you capitalize, for example, Chinese? The way of doin

Re: [Freecol-developers] First Successful Merge Request completed

2015-04-06 Thread Caleb Williams
All: Based on WT's non-public comment on the issue, SF's Git integration seems problematic to say the least. I submitted a few MR's tonight and #29 combines all three, so please push that one of any of them. Sorry for the confusion. You'll notice that the above MR attempts to add commons-l