Re: [Freecol-developers] emails from patches

2017-02-13 Thread Enrico Weigelt, metux IT consult
On 13.02.2017 15:06, win...@genial.ms wrote: > Hello, > > you know how that answer feels? Like talking to an old kernel hacker, who's used to cope with many and large patch queues and therefore tries to get around w/ minimal bureaucracy ? :o Having to create tickets and copy-paste patches on so

[Freecol-developers] fcgo serialization and sorting

2017-02-13 Thread Enrico Weigelt, metux IT consult
Hi folks, I've seen lots of places where child lists (eg. Colony's WorkLocation's) are sorted before serialization. Is this really required ? --mtx -- Check out the vibrant tech community on one of the world's most eng

Re: [Freecol-developers] Indians roaming too far

2017-02-13 Thread Michael T. Pope
On Sun, 12 Feb 2017 00:14:14 +0100 Fenyo wrote: > Have you guys noticed that the indian braves can go really far away from > their home settlement? > They can go even to the other side of the map. The usual mode of operation for a native unit is to wander around looking for something to attack,

Re: [Freecol-developers] emails from patches

2017-02-13 Thread winter
Hello, you know how that answer feels? Like you only value your own time, as you don't even invest enough of it to write a tiny justification for each patch. Then it costs others about twice as much time to figure out what to do with such a patch, cause of reverse engineering the reasons you made

Re: [Freecol-developers] emails from patches

2017-02-13 Thread Enrico Weigelt, metux IT consult
On 13.02.2017 13:25, Fenyo wrote: > Hi, > > *> I don't remember ever getting so many emails from people submitting >> patches. Is there something Enrico is doing differently? > > *I was just gonna say that. > > Is it possible that Enrico should post his patches at this page?: > https://sourcefo

Re: [Freecol-developers] emails from patches

2017-02-13 Thread Fenyo
Hi, > I don't remember ever getting so many emails from people submitting > patches. Is there something Enrico is doing differently? I was just gonna say that. Is it possible that Enrico should post his patches at this page?: https://sourceforge.net/p/freecol/patches/ Regards, Fenyo--

[Freecol-developers] emails from patches

2017-02-13 Thread Michael Berger
Hi guys, I don't remember ever getting so many emails from people submitting patches. Is there something Enrico is doing differently? Thanks, Mike Berger -- Check out the vibrant tech community on one of the world's most en

[Freecol-developers] [PATCH] common: networking: ChangeSet: fix missing typecast

2017-02-13 Thread Enrico Weigelt, metux IT consult
--- src/net/sf/freecol/common/networking/ChangeSet.java | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/net/sf/freecol/common/networking/ChangeSet.java b/src/net/sf/freecol/common/networking/ChangeSet.java index 14d93a39cd7..85e82347e78 100644 --- a/src/net/sf/freecol/comm

[Freecol-developers] [PATCH] common: model: Specification: fix type mismatch

2017-02-13 Thread Enrico Weigelt, metux IT consult
compile: [javac] Compiling 374 source files to /home/nekrad/src/packaging/pkg/freecol.git/build [javac] /home/nekrad/src/packaging/pkg/freecol.git/src/net/sf/freecol/common/model/Specification.java:2013: error: incompatible types [javac] Collection allG = new HashSet<>(allOp

Re: [Freecol-developers] River styles

2017-02-13 Thread Michael T. Pope
On Sun, 12 Feb 2017 12:02:55 +1030 "Michael T. Pope" wrote: On Fri, 10 Feb 2017 22:56:50 +0100 win...@genial.ms wrote: > I upgraded the code for checking roads/rivers have no style problems, > as I had looked at it so much recently and the compat code is going > to be upgraded soon. > Its at: http

Re: [Freecol-developers] [PATCH] common: util: CollectionUtils: optimize variants of first()

2017-02-13 Thread Enrico Weigelt, metux IT consult
On 13.02.2017 11:55, Enrico Weigelt, metux IT consult wrote: > +public static T first(List l) { > +return (l == null || list.isEmpty()) ? null : l.get(0); ups, there's a typo in here ... will repost fixed patched. --mtx -

[Freecol-developers] [PATCH] common: util: CollectionUtils: optimized variants of find()

2017-02-13 Thread Enrico Weigelt, metux IT consult
--- .../sf/freecol/common/util/CollectionUtils.java| 39 ++ 1 file changed, 18 insertions(+), 21 deletions(-) diff --git a/src/net/sf/freecol/common/util/CollectionUtils.java b/src/net/sf/freecol/common/util/CollectionUtils.java index 841cf3dad2f..058835714a1 100644 --- a

[Freecol-developers] [PATCH] common: util: CollectionUtils: optimize variants of first()

2017-02-13 Thread Enrico Weigelt, metux IT consult
--- .../sf/freecol/common/util/CollectionUtils.java| 31 +++--- 1 file changed, 15 insertions(+), 16 deletions(-) diff --git a/src/net/sf/freecol/common/util/CollectionUtils.java b/src/net/sf/freecol/common/util/CollectionUtils.java index 058835714a1..4e25f7d599e 100644 --- a