Hello, you know how that answer feels? Like you only value your own time, as you don't even invest enough of it to write a tiny justification for each patch. Then it costs others about twice as much time to figure out what to do with such a patch, cause of reverse engineering the reasons you made it from the code, before verifying it actually works. I still saw no numbers from you as to how much cpu time these supposed optimization patches would conserve, and I suspect its because you still did not profile. That means we'd have to take the time to profile and most likely see no significant improvement to justify changing the code. Then if I would decide on using such a patch I personally would need to copy the text from each email out into a new file and try to apply it. Mike Pope may be able to use the emails directly, but would still have to figure all other stuff out. You could just post a link to a branch on your SF or Github fork and if its just a whole stack of related commits one posting including a link to a git repository and a few numbers would be better than a stack of emails. Even better would be if you made bugfixes instead of micro-optimizations.
Regards, wintertime > Gesendet: Montag, 13. Februar 2017 um 13:52 Uhr > Von: "Enrico Weigelt, metux IT consult" <enrico.weig...@gr13.net> > An: freecol-developers@lists.sourceforge.net > Betreff: Re: [Freecol-developers] emails from patches > > On 13.02.2017 13:25, Fenyo wrote: > > Hi, > > > > *> I don't remember ever getting so many emails from people submitting > >> patches. Is there something Enrico is doing differently? > > > > *I was just gonna say that. > > > > Is it possible that Enrico should post his patches at this page?: > > https://sourceforge.net/p/freecol/patches/ > > Far to complicated and time consuming. > > --mtx ------------------------------------------------------------------------------ Check out the vibrant tech community on one of the world's most engaging tech sites, SlashDot.org! http://sdm.link/slashdot _______________________________________________ Freecol-developers mailing list Freecol-developers@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/freecol-developers
