Re: [Freedreno] [PATCHv4 6/6] iommu: arm-smmu-impl: Remove unwanted extra blank lines

2020-09-14 Thread Sai Prakash Ranjan
On 2020-09-11 22:20, Sai Prakash Ranjan wrote: On 2020-09-11 22:04, Robin Murphy wrote: On 2020-09-11 17:21, Sai Prakash Ranjan wrote: On 2020-09-11 21:37, Will Deacon wrote: On Fri, Sep 11, 2020 at 05:03:06PM +0100, Robin Murphy wrote: BTW am I supposed to have received 3 copies of everything

Re: [Freedreno] [PATCH] drm/msm/a6xx: fix a potential overflow issue

2020-09-14 Thread Bjorn Andersson
On Sat 12 Sep 10:25 UTC 2020, Zhenzhong Duan wrote: > It's allocating an array of a6xx_gpu_state_obj structure rathor than > its pointers. > > This patch fix it. > Reviewed-by: Bjorn Andersson > Signed-off-by: Zhenzhong Duan > --- > drivers/gpu/drm/msm/adreno/a6xx_gpu_state.c | 2 +- > 1 fi

[Freedreno] [PATCH 1/3] drm/msm: Allow a5xx to mark the RPTR shadow as privileged

2020-09-14 Thread Jordan Crouse
Newer microcode versions have support for the CP_WHERE_AM_I opcode which allows the RPTR shadow memory to be marked as privileged to protect it from corruption. Move the RPTR shadow into its own buffer and protect it it if the current microcode version supports the new feature. We can also re-enab

[Freedreno] [PATCH 3/3] drm/msm: Get rid of the REG_ADRENO offsets

2020-09-14 Thread Jordan Crouse
As newer GPU families are added it makes less sense to maintain a "generic" version functions for older families. Move adreno_submit() and get_rptr() into the target specific code for a2xx, a3xx and a4xx. Add a parameter to adreno_flush to pass the target specific WPTR register instead of relying o

[Freedreno] [PATCH 2/3] drm/msm: a6xx: Use WHERE_AM_I for eligible targets

2020-09-14 Thread Jordan Crouse
Support the WHERE_AM_I opcode for the A618, A630 and A640 GPUs if the microcode supports it. The WHERE_AM_I opcode allows the RPTR shadow to be updated in priviliged memory which protects the shadow from being read or written from user submissions. A650 already supports extended APRIV have built i

[Freedreno] [PATCH 0/3] drm/msm: Add support for the WHERE_AM_I opcode

2020-09-14 Thread Jordan Crouse
The microcode in linux-firmware has been updated to 1.87.01 for a5xx 1.77.01 for a6xx [1]. These microcode versions support a new opcode called WHERE_AM_I that takes the place of the hardware RPTR shadow and enables the microcode to update the RPTR shadow in privileged memory so it is protected aga

Re: [Freedreno] [PATCH v12 0/5] Add support for DisplayPort driver on SnapDragon

2020-09-14 Thread Tanmay Shah
On 2020-09-12 11:25, Rob Clark wrote: Fyi, I've pushed this series and the dp-compliance bits to msm-next-dp[1] I didn't include the dp audio series yet, which seems to need some minor rebasing. (And a small request, when resending, cc freedreno@lists.freedesktop.org, so it shows up in the pat

Re: [Freedreno] [PATCH 01/20] drm/amdgpu: Introduce GEM object functions

2020-09-14 Thread Christian König
Am 14.09.20 um 17:05 schrieb Thomas Zimmermann: Hi Am 13.08.20 um 12:22 schrieb Christian König: Am 13.08.20 um 10:36 schrieb Thomas Zimmermann: GEM object functions deprecate several similar callback interfaces in struct drm_driver. This patch replaces the per-driver callbacks with per-instan

Re: [Freedreno] [PATCH] drm/msm/a6xx: fix a potential overflow issue

2020-09-14 Thread Jordan Crouse
On Sat, Sep 12, 2020 at 06:25:58PM +0800, Zhenzhong Duan wrote: > It's allocating an array of a6xx_gpu_state_obj structure rathor than > its pointers. > > This patch fix it. > > Signed-off-by: Zhenzhong Duan LGTM but should have a Fixes: tag for the stable trees Fixes: d6852b4b2d01 ("drm/msm/a

Re: [Freedreno] [PATCH 01/20] drm/amdgpu: Introduce GEM object functions

2020-09-14 Thread Thomas Zimmermann
Hi Am 13.08.20 um 12:22 schrieb Christian König: > Am 13.08.20 um 10:36 schrieb Thomas Zimmermann: >> GEM object functions deprecate several similar callback interfaces in >> struct drm_driver. This patch replaces the per-driver callbacks with >> per-instance callbacks in amdgpu. The only exceptio

Re: [Freedreno] Adreno GPU microcode update

2020-09-14 Thread Josh Boyer
On Tue, Sep 8, 2020 at 1:11 PM Jordan Crouse wrote: > > The following changes since commit d5f9eea5a251d43412b07f5295d03e97b89ac4a5: > > wl18xx: update firmware file 8.9.0.0.83 (2020-09-01 08:07:59 -0400) > > are available in the Git repository at: > > https://github.com/CosmicPenguin/linux-fi