[Freedreno] [PATCH] drm/msm/dpu: sc7180: add missing WB2 clock control

2023-01-16 Thread Dmitry Baryshkov
Add missing DPU_CLK_CTRL_WB2 to sc7180_mdp clocks array. Fixes: 51e4d60e6ba5 ("drm/msm/dpu: add writeback support for sc7180") Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/disp/dpu1/dpu_hw_catalog.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/gpu/drm/msm/disp/dpu1/dp

[Freedreno] [PATCH 1/2] dt-bindings: display/msm: Add SM6375 DSI PHY

2023-01-16 Thread Konrad Dybcio
SM6375 has a single 7nm DSI PHY. Document it. Signed-off-by: Konrad Dybcio --- Documentation/devicetree/bindings/display/msm/dsi-phy-7nm.yaml | 1 + 1 file changed, 1 insertion(+) diff --git a/Documentation/devicetree/bindings/display/msm/dsi-phy-7nm.yaml b/Documentation/devicetree/bindings/di

[Freedreno] [PATCH 2/2] drm/msm/dsi: Add phy configuration for SM6375

2023-01-16 Thread Konrad Dybcio
From: Konrad Dybcio SM6375 uses a boring standard 7nm PHY. Add a configuration entry for it. Signed-off-by: Konrad Dybcio --- Depends on [1] to work properly, but won't hurt for it to land separately.. [1] https://patchwork.kernel.org/project/linux-arm-msm/patch/1642586079-12472-1-git-send-em

Re: [Freedreno] [PATCH 2/2] drm/msm/dsi: Add phy configuration for SM6375

2023-01-16 Thread Konrad Dybcio
On 16.01.2023 12:40, Konrad Dybcio wrote: > From: Konrad Dybcio > > SM6375 uses a boring standard 7nm PHY. Add a configuration entry for it. > > Signed-off-by: Konrad Dybcio > --- Signed-off-by: Konrad Dybcio Sorry, bit messy revisiting old patches before the email change.. Konrad > Depen

Re: [Freedreno] [PATCH 2/2] drm/msm/dsi: Add phy configuration for SM6375

2023-01-16 Thread Dmitry Baryshkov
On Mon, 16 Jan 2023 at 13:42, Konrad Dybcio wrote: > > > > On 16.01.2023 12:40, Konrad Dybcio wrote: > > From: Konrad Dybcio > > > > SM6375 uses a boring standard 7nm PHY. Add a configuration entry for it. > > > > Signed-off-by: Konrad Dybcio > > --- > Signed-off-by: Konrad Dybcio > > Sorry, bi

Re: [Freedreno] [PATCH 2/2] drm/msm/dsi: Add phy configuration for SM6375

2023-01-16 Thread Konrad Dybcio
On 16.01.2023 12:47, Dmitry Baryshkov wrote: > On Mon, 16 Jan 2023 at 13:42, Konrad Dybcio wrote: >> >> >> >> On 16.01.2023 12:40, Konrad Dybcio wrote: >>> From: Konrad Dybcio >>> >>> SM6375 uses a boring standard 7nm PHY. Add a configuration entry for it. >>> >>> Signed-off-by: Konrad Dybcio

[Freedreno] [PATCH] dt-bindings: msm/dsi: Don't require vdds-supply on 7nm PHY

2023-01-16 Thread Konrad Dybcio
On some SoCs (hello SM6375) vdds-supply is not wired to any smd-rpm or rpmh regulator, but instead powered by the VDD_MX/mx.lvl line, which is voted for in the DSI ctrl node. Signed-off-by: Konrad Dybcio --- Documentation/devicetree/bindings/display/msm/dsi-phy-7nm.yaml | 1 - 1 file changed, 1

Re: [Freedreno] [PATCH] dt-bindings: msm/dsi: Don't require vdds-supply on 7nm PHY

2023-01-16 Thread Krzysztof Kozlowski
On 16/01/2023 12:51, Konrad Dybcio wrote: > On some SoCs (hello SM6375) vdds-supply is not wired to any smd-rpm > or rpmh regulator, but instead powered by the VDD_MX/mx.lvl line, > which is voted for in the DSI ctrl node. > > Signed-off-by: Konrad Dybcio > --- Acked-by: Krzysztof Kozlowski B

Re: [Freedreno] [PATCH] dt-bindings: msm/dsi: Don't require vdds-supply on 7nm PHY

2023-01-16 Thread Dmitry Baryshkov
On Mon, 16 Jan 2023 at 13:51, Konrad Dybcio wrote: > > On some SoCs (hello SM6375) vdds-supply is not wired to any smd-rpm > or rpmh regulator, but instead powered by the VDD_MX/mx.lvl line, > which is voted for in the DSI ctrl node. I think we should have an explicit `if compatible then required

[Freedreno] [PATCH AUTOSEL 6.1 16/53] drm/msm/a6xx: Avoid gx gbit halt during rpm suspend

2023-01-16 Thread Sasha Levin
From: Akhil P Oommen [ Upstream commit f4a75b5933c998e60fd812a7680e0971eb1c7cee ] As per the downstream driver, gx gbif halt is required only during recovery sequence. So lets avoid it during regular rpm suspend. Signed-off-by: Akhil P Oommen Patchwork: https://patchwork.freedesktop.org/patch/

Re: [Freedreno] [PATCH] dt-bindings: msm/dsi: Don't require vdds-supply on 7nm PHY

2023-01-16 Thread Konrad Dybcio
On 16.01.2023 13:52, Dmitry Baryshkov wrote: > On Mon, 16 Jan 2023 at 13:51, Konrad Dybcio wrote: >> >> On some SoCs (hello SM6375) vdds-supply is not wired to any smd-rpm >> or rpmh regulator, but instead powered by the VDD_MX/mx.lvl line, >> which is voted for in the DSI ctrl node. > > I thi

Re: [Freedreno] [PATCH 2/2] drm/msm/dpu: don't use DPU_CLK_CTRL_CURSORn for DMA SSPP clocks

2023-01-16 Thread Neil Armstrong
CLK_CTRL_DMA4, + DPU_CLK_CTRL_DMA5, DPU_CLK_CTRL_CURSOR0, DPU_CLK_CTRL_CURSOR1, DPU_CLK_CTRL_INLINE_ROT0_SSPP, Reviewed-by: Neil Armstrong Tested-by: Neil Armstrong # on SM8550 on top of next-20230116

[Freedreno] [PATCH v7 1/4] dt-bindings: msm: dsi-controller-main: Add compatible strings for every current SoC

2023-01-16 Thread Bryan O'Donoghue
Currently we do not differentiate between the various users of the qcom,mdss-dsi-ctrl. The driver is flexible enough to operate from one compatible string but, the hardware does have some significant differences in the number of clocks. To facilitate documenting the clocks add the following compat

[Freedreno] [PATCH v7 0/4] mdss-dsi-ctrl binding and dts fixes

2023-01-16 Thread Bryan O'Donoghue
V7: - The bulk of the patches for this series have been merged. There are still four patches to be pushed/updated. - Adds clocks for msm8974 - Dmitry - Adds compat strings for sm8150, sm8350, sm8450, sm8550 - Dmitry - Changes last patch in series to state - Rob compatible: contains: c

[Freedreno] [PATCH v7 2/4] dt-bindings: msm: dsi-controller-main: Document clocks on a per compatible basis

2023-01-16 Thread Bryan O'Donoghue
Each compatible has a different set of clocks which are associated with it. Add in the list of clocks for each compatible. Acked-by: Rob Herring Acked-by: Krzysztof Kozlowski Signed-off-by: Bryan O'Donoghue --- .../display/msm/dsi-controller-main.yaml | 219 -- 1 file chan

[Freedreno] [PATCH v7 4/4] dt-bindings: display/msm: Add list of mdss-dsi-ctrl compats

2023-01-16 Thread Bryan O'Donoghue
Add the list of current compats absent the deprecated qcm2290 to the list of dsi compats listed here. Several MDSS yaml files exist which document the dsi sub-node. For each existing SoC MDSS yaml, provide the right dsi compat string. Signed-off-by: Bryan O'Donoghue --- .../devicetree/bindings/

[Freedreno] [PATCH v7 3/4] dt-bindings: msm: dsi-controller-main: Add vdd* descriptions back in

2023-01-16 Thread Bryan O'Donoghue
When converting from .txt to .yaml we didn't include descriptions for the existing regulator supplies. - vdd - vdda - vddio Add those descriptions into the yaml now as they were prior to the conversion. In the .txt description we marked these regulators as required, however, that requirement appe

Re: [Freedreno] [PATCH 1/3] drm/msm/dpu: fix blend setup for DMA4 and DMA5 layers

2023-01-16 Thread Neil Armstrong
On 16/01/2023 07:33, Dmitry Baryshkov wrote: SM8550 uses new register to map SSPP_DMA4 and SSPP_DMA5 units to blend stages. Add proper support for this register to allow using these two planes for image processing. Fixes: efcd0107727c ("drm/msm/dpu: add support for SM8550") Cc: Neil Armstrong S

Re: [Freedreno] [PATCH 2/3] drm/msm/dpu: simplify ctl_setup_blendstage calculation

2023-01-16 Thread Neil Armstrong
On 16/01/2023 07:33, Dmitry Baryshkov wrote: Extract the common expression in the dpu_hw_ctl_setup_blendstage() function. Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/disp/dpu1/dpu_hw_ctl.c | 38 +++--- 1 file changed, 19 insertions(+), 19 deletions(-) diff --git

Re: [Freedreno] [PATCH 3/3] drm/msm/dpu: simplify blend configuration

2023-01-16 Thread Neil Armstrong
On 16/01/2023 07:33, Dmitry Baryshkov wrote: Rewrite dpu_hw_ctl_setup_blendstage() to use static data configuration rather than using a switch-case. This simplifies adding support for new pipes. Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/disp/dpu1/dpu_hw_ctl.c | 156 ++---

Re: [Freedreno] [PATCH v7 1/4] dt-bindings: msm: dsi-controller-main: Add compatible strings for every current SoC

2023-01-16 Thread Rob Herring
On Mon, 16 Jan 2023 15:21:25 +, Bryan O'Donoghue wrote: > Currently we do not differentiate between the various users of the > qcom,mdss-dsi-ctrl. The driver is flexible enough to operate from one > compatible string but, the hardware does have some significant differences > in the number of

[Freedreno] [pull] drm/msm: drm-msm-fixes-2023-01-16 for v6.3-rc5

2023-01-16 Thread Rob Clark
Hi Dave, A couple more fixes for the v6.3 cycle, which were meant to be part of the previous fixes pull, but I fumbled at git when applying the tag. The following changes since commit f4a75b5933c998e60fd812a7680e0971eb1c7cee: drm/msm/a6xx: Avoid gx gbit halt during rpm suspend (2023-01-05 15:1

Re: [Freedreno] [PATCH 1/2] dt-bindings: display/msm: Add SM6375 DSI PHY

2023-01-16 Thread Krzysztof Kozlowski
On 16/01/2023 12:40, Konrad Dybcio wrote: > SM6375 has a single 7nm DSI PHY. Document it. > > Signed-off-by: Konrad Dybcio > --- Acked-by: Krzysztof Kozlowski Best regards, Krzysztof

[Freedreno] [PATCH v8 0/3] mdss-dsi-ctrl binding and dts fixes

2023-01-16 Thread Bryan O'Donoghue
V8: - Squash first and last patch to fix bisectability link: https://lore.kernel.org/linux-arm-msm/167388664232.594279.4607492026981202284.r...@kernel.org/T/#u V7: - The bulk of the patches for this series have been merged. There are still four patches to be pushed/updated. - Adds clocks for m

[Freedreno] [PATCH v8 1/3] dt-bindings: msm: dsi-controller-main: Add compatible strings for every current SoC

2023-01-16 Thread Bryan O'Donoghue
Currently we do not differentiate between the various users of the qcom,mdss-dsi-ctrl. The driver is flexible enough to operate from one compatible string but, the hardware does have some significant differences in the number of clocks. To facilitate documenting the clocks add the following compat

[Freedreno] [PATCH v8 2/3] dt-bindings: msm: dsi-controller-main: Document clocks on a per compatible basis

2023-01-16 Thread Bryan O'Donoghue
Each compatible has a different set of clocks which are associated with it. Add in the list of clocks for each compatible. Acked-by: Rob Herring Acked-by: Krzysztof Kozlowski Signed-off-by: Bryan O'Donoghue --- .../display/msm/dsi-controller-main.yaml | 219 -- 1 file chan

[Freedreno] [PATCH v8 3/3] dt-bindings: msm: dsi-controller-main: Add vdd* descriptions back in

2023-01-16 Thread Bryan O'Donoghue
When converting from .txt to .yaml we didn't include descriptions for the existing regulator supplies. - vdd - vdda - vddio Add those descriptions into the yaml now as they were prior to the conversion. In the .txt description we marked these regulators as required, however, that requirement appe

Re: [Freedreno] [PATCH] drm/msm: Initialize mode_config earlier

2023-01-16 Thread Bjorn Andersson
On Fri, Jan 13, 2023 at 10:57:18AM +0200, Dmitry Baryshkov wrote: > On 13/01/2023 06:23, Dmitry Baryshkov wrote: > > On 13/01/2023 06:10, Bjorn Andersson wrote: > > > Invoking drm_bridge_hpd_notify() on a drm_bridge with a HPD-enabled > > > bridge_connector ends up in drm_bridge_connector_hpd_cb()