Re: [Freedreno] [PATCH v8 01/18] dt-bindings: display/msm: gpu: Document GMU wrapper-equipped A6xx

2023-06-09 Thread Konrad Dybcio
On 8.06.2023 22:58, Rob Herring wrote: > On Tue, May 30, 2023 at 03:35:09PM +0200, Konrad Dybcio wrote: >> >> >> On 30.05.2023 14:26, Krzysztof Kozlowski wrote: >>> On Mon, 29 May 2023 15:52:20 +0200, Konrad Dybcio wrote: The "GMU Wrapper" is Qualcomm's name for "let's treat the GPU blocks

Re: [Freedreno] Adreno devfreq lockdep splat with 6.3-rc2

2023-06-09 Thread Rob Clark
On Thu, Jun 8, 2023 at 11:17 PM Johan Hovold wrote: > > On Thu, Jun 08, 2023 at 02:17:45PM -0700, Rob Clark wrote: > > On Thu, Jun 8, 2023 at 7:12 AM Johan Hovold wrote: > > > > Have you had a chance to look at this regression yet? It prevents us > > > from using lockdep on the X13s as it is disa

Re: [Freedreno] [PATCH v5 2/5] drm/msm/dsi: Adjust pclk rate for compression

2023-06-09 Thread Dmitry Baryshkov
On 08/06/2023 23:36, Marijn Suijten wrote: Same title suggestion as earlier: s/adjust/reduce On 2023-05-22 18:08:56, Jessica Zhang wrote: Adjust the pclk rate to divide hdisplay by the compression ratio when DSC is enabled. Signed-off-by: Jessica Zhang --- drivers/gpu/drm/msm/dsi/dsi_host.c

Re: [Freedreno] [PATCH v5 2/5] drm/msm/dsi: Adjust pclk rate for compression

2023-06-09 Thread Jessica Zhang
On 6/9/2023 9:58 AM, Dmitry Baryshkov wrote: On 08/06/2023 23:36, Marijn Suijten wrote: Same title suggestion as earlier: s/adjust/reduce On 2023-05-22 18:08:56, Jessica Zhang wrote: Adjust the pclk rate to divide hdisplay by the compression ratio when DSC is enabled. Signed-off-by: Jessi

Re: [Freedreno] [PATCH v8 08/18] drm/msm/a6xx: Remove both GBIF and RBBM GBIF halt on hw init

2023-06-09 Thread Akhil P Oommen
On Mon, May 29, 2023 at 03:52:27PM +0200, Konrad Dybcio wrote: > > Currently we're only deasserting REG_A6XX_RBBM_GBIF_HALT, but we also > need REG_A6XX_GBIF_HALT to be set to 0. > > This is typically done automatically on successful GX collapse, but in > case that fails, we should take care of i

Re: [Freedreno] [PATCH v8 08/18] drm/msm/a6xx: Remove both GBIF and RBBM GBIF halt on hw init

2023-06-09 Thread Konrad Dybcio
On 9.06.2023 20:25, Akhil P Oommen wrote: > On Mon, May 29, 2023 at 03:52:27PM +0200, Konrad Dybcio wrote: >> >> Currently we're only deasserting REG_A6XX_RBBM_GBIF_HALT, but we also >> need REG_A6XX_GBIF_HALT to be set to 0. >> >> This is typically done automatically on successful GX collapse,

Re: [Freedreno] [PATCH v8 09/18] drm/msm/a6xx: Extend and explain UBWC config

2023-06-09 Thread Akhil P Oommen
On Mon, May 29, 2023 at 03:52:28PM +0200, Konrad Dybcio wrote: > > Rename lower_bit to hbb_lo and explain what it signifies. > Add explanations (wherever possible to other tunables). > > Port setting min_access_length, ubwc_mode and hbb_hi from downstream. > > Reviewed-by: Rob Clark > Signed-of

Re: [Freedreno] [PATCH v8 10/18] drm/msm/a6xx: Introduce GMU wrapper support

2023-06-09 Thread Akhil P Oommen
On Mon, May 29, 2023 at 03:52:29PM +0200, Konrad Dybcio wrote: > > Some (particularly SMD_RPM, a.k.a non-RPMh) SoCs implement A6XX GPUs > but don't implement the associated GMUs. This is due to the fact that > the GMU directly pokes at RPMh. Sadly, this means we have to take care > of enabling & s

[Freedreno] [PATCH v6 0/6] Add DSC v1.2 Support for DSI

2023-06-09 Thread Jessica Zhang
This is a series of changes for DSI to enable command mode support for DSC v1.2. This includes: 1) Rounding up `hdisplay / 3` in dsc_timing_setup() 2) Adjusting pclk_rate to account for compression 3) Fixing incorrect uses of slice_count in DSI DSC calculations 4) Setting the DATA_COMPRESS bit wh

[Freedreno] [PATCH v6 5/6] drm/msm/dsi: Remove incorrect references to slice_count

2023-06-09 Thread Jessica Zhang
Currently, slice_count is being used to calculate word count and pkt_per_line. Instead, these values should be calculated using slice per packet, which is not the same as slice_count. Slice count represents the number of slices per interface, and its value will not always match that of slice per p

[Freedreno] [PATCH v6 3/6] drm/msm/dpu: Add DPU_INTF_DATA_COMPRESS feature flag for DPU >= 7.0

2023-06-09 Thread Jessica Zhang
In DPU 7.x and later, DSC/DCE enablement registers have been moved from PINGPONG to INTF. Thus, add a DPU_INTF_DATA_COMPRESS feature flag that will be set if the DATA_COMPRESS register is in the INTF block. Reviewed-by: Marijn Suijten Signed-off-by: Jessica Zhang --- drivers/gpu/drm/msm/disp/dp

[Freedreno] [PATCH v6 6/6] drm/msm/dsi: Document DSC related pclk_rate and hdisplay calculations

2023-06-09 Thread Jessica Zhang
Add documentation comments explaining the pclk_rate and hdisplay math related to DSC. Signed-off-by: Jessica Zhang --- drivers/gpu/drm/msm/dsi/dsi_host.c | 10 ++ 1 file changed, 10 insertions(+) diff --git a/drivers/gpu/drm/msm/dsi/dsi_host.c b/drivers/gpu/drm/msm/dsi/dsi_host.c index

[Freedreno] [PATCH v6 1/6] msm/drm/dsi: Round up DSC hdisplay calculation

2023-06-09 Thread Jessica Zhang
Currently, when compression is enabled, hdisplay is reduced via integer division. This causes issues for modes where the original hdisplay is not a multiple of 3. To fix this, use DIV_ROUND_UP to divide hdisplay. Suggested-by: Marijn Suijten Fixes: 08802f515c3cf ("drm/msm/dsi: Add support for DS

[Freedreno] [PATCH v6 4/6] drm/msm/dpu: Set DATA_COMPRESS on command mode for DCE/DSC 1.2

2023-06-09 Thread Jessica Zhang
Add a DPU INTF op to set the DCE_DATA_COMPRESS bit to enable the DCE/DSC 1.2 datapath Note: For now, this op is called for command mode encoders only. Changes to set DATA_COMPRESS for video mode encoders will be posted along with DSC v1.2 support for DP. Signed-off-by: Jessica Zhang --- drivers

[Freedreno] [PATCH v6 2/6] drm/msm/dsi: Reduce pclk rate for compression

2023-06-09 Thread Jessica Zhang
Adjust the pclk rate to divide hdisplay by the compression ratio when DSC is enabled. Signed-off-by: Jessica Zhang --- drivers/gpu/drm/msm/dsi/dsi_host.c | 21 ++--- 1 file changed, 18 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/msm/dsi/dsi_host.c b/drivers/gpu/d

Re: [Freedreno] [PATCH v6 4/6] drm/msm/dpu: Set DATA_COMPRESS on command mode for DCE/DSC 1.2

2023-06-09 Thread Abhinav Kumar
On 6/9/2023 3:57 PM, Jessica Zhang wrote: Add a DPU INTF op to set the DCE_DATA_COMPRESS bit to enable the DCE/DSC 1.2 datapath Note: For now, this op is called for command mode encoders only. Changes to set DATA_COMPRESS for video mode encoders will be posted along with DSC v1.2 support for

Re: [Freedreno] [PATCH v6 2/6] drm/msm/dsi: Reduce pclk rate for compression

2023-06-09 Thread Abhinav Kumar
On 6/9/2023 3:57 PM, Jessica Zhang wrote: Adjust the pclk rate to divide hdisplay by the compression ratio when DSC is enabled. Signed-off-by: Jessica Zhang --- Reviewed-by: Abhinav Kumar

Re: [Freedreno] [PATCH v6 6/6] drm/msm/dsi: Document DSC related pclk_rate and hdisplay calculations

2023-06-09 Thread Dmitry Baryshkov
On 10/06/2023 01:57, Jessica Zhang wrote: Add documentation comments explaining the pclk_rate and hdisplay math related to DSC. Signed-off-by: Jessica Zhang --- drivers/gpu/drm/msm/dsi/dsi_host.c | 10 ++ 1 file changed, 10 insertions(+) diff --git a/drivers/gpu/drm/msm/dsi/dsi_host

Re: [Freedreno] [RFC PATCH v2 12/13] drm/msm/dpu: add support for virtual planes

2023-06-09 Thread Abhinav Kumar
On 6/8/2023 12:51 PM, Abhinav Kumar wrote: On 6/7/2023 2:56 PM, Dmitry Baryshkov wrote: On 08/06/2023 00:05, Abhinav Kumar wrote: On 3/20/2023 6:18 PM, Dmitry Baryshkov wrote: Only several SSPP blocks support such features as YUV output or scaling, thus different DRM planes have differ