Re: [Freedreno] [PATCH] soc: qcom: pmic_glink: fix connector type to be DisplayPort

2023-10-16 Thread Bjorn Andersson
On Wed, Oct 11, 2023 at 01:52:29AM +0300, Dmitry Baryshkov wrote: > As it was pointed out by Simon Ser, the DRM_MODE_CONNECTOR_USB connector > is reserved for the GUD devices. Other drivers (i915, amdgpu) use > DRM_MODE_CONNECTOR_DisplayPort even if the DP stream is handled by the > USB-C altmode.

Re: [Freedreno] [PATCH v2 0/4] arm64: dts: qcom: qrb5165-rb5: enable DP support

2023-09-19 Thread Bjorn Andersson
rd USB-C redriver commit: d342e1c993bd7589cad9d2da099c6a9c652ecb9f [3/4] arm64: dts: qcom: qrb5165-rb5: enable displayport controller commit: 96387ee7534dc449be35a9bb98b7668da2bed545 [4/4] arm64: dts: qcom: qrb5165-rb5: enable DP altmode commit: b3dea914127e9065df003002ed13a2ef40d19877 Best regards, -- Bjorn Andersson

Re: [Freedreno] (subset) [PATCH 0/5] arm64: dts: qcom: qrb5165-rb5: enable DP support

2023-09-19 Thread Bjorn Andersson
rd USB-C redriver commit: d342e1c993bd7589cad9d2da099c6a9c652ecb9f [4/5] arm64: dts: qcom: qrb5165-rb5: enable displayport controller commit: 96387ee7534dc449be35a9bb98b7668da2bed545 [5/5] arm64: dts: qcom: qrb5165-rb5: enable DP altmode commit: b3dea914127e9065df003002ed13a2ef40d19877 Best regards, -- Bjorn Andersson

Re: [Freedreno] [PATCH v2 1/4] arm64: dts: qcom: sm8250: Add DisplayPort device node

2023-09-19 Thread Bjorn Andersson
On Thu, Aug 17, 2023 at 05:59:37PM +0300, Dmitry Baryshkov wrote: > Declare the displayport controller present on the Qualcomm SM8250 SoC. > > Signed-off-by: Dmitry Baryshkov > --- > arch/arm64/boot/dts/qcom/sm8250.dtsi | 89 > 1 file changed, 89 insertions(+) > > d

Re: [Freedreno] (subset) [PATCH v4 00/17] drm/msm: Add SM6125 MDSS/DPU hardware and enable Sony Xperia 10 II panel

2023-09-19 Thread Bjorn Andersson
d23a02260a76963bd18d9ae603e77cdd0eba [17/17] arm64: dts: qcom: sm6125-seine: Configure MDSS, DSI and panel commit: 5078dfe3c5c7b8d2d6494c26de81a4f3d4a5a3d7 Best regards, -- Bjorn Andersson

Re: [Freedreno] [RFC PATCH v1 07/12] soc: qcom: pmic_glink_altmode: report that this is a Type-C connector

2023-09-04 Thread Bjorn Andersson
h, I'm okay with this going through the USB tree. Acked-by: Bjorn Andersson Regards, Bjorn

Re: [Freedreno] [RFC PATCH v1 06/12] soc: qcom: pmic_glink_altmode: fix DRM connector type

2023-09-04 Thread Bjorn Andersson
B-n". Similarly, it looks quite reasonable that the output on my laptop are eDP-1, USB-1 and USB-2. But, if this is not the way its intended to be used, feel free to pick this together with the other patches. Acked-by: Bjorn Andersson Regards, Bjorn

Re: [Freedreno] [RFC PATCH v1 00/12] drm, usb/typec: uABI for USB-C DisplayPort connectors

2023-09-04 Thread Bjorn Andersson
On Mon, Sep 04, 2023 at 12:41:38AM +0300, Dmitry Baryshkov wrote: > During the discussion regarding DisplayPort wrapped in the USB-C > connectors (via the USB-C altmode) it was pointed out that currently > there is no good way to let userspace know if the DRM connector in > question is the 'native'

Re: [Freedreno] (subset) [PATCH v6 1/2] dt-bindings: display/msm: mdss-common: add memory-region property

2023-08-18 Thread Bjorn Andersson
Applied, thanks! [2/2] arm64: dts: qcom: sdm845-db845c: Mark cont splash memory region as reserved commit: 110e70fccce4f22b53986ae797d665ffb1950aa6 Best regards, -- Bjorn Andersson

Re: [Freedreno] [PATCH -next] drm/msm/adreno: adreno_gpu: Switch to memdup_user_nul() helper

2023-08-10 Thread Bjorn Andersson
On Thu, Aug 10, 2023 at 08:04:24PM +0800, Ruan Jinjie wrote: > Use memdup_user_nul() helper instead of open-coding to simplify the code. > > Signed-off-by: Ruan Jinjie Reviewed-by: Bjorn Andersson Regards, Bjorn

Re: [Freedreno] [PATCH 0/5] arm64: dts: qcom: qrb5165-rb5: enable DP support

2023-07-21 Thread Bjorn Andersson
On Tue, Jul 18, 2023 at 09:09:41AM +0300, Dmitry Baryshkov wrote: > On 18/07/2023 07:37, Bjorn Andersson wrote: > > On Sun, Jul 09, 2023 at 07:19:21AM +0300, Dmitry Baryshkov wrote: > > > Implement DisplayPort support for the Qualcomm RB5 platform. > > > > > >

Re: [Freedreno] [PATCH] drm/msm: Check for the GPU IOMMU during bind

2023-07-20 Thread Bjorn Andersson
On Mon, Jul 10, 2023 at 03:20:44AM +0530, Akhil P Oommen wrote: > On Fri, Jul 07, 2023 at 08:27:18PM +0300, Dmitry Baryshkov wrote: > > > > On 07/07/2023 18:03, Jordan Crouse wrote: > > > On Thu, Jul 06, 2023 at 09:55:13PM +0300, Dmitry Baryshkov wrote: > > > > > > > > On 10/03/2023 00:20, Jordan

Re: [Freedreno] [PATCH 0/5] arm64: dts: qcom: qrb5165-rb5: enable DP support

2023-07-17 Thread Bjorn Andersson
On Sun, Jul 09, 2023 at 07:19:21AM +0300, Dmitry Baryshkov wrote: > Implement DisplayPort support for the Qualcomm RB5 platform. > > Note: while testing this, I had link training issues with several > dongles with DP connectors. Other DisplayPort-USB-C dongles (with HDMI > or VGA connectors) work

Re: [Freedreno] (subset) [PATCH v2 0/8] MDSS reg bus interconnect

2023-07-13 Thread Bjorn Andersson
25191e6cb00d6c3f3a8e1b67fd242e639b3c3 Best regards, -- Bjorn Andersson

Re: [Freedreno] (subset) [PATCH v3 0/7] Display support for MSM8226

2023-07-09 Thread Bjorn Andersson
.] Applied, thanks! [7/7] ARM: dts: qcom: msm8226: Add mdss nodes commit: d5fb01ad5eb449ccfd950e946a882639cad168b3 Best regards, -- Bjorn Andersson

Re: [Freedreno] [PATCH 1/5] dt-bindings: display: msm: dp-controller: document SM8250 compatible

2023-07-09 Thread Bjorn Andersson
On Sun, Jul 09, 2023 at 07:19:22AM +0300, Dmitry Baryshkov wrote: > It looks like DP controlled on SM8250 is the same as DP controller on > SM8350. Use the SM8350 compatible as fallback for SM8250. > > Signed-off-by: Dmitry Baryshkov Reviewed-by: Bjorn Andersson Re

Re: [Freedreno] [PATCH v1 4/5] drm/msm/dp: move relevant dp initialization code from bind() to probe()

2023-07-08 Thread Bjorn Andersson
On Fri, Jul 07, 2023 at 04:52:22PM -0700, Kuogee Hsieh wrote: > In preparation of moving edp of_dp_aux_populate_bus() to > dp_display_probe(), move dp_display_request_irq(), > dp->parser->parse() and dp_power_client_init() to dp_display_probe() > too. > > Signed-off-by: Kuogee Hsieh > --- > driv

Re: [Freedreno] [PATCH v1 2/5] drm/msm/dp: incorporate pm_runtime framework into DP driver

2023-07-08 Thread Bjorn Andersson
On Fri, Jul 07, 2023 at 04:52:20PM -0700, Kuogee Hsieh wrote: > Incorporating pm runtime framework into DP driver so that power > and clock resource handling can be centralized allowing easier > control of these resources in preparation of registering aux bus > uring probe. > > Signed-off-by: Kuog

Re: [Freedreno] [PATCH v1 1/5] drm/msm/dp: remove pm_runtime_xxx() from dp_power.c

2023-07-08 Thread Bjorn Andersson
On Fri, Jul 07, 2023 at 04:52:19PM -0700, Kuogee Hsieh wrote: > Since both pm_runtime_resume() and pm_runtime_suspend() are not > populated at dp_pm_ops. Those pm_runtime_get/put() functions within > dp_power.c will not have any effects in addition to increase/decrease > power counter. Also pm_runt

Re: [Freedreno] [PATCH v2 0/3] drm/msm/adreno: GPU support on SC8280XP

2023-06-14 Thread Bjorn Andersson
On Wed, Jun 14, 2023 at 09:03:34AM -0700, Bjorn Andersson wrote: > On Mon, 22 May 2023 18:15:19 -0700, Bjorn Andersson wrote: > > This series introduces support for A690 in the DRM/MSM driver and > > enables it for the two SC8280XP laptops. > > > > Bjorn Andersson (3)

Re: [Freedreno] [PATCH 0/3] drm/msm/adreno: GPU support on SC8280XP

2023-06-14 Thread Bjorn Andersson
On Tue, 7 Feb 2023 19:40:49 -0800, Bjorn Andersson wrote: > This series introduces support for A690 in the DRM/MSM driver and > enables it for the two SC8280XP laptops. > > Bjorn Andersson (3): > drm/msm/adreno: Add Adreno A690 support > arm64: dts: qcom: sc8280xp: Add

Re: [Freedreno] [PATCH v4 0/2] drm/msm/adreno: GPU support on SC8280XP

2023-06-14 Thread Bjorn Andersson
On Wed, 14 Jun 2023 07:22:02 -0700, Bjorn Andersson wrote: > With the A690 support merged in the drm/msm driver, this series adds the > DeviceTree pieces to make it go on sc8280xp. > > Note that in order for the GPU driver to probe, the last change > requires (which is now in linux

Re: [Freedreno] [PATCH v2 0/3] drm/msm/adreno: GPU support on SC8280XP

2023-06-14 Thread Bjorn Andersson
On Mon, 22 May 2023 18:15:19 -0700, Bjorn Andersson wrote: > This series introduces support for A690 in the DRM/MSM driver and > enables it for the two SC8280XP laptops. > > Bjorn Andersson (3): > drm/msm/adreno: Add Adreno A690 support > arm64: dts: qcom: sc8280xp: Add

Re: [Freedreno] [PATCH v4 2/2] arm64: dts: qcom: sc8280xp: Enable GPU related nodes

2023-06-14 Thread Bjorn Andersson
On Wed, Jun 14, 2023 at 05:27:24PM +0200, Konrad Dybcio wrote: > On 14.06.2023 16:22, Bjorn Andersson wrote: > > From: Bjorn Andersson > > > > Add memory reservation for the zap-shader and enable the Adreno SMMU, > > GPU clock controller, GMU and the GPU nodes f

[Freedreno] [PATCH v4 2/2] arm64: dts: qcom: sc8280xp: Enable GPU related nodes

2023-06-14 Thread Bjorn Andersson
From: Bjorn Andersson Add memory reservation for the zap-shader and enable the Adreno SMMU, GPU clock controller, GMU and the GPU nodes for the SC8280XP CRD and the Lenovo ThinkPad X13s. Tested-by: Steev Klimaszewski Signed-off-by: Bjorn Andersson Tested-by: Johan Hovold Signed-off-by: Bjorn

[Freedreno] [PATCH v4 1/2] arm64: dts: qcom: sc8280xp: Add GPU related nodes

2023-06-14 Thread Bjorn Andersson
From: Bjorn Andersson Add Adreno SMMU, GPU clock controller, GMU and GPU nodes for the SC8280XP. Tested-by: Steev Klimaszewski Signed-off-by: Bjorn Andersson Tested-by: Johan Hovold Signed-off-by: Bjorn Andersson --- arch/arm64/boot/dts/qcom/sa8540p.dtsi | 8 ++ arch/arm64/boot/dts/qcom

[Freedreno] [PATCH v4 0/2] drm/msm/adreno: GPU support on SC8280XP

2023-06-14 Thread Bjorn Andersson
) - Corrected opp-level for highest gpu opp - Added dma-coherent to gpu smmu Changes since v1: - Dropped gmu_pdc_seq region from &gmu, as it shouldn't have been used. - Added missing compatible to &adreno_smmu. - Dropped aoss_qmp clock in &gmu and &adreno_smmu. Bjorn Andersson (2

Re: [Freedreno] [PATCH v4 0/2] arm64: dts: qcom: add DP Controller to SM8550 DTS

2023-06-13 Thread Bjorn Andersson
port on the QRD > board will be sent later. > > [...] Applied, thanks! [1/2] arm64: dts: qcom: sm8550: fix low_svs RPMhPD labels commit: bbde65f9da9291a77636e1467b28f27ced1b4ece [2/2] arm64: dts: qcom: sm8550: add display port nodes commit: 66adfbc4d33993865a180016db73520a15e754c9

Re: [Freedreno] [PATCH] drm/msm/dpu: Configure DP INTF/PHY selector

2023-06-13 Thread Bjorn Andersson
On Tue, Jun 13, 2023 at 01:31:40AM +0300, Dmitry Baryshkov wrote: > On 13/06/2023 01:10, Bjorn Andersson wrote: > > From: Bjorn Andersson > > > > Some platforms provides a mechanism for configuring the mapping between > > (one or two) DisplayPort intfs and their P

[Freedreno] [PATCH] drm/msm/dpu: Configure DP INTF/PHY selector

2023-06-12 Thread Bjorn Andersson
From: Bjorn Andersson Some platforms provides a mechanism for configuring the mapping between (one or two) DisplayPort intfs and their PHYs. In particular SC8180X provides this functionality, without a default configuration, resulting in no connection between its two external DisplayPort

[Freedreno] [PATCH] drm/msm/dp: Free resources after unregistering them

2023-06-12 Thread Bjorn Andersson
y use-after-free that otherwise happens in this code path. Fixes: c943b4948b58 ("drm/msm/dp: add displayPort driver support") Signed-off-by: Bjorn Andersson --- drivers/gpu/drm/msm/dp/dp_display.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/msm/dp/

[Freedreno] [PATCH] drm/msm/dp: Drop aux devices together with DP controller

2023-06-12 Thread Bjorn Andersson
n the error path, and in the component unbind path, to avoid these issues. Fixes: 2b57f726611e ("drm/msm/dp: fix aux-bus EP lifetime") Signed-off-by: Bjorn Andersson --- drivers/gpu/drm/msm/dp/dp_display.c | 14 +++--- 1 file changed, 3 insertions(+), 11 deletions(-) diff --git a/

Re: [Freedreno] [PATCH v3 2/3] arm64: dts: qcom: sc8280xp: Add GPU related nodes

2023-05-31 Thread Bjorn Andersson
On Wed, May 31, 2023 at 09:28:35AM +0200, Johan Hovold wrote: > On Tue, May 30, 2023 at 08:09:44PM -0700, Bjorn Andersson wrote: > > From: Bjorn Andersson > > > > Add Adreno SMMU, GPU clock controller, GMU and GPU nodes for the > > SC8280XP. > > > > Tested

[Freedreno] [PATCH v3 1/3] drm/msm/adreno: Add Adreno A690 support

2023-05-30 Thread Bjorn Andersson
From: Bjorn Andersson Introduce support for the Adreno A690, found in Qualcomm SC8280XP. Tested-by: Steev Klimaszewski Reviewed-by: Konrad Dybcio Signed-off-by: Bjorn Andersson Signed-off-by: Bjorn Andersson --- Changes since v2: - None Changes since v1: - Moved a690 to

[Freedreno] [PATCH v3 2/3] arm64: dts: qcom: sc8280xp: Add GPU related nodes

2023-05-30 Thread Bjorn Andersson
From: Bjorn Andersson Add Adreno SMMU, GPU clock controller, GMU and GPU nodes for the SC8280XP. Tested-by: Steev Klimaszewski Signed-off-by: Bjorn Andersson Signed-off-by: Bjorn Andersson --- Changes since v2: - Added missing opp level (both gpu and gmu) - Corrected opp-level for highest

[Freedreno] [PATCH v3 3/3] arm64: dts: qcom: sc8280xp: Enable GPU related nodes

2023-05-30 Thread Bjorn Andersson
From: Bjorn Andersson Add memory reservation for the zap-shader and enable the Adreno SMMU, GPU clock controller, GMU and the GPU nodes for the SC8280XP CRD and the Lenovo ThinkPad X13s. Tested-by: Steev Klimaszewski Signed-off-by: Bjorn Andersson Signed-off-by: Bjorn Andersson --- Changes

[Freedreno] [PATCH v3 0/3] drm/msm/adreno: GPU support on SC8280XP

2023-05-30 Thread Bjorn Andersson
This series introduces support for A690 in the DRM/MSM driver and enables it for the two SC8280XP laptops. Bjorn Andersson (3): drm/msm/adreno: Add Adreno A690 support arm64: dts: qcom: sc8280xp: Add GPU related nodes arm64: dts: qcom: sc8280xp: Enable GPU related nodes arch/arm64/boot

Re: [Freedreno] [PATCH] drm/msm/dpu: re-introduce dpu core revision to the catalog

2023-05-30 Thread Bjorn Andersson
On Tue, May 30, 2023 at 05:53:55PM -0700, Abhinav Kumar wrote: > With [1] dpu core revision was dropped in favor of using the > compatible string from the device tree to select the dpu catalog > being used in the device. > > This approach works well however also necessitates adding catalog > entri

Re: [Freedreno] [PATCH v2 2/3] arm64: dts: qcom: sc8280xp: Add GPU related nodes

2023-05-30 Thread Bjorn Andersson
gt; On 23.05.2023 03:15, Bjorn Andersson wrote: > > >>> From: Bjorn Andersson [..] > > >>> diff --git a/arch/arm64/boot/dts/qcom/sc8280xp.dtsi > > >>> b/arch/arm64/boot/dts/qcom/sc8280xp.dtsi [..] > > >>> + gmu: gmu@3d6a000 { [..]

Re: [Freedreno] (subset) [PATCH 0/4] ARM: dts: qcom: apq8074-dragonboard enable DSI and remoteproc

2023-05-26 Thread Bjorn Andersson
/4] ARM: dts: qcom: apq8074-dragonboard: enable adsp and MSS commit: 3a0dda1a2553f97c0c8aebd181cd33e0eee5094d [4/4] ARM: dts: qcom: apq8074-dragonboard: enable DSI panel commit: ac366501f64f83e03a0f6fd21b87188f92ce0e57 Best regards, -- Bjorn Andersson

Re: [Freedreno] [PATCH v6] drm/msm/dp: enable HDP plugin/unplugged interrupts at hpd_enable/disable

2023-05-25 Thread Bjorn Andersson
> Changes in V5: > -- replace dp_display_host_start() with dp_display_host_init() > > Changes in V6: > -- squash remove enable_irq() and disable_irq() > > Fixes: cd198caddea7 ("drm/msm/dp: Rely on hpd_enable/disable callbacks") Reviewed-by: Bjorn Andersson Tested-by: Bjo

Re: [Freedreno] [PATCH] arm64: dts: qcom: enable dual ("bonded") DSI mode for DB845c

2023-05-24 Thread Bjorn Andersson
; > Applied, thanks! [1/1] arm64: dts: qcom: enable dual ("bonded") DSI mode for DB845c commit: 8721e18ca6960f3c5a6a7f58245d9ab084ad09dd Best regards, -- Bjorn Andersson

Re: [Freedreno] [PATCH] drm/msm/a6xx: don't set IO_PGTABLE_QUIRK_ARM_OUTER_WBWA with coherent SMMU

2023-05-23 Thread Bjorn Andersson
On Mon, Apr 10, 2023 at 09:52:26PM +0300, Dmitry Baryshkov wrote: > If the Adreno SMMU is dma-coherent, allocation will fail unless we > disable IO_PGTABLE_QUIRK_ARM_OUTER_WBWA. Skip setting this quirk for the > coherent SMMUs (like we have on sm8350 platform). > > Fixes: 54af0ceb7595 ("arm64: dts

Re: [Freedreno] [PATCH v4] drm/msm/dp: enable HDP plugin/unplugged interrupts at hpd_enable/disable

2023-05-23 Thread Bjorn Andersson
think what Dmitry was asking for was that you remove the disable_irq() from dp_display_request_irq(), but perhaps I missed some argumentation for why that can't/shouldn't be done? > Either way, this looks good and it works for me. Reviewed-by: Bjorn Andersson Tested-by: Bjorn Andersson

Re: [Freedreno] [PATCH v2 3/3] arm64: dts: qcom: sc8280xp: Enable GPU related nodes

2023-05-23 Thread Bjorn Andersson
On Tue, May 23, 2023 at 10:04:40AM +0200, Konrad Dybcio wrote: > > > On 23.05.2023 03:15, Bjorn Andersson wrote: > > From: Bjorn Andersson > > > > Add memory reservation for the zap-shader and enable the Adreno SMMU, > > GPU clock controller, GMU and the GPU n

[Freedreno] [PATCH v2 2/3] arm64: dts: qcom: sc8280xp: Add GPU related nodes

2023-05-22 Thread Bjorn Andersson
From: Bjorn Andersson Add Adreno SMMU, GPU clock controller, GMU and GPU nodes for the SC8280XP. Signed-off-by: Bjorn Andersson Signed-off-by: Bjorn Andersson --- Changes since v1: - Dropped gmu_pdc_seq region from &gmu, as it shouldn't have been used. - Added missing comp

[Freedreno] [PATCH v2 1/3] drm/msm/adreno: Add Adreno A690 support

2023-05-22 Thread Bjorn Andersson
From: Bjorn Andersson Introduce support for the Adreno A690, found in Qualcomm SC8280XP. Signed-off-by: Bjorn Andersson Signed-off-by: Bjorn Andersson --- Changes since v1: - Moved a690 to adreno_is_a660_family(), which simplifies hw_init() and ensured that pdc_in_aop got set. - Dropped

[Freedreno] [PATCH v2 3/3] arm64: dts: qcom: sc8280xp: Enable GPU related nodes

2023-05-22 Thread Bjorn Andersson
From: Bjorn Andersson Add memory reservation for the zap-shader and enable the Adreno SMMU, GPU clock controller, GMU and the GPU nodes for the SC8280XP CRD and the Lenovo ThinkPad X13s. Signed-off-by: Bjorn Andersson Signed-off-by: Bjorn Andersson --- Changes since v1: - None arch/arm64

[Freedreno] [PATCH v2 0/3] drm/msm/adreno: GPU support on SC8280XP

2023-05-22 Thread Bjorn Andersson
This series introduces support for A690 in the DRM/MSM driver and enables it for the two SC8280XP laptops. Bjorn Andersson (3): drm/msm/adreno: Add Adreno A690 support arm64: dts: qcom: sc8280xp: Add GPU related nodes arm64: dts: qcom: sc8280xp: Enable GPU related nodes arch/arm64/boot

Re: [Freedreno] [PATCH v3] drm/msm/dp: enable HDP plugin/unplugged interrupts at hpd_enable/disable

2023-05-22 Thread Bjorn Andersson
On Mon, May 22, 2023 at 03:35:13PM -0700, Kuogee Hsieh wrote: > > > > > >   -static void dp_display_config_hpd(struct dp_display_private *dp) > > > > -{ > > > > - > > > > -    dp_display_host_init(dp); > > > > -    dp_catalog_ctrl_hpd_config(dp->catalog); > > > > - > > > > -    /* Enable plug and

Re: [Freedreno] [PATCH v3] drm/msm/dp: enable HDP plugin/unplugged interrupts at hpd_enable/disable

2023-05-22 Thread Bjorn Andersson
On Mon, May 22, 2023 at 02:31:32PM -0700, Kuogee Hsieh wrote: > The internal_hpd flag is set to true by dp_bridge_hpd_enable() and set to > false by dp_bridge_hpd_disable() to handle GPIO pinmuxed into DP controller > case. HDP related interrupts can not be enabled until internal_hpd is set > to tr

Re: [Freedreno] [RFC] drm/msm/dp: Allow attaching a drm_panel

2023-05-22 Thread Bjorn Andersson
On Mon, May 22, 2023 at 03:51:01PM -0500, Bjorn Andersson wrote: > On Fri, Oct 08, 2021 at 03:38:21PM +0300, Heikki Krogerus wrote: > > Hi, > > > > On Thu, Oct 07, 2021 at 09:15:12AM -0700, Bjorn Andersson wrote: > > > The one thing that I still don't und

Re: [Freedreno] [RFC] drm/msm/dp: Allow attaching a drm_panel

2023-05-22 Thread Bjorn Andersson
On Fri, Oct 08, 2021 at 03:38:21PM +0300, Heikki Krogerus wrote: > Hi, > > On Thu, Oct 07, 2021 at 09:15:12AM -0700, Bjorn Andersson wrote: > > The one thing that I still don't understand though is, if the typec_mux > > is used by the typec controller to inform _the_ mux

Re: [Freedreno] [PATCH v2] drm/msm/dp: remove most of usbpd-related remains

2023-05-20 Thread Bjorn Andersson
On Sat, May 20, 2023 at 09:20:50PM +0300, Dmitry Baryshkov wrote: > Remove most of remains of downstream usbpd code. Mainline kernel uses > different approach for managing Type-C / USB-PD, so this remains unused. > > Signed-off-by: Dmitry Baryshkov Reviewed-by: Bjorn Andersson Re

Re: [Freedreno] [PATCH 3/3] drm/msm/dp: Clean up pdev/dev duplication in dp_power

2023-05-20 Thread Bjorn Andersson
On Sat, May 20, 2023 at 04:26:59AM +0300, Dmitry Baryshkov wrote: > On 15/05/2023 06:02, Bjorn Andersson wrote: > > The dp_power module keeps track of both the DP controller's struct > > platform_device and struct device - with the prior pulled out of the > > dp_parser

[Freedreno] [PATCH 1/3] drm/msm/dp: Drop now unused dp_hpd module

2023-05-14 Thread Bjorn Andersson
The dp_hpd module is a remnant from the downstream design and is now completely unused. Drop it and all references to it. Signed-off-by: Bjorn Andersson --- drivers/gpu/drm/msm/dp/dp_debug.c | 8 ++- drivers/gpu/drm/msm/dp/dp_debug.h | 12 ++--- drivers/gpu/drm/msm/dp/dp_display.c | 35

[Freedreno] [PATCH 2/3] drm/msm/dp: Clean up logs dp_power module

2023-05-14 Thread Bjorn Andersson
module does thereby not provide any benefit. While at it, none of the dp_power handles passed to these functions are dynamic in nature, so there should not be any need for runtime checking them. Drop these as well. Signed-off-by: Bjorn Andersson --- drivers/gpu/drm/msm/dp/dp_power.c | 62

[Freedreno] [PATCH 3/3] drm/msm/dp: Clean up pdev/dev duplication in dp_power

2023-05-14 Thread Bjorn Andersson
The dp_power module keeps track of both the DP controller's struct platform_device and struct device - with the prior pulled out of the dp_parser module. Clean up the duplication by dropping the platform_device reference and just track the passed struct device. Signed-off-by: Bjorn Ande

Re: [Freedreno] [PATCH v1 1/2] drm/msm/dp: enable HDP plugin/unplugged interrupts to hpd_enable/disable

2023-05-11 Thread Bjorn Andersson
On Thu, May 11, 2023 at 07:24:46AM +0300, Dmitry Baryshkov wrote: > On Wed, 10 May 2023 at 23:31, Kuogee Hsieh wrote: > > > > The internal_hpd flag was introduced to handle external DP HPD derived from > > GPIO > > pinmuxed into DP controller. HPD plug/unplug interrupts cannot be enabled > > unt

Re: [Freedreno] [PATCH v1 1/2] drm/msm/dp: enable HDP plugin/unplugged interrupts to hpd_enable/disable

2023-05-11 Thread Bjorn Andersson
On Wed, May 10, 2023 at 05:39:07PM -0700, Abhinav Kumar wrote: > > > On 5/10/2023 4:55 PM, Stephen Boyd wrote: > > Quoting Kuogee Hsieh (2023-05-10 13:31:04) > > > The internal_hpd flag was introduced to handle external DP HPD derived > > > from GPIO > > > pinmuxed into DP controller. > > > > W

Re: [Freedreno] [PATCH v1 1/2] drm/msm/dp: enable HDP plugin/unplugged interrupts to hpd_enable/disable

2023-05-11 Thread Bjorn Andersson
On Wed, May 10, 2023 at 04:55:04PM -0700, Stephen Boyd wrote: > Quoting Kuogee Hsieh (2023-05-10 13:31:04) > > The internal_hpd flag was introduced to handle external DP HPD derived from > > GPIO > > pinmuxed into DP controller. > > Was it? It looks more like it was done to differentiate between

Re: [Freedreno] [PATCH] Revert "drm/msm/dp: Remove INIT_SETUP delay"

2023-05-07 Thread Bjorn Andersson
On Mon, May 08, 2023 at 01:06:13AM +, Leonard Lausen wrote: > This reverts commit e17af1c9d861dc177e5b56009bd4f71ace688d97. > > Removing the delay of 100 units broke hot plug detection for USB-C displays on > qcom sc7180 lazor devices. Lazor uses mdss for hot plug detection and declares > dp_h

Re: [Freedreno] (subset) [PATCH v3 0/5] SM8[12]50 GPU speedbin

2023-04-07 Thread Bjorn Andersson
2a50d1a038be17972220a810c28e9b777cdfcb22 Best regards, -- Bjorn Andersson

Re: [Freedreno] (subset) [PATCH v2 00/23] drm/msm+PM+icc: Make job_run() reclaim-safe

2023-04-07 Thread Bjorn Andersson
to complete, causing deadlock. > > [...] Applied, thanks! [20/23] soc: qcom: smd-rpm: Use GFP_ATOMIC in write path commit: 5808c532ca0a983d643319caca44f2bcb148298f Best regards, -- Bjorn Andersson

Re: [Freedreno] [PATCH] arm64: dts: qcom: sc7280: remove hbr3 support on herobrine boards

2023-04-07 Thread Bjorn Andersson
b515d7c50ed429ef4e1c5f3f Best regards, -- Bjorn Andersson

Re: [Freedreno] (subset) [PATCH v6 0/9] Fix DSI host idx detection on HW revision clash

2023-04-07 Thread Bjorn Andersson
v5: > - Drop superfluous items: level in [8/10] > - Remove the header define for the qcm2290 config in [6/10] instead of > [7/10] > - Pick up tags > > [...] Applied, thanks! [9/9] arm64: dts: qcom: sm6115: Use the correct DSI compatible commit: 1e6e0c1c971e5e02047a05c015510cc203530dc2 Best regards, -- Bjorn Andersson

Re: [Freedreno] (subset) [PATCH v2 0/4] arm64: qcom: sm8450: bindings check cleanup

2023-04-04 Thread Bjorn Andersson
ove invalid properties in cluster-sleep nodes commit: 35fa9a7fc577a4d1ed541ff37d9dda83b0635e4b Best regards, -- Bjorn Andersson

Re: [Freedreno] [PATCH v14 14/14] drm/msm/dp: set self refresh aware based on PSR support

2023-03-26 Thread Bjorn Andersson
On Sun, Mar 26, 2023 at 09:27:23AM -0700, Bjorn Andersson wrote: > On Thu, Mar 02, 2023 at 10:03:17PM +0530, Vinod Polimera wrote: > > For the PSR to kick in, self_refresh_aware has to be set. > > Initialize it based on the PSR support for the eDP interface. > > > &

Re: [Freedreno] [PATCH v14 14/14] drm/msm/dp: set self refresh aware based on PSR support

2023-03-26 Thread Bjorn Andersson
On Thu, Mar 02, 2023 at 10:03:17PM +0530, Vinod Polimera wrote: > For the PSR to kick in, self_refresh_aware has to be set. > Initialize it based on the PSR support for the eDP interface. > When I boot my sc8280xp devices (CRD and X13s) to console with this patch included I get a login prompt, an

Re: [Freedreno] [PATCH v2 2/4] arm64: dts: qcom: sm8450: remove invalid properties in cluster-sleep nodes

2023-03-24 Thread Bjorn Andersson
On Fri, Mar 24, 2023 at 08:27:12PM +0100, Krzysztof Kozlowski wrote: > On 24/03/2023 18:45, Bjorn Andersson wrote: > > On Fri, Mar 24, 2023 at 10:28:47AM +0100, Neil Armstrong wrote: > >> Fixes the following DT bindings check error: > > > > Is that because idle-s

Re: [Freedreno] (subset) [PATCH v2 0/4] arm64: qcom: sm8450: bindings check cleanup

2023-03-24 Thread Bjorn Andersson
move invalid power-domain-names in pcie nodes commit: c98a56395e7854f7975dd8539d0563e0ac7d060e [4/4] arm64: dts: qcom: sm8450: fix pcie1 gpios properties name commit: e57430d2483506f046e39bf8c61159dde88aede2 Best regards, -- Bjorn Andersson

Re: [Freedreno] (subset) [PATCH v6 0/5] arm64: dts: qcom: add DP Controller to SM8350 & SM8450 DTS

2023-03-24 Thread Bjorn Andersson
d dp controller commit: a2802008af93b70165a80624082c695d89f51eb2 [4/5] arm64: dts: qcom: sm8450: switch to usb3/dp combo phy commit: d3054cec1e9ea475e53280724db62b62e25669d7 [5/5] arm64: dts: qcom: sm8450: add dp controller commit: bdd2f4ce5e762d5aede6c30ae161e377536dae1c Best regards, -- Bjorn Andersson

Re: [Freedreno] [PATCH v2 2/4] arm64: dts: qcom: sm8450: remove invalid properties in cluster-sleep nodes

2023-03-24 Thread Bjorn Andersson
On Fri, Mar 24, 2023 at 10:28:47AM +0100, Neil Armstrong wrote: > Fixes the following DT bindings check error: Is that because idle-state-name and local-timer-stop should not be defined for domain-idle-states or are you just clearing out the dtbs_check warning? According to cpu-capacity.txt local

Re: [Freedreno] [PATCH v6 5/5] arm64: dts: qcom: sm8450: add dp controller

2023-03-23 Thread Bjorn Andersson
On Tue, Mar 21, 2023 at 09:51:34PM +0100, Konrad Dybcio wrote: > On 17.03.2023 16:06, Neil Armstrong wrote: > > @@ -2783,6 +2790,78 @@ opp-5 { > > }; > > }; > > > > + mdss_dp0: displayport-controller@ae9 { > > +

Re: [Freedreno] [PATCH] drm/msm: Initialize mode_config earlier

2023-03-02 Thread Bjorn Andersson
On Wed, Mar 01, 2023 at 02:58:50PM +0100, Johan Hovold wrote: > On Tue, Jan 24, 2023 at 09:09:02AM +0100, Johan Hovold wrote: > > On Mon, Jan 23, 2023 at 09:17:49AM -0800, Bjorn Andersson wrote: > > > On Mon, Jan 23, 2023 at 05:01:45PM +0100, Johan Hovold wrote: > > > &

Re: [Freedreno] [RFC PATCH 2/2] drm/msm/dp: enable pm_runtime support for dp driver

2023-02-27 Thread Bjorn Andersson
On Thu, Feb 23, 2023 at 07:26:35PM +0530, Sankeerth Billakanti wrote: > diff --git a/drivers/gpu/drm/msm/dp/dp_aux.c b/drivers/gpu/drm/msm/dp/dp_aux.c [..] > +static int dp_runtime_resume(struct device *dev) > +{ > + struct platform_device *pdev = to_platform_device(dev); > + struct msm_dp

Re: [Freedreno] [PATCH v3 0/6] arm64: dts: qcom: sm8350: enable GPU on the HDK board

2023-02-13 Thread Bjorn Andersson
8ecd17bb681d1743309b0d2a4622b643b61d69c Best regards, -- Bjorn Andersson

Re: [Freedreno] [PATCH] firmware: qcom_scm: Move qcom_scm.h to include/linux/firmware/qcom/

2023-02-08 Thread Bjorn Andersson
mware: qcom_scm: Move qcom_scm.h to include/linux/firmware/qcom/ commit: 3bf90eca76c98c55c975fa817799789b9176f9f3 Best regards, -- Bjorn Andersson

Re: [Freedreno] (subset) [PATCH v2 0/8] arm64: dts: qcom: sm8350: enable GPU on the HDK board

2023-02-08 Thread Bjorn Andersson
e do not support that chip > revision. > > [...] Applied, thanks! [2/8] dt-bindings: power: qcom,rpmpd: add RPMH_REGULATOR_LEVEL_LOW_SVS_L1 commit: bdd133c2eeffad142e7c8a48ab7e86e1ca37e67d Best regards, -- Bjorn Andersson

Re: [Freedreno] (subset) [PATCH 0/6] drm/msm/hdmi: integrate msm8960 HDMI PHY with DT clocks infrastructure

2023-02-08 Thread Bjorn Andersson
> > [...] Applied, thanks! [5/6] ARM: dts: qcom: apq8064: add #clock-cells to the HDMI PHY node commit: c9f678afe0bbdfb3748c1db5ac94d1c02a6eb64b [6/6] ARM: dts: qcom: apq8064: use hdmi_phy for the MMCC's hdmipll clock commit: f1a359db6d9d198b84877e2340dd7c37809a4882 Best regards, -- Bjorn Andersson

Re: [Freedreno] [PATCH v2 4/8] arm64: dts: qcom: sm8350: reorder device nodes

2023-02-08 Thread Bjorn Andersson
On Mon, Feb 06, 2023 at 04:57:03PM +0200, Dmitry Baryshkov wrote: > Start ordering DT nodes according to agreed order. Move apps SMMU, GIC, > timer, apps RSC, cpufreq ADSP and cDSP nodes to the end to the proper > position at the end of /soc/. > I think "according to agreed order" means "sorted b

[Freedreno] [PATCH 3/3] arm64: dts: qcom: sc8280xp: Enable GPU related nodes

2023-02-07 Thread Bjorn Andersson
From: Bjorn Andersson Add memory reservation for the zap-shader and enable the Adreno SMMU, GPU clock controller, GMU and the GPU nodes for the SC8280XP CRD and the Lenovo ThinkPad X13s. Signed-off-by: Bjorn Andersson Signed-off-by: Bjorn Andersson --- arch/arm64/boot/dts/qcom/sc8280xp

[Freedreno] [PATCH 2/3] arm64: dts: qcom: sc8280xp: Add GPU related nodes

2023-02-07 Thread Bjorn Andersson
From: Bjorn Andersson Add Adreno SMMU, GPU clock controller, GMU and GPU nodes for the SC8280XP. Signed-off-by: Bjorn Andersson Signed-off-by: Bjorn Andersson --- arch/arm64/boot/dts/qcom/sc8280xp.dtsi | 171 + 1 file changed, 171 insertions(+) diff --git a/arch

[Freedreno] [PATCH 1/3] drm/msm/adreno: Add Adreno A690 support

2023-02-07 Thread Bjorn Andersson
From: Bjorn Andersson Introduce support for the Adreno A690, found in Qualcomm SC8280XP. Signed-off-by: Bjorn Andersson Signed-off-by: Bjorn Andersson --- drivers/gpu/drm/msm/adreno/a6xx_gpu.c | 120 - drivers/gpu/drm/msm/adreno/a6xx_hfi.c | 34 ++ drivers

[Freedreno] [PATCH 0/3] drm/msm/adreno: GPU support on SC8280XP

2023-02-07 Thread Bjorn Andersson
This series introduces support for A690 in the DRM/MSM driver and enables it for the two SC8280XP laptops. Bjorn Andersson (3): drm/msm/adreno: Add Adreno A690 support arm64: dts: qcom: sc8280xp: Add GPU related nodes arm64: dts: qcom: sc8280xp: Enable GPU related nodes arch/arm64/boot

Re: [Freedreno] (subset) [PATCH 1/4] dt-bindings: display/msm: add qcom, sc8280xp-edp to list of eDP devices

2023-02-03 Thread Bjorn Andersson
arm64: dts: qcom: sc8280xp: add p1 register blocks to DP nodes commit: 19eee67386fe68b8f39dc947d15711a5b5cef6ac Best regards, -- Bjorn Andersson

Re: [Freedreno] [PATCH] arm64: dts: qcom: sm8350: use qcom, sm8350-dsi-ctrl compatibles

2023-02-03 Thread Bjorn Andersson
commit: d7133d6d25fbc9374447e2ca4e23a04023824779 Best regards, -- Bjorn Andersson

[Freedreno] [RFC] drm/msm/adreno: Balance pm_runtime enable

2023-02-03 Thread Bjorn Andersson
adreno_unbind(). Fixes: 4b18299b3365 ("drm/msm/adreno: Defer enabling runpm until hw_init()") Signed-off-by: Bjorn Andersson --- drivers/gpu/drm/msm/adreno/adreno_device.c | 11 ++- 1 file changed, 2 insertions(+), 9 deletions(-) diff --git a/drivers/gpu/drm/msm/adreno/adreno_d

Re: [Freedreno] (subset) [PATCH 1/8] drm/msm/dsi: Allow 2 CTRLs on v2.5.0

2023-01-30 Thread Bjorn Andersson
k up DSI1 to MDP commit: b904227a4b693fbb9d5eabc9d7100dc01d9eb973 Best regards, -- Bjorn Andersson

Re: [Freedreno] [PATCH] drm/msm: Initialize mode_config earlier

2023-01-23 Thread Bjorn Andersson
On Mon, Jan 23, 2023 at 05:01:45PM +0100, Johan Hovold wrote: > On Tue, Jan 17, 2023 at 09:04:39AM +0100, Johan Hovold wrote: > > On Mon, Jan 16, 2023 at 08:51:22PM -0600, Bjorn Andersson wrote: > > > On Fri, Jan 13, 2023 at 10:57:18AM +0200, Dmitry Baryshkov wrote: > >

Re: [Freedreno] [PATCH v5 10/12] arm64: dts: qcom: sc8280xp: Define some of the display blocks

2023-01-19 Thread Bjorn Andersson
On Wed, Jan 18, 2023 at 04:58:26AM +0200, Dmitry Baryshkov wrote: > On 08/12/2022 00:00, Bjorn Andersson wrote: > > From: Bjorn Andersson > > > > Define the display clock controllers, the MDSS instances, the DP phys > > and connect these together. > > &

Re: [Freedreno] (subset) [PATCH v5 0/4] dt-bindings: display/msm: convert MDP5 schema to YAML format

2023-01-18 Thread Bjorn Andersson
> Changes since v4: > - Adjust qcom,mdss.yaml to follow the addition of per-SoC compatibles > > [...] Applied, thanks! [3/4] ARM: dts: qcom-msm8974: add SoC specific compat string to mdp5 node commit: 11691dab82e135c9a13cda49234ff3e76bba48d3 Best regards, -- Bjorn Andersson

Re: [Freedreno] (subset) [PATCH 0/6] dt-bindings: display/msm: rename mdss and mdp nodes

2023-01-18 Thread Bjorn Andersson
974: rename mdss node to display-subsystem commit: 19230930286005d7c733a5cb0ed8ebce9cad4423 [6/6] ARM: dts: qcom: rename mdp nodes to display-controller commit: 858b0d4b04ead05cdfec094a1e4b18865f28cedc Best regards, -- Bjorn Andersson

Re: [Freedreno] (subset) [PATCH v16 0/5] Add data-lanes and link-frequencies to dp_out endpoint

2023-01-17 Thread Bjorn Andersson
/dp: add support of max dp link rate > > [...] Applied, thanks! [1/5] arm64: dts: qcom: add data-lanes and link-freuencies into dp_out endpoint commit: 26c5aa54f5973a3b1181939811f231faa638332a Best regards, -- Bjorn Andersson

[Freedreno] [PATCH] drm/msm/dp: Remove INIT_SETUP delay

2023-01-17 Thread Bjorn Andersson
Type-C and have the display power up, without disconnecting and reconnecting the cable. Signed-off-by: Bjorn Andersson --- drivers/gpu/drm/msm/dp/dp_display.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/msm/dp/dp_display.c b/drivers/gpu/drm/msm/dp/dp_

Re: [Freedreno] [PATCH] drm/msm: Initialize mode_config earlier

2023-01-16 Thread Bjorn Andersson
On Fri, Jan 13, 2023 at 10:57:18AM +0200, Dmitry Baryshkov wrote: > On 13/01/2023 06:23, Dmitry Baryshkov wrote: > > On 13/01/2023 06:10, Bjorn Andersson wrote: > > > Invoking drm_bridge_hpd_notify() on a drm_bridge with a HPD-enabled > > > bridge_connector ends up in

[Freedreno] [PATCH] drm/msm: Initialize mode_config earlier

2023-01-12 Thread Bjorn Andersson
ld Signed-off-by: Bjorn Andersson --- drivers/gpu/drm/msm/msm_drv.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/msm/msm_drv.c b/drivers/gpu/drm/msm/msm_drv.c index ee2f60b6f09b..7ac670f3e6ab 100644 --- a/drivers/gpu/drm/msm/msm_drv.c +++ b/drivers/g

Re: [Freedreno] (subset) [PATCH 1/3] ARM: dts: qcom: msm8974: Add compat qcom, msm8974-dsi-ctrl to dsi1

2023-01-10 Thread Bjorn Andersson
commit: b0b8b34a8d6b4c50dac086ca18964fae5e6954d4 [3/3] arm64: dts: qcom: sm8450: Add compat qcom,sm8450-dsi-ctrl commit: b7f4f6971d62f0019c27142ee6b703d8cab96e38 Best regards, -- Bjorn Andersson

Re: [Freedreno] (subset) [PATCH v5 0/5] Improve GPU reset sequence for Adreno GPU

2023-01-10 Thread Bjorn Andersson
2a974cc7eaa971fae92aa477c5 [2/5] clk: qcom: gdsc: Support 'synced_poweroff' genpd flag commit: 8b6af3b58cafc2cbdf6269f655b2d3731eb93c2f Best regards, -- Bjorn Andersson

Re: [Freedreno] [PATCH v5 0/5] Improve GPU reset sequence for Adreno GPU

2023-01-10 Thread Bjorn Andersson
On Mon, Jan 02, 2023 at 04:18:26PM +0530, Akhil P Oommen wrote: > > This is a rework of [1] using genpd instead of 'reset' framework. > > As per the recommended reset sequence of Adreno gpu, we should ensure that > gpucc-cx-gdsc has collapsed at hardware to reset gpu's internal hardware > states

<    1   2   3   4   5   6   7   8   >