Re: [Freedreno] [PATCH v6 20/21] drm/kirin: dsi: Adjust probe order

2021-10-27 Thread John Stultz
rivers were taking evasive maneuvers to try to workaround this, > but not all of them were following the same conventions, resulting in > various incompatibilities between DSI hosts and devices. > > Now that we have a sequence agreed upon and documented, let's convert > kirin to it. > &g

Re: [Freedreno] [PATCH] drm/msm/devfreq: Restrict idle clamping to a618 for now

2021-10-18 Thread John Stultz
a workaround for the power > instability issues on a630.. could you give it a try? While I hit it fairly often, I can't reliably reproduce the crash, but in limited testing this seems ok to me. I've not hit the crash so far, nor seen any other negative side effects over 5.14. So for what that's

Re: [Freedreno] [PATCH v2 2/2] qcom_scm: hide Kconfig symbol

2021-10-11 Thread John Stultz
On Thu, Oct 7, 2021 at 8:10 AM Arnd Bergmann wrote: > > From: Arnd Bergmann > > Now that SCM can be a loadable module, we have to add another > dependency to avoid link failures when ipa or adreno-gpu are > built-in: > > aarch64-linux-ld: drivers/net/ipa/ipa_main.o: in function `ipa_probe': >

Re: [Freedreno] [PATCH v4 00/24] drm/bridge: Make panel and bridge probe order consistent

2021-09-29 Thread John Stultz
On Wed, Sep 29, 2021 at 4:20 PM Rob Clark wrote: > On Wed, Sep 29, 2021 at 2:51 PM John Stultz wrote: > > On Wed, Sep 29, 2021 at 2:32 PM John Stultz wrote: > > > On Wed, Sep 29, 2021 at 2:27 PM John Stultz > > > wrote: > > > > On Fri, Sep 1

Re: [Freedreno] [PATCH v4 00/24] drm/bridge: Make panel and bridge probe order consistent

2021-09-29 Thread John Stultz
On Wed, Sep 29, 2021 at 2:51 PM John Stultz wrote: > > On Wed, Sep 29, 2021 at 2:32 PM John Stultz wrote: > > On Wed, Sep 29, 2021 at 2:27 PM John Stultz wrote: > > > On Fri, Sep 10, 2021 at 3:12 AM Maxime Ripard wrote: > > > > The best practice to avoi

Re: [Freedreno] [PATCH v4 00/24] drm/bridge: Make panel and bridge probe order consistent

2021-09-29 Thread John Stultz
On Wed, Sep 29, 2021 at 4:20 PM Rob Clark wrote: > On Wed, Sep 29, 2021 at 2:51 PM John Stultz wrote: > > On Wed, Sep 29, 2021 at 2:32 PM John Stultz wrote: > > > On Wed, Sep 29, 2021 at 2:27 PM John Stultz > > > wrote: > > > > On Fri, Sep 1

Re: [Freedreno] [PATCH v4 00/24] drm/bridge: Make panel and bridge probe order consistent

2021-09-29 Thread John Stultz
On Wed, Sep 29, 2021 at 2:32 PM John Stultz wrote: > On Wed, Sep 29, 2021 at 2:27 PM John Stultz wrote: > > On Fri, Sep 10, 2021 at 3:12 AM Maxime Ripard wrote: > > > The best practice to avoid those issues is to register its functions only > > > after > > &g

Re: [Freedreno] [PATCH v4 00/24] drm/bridge: Make panel and bridge probe order consistent

2021-09-29 Thread John Stultz
On Wed, Sep 29, 2021 at 2:27 PM John Stultz wrote: > > On Fri, Sep 10, 2021 at 3:12 AM Maxime Ripard wrote: > > > > We've encountered an issue with the RaspberryPi DSI panel that prevented the > > whole display driver from probing. > > > > The issue

Re: [Freedreno] [PATCH v4 00/24] drm/bridge: Make panel and bridge probe order consistent

2021-09-29 Thread John Stultz
On Fri, Sep 10, 2021 at 3:12 AM Maxime Ripard wrote: > > We've encountered an issue with the RaspberryPi DSI panel that prevented the > whole display driver from probing. > > The issue is described in detail in the commit 7213246a803f ("drm/vc4: dsi: > Only register our component once a DSI

Re: [Freedreno] [PATCH] drm/msm: Disable frequency clamping on a630

2021-09-03 Thread John Stultz
On Thu, Jul 29, 2021 at 1:49 PM Rob Clark wrote: > On Thu, Jul 29, 2021 at 1:28 PM Caleb Connolly > wrote: > > On 29/07/2021 21:24, Rob Clark wrote: > > > On Thu, Jul 29, 2021 at 1:06 PM Caleb Connolly > > > wrote: > > >> > > >> Hi Rob, > > >> > > >> I've done some more testing! It looks like

Re: [Freedreno] [PATCH] drm/msm: Fix display fault handling

2021-07-26 Thread John Stultz
to f8f934c180f629bb927a04fd90d) > > Reported-by: Dmitry Baryshkov > Reported-by: Yassine Oudjana > Fixes: 2a574cc05d38 ("drm/msm: Improve the a6xx page fault handler") > Signed-off-by: Rob Clark > Tested-by: John Stultz > --- Hey folks! Just wanted to follow up

Re: [Freedreno] [PATCH v5 0/5] iommu/arm-smmu: adreno-smmu page fault handling

2021-07-06 Thread John Stultz
helpful, I applied that and it got the db845c booting mainline again for me (along with some reverts for a separate ext4 shrinker crash). Tested-by: John Stultz thanks -john ___ Freedreno mailing list Freedreno@lists.freedesktop.org https://lists.freed

Re: [Freedreno] [PATCH v4 22/24] drm/msm/dsi: remove temp data from global pll structure

2021-06-11 Thread John Stultz
On Fri, Jun 11, 2021 at 2:01 AM Dmitry Baryshkov wrote: > > Hi, > > On Fri, 11 Jun 2021 at 10:07, John Stultz wrote: > > > > On Wed, Mar 31, 2021 at 3:58 AM Dmitry Baryshkov > > wrote: > > > > > > The 7nm, 10nm and 14nm drivers would store int

Re: [Freedreno] [PATCH v4 22/24] drm/msm/dsi: remove temp data from global pll structure

2021-06-11 Thread John Stultz
On Wed, Mar 31, 2021 at 3:58 AM Dmitry Baryshkov wrote: > > The 7nm, 10nm and 14nm drivers would store interim data used during > VCO/PLL rate setting in the global dsi_pll_Nnm structure. Move this data > structures to the onstack storage. While we are at it, drop > unused/static 'config' data,

Re: [Freedreno] [PATCH] drm/msm/dpu: Delete bonkers code

2021-04-30 Thread John Stultz
CRTC's > atomic_check() should be adding the planes to the atomic update. Thanks! This patch gets things booting again! Tested-by: John Stultz thanks -john ___ Freedreno mailing list Freedreno@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/freedreno

Re: [Freedreno] [PATCH] drm/msm: Fix removal of valid error case when checking speed_bin

2021-04-05 Thread John Stultz
On Mon, Mar 29, 2021 at 6:34 PM John Stultz wrote: > > Commit 7bf168c8fe8c ("drm/msm: Fix speed-bin support not to > access outside valid memory"), reworked the nvmem reading of > "speed_bin", but in doing so dropped handling of the -ENOENT > case which

[Freedreno] [PATCH] drm/msm: Fix removal of valid error case when checking speed_bin

2021-03-29 Thread John Stultz
d-bin support not to access outside valid memory") Signed-off-by: John Stultz --- drivers/gpu/drm/msm/adreno/a6xx_gpu.c | 8 +++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/msm/adreno/a6xx_gpu.c b/drivers/gpu/drm/msm/adreno/a6xx_gpu.c index 690409ca8a186

[Freedreno] [PATCH] drm/msm: Fix 0xfffflub in "Refactor address space initialization"

2020-06-12 Thread John Stultz
m/msm: Refactor address space initialization") Signed-off-by: John Stultz --- drivers/gpu/drm/msm/adreno/adreno_gpu.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/msm/adreno/adreno_gpu.c b/drivers/gpu/drm/msm/adreno/adreno_gpu.c index 89673c7ed473.

Re: [Freedreno] [v1] drm/msm/dpu: request for display color blocks based on hw catalog entry

2020-06-11 Thread John Stultz
On Thu, Jun 11, 2020 at 5:55 AM Krishna Manikandan wrote: > > From: Kalyan Thota > > Request for color processing blocks only if they are > available in the display hw catalog and they are > sufficient in number for the selection. > > Signed-off-by: Kalyan Thota Tested-

Re: [Freedreno] [PATCH 1/2] drm/msm/dpu: add support for color processing blocks in dpu driver

2020-06-08 Thread John Stultz
On Mon, Jun 8, 2020 at 3:25 PM John Stultz wrote: > > On Wed, Mar 25, 2020 at 1:17 AM Kalyan Thota wrote: > > > > This change adds support to configure dspp blocks in > > the dpu driver. > > > > Macro description of the changes coming in this patch. > >

Re: [Freedreno] [PATCH 1/2] drm/msm/dpu: add support for color processing blocks in dpu driver

2020-06-08 Thread John Stultz
On Wed, Mar 25, 2020 at 1:17 AM Kalyan Thota wrote: > > This change adds support to configure dspp blocks in > the dpu driver. > > Macro description of the changes coming in this patch. > 1) Add dspp definitions in the hw catalog. > 2) Add capability to reserve dspp blocks in the display data

Re: [Freedreno] [PATCH v2 4/4] drm/msm/a6xx: Use the DMA API for GMU memory objects

2020-02-25 Thread John Stultz
On Thu, Feb 20, 2020 at 10:27 AM Jordan Crouse wrote: > > The GMU has very few memory allocations and uses a flat memory space so > there is no good reason to go out of our way to bypass the DMA APIs which > were basically designed for this exact scenario. > > v2: Pass force_dma false to

Re: [Freedreno] [PATCH v2 0/4] msm/gpu/a6xx: use the DMA-API for GMU memory allocations

2020-02-20 Thread John Stultz
onverted to YAML and 99 less lines of code to worry about. > > v2: Fix the example bindings for dma-ranges - the third item is the size > Pass false to of_dma_configure so that it fails probe if the DMA region is not > set up. This set still works

Re: [Freedreno] [PATCH v1 0/4] msm/gpu/a6xx: use the DMA-API for GMU memory allocations

2020-02-19 Thread John Stultz
gt; drm/msm/a6xx: Use the DMA API for GMU memory objects Awesome! Thanks so much for the quick turnaround on this! This set resolves the crashes I was seeing with CONFIG_INIT_ON_ALLOC_DEFAULT_ON. Tested-by: John Stultz thanks again! -john ___ Freedr

Re: [Freedreno] [PATCH] drm/msm/a6xx: Remove unneeded GBIF unhalt

2020-02-05 Thread John Stultz
roid-dev.git/commit/?h=dev/db845c-mainline-WIP=4e6a2e84dd77fe74faa1a6b797eb0ee7bf11ffd7 So, I think I can safely add: Tested-by: John Stultz Thanks so much for the quick turnaround on this! -john ___ Freedreno mailing list Freedreno@lists.freedesktop.org

Re: [Freedreno] [PATCH v2 2/3] drm: msm: a6xx: Add support for A618

2020-02-03 Thread John Stultz
On Wed, Jan 22, 2020 at 11:19 PM Sharat Masetty wrote: > > This patch adds support for enabling Graphics Bus Interface(GBIF) > used in multiple A6xx series chipets. Also makes changes to the > PDC/RSC sequencing specifically required for A618. This is needed > for proper interfacing with RPMH. >

[Freedreno] [PATCH] drm: msm: Fix return type of dsi_mgr_connector_mode_valid for kCFI

2020-01-29 Thread John Stultz
: freedreno@lists.freedesktop.org Cc: clang-built-li...@googlegroups.com Signed-off-by: John Stultz --- drivers/gpu/drm/msm/dsi/dsi_manager.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/msm/dsi/dsi_manager.c b/drivers/gpu/drm/msm/dsi/dsi_manager.c index

[Freedreno] [PATCH] drm: msm: Quiet down plane errors in atomic_check

2020-01-07 Thread John Stultz
: David Airlie Cc: Daniel Vetter Cc: dri-de...@lists.freedesktop.org Cc: freedreno@lists.freedesktop.org Signed-off-by: John Stultz --- drivers/gpu/drm/msm/disp/dpu1/dpu_plane.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/drivers/gpu/drm/msm/disp/dpu1