[Freeipa-devel] [PATCH] jderose 042 output_params

2010-02-10 Thread Jason Gerard DeRose
As discussed with Rob on IRC, this patch changes the Command.get_output_params() method so that by default your Command.output_params will be the same as your Command.params. This make the behavior similar to how Method.get_output_params() fills your Method.params with the params in the correspond

Re: [Freeipa-devel] [PATCH[ 376 fix ipa-join segfault

2010-02-10 Thread Jason Gerard DeRose
On Tue, 2010-02-09 at 23:04 -0500, Rob Crittenden wrote: > Make sure incoming data isn't NULL before trying to strdup() it. Bad > things happen otherwise. > > rob ack. pushed to master. ___ Freeipa-devel mailing list Freeipa-devel@redhat.com https://

Re: [Freeipa-devel] [PATCH] 375 selinux fix for CRLs

2010-02-10 Thread Jason Gerard DeRose
On Tue, 2010-02-09 at 17:25 -0500, Rob Crittenden wrote: > Fix an SELinux permissions problem when retrieving CRLs via Apache. > > rob ack. pushed to master. ___ Freeipa-devel mailing list Freeipa-devel@redhat.com https://www.redhat.com/mailman/listin

[Freeipa-devel] Important: Action required if you add a new file

2010-02-10 Thread John Dennis
If you add a new file to our git tree and that file has translatable strings in it (e.g. a string enclosed in _()) then you must edit the file install/po/Makefile.in and add the file to one of the POTFILES list (currently there are two POTFILES lists, one for python sources and one for C sourc

[Freeipa-devel] [PATCH] Friendlier diagnostics for i18n test

2010-02-10 Thread John Dennis
The diagnostic messages in test_i18n.py were a bit confusing because it didn't indicate what the test string was and where it came from. Hopefully this is clearer now. -- John Dennis Looking to carve out IT costs? www.redhat.com/carveoutcosts/ From c81728580e4e5f43d5cd35a0d48073e63d2cfe05 Mon Se

Re: [Freeipa-devel] [PATCHES] Bring back old outputting functionality

2010-02-10 Thread Jason Gerard DeRose
On Wed, 2010-02-10 at 10:30 -0500, Rob Crittenden wrote: > Pavel Zuna wrote: > > What I'm saying is that the Env object stores all strings as str and the > > env command uses the same output_for_cli as LDAP commands, that only use > > str for binary. So, we either need to override output_for_cli

Re: [Freeipa-devel] [PATCH] add a test locale to our i18n support, used for testing translations

2010-02-10 Thread Rob Crittenden
John Dennis wrote: This patch adds testing support to our i18n translations. Read the file test_i18n.py to see how this is done. Makefile now supports a test_lang and test target "make test" creates the test language, installs it in under a temporary locale directory in the install/po subdir

Re: [Freeipa-devel] [PATCH] Pass target locale to msginit

2010-02-10 Thread Rob Crittenden
John Dennis wrote: Pass target locale to msginit msginit should have been passed the locale because the resulting .po file is parameterized from the locale. Also, if the target locale is not specified it defaults to the current locale. If the target locale is English msgid's are copied to their

Re: [Freeipa-devel] [PATCH] Add 1 intital language translation

2010-02-10 Thread Rob Crittenden
John Dennis wrote: The %{find_lang} macro in the ipa.spec file will fail if there are no language translations causing the build to fail. This patch creates an Italian translation (in honor of Simo). The Italian translation is initially fully untranslated. ack, pushed to master __

[Freeipa-devel] [PATCH] Add 1 intital language translation

2010-02-10 Thread John Dennis
The %{find_lang} macro in the ipa.spec file will fail if there are no language translations causing the build to fail. This patch creates an Italian translation (in honor of Simo). The Italian translation is initially fully untranslated. -- John Dennis Looking to carve out IT costs? www.redhat.

Re: [Freeipa-devel] [PATCHES] Bring back old outputting functionality

2010-02-10 Thread Rob Crittenden
Pavel Zuna wrote: Rob Crittenden wrote: Pavel Zuna wrote: I compiled 3 patches, that effectively bring back all the functionality we had before Jasons big patch (i.e. before introducing output validation and the common output interface). --all and --raw are back, but this time as global opti

[Freeipa-devel] [PATCH] Pass target locale to msginit

2010-02-10 Thread John Dennis
Pass target locale to msginit msginit should have been passed the locale because the resulting .po file is parameterized from the locale. Also, if the target locale is not specified it defaults to the current locale. If the target locale is English msgid's are copied to their msgstr's resulting i

Re: [Freeipa-devel] [PATCHES] Bring back old outputting functionality

2010-02-10 Thread Pavel Zuna
Rob Crittenden wrote: Pavel Zuna wrote: I compiled 3 patches, that effectively bring back all the functionality we had before Jasons big patch (i.e. before introducing output validation and the common output interface). --all and --raw are back, but this time as global options replacing DNs w

Re: [Freeipa-devel] [PATCHES] Bring back old outputting functionality

2010-02-10 Thread Pavel Zuna
Rob Crittenden wrote: Pavel Zuna wrote: I compiled 3 patches, that effectively bring back all the functionality we had before Jasons big patch (i.e. before introducing output validation and the common output interface). --all and --raw are back, but this time as global options replacing DNs w