Re: [Freeipa-devel] More types of replica in FreeIPA

2012-04-09 Thread Rich Megginson
On 04/06/2012 09:15 AM, Ondrej Hamada wrote: On 04/04/2012 06:16 PM, Ondrej Hamada wrote: On 04/04/2012 03:02 PM, Simo Sorce wrote: On Tue, 2012-04-03 at 18:45 +0200, Ondrej Hamada wrote: On 03/13/2012 01:13 AM, Dmitri Pal wrote: On 03/12/2012 06:10 PM, Simo Sorce wrote: On Mon, 2012-03-12

Re: [Freeipa-devel] [PATCH] 0034 Limit permission and selfservice names

2012-04-09 Thread Rob Crittenden
Petr Viktorin wrote: https://fedorahosted.org/freeipa/ticket/2585: ipa permission-add throws internal server error when name contains '', '' or other special characters. The problem is, of course, proper escaping; not only in DNs but also in ACIs. Right now we don't really do either. This

Re: [Freeipa-devel] [PATCH] 1003 return consistent value in netgroup triple

2012-04-09 Thread Rob Crittenden
Jan Cholasta wrote: On 5.4.2012 20:55, Rob Crittenden wrote: Jan Cholasta wrote: On 5.4.2012 17:04, Rob Crittenden wrote: When constructing netgroup triples with hostcat or usercat set to all we weren't setting the user/host part of the triple correctly. The first entry would have '' as the

Re: [Freeipa-devel] [PATCH] 74 Check configured maximum user login length on user rename

2012-04-09 Thread Rob Crittenden
Jan Cholasta wrote: On 5.4.2012 23:38, Rob Crittenden wrote: Jan Cholasta wrote: https://fedorahosted.org/freeipa/ticket/2587 Honza This looks ok, it would be nice to have a unit test. rob Test added. Honza ACK, pushed to master and ipa-2-2

Re: [Freeipa-devel] [PATCH] 247 Fix installation when server hostname is not in a default domain

2012-04-09 Thread Rob Crittenden
Martin Kosek wrote: When IPA server is configured with DNS and its hostname is not located in a default domain, SRV records are not valid. Additionally, httpd does not serve XMLRPC interface because it IPA server domain-realm mapping is missing in krb5.conf. All CLI commands were then failing.

[Freeipa-devel] [PATCH] 1005 fix password history

2012-04-09 Thread Rob Crittenden
Password history wasn't working because the qsort comparison function was comparing pointers, not data. This resulted in a random element being removed from the history on overflow rather than the oldest. We sort in reverse so we don't have to move elements inside the list when removing to

Re: [Freeipa-devel] [PATCH] 1005 fix password history

2012-04-09 Thread yi zhang
On 04/09/2012 08:54 PM, Rob Crittenden wrote: Password history wasn't working because the qsort comparison function was comparing pointers, not data. This resulted in a random element being removed from the history on overflow rather than the oldest. We sort in reverse so we don't have to