Re: [Freeipa-devel] DN patch and documentation

2012-07-27 Thread Petr Viktorin
On 07/26/2012 10:11 PM, John Dennis wrote: On 07/17/2012 06:47 PM, John Dennis wrote: ipapython/dn.py: in docstring: DN(arg0, ..., locked=False, first_key_match=True) followed by: def __init__(self, *args, **kwds): and: kwds.get('first_key_match', True) I don't see the

[Freeipa-devel] [PATCH 0042] Flush zones and RRs cache when handling persistent search reconnection

2012-07-27 Thread Petr Spacek
Hello, this patch implements Flush zones and RRs cache when handling persistent search reconnection behaviour as requested in ticket https://fedorahosted.org/bind-dyndb-ldap/ticket/44 . Petr^2 Spacek From 06f38006e841a210d60ae93bb5c9027e40073d84 Mon Sep 17 00:00:00 2001 From: Petr Spacek

[Freeipa-devel] [PATCH 0042] Flush zones and RRs cache when handling persistent search reconnection

2012-07-27 Thread Petr Spacek
Hello, this patch implements Flush zones and RRs cache when handling persistent search reconnection behaviour as requested in ticket https://fedorahosted.org/bind-dyndb-ldap/ticket/44 . Petr^2 Spacek From 06f38006e841a210d60ae93bb5c9027e40073d84 Mon Sep 17 00:00:00 2001 From: Petr Spacek

[Freeipa-devel] [Patch] 0001 Add check for existence of ipa-join in the tree in test_host_plugin.py

2012-07-27 Thread Tomas Babej
Hi, this patch simply checks if ipa-join exists in ipa-client folder, if not, skips tests relying on it. Uses nose.plugin.skip. https://fedorahosted.org/freeipa/ticket/2905 Tomas BabejFrom 2f7cb184619fddd40c7d141b42d35892b6cd5aff Mon Sep 17 00:00:00 2001 From: Tomas Babej tba...@redhat.com

Re: [Freeipa-devel] [Patch] 0001 Add check for existence of ipa-join in the tree in test_host_plugin.py

2012-07-27 Thread Petr Viktorin
On 07/27/2012 01:13 PM, Tomas Babej wrote: Hi, this patch simply checks if ipa-join exists in ipa-client folder, if not, skips tests relying on it. Uses nose.plugin.skip. https://fedorahosted.org/freeipa/ticket/2905 Tomas Babej Hello, This would be better done in class setup, so you

[Freeipa-devel] [PATCH 0043] Extend API to be compatible with libdns interface = 90

2012-07-27 Thread Petr Spacek
Hello, this patch prevents compiler warning on systems with libdns interface version = 90. This libdns version comes with BIND 9.0.0. Both new methods are not obligatory, see in bind/lib/dns/db.c, functions dns_db_findext() and dns_db_findnodeext(). Petr^2 Spacek From

Re: [Freeipa-devel] DN patch and documentation

2012-07-27 Thread Petr Viktorin
On 07/26/2012 11:48 PM, John Dennis wrote: I have applied the suggested fixes, rebased against master, run all the unit tests successfully, built RPM's, did a full install without errors, and brought up the web UI successfully. The current code can be found here: git clone

Re: [Freeipa-devel] DN patch and documentation

2012-07-27 Thread Petr Viktorin
On 07/26/2012 11:30 PM, John Dennis wrote: The DN patch has been reworked. The single largest change was to the DN implementation and it's unit test to refactor the AVA, RDN and DN classes into a base class that is immutable and a subclass that supports editing. This makes these classes fully

Re: [Freeipa-devel] DN patch and documentation

2012-07-27 Thread John Dennis
On 07/27/2012 05:06 AM, Petr Viktorin wrote: On 07/26/2012 10:11 PM, John Dennis wrote: On 07/17/2012 06:47 PM, John Dennis wrote: ipapython/dn.py: in docstring: DN(arg0, ..., locked=False, first_key_match=True) followed by: def __init__(self, *args, **kwds): and:

Re: [Freeipa-devel] DN patch and documentation

2012-07-27 Thread Petr Viktorin
The nitpicks continue. None of the things in this mail are holding up the patch, consider it more of a discussion about good practices. (I'm assuming you're interested.) ipaserver/rpcserver.py: elif isinstance(val, (list, tuple)): -new_list = [] -n = len(val) -i

[Freeipa-devel] [PATCH] 175, 176 Fixed: Unable to select option in combobox in IE and Chrome

2012-07-27 Thread Petr Vobornik
[PATCH] 175 Fixed: Unable to select option in combobox in IE and Chrome There's probably a bug regarding z-index stacking in Chrome and IE. It appears when combobox is used in dialog. Combobox's select area had z-index=1010. When first jquery dialog is open it has z-index=1000. Further

Re: [Freeipa-devel] [PATCH] Minor fix to sidgen plugin

2012-07-27 Thread Simo Sorce
On Fri, 2012-07-27 at 07:04 +0300, Alexander Bokovoy wrote: On Thu, 26 Jul 2012, Simo Sorce wrote: Remove an unnecessary check that may give spurious failures on modified server where 999 is a valid ID. ACK. Pushed to master. Simo. -- Simo Sorce * Red Hat, Inc * New York

Re: [Freeipa-devel] DN patch and documentation

2012-07-27 Thread John Dennis
On 07/27/2012 11:18 AM, Petr Viktorin wrote: The nitpicks continue. None of the things in this mail are holding up the patch, consider it more of a discussion about good practices. (I'm assuming you're interested.) ipaserver/rpcserver.py: elif isinstance(val, (list, tuple)): -

Re: [Freeipa-devel] DN patch and documentation

2012-07-27 Thread John Dennis
On 07/27/2012 09:14 AM, Petr Viktorin wrote: Unfortunately, that's not quite true yet. If an object implements both __hash__ and __cmp__/__eq__, it must ensure that two equal objects will have the same hash value -- see http://docs.python.org/reference/datamodel.html#object.__hash__ This is

Re: [Freeipa-devel] [PATCH] 1033 renew CA subsystem certificates

2012-07-27 Thread Rob Crittenden
Jan Cholasta wrote: Dne 25.7.2012 22:58, Rob Crittenden napsal(a): Jan Cholasta wrote: All these scripts could use more exception handling, but I guess potential bugs can be sorted out later. Well, they all run in the background so even if they caught errors nothing would see them unless we

Re: [Freeipa-devel] [PATCH] 1039 fix selinux usermap config options

2012-07-27 Thread Rob Crittenden
Petr Viktorin wrote: On 07/25/2012 05:03 AM, Rob Crittenden wrote: The configuration options for the default user and map order were a bit broken in several ways. I wasn't handling the case where one of the values was coming from LDAP so was a list vs as an option which was a string, so all

Re: [Freeipa-devel] [PATCH] 0065 Ensure ipa-adtrust-install is run with administrator privileges and Kerberos ticket

2012-07-27 Thread Rob Crittenden
Alexander Bokovoy wrote: On Thu, 26 Jul 2012, Alexander Bokovoy wrote: Hi, When setting up AD trusts support, ipa-adtrust-install utility needs to be run as: - root, for performing Samba configuration and using LDAPI/autobind - kinit-ed IPA admin user, to ensure proper ACIs are granted to

Re: [Freeipa-devel] [PATCHES][RFC] Implement special operation to revoer NT hash for a user

2012-07-27 Thread Simo Sorce
On Fri, 2012-07-27 at 07:15 +0300, Alexander Bokovoy wrote: On Thu, 12 Jul 2012, Alexander Bokovoy wrote: On Thu, 12 Jul 2012, Simo Sorce wrote: On Thu, 2012-07-12 at 10:48 +0300, Alexander Bokovoy wrote: On Wed, 11 Jul 2012, Simo Sorce wrote: From 84ef09a1193ff42fc301fb71354055c5039f51a5 Mon