Re: [Freeipa-devel] [PATCH 0060] Fix ipa-getkeytab for pre-4.0 servers

2014-07-24 Thread Martin Kosek
On 07/24/2014 05:12 PM, Nathaniel McCallum wrote: > On Thu, 2014-07-24 at 17:19 +0300, Alexander Bokovoy wrote: >> On Thu, 24 Jul 2014, Nathaniel McCallum wrote: >>> Also, make the error messages for this fallback case less scary and >>> clean up some indentation issues in the nearby code which mad

Re: [Freeipa-devel] [PATCH] 711 webui: internet explorer fixes

2014-07-24 Thread Petr Vobornik
On 23.7.2014 15:17, Petr Vobornik wrote: Fixed: 1. IE doesn't support value 'initial' in CSS rule. 2. setting innerHTML='' also destroys content of child nodes in LoginScreen in IE -> reattached buttons have no text. Should go into 4.0 Milestone Found an issue in the implementation, new versi

[Freeipa-devel] [PATCH] 310 Exclude attributelevelrights from --raw result processing in baseldap

2014-07-24 Thread Jan Cholasta
Hi, the attached patch fixes . Honza -- Jan Cholasta >From 76204f58608ee9f85b704f71909449bed0173253 Mon Sep 17 00:00:00 2001 From: Jan Cholasta Date: Thu, 24 Jul 2014 17:17:48 +0200 Subject: [PATCH] Exclude attributelevelrights from --raw result pr

Re: [Freeipa-devel] LDAP updater with --test option

2014-07-24 Thread Rob Crittenden
Martin Basti wrote: > Hi list, > > maybe I missed something, but I expected, there are no modifications > with this option. > > With --test option the LDAP schema is not updated, but update plugins > don't care about --test option ('live_run' in code). > > Update plugins use and IPA api directl

Re: [Freeipa-devel] LDAP updater with --test option

2014-07-24 Thread Jan Cholasta
Dne 24.7.2014 v 17:14 Martin Basti napsal(a): Hi list, maybe I missed something, but I expected, there are no modifications with this option. With --test option the LDAP schema is not updated, but update plugins don't care about --test option ('live_run' in code). Most plugins should respect

[Freeipa-devel] LDAP updater with --test option

2014-07-24 Thread Martin Basti
Hi list, maybe I missed something, but I expected, there are no modifications with this option. With --test option the LDAP schema is not updated, but update plugins don't care about --test option ('live_run' in code). Update plugins use and IPA api directly to modify LDAP instead of retur

Re: [Freeipa-devel] [PATCH 0060] Fix ipa-getkeytab for pre-4.0 servers

2014-07-24 Thread Nathaniel McCallum
On Thu, 2014-07-24 at 17:19 +0300, Alexander Bokovoy wrote: > On Thu, 24 Jul 2014, Nathaniel McCallum wrote: > >Also, make the error messages for this fallback case less scary and > >clean up some indentation issues in the nearby code which made this > >code difficult to read. > ACK. Here is how it

[Freeipa-devel] [PATCH] 309 Check if /root/ipa.csr exists when installing server with external CA

2014-07-24 Thread Jan Cholasta
Hi, the attached patch fixes . Honza -- Jan Cholasta >From 94a7696c04b2d36da10bf6d64c94902d0dde0216 Mon Sep 17 00:00:00 2001 From: Jan Cholasta Date: Thu, 24 Jul 2014 16:32:00 +0200 Subject: [PATCH] Check if /root/ipa.csr exists when installing ser

Re: [Freeipa-devel] [PATCH 0060] Fix ipa-getkeytab for pre-4.0 servers

2014-07-24 Thread Alexander Bokovoy
On Thu, 24 Jul 2014, Nathaniel McCallum wrote: Also, make the error messages for this fallback case less scary and clean up some indentation issues in the nearby code which made this code difficult to read. ACK. Here is how it looks now in /var/log/ipaclient-install.log: 2014-07-24T14:15:36Z DE

[Freeipa-devel] [PATCH] 308 Allow changing CA renewal master in ipa-csreplica-manage

2014-07-24 Thread Jan Cholasta
Hi, the attached patch fixes . Requires my patches 246 and 262 (current versions attached). Honza -- Jan Cholasta >From 37deddbb4c80697460ef4af204e3a2e36dcbbe4e Mon Sep 17 00:00:00 2001 From: Jan Cholasta Date: Mon, 24 Mar 2014 15:30:53 +0100 Subj

[Freeipa-devel] [PATCH 0060] Fix ipa-getkeytab for pre-4.0 servers

2014-07-24 Thread Nathaniel McCallum
Also, make the error messages for this fallback case less scary and clean up some indentation issues in the nearby code which made this code difficult to read. From 7cfe668e116b60ab2e4149135110f32b165f4915 Mon Sep 17 00:00:00 2001 From: Nathaniel McCallum Date: Thu, 24 Jul 2014 09:50:57 -0400 Subj

Re: [Freeipa-devel] [PATCH 0246] baseldap: Fix undefined variable reference in

2014-07-24 Thread Rob Crittenden
Tomas Babej wrote: > > On 07/24/2014 12:35 PM, Tomas Babej wrote: >> Hi, >> >> on receiving a PublicError we fail with InternalError since msg is not >> defined. >> >> >> >> ___ >> Freeipa-devel mailing list >> Freeipa-devel@redhat.com >> https://www.red

[Freeipa-devel] [PATCH] 0007 test group: remove group from protected group

2014-07-24 Thread David Kupka
Simple test scenario from ticket #4448. Last test will fail until patch freeipa-dkupka-0006 gets accepted. -- David Kupka From 240f48865ebb93a9a4d71250f3bcef1c48c453bb Mon Sep 17 00:00:00 2001 From: David Kupka Date: Thu, 24 Jul 2014 14:45:50 +0200 Subject: [PATCH] test group: remove group from

Re: [Freeipa-devel] [PATCH] 0002 Improve password validity check

2014-07-24 Thread Martin Kosek
On 07/24/2014 02:02 PM, David Kupka wrote: > On 07/22/2014 08:55 AM, Martin Kosek wrote: >> On 07/21/2014 04:08 PM, David Kupka wrote: >>> On 07/18/2014 12:52 PM, Martin Kosek wrote: On 07/18/2014 12:33 PM, David Kupka wrote: > https://fedorahosted.org/freeipa/ticket/2796 1) Woul

Re: [Freeipa-devel] [PATCH] 0002 Improve password validity check

2014-07-24 Thread David Kupka
On 07/22/2014 08:55 AM, Martin Kosek wrote: On 07/21/2014 04:08 PM, David Kupka wrote: On 07/18/2014 12:52 PM, Martin Kosek wrote: On 07/18/2014 12:33 PM, David Kupka wrote: https://fedorahosted.org/freeipa/ticket/2796 1) Would it be easier/more convenient to just implement following simple

Re: [Freeipa-devel] [PATCH] 479 Do not require dogtag-pki-server-theme

2014-07-24 Thread Martin Kosek
On 07/23/2014 05:28 PM, Alexander Bokovoy wrote: > On Wed, 23 Jul 2014, Martin Kosek wrote: >> On 07/23/2014 05:21 PM, Alexander Bokovoy wrote: >>> On Wed, 23 Jul 2014, Martin Kosek wrote: On 07/23/2014 05:07 PM, Alexander Bokovoy wrote: > On Wed, 23 Jul 2014, Martin Kosek wrote: >> Th

[Freeipa-devel] Announcing bind-dyndb-ldap version 5.1

2014-07-24 Thread Petr Spacek
The FreeIPA team is proud to announce bind-dyndb-ldap version 5.1. It can be downloaded from https://fedorahosted.org/released/bind-dyndb-ldap/ The new version has also been built for Fedora 20+ and and is on its way to updates-testing: https://admin.fedoraproject.org/updates/bind-dyndb-ldap-5

Re: [Freeipa-devel] [PATCH 0246] baseldap: Fix undefined variable reference in

2014-07-24 Thread Tomas Babej
On 07/24/2014 12:35 PM, Tomas Babej wrote: > Hi, > > on receiving a PublicError we fail with InternalError since msg is not > defined. > > > > ___ > Freeipa-devel mailing list > Freeipa-devel@redhat.com > https://www.redhat.com/mailman/listinfo/freeipa-d

[Freeipa-devel] [PATCH 0246] baseldap: Fix undefined variable reference in

2014-07-24 Thread Tomas Babej
Hi, on receiving a PublicError we fail with InternalError since msg is not defined. -- Tomas Babej Associate Software Engineer | Red Hat | Identity Management RHCE | Brno Site | IRC: tbabej | freeipa.org >From d81984981a2de72aa820feb710fec1ccb8e5 Mon Sep 17 00:00:00 2001 From: Tomas Babej

Re: [Freeipa-devel] [PATCH 0276] Fix crash during reconnection to LDAP

2014-07-24 Thread Petr Spacek
On 24.7.2014 10:20, Tomas Hozza wrote: On 07/23/2014 02:26 PM, Petr Spacek wrote: >Hello, > >Fix crash during reconnection to LDAP. > The fix works. ACK. Pushed to master: fb979d2f07be16f8cf441d393612504235ab26d8 -- Petr^2 Spacek ___ Freeipa-deve

Re: [Freeipa-devel] [PATCH 0277] Bump NVR to 5.1

2014-07-24 Thread Petr Spacek
On 24.7.2014 10:21, Tomas Hozza wrote: On 07/23/2014 02:27 PM, Petr Spacek wrote: >Hello, > >Bump NVR to 5.1. > ACK. Pushed to master: 1ac2fd5e1d7e5ad742739b4ec5d2c326dcc0f184 -- Petr^2 Spacek ___ Freeipa-devel mailing list Freeipa-devel@redhat.co

Re: [Freeipa-devel] [PATCH 0275] Add TLSARecord to idnsRecord object class

2014-07-24 Thread Petr Spacek
On 24.7.2014 10:20, Tomas Hozza wrote: On 07/23/2014 02:25 PM, Petr Spacek wrote: >Hello, > >Add TLSARecord to idnsRecord object class. > ACK. Pushed to master: 2d358ccbc323ea6d4339f22b16d419195054e017 -- Petr^2 Spacek ___ Freeipa-devel mailing lis

Re: [Freeipa-devel] [PATCH][bind-dyndb-ldap] AUTOCONF: Improve detection of bind9 header files

2014-07-24 Thread Petr Spacek
On 27.2.2014 15:19, Lukas Slebodnik wrote: ehlo, I did some reviews of bind-dyndb-ldap last week and it was little bit annoying to export special CFLAGS for bind9 header files. It can be automatically detected in configure script using utility isc-config. Attached patch should improve this and

Re: [Freeipa-devel] [PATCH 0277] Bump NVR to 5.1

2014-07-24 Thread Tomas Hozza
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 07/23/2014 02:27 PM, Petr Spacek wrote: > Hello, > > Bump NVR to 5.1. > ACK. Tomas -BEGIN PGP SIGNATURE- Version: GnuPG v1 Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBAgAGBQJT0MHvAAoJEMWIetUdnzwtwG4H/3yoylMf

Re: [Freeipa-devel] [PATCH 0276] Fix crash during reconnection to LDAP

2014-07-24 Thread Tomas Hozza
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 07/23/2014 02:26 PM, Petr Spacek wrote: > Hello, > > Fix crash during reconnection to LDAP. > The fix works. ACK. Tomas -BEGIN PGP SIGNATURE- Version: GnuPG v1 Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBAg

Re: [Freeipa-devel] [PATCH 0275] Add TLSARecord to idnsRecord object class

2014-07-24 Thread Tomas Hozza
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 07/23/2014 02:25 PM, Petr Spacek wrote: > Hello, > > Add TLSARecord to idnsRecord object class. > ACK. Tomas -BEGIN PGP SIGNATURE- Version: GnuPG v1 Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBAgAGBQJT0MG0AA

Re: [Freeipa-devel] [PATCH] 0005 Verify otptoken timespan is valid

2014-07-24 Thread David Kupka
On 07/23/2014 05:07 PM, Jan Cholasta wrote: Hi, On 23.7.2014 15:46, David Kupka wrote: https://fedorahosted.org/freeipa/ticket/4244 1) Use "isinstance(X, Y)" instead of "type(X) is Y". Thanks for advice, will try to remember. 2) When is "type(not_before) is str" or "type(not_after) is s

Re: [Freeipa-devel] [PATCH] 0105 FIX: LDAP_updater

2014-07-24 Thread Martin Basti
On 23/07/14 15:17, Martin Basti wrote: This patch fixes ordering problem of schema updates Martin should it be in IPA 4.0.x ? It requires rebased ldap_python (will be in Fedora 21) Patch attached I found a bug there, but before I send updated version, I need to decide how print modlist: