[Freeipa-devel] [Patch] 0001-2 User Life Cycle: create containers and scoping DS plugins

2014-08-14 Thread thierry bordaz
Hello, Following Petr remarks from the previous review, I modified the original fix to move it only in '.update' files. Thanks thierry From d45e78dfeb7761348c464b3bb3956656bb115ce0 Mon Sep 17 00:00:00 2001 From: "Thierry bordaz (tbordaz)" Date: Thu, 7 Aug 2014 16:29:02 +0200 Subjec

Re: [Freeipa-devel] [PATCH] - Add DRM to IPA

2014-08-14 Thread Petr Viktorin
On 08/14/2014 10:53 AM, Martin Kosek wrote: On 08/13/2014 09:54 PM, Ade Lee wrote: In Dogtag, we have decided to revert the name of the DRM to the old name KRA. DRM was really only used in docs/marketing, whereas KRA is all over the code. Soon, the code and the marketing/docs will match. The fo

Re: [Freeipa-devel] [PATCH] - Add DRM to IPA

2014-08-14 Thread Martin Kosek
On 08/13/2014 09:54 PM, Ade Lee wrote: > In Dogtag, we have decided to revert the name of the DRM to the old name KRA. > DRM was really only used in docs/marketing, whereas KRA is all over the code. > Soon, the code and the marketing/docs will match. > > The following patch changes all references

Re: [Freeipa-devel] [PATCH] 0001 User Life Cycle: create containers and scoping DS plugins

2014-08-14 Thread Martin Kosek
On 08/13/2014 05:34 PM, Petr Viktorin wrote: > On 08/13/2014 05:17 PM, thierry bordaz wrote: ... >>> Patch submission technicalities: >>> Please don't add the "Reviewed by" tag to the commit message, it's >>> added when pushing. The other tags are not used FreeIPA. (What's a >>> "Flag Day"?) >>> Wh

Re: [Freeipa-devel] [PATCH] 315 Convert external CA chain to PKCS#7 before passing it to pkispawn

2014-08-14 Thread Petr Viktorin
On 08/13/2014 03:57 PM, Martin Kosek wrote: On 08/13/2014 03:12 PM, Petr Viktorin wrote: [...] This works for me, but I'm not sure if I'm correctly reproducing the specific scenario this patch fixes. So as always, can you please add tests for code you write? +1! As far as other scenarios, i