Re: [Freeipa-devel] [PATCH] Port from python-kerberos library to python-gssapi

2015-07-27 Thread Simo Sorce
On Sun, 2015-07-26 at 21:51 +0200, Michael Šimáček wrote: > It would probably be nicer to do the full cycle, but I'd like to > avoid > changes in behavior when porting from one library to another. And the > code above doesn't actually hold any connection, so it would require > more refactoring t

[Freeipa-devel] Added Martin Basti to comitters group

2015-07-27 Thread Martin Kosek
Hi all, In order to spread better review/push load, I think we need to expand the FreeIPA comitters group a bit. I added Martin Basti to the group, so please feel free to bug him with push requests :-) -- Martin Kosek Supervisor, Software Engineering - Identity Management Team Red Hat Inc. --

Re: [Freeipa-devel] [PATCH] 905 webui: add Kerberos configuration instructions for Chrome

2015-07-27 Thread Martin Basti
On 22/07/15 14:00, Petr Vobornik wrote: * IE section moved at the end * Chrome section added * FF and IE icons removed https://fedorahosted.org/freeipa/ticket/823 ACK -- Martin Basti -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/fre

[Freeipa-devel] [patch 0007] tests: Allow Tracker.dn be an instance of Fuzzy

2015-07-27 Thread Milan Kubík
Hi, the patch changes the check on the Tracker.dn setter, allowing to use an instance of ipatests.util.Fuzzy to ease writing Trackers for plugins like CA ACL, which use ipaUniqueID as their primary key. Thanks, Milan >From 0d586dffbb424f8292faa90ea92021b075b34926 Mon Sep 17 00:00:00 2001 From: =

Re: [Freeipa-devel] [PATCH] 905 webui: add Kerberos configuration instructions for Chrome

2015-07-27 Thread Martin Basti
On 27/07/15 12:06, Martin Basti wrote: On 22/07/15 14:00, Petr Vobornik wrote: * IE section moved at the end * Chrome section added * FF and IE icons removed https://fedorahosted.org/freeipa/ticket/823 ACK -- Martin Basti Pushed to: master: a4be844809179ff0a05286606df1487d81a70022 ipa-4-

Re: [Freeipa-devel] C coding style guide update

2015-07-27 Thread Michal Židek
On 07/26/2015 10:09 PM, Jakub Hrozek wrote: On Thu, Jul 23, 2015 at 06:21:25PM +0200, Michal Židek wrote: Hi, in SSSD we use the freeipa coding guidelines which are located here: http://www.freeipa.org/page/Coding_Style However this coding style guide is already dated and there are some rules

Re: [Freeipa-devel] [PATCH] 905, 295 webui: add Kerberos configuration instructions for Chrome

2015-07-27 Thread Martin Basti
On 27/07/15 13:52, Martin Basti wrote: On 27/07/15 12:06, Martin Basti wrote: On 22/07/15 14:00, Petr Vobornik wrote: * IE section moved at the end * Chrome section added * FF and IE icons removed https://fedorahosted.org/freeipa/ticket/823 ACK -- Martin Basti Pushed to: master: a4be844

Re: [Freeipa-devel] [PATCH] 905, 295 webui: add Kerberos configuration instructions for Chrome

2015-07-27 Thread Martin Babinsky
On 07/27/2015 04:12 PM, Martin Basti wrote: On 27/07/15 13:52, Martin Basti wrote: On 27/07/15 12:06, Martin Basti wrote: On 22/07/15 14:00, Petr Vobornik wrote: * IE section moved at the end * Chrome section added * FF and IE icons removed https://fedorahosted.org/freeipa/ticket/823 ACK

Re: [Freeipa-devel] [PATCH] 0035 client: Update DNS with all available local IP addresses.

2015-07-27 Thread David Kupka
On 15/01/15 17:13, David Kupka wrote: On 01/15/2015 03:22 PM, David Kupka wrote: On 01/15/2015 12:43 PM, David Kupka wrote: On 01/12/2015 06:34 PM, Martin Basti wrote: On 09/01/15 14:43, David Kupka wrote: On 01/07/2015 04:15 PM, Martin Basti wrote: On 07/01/15 12:27, David Kupka wrote: htt

[Freeipa-devel] [PATCH 0002] TEST: Stageuser plugin

2015-07-27 Thread Lenka Doudova
Hi, I'm attaching a patch with automated tests for stageuser plugin (https://fedorahosted.org/freeipa/ticket/3813). The user plugin test is affected as well (one class was added). The tests seem a bit of a mess even to myself, but what with the way freeipa behaves I didn't know how else to imp

Re: [Freeipa-devel] [PATCH 0050] ACI plugin: correctly parse bind rules enclosed in parentheses

2015-07-27 Thread Martin Basti
On 23/07/15 16:06, Martin Babinsky wrote: This is a quick fix for https://fedorahosted.org/freeipa/ticket/5037 NACK I do not like your change in first regexp too much. Can you try this instead? PermPat = re.compile(r'(\w+)\s*\(([^()]*)\)\s*(.*)', re.UNICODE) This just removes '(' and ') '

Re: [Freeipa-devel] [PATCH 0001] Test Topology plugin is listed among DS plugins

2015-07-27 Thread Martin Basti
On 23/07/15 16:27, Martin Basti wrote: On 23/07/15 11:42, Oleg Fayans wrote: Forgot to attach the new version, sorry! On 07/23/2015 10:32 AM, Oleg Fayans wrote: Hi Martin, On 07/22/2015 05:48 PM, Martin Basti wrote: On 22/07/15 15:19, Oleg Fayans wrote: Hi Martin, Fixed. On 07/22/2015 09:

Re: [Freeipa-devel] [PATCH 018] certprofile-import: improve profile format documentation

2015-07-27 Thread Martin Basti
On 24/07/15 04:06, Fraser Tweedale wrote: On Thu, Jul 23, 2015 at 06:25:25PM +0200, Christian Heimes wrote: The certprofile-import plugin expects a raw Dogtag config file. The XML format is not supported. --help gives a hint about the correct file format. https://fedorahosted.org/freeipa/ticket

Re: [Freeipa-devel] C coding style guide update

2015-07-27 Thread Jakub Hrozek
On Mon, Jul 27, 2015 at 03:54:22PM +0200, Michal Židek wrote: > > - Line-comments (//, aka C++ comments) should be still avoided, > > though > > I really do not know what people have against line comments, but > this is not the first time I see someone resisting them, so I > guess there

Re: [Freeipa-devel] [PATCH] otptoken: use ipapython.nsslib instead of Python's ssl module

2015-07-27 Thread Martin Basti
On 22/07/15 10:38, Martin Basti wrote: On 07/07/15 18:40, Christian Heimes wrote: Hello, the patch removes the dependency on Python's ssl module and python-backports-ssl_match_hostname. https://fedorahosted.org/freeipa/ticket/5068 Open question - Is paths.IPA_NSSDB_DIR the correct

Re: [Freeipa-devel] Replace stageuser-add --from-delete with user-undel --to-staged

2015-07-27 Thread Martin Basti
On 23/07/15 14:43, Martin Basti wrote: Hello, I tried to fix #5145 and I partially succeeded. However, I cannot fix this part of ticket, where user is prompted to write name and surname. $ ipa stageuser-add tuser --from-delete First name: this will be ignored Last name: this will be also ign

Re: [Freeipa-devel] [PATCH] Use Exception class instead of StandardError

2015-07-27 Thread Martin Basti
On 29/06/15 08:41, Niranjan wrote: Martin Basti wrote: On 10/06/15 00:59, Niranjan wrote: Niranjan wrote: Greetings, Please find the modified patch for ipapython/adminutil.py. I have run few tests manually like running ipa-server-install as non-root user or provide --quiet and --verbose to s

Re: [Freeipa-devel] [PATCH 0050] Fix client ca.crt to match the server's cert

2015-07-27 Thread Martin Basti
On 22/07/15 10:41, Martin Basti wrote: On 13/07/15 17:55, Martin Basti wrote: On 08/07/15 16:09, Gabe Alford wrote: Thanks, Martin. Update patch attached. I was getting an 'No newline at the end of file' in my environment hence an extra '\n' at the end. Please let me know if you see the same

Re: [Freeipa-devel] C coding style guide update

2015-07-27 Thread Petr Vobornik
On 07/26/2015 10:09 PM, Jakub Hrozek wrote: On Thu, Jul 23, 2015 at 06:21:25PM +0200, Michal Židek wrote: Hi, in SSSD we use the freeipa coding guidelines which are located here: http://www.freeipa.org/page/Coding_Style However this coding style guide is already dated and there are some rules