Re: [Freeipa-devel] [PATCH 0082] remove Kerberos authenticators after service uninstall

2015-10-14 Thread Martin Babinsky
On 10/13/2015 02:52 PM, Simo Sorce wrote: On 13/10/15 04:04, Petr Spacek wrote: On 13.10.2015 09:34, Martin Babinsky wrote: On 10/13/2015 09:17 AM, Petr Spacek wrote: On 12.10.2015 13:38, Martin Babinsky wrote: each service possessing Kerberos keytab wiil now remove it and destroy any

[Freeipa-devel] [PATCH 0085] remove idoverrides when deleting a user

2015-10-14 Thread Martin Babinsky
This patch fixes a regression which was caused by incorrect refactoring of user-del command in commit c6299a8cfde7d4e4bb9a50e3cf6406667cee0a6f While the `remove_ipaobject_overrides` function was originally called in the execute method, this patch puts it into the pre-callback because: 1.) it

Re: [Freeipa-devel] Stageuser capability in UI

2015-10-14 Thread Petr Vobornik
On 10/13/2015 04:09 PM, Lenka Doudova wrote: Hi, I've been told to do some tests of stageuser UI capabilities ASAP. I think I covered most of the test cases from test plan (http://www.freeipa.org/page/V4/User_Life-Cycle_Management/Test_Plan) (will check that tomorrow morning, as I need to go

Re: [Freeipa-devel] [PATCH 0056] Enable nsaccountlock in user.py cli

2015-10-14 Thread Martin Basti
Sorry, we cannot push this patch because I realize that it breaks API compatibility. The proper fix is add this code to find method (not tested) def get_options(self): for option in super(user_find, self).get_options(): if option.name == "nsaccountlock":

Re: [Freeipa-devel] Stageuser capability in UI

2015-10-14 Thread Lenka Doudova
On 10/14/2015 09:45 AM, Petr Vobornik wrote: On 10/13/2015 04:09 PM, Lenka Doudova wrote: Hi, I've been told to do some tests of stageuser UI capabilities ASAP. I think I covered most of the test cases from test plan (http://www.freeipa.org/page/V4/User_Life-Cycle_Management/Test_Plan) (will

[Freeipa-devel] [PATCH 0326] Replace tab with space in test_user_plugin

2015-10-14 Thread Martin Basti
Mixing spaces and tabs is not allowed in python3. Patch attached. From fce642348d11e80fe291eda3ca533a06b6909ec6 Mon Sep 17 00:00:00 2001 From: Martin Basti Date: Wed, 14 Oct 2015 09:53:04 +0200 Subject: [PATCH] Replace tab with space in test_user_plugin.py Mixing tabs and

Re: [Freeipa-devel] [PATCH 0326] Replace tab with space in test_user_plugin

2015-10-14 Thread Martin Basti
On 14.10.2015 10:04, Martin Babinsky wrote: On 10/14/2015 09:56 AM, Martin Basti wrote: Mixing spaces and tabs is not allowed in python3. Patch attached. ACK Pushed to: master: 16261adc58fb9bfe51c679d6e00d85f21c1f6447 ipa-4-2: 8b66b6f49a568f4171f88c3b4a042f368bc088b8 -- Manage your

Re: [Freeipa-devel] [PATCH 0326] Replace tab with space in test_user_plugin

2015-10-14 Thread Martin Babinsky
On 10/14/2015 09:56 AM, Martin Basti wrote: Mixing spaces and tabs is not allowed in python3. Patch attached. ACK -- Martin^3 Babinsky -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA:

Re: [Freeipa-devel] [PATCH 0009] WebUI: Disappearing automember rule expressions

2015-10-14 Thread Martin Basti
On 13.10.2015 13:13, Tomas Babej wrote: On 10/09/2015 01:46 PM, Stanislav Laznicka wrote: Hi, please see the patch attached. Standa L. ACK, works as desired. Tomas Pushed to: master: 9d562038addb1e653f91031731f62e91325c1591 ipa-4-2: cbccec68fc3e6314ee35a3a3697e65657d916370 -- Manage

Re: [Freeipa-devel] [PATCH 0059] ipa-adtrust-install: Print complete SRV record

2015-10-14 Thread Martin Basti
On 13.10.2015 12:49, Tomas Babej wrote: On 10/09/2015 02:59 PM, Petr Spacek wrote: Hello, I found this when reviewing DNS parts of IdM and AD integration guides. ipa-adtrust-install: Print complete SRV records. https://fedorahosted.org/freeipa/ticket/5358 ACK, generates correct output.

Re: [Freeipa-devel] [PATCH 373-374] idoverrides: Ignore SID conversion error and add coverage

2015-10-14 Thread Tomas Babej
On 10/13/2015 03:32 PM, Martin Babinsky wrote: > On 10/13/2015 12:21 PM, Tomas Babej wrote: >> Hi, >> >> this couple of patches fixes and improves the coverage for referential >> integrity of ID overrides. >> >> Note: Last test in the patch 374 is supposed to be failing (for now). >> >>

Re: [Freeipa-devel] [PATCH 0085] remove idoverrides when deleting a user

2015-10-14 Thread Tomas Babej
On 10/14/2015 09:02 AM, Martin Babinsky wrote: > This patch fixes a regression which was caused by incorrect refactoring > of user-del command in commit c6299a8cfde7d4e4bb9a50e3cf6406667cee0a6f > > While the `remove_ipaobject_overrides` function was originally called in > the execute method,

Re: [Freeipa-devel] [PATCH 0083] perform an unlimited search for reverse zones when adding DNS records

2015-10-14 Thread Martin Babinsky
On 10/13/2015 04:00 PM, Petr Spacek wrote: On 13.10.2015 13:37, Martin Babinsky wrote: On 10/13/2015 09:36 AM, Petr Spacek wrote: On 12.10.2015 16:35, Martin Babinsky wrote: https://fedorahosted.org/freeipa/ticket/5200 --- ipalib/plugins/dns.py | 3 ++- 1 file changed, 2 insertions(+), 1

Re: [Freeipa-devel] [PATCH 373-374] idoverrides: Ignore SID conversion error and add coverage

2015-10-14 Thread Martin Babinsky
On 10/14/2015 12:54 PM, Tomas Babej wrote: On 10/13/2015 03:32 PM, Martin Babinsky wrote: On 10/13/2015 12:21 PM, Tomas Babej wrote: Hi, this couple of patches fixes and improves the coverage for referential integrity of ID overrides. Note: Last test in the patch 374 is supposed to be

Re: [Freeipa-devel] [PATCHES 0318 - 0320, 0323] installer: allow to modify dse.ldif during installation

2015-10-14 Thread Martin Babinsky
On 10/13/2015 06:38 PM, Martin Basti wrote: On 12.10.2015 12:30, Martin Babinsky wrote: On 10/08/2015 05:58 PM, Martin Basti wrote: The attached patches fix following tickets: https://fedorahosted.org/freeipa/ticket/4949 https://fedorahosted.org/freeipa/ticket/4048

Re: [Freeipa-devel] [PATCH 0083] perform an unlimited search for reverse zones when adding DNS records

2015-10-14 Thread Petr Spacek
On 14.10.2015 14:13, Martin Babinsky wrote: > On 10/13/2015 04:00 PM, Petr Spacek wrote: >> On 13.10.2015 13:37, Martin Babinsky wrote: >>> On 10/13/2015 09:36 AM, Petr Spacek wrote: On 12.10.2015 16:35, Martin Babinsky wrote: > https://fedorahosted.org/freeipa/ticket/5200 > --- >

Re: [Freeipa-devel] [PATCHES 0318 - 0320, 0323] installer: allow to modify dse.ldif during installation

2015-10-14 Thread Martin Basti
On 14.10.2015 15:51, Martin Babinsky wrote: On 10/13/2015 06:38 PM, Martin Basti wrote: On 12.10.2015 12:30, Martin Babinsky wrote: On 10/08/2015 05:58 PM, Martin Basti wrote: The attached patches fix following tickets: https://fedorahosted.org/freeipa/ticket/4949