[Freeipa-devel] [freeipa PR#364][comment] Client-only builds with --disable-server

2017-02-10 Thread lslebodn
URL: https://github.com/freeipa/freeipa/pull/364 Title: #364: Client-only builds with --disable-server lslebodn commented: """ It works quite good with the following change ``` diff --git a/Makefile.am b/Makefile.am index 311f6121f..13e5a87b0 100644 --- a/Makefile.am +++ b/Makefile.am @@ -1,13

[Freeipa-devel] [freeipa PR#314][comment] RFC: privilege separation for ipa framework code

2017-02-10 Thread simo5
URL: https://github.com/freeipa/freeipa/pull/314 Title: #314: RFC: privilege separation for ipa framework code simo5 commented: """ So I am not sure what is going on here, after fiddling with the failing tests to print out what was going on, they suddenly started working (and a 3 other

[Freeipa-devel] [freeipa PR#448][comment] Tests: Basic coverage with tree root domain

2017-02-10 Thread gkaihorodova
URL: https://github.com/freeipa/freeipa/pull/448 Title: #448: Tests: Basic coverage with tree root domain gkaihorodova commented: """ Yes, sure I'll work on these issues """ See the full comment at https://github.com/freeipa/freeipa/pull/448#issuecomment-278975336 -- Manage your

[Freeipa-devel] [freeipa PR#458][comment] Enable Bytes and deprecation warnings

2017-02-10 Thread MartinBasti
URL: https://github.com/freeipa/freeipa/pull/458 Title: #458: Enable Bytes and deprecation warnings MartinBasti commented: """ Fixed upstream master: https://fedorahosted.org/freeipa/changeset/a33b25dea988aa34844869a8adc57d5cd396d3aa

[Freeipa-devel] [freeipa PR#448][comment] Tests: Basic coverage with tree root domain

2017-02-10 Thread martbab
URL: https://github.com/freeipa/freeipa/pull/448 Title: #448: Tests: Basic coverage with tree root domain martbab commented: """ Well you still have some issues to fix, notably the failing Travis CI and the not-so nice multiline-string literal. """ See the full comment at

[Freeipa-devel] [freeipa PR#458][closed] Enable Bytes and deprecation warnings

2017-02-10 Thread MartinBasti
URL: https://github.com/freeipa/freeipa/pull/458 Author: tiran Title: #458: Enable Bytes and deprecation warnings Action: closed To pull the PR as Git branch: git remote add ghfreeipa https://github.com/freeipa/freeipa git fetch ghfreeipa pull/458/head:pr458 git checkout pr458 -- Manage your

[Freeipa-devel] [freeipa PR#458][+pushed] Enable Bytes and deprecation warnings

2017-02-10 Thread MartinBasti
URL: https://github.com/freeipa/freeipa/pull/458 Title: #458: Enable Bytes and deprecation warnings Label: +pushed -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA:

[Freeipa-devel] [freeipa PR#458][+ack] Enable Bytes and deprecation warnings

2017-02-10 Thread MartinBasti
URL: https://github.com/freeipa/freeipa/pull/458 Title: #458: Enable Bytes and deprecation warnings Label: +ack -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA:

[Freeipa-devel] [freeipa PR#448][comment] Tests: Basic coverage with tree root domain

2017-02-10 Thread gkaihorodova
URL: https://github.com/freeipa/freeipa/pull/448 Title: #448: Tests: Basic coverage with tree root domain gkaihorodova commented: """ Thank you for explanation and tips. I noticed it as well and I agree that it (and not only that) worth refactoring. Yes, my PR is more or less copy-paste,

[Freeipa-devel] [freeipa PR#450][comment] Add FIPS-token password of HTTPD NSS database

2017-02-10 Thread stlaz
URL: https://github.com/freeipa/freeipa/pull/450 Title: #450: Add FIPS-token password of HTTPD NSS database stlaz commented: """ That was my original approach to it but we had offline talk with @HonzaCholasta and got to the point that it might be better to do it this way. From my point of view

[Freeipa-devel] [freeipa PR#364][comment] Client-only builds with --disable-server

2017-02-10 Thread tiran
URL: https://github.com/freeipa/freeipa/pull/364 Title: #364: Client-only builds with --disable-server tiran commented: """ In the latest version, ```--disable-server``` does not affect ```make dist```. It only changes the components that are built by ```make``` and installed by ```make

[Freeipa-devel] [freeipa PR#364][comment] Client-only builds with --disable-server

2017-02-10 Thread lslebodn
URL: https://github.com/freeipa/freeipa/pull/364 Title: #364: Client-only builds with --disable-server lslebodn commented: """ On (10/02/17 06:11), Petr Vobornik wrote: >I still think that this use case needs to be documented in

[Freeipa-devel] [freeipa PR#450][comment] Add FIPS-token password of HTTPD NSS database

2017-02-10 Thread rcritten
URL: https://github.com/freeipa/freeipa/pull/450 Title: #450: Add FIPS-token password of HTTPD NSS database rcritten commented: """ I guess this is one approach to fix the problem. Would it be cleaner to pass in, or detect, FIPS mode, and only write out the token that will actually be used?

[Freeipa-devel] [freeipa PR#364][comment] Client-only builds with --disable-server

2017-02-10 Thread pvoborni
URL: https://github.com/freeipa/freeipa/pull/364 Title: #364: Client-only builds with --disable-server pvoborni commented: """ I still think that this use case needs to be documented in http://www.freeipa.org/page/V4/Build_system_refactoring#How_to_Use . IMHO `make dist` can fail with

[Freeipa-devel] [freeipa PR#458][comment] Enable Bytes and deprecation warnings

2017-02-10 Thread abbra
URL: https://github.com/freeipa/freeipa/pull/458 Title: #458: Enable Bytes and deprecation warnings abbra commented: """ Thanks. LGTM. """ See the full comment at https://github.com/freeipa/freeipa/pull/458#issuecomment-278949308 -- Manage your subscription for the Freeipa-devel mailing

[Freeipa-devel] [freeipa PR#458][edited] Enable Bytes and deprecation warnings

2017-02-10 Thread tiran
URL: https://github.com/freeipa/freeipa/pull/458 Author: tiran Title: #458: Enable Bytes and deprecation warnings Action: edited Changed field: title Original value: """ Bytes deprecation warnings """ -- Manage your subscription for the Freeipa-devel mailing list:

[Freeipa-devel] [freeipa PR#457][comment] adtrustinstance: use LDAPI/EXTERNAL to retrieve CIFS keytab

2017-02-10 Thread martbab
URL: https://github.com/freeipa/freeipa/pull/457 Title: #457: adtrustinstance: use LDAPI/EXTERNAL to retrieve CIFS keytab martbab commented: """ Sorry I just got confused for a bit. Fixed the docstring now refer only to 'samba keytab'. """ See the full comment at

[Freeipa-devel] [freeipa PR#457][synchronized] adtrustinstance: use LDAPI/EXTERNAL to retrieve CIFS keytab

2017-02-10 Thread martbab
URL: https://github.com/freeipa/freeipa/pull/457 Author: martbab Title: #457: adtrustinstance: use LDAPI/EXTERNAL to retrieve CIFS keytab Action: synchronized To pull the PR as Git branch: git remote add ghfreeipa https://github.com/freeipa/freeipa git fetch ghfreeipa pull/457/head:pr457 git

[Freeipa-devel] [freeipa PR#437][synchronized] FIPS: replica install check

2017-02-10 Thread tomaskrizek
URL: https://github.com/freeipa/freeipa/pull/437 Author: tomaskrizek Title: #437: FIPS: replica install check Action: synchronized To pull the PR as Git branch: git remote add ghfreeipa https://github.com/freeipa/freeipa git fetch ghfreeipa pull/437/head:pr437 git checkout pr437 From

[Freeipa-devel] [freeipa PR#458][synchronized] Bytes deprecation warnings

2017-02-10 Thread tiran
URL: https://github.com/freeipa/freeipa/pull/458 Author: tiran Title: #458: Bytes deprecation warnings Action: synchronized To pull the PR as Git branch: git remote add ghfreeipa https://github.com/freeipa/freeipa git fetch ghfreeipa pull/458/head:pr458 git checkout pr458 From

[Freeipa-devel] [freeipa PR#458][opened] Bytes deprecation warnings

2017-02-10 Thread tiran
URL: https://github.com/freeipa/freeipa/pull/458 Author: tiran Title: #458: Bytes deprecation warnings Action: opened PR body: """ * Enable bytes and deprecation warnings * Fix a couple of bytes and deprecation warnings https://fedorahosted.org/freeipa/ticket/6631 """ To pull the PR as Git

[Freeipa-devel] [freeipa PR#446][synchronized] No NSS database passwords in ipa-client-install

2017-02-10 Thread stlaz
URL: https://github.com/freeipa/freeipa/pull/446 Author: stlaz Title: #446: No NSS database passwords in ipa-client-install Action: synchronized To pull the PR as Git branch: git remote add ghfreeipa https://github.com/freeipa/freeipa git fetch ghfreeipa pull/446/head:pr446 git checkout pr446

[Freeipa-devel] [freeipa PR#448][comment] Tests: Basic coverage with tree root domain

2017-02-10 Thread martbab
URL: https://github.com/freeipa/freeipa/pull/448 Title: #448: Tests: Basic coverage with tree root domain martbab commented: """ If you look at the test cases (e.g. test_login_ipa-user, test_login_ad_user, test_login_subdomain_user are the 'best: examples) you can see that the function body

[Freeipa-devel] [freeipa PR#455][+ack] Backup /root/kracert.p12

2017-02-10 Thread stlaz
URL: https://github.com/freeipa/freeipa/pull/455 Title: #455: Backup /root/kracert.p12 Label: +ack -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code

[Freeipa-devel] [freeipa PR#455][comment] Backup /root/kracert.p12

2017-02-10 Thread stlaz
URL: https://github.com/freeipa/freeipa/pull/455 Title: #455: Backup /root/kracert.p12 stlaz commented: """ Works as expected, ACK. """ See the full comment at https://github.com/freeipa/freeipa/pull/455#issuecomment-278939314 -- Manage your subscription for the Freeipa-devel mailing list:

[Freeipa-devel] [freeipa PR#428][comment] [Py3] ipa-server-install

2017-02-10 Thread HonzaCholasta
URL: https://github.com/freeipa/freeipa/pull/428 Title: #428: [Py3] ipa-server-install HonzaCholasta commented: """ Fixed upstream master: https://fedorahosted.org/freeipa/changeset/88b192a37ead1538e6d840c2f686f8d21a948542

[Freeipa-devel] [freeipa PR#428][closed] [Py3] ipa-server-install

2017-02-10 Thread HonzaCholasta
URL: https://github.com/freeipa/freeipa/pull/428 Author: MartinBasti Title: #428: [Py3] ipa-server-install Action: closed To pull the PR as Git branch: git remote add ghfreeipa https://github.com/freeipa/freeipa git fetch ghfreeipa pull/428/head:pr428 git checkout pr428 -- Manage your

[Freeipa-devel] [freeipa PR#428][+pushed] [Py3] ipa-server-install

2017-02-10 Thread HonzaCholasta
URL: https://github.com/freeipa/freeipa/pull/428 Title: #428: [Py3] ipa-server-install Label: +pushed -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code

[Freeipa-devel] [freeipa PR#428][+ack] [Py3] ipa-server-install

2017-02-10 Thread HonzaCholasta
URL: https://github.com/freeipa/freeipa/pull/428 Title: #428: [Py3] ipa-server-install Label: +ack -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code

[Freeipa-devel] [freeipa PR#457][opened] adtrustinstance: use LDAPI/EXTERNAL to retrieve CIFS keytab

2017-02-10 Thread martbab
URL: https://github.com/freeipa/freeipa/pull/457 Author: martbab Title: #457: adtrustinstance: use LDAPI/EXTERNAL to retrieve CIFS keytab Action: opened PR body: """ In order to be able to function as a part of composite installer, samba configuration code must be able to work without admin

[Freeipa-devel] [freeipa PR#450][synchronized] Add FIPS-token password of HTTPD NSS database

2017-02-10 Thread stlaz
URL: https://github.com/freeipa/freeipa/pull/450 Author: stlaz Title: #450: Add FIPS-token password of HTTPD NSS database Action: synchronized To pull the PR as Git branch: git remote add ghfreeipa https://github.com/freeipa/freeipa git fetch ghfreeipa pull/450/head:pr450 git checkout pr450

[Freeipa-devel] [freeipa PR#456][closed] bindinstance: fix named.conf parsing regexs

2017-02-10 Thread MartinBasti
URL: https://github.com/freeipa/freeipa/pull/456 Author: tomaskrizek Title: #456: bindinstance: fix named.conf parsing regexs Action: closed To pull the PR as Git branch: git remote add ghfreeipa https://github.com/freeipa/freeipa git fetch ghfreeipa pull/456/head:pr456 git checkout pr456 --

[Freeipa-devel] [freeipa PR#456][comment] bindinstance: fix named.conf parsing regexs

2017-02-10 Thread MartinBasti
URL: https://github.com/freeipa/freeipa/pull/456 Title: #456: bindinstance: fix named.conf parsing regexs MartinBasti commented: """ Fixed upstream master: https://fedorahosted.org/freeipa/changeset/52582ae9284b80c22a272f0793f0cddfb761f6dc

[Freeipa-devel] [freeipa PR#456][+ack] bindinstance: fix named.conf parsing regexs

2017-02-10 Thread MartinBasti
URL: https://github.com/freeipa/freeipa/pull/456 Title: #456: bindinstance: fix named.conf parsing regexs Label: +ack -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA:

[Freeipa-devel] [freeipa PR#456][+pushed] bindinstance: fix named.conf parsing regexs

2017-02-10 Thread MartinBasti
URL: https://github.com/freeipa/freeipa/pull/456 Title: #456: bindinstance: fix named.conf parsing regexs Label: +pushed -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA:

[Freeipa-devel] [freeipa PR#452][comment] [ WIP] ipa-run-tests: allow to run tests with server-api

2017-02-10 Thread tiran
URL: https://github.com/freeipa/freeipa/pull/452 Title: #452: [ WIP] ipa-run-tests: allow to run tests with server-api tiran commented: """ It's going to get simpler when privilege separation patch has landet. """ See the full comment at

[Freeipa-devel] [freeipa PR#452][+rejected] [ WIP] ipa-run-tests: allow to run tests with server-api

2017-02-10 Thread MartinBasti
URL: https://github.com/freeipa/freeipa/pull/452 Title: #452: [ WIP] ipa-run-tests: allow to run tests with server-api Label: +rejected -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA:

[Freeipa-devel] [freeipa PR#452][comment] [ WIP] ipa-run-tests: allow to run tests with server-api

2017-02-10 Thread MartinBasti
URL: https://github.com/freeipa/freeipa/pull/452 Title: #452: [ WIP] ipa-run-tests: allow to run tests with server-api MartinBasti commented: """ There are too many issues, it is not possible to run tests with server api easily, too many changes required. """ See the full comment at

[Freeipa-devel] [freeipa PR#452][closed] [ WIP] ipa-run-tests: allow to run tests with server-api

2017-02-10 Thread MartinBasti
URL: https://github.com/freeipa/freeipa/pull/452 Author: MartinBasti Title: #452: [ WIP] ipa-run-tests: allow to run tests with server-api Action: closed To pull the PR as Git branch: git remote add ghfreeipa https://github.com/freeipa/freeipa git fetch ghfreeipa pull/452/head:pr452 git

Re: [Freeipa-devel] FreeIPA and wildcard certificates

2017-02-10 Thread Martin Kosek
On 02/10/2017 10:37 AM, Fraser Tweedale wrote: > On Fri, Feb 10, 2017 at 09:23:10AM +0100, Martin Kosek wrote: >> On 02/09/2017 10:44 PM, Fraser Tweedale wrote: >>> On Thu, Feb 09, 2017 at 08:37:23AM +0100, Martin Kosek wrote: On 02/09/2017 02:12 AM, Fraser Tweedale wrote: > On Wed, Feb

[Freeipa-devel] [freeipa PR#456][opened] bindinstance: fix named.conf parsing regexs

2017-02-10 Thread tomaskrizek
URL: https://github.com/freeipa/freeipa/pull/456 Author: tomaskrizek Title: #456: bindinstance: fix named.conf parsing regexs Action: opened PR body: """ Since named.conf API for bind-dyndb-ldap was updated, our parsing regexes have to change. https://fedorahosted.org/freeipa/ticket/6565 """

[Freeipa-devel] [freeipa PR#455][opened] Backup /root/kracert.p12

2017-02-10 Thread tiran
URL: https://github.com/freeipa/freeipa/pull/455 Author: tiran Title: #455: Backup /root/kracert.p12 Action: opened PR body: """ ipa-backup now backs up /root/kracert.p12. The file contains the certs and encrypted private keys for KRA transport, storage and audit. Closes:

[Freeipa-devel] [freeipa PR#450][synchronized] Add FIPS-token password of HTTPD NSS database

2017-02-10 Thread stlaz
URL: https://github.com/freeipa/freeipa/pull/450 Author: stlaz Title: #450: Add FIPS-token password of HTTPD NSS database Action: synchronized To pull the PR as Git branch: git remote add ghfreeipa https://github.com/freeipa/freeipa git fetch ghfreeipa pull/450/head:pr450 git checkout pr450

Re: [Freeipa-devel] FreeIPA and wildcard certificates

2017-02-10 Thread Fraser Tweedale
On Fri, Feb 10, 2017 at 09:23:10AM +0100, Martin Kosek wrote: > On 02/09/2017 10:44 PM, Fraser Tweedale wrote: > > On Thu, Feb 09, 2017 at 08:37:23AM +0100, Martin Kosek wrote: > >> On 02/09/2017 02:12 AM, Fraser Tweedale wrote: > >>> On Wed, Feb 08, 2017 at 10:19:54AM +0200, Alexander Bokovoy

Re: [Freeipa-devel] FreeIPA and wildcard certificates

2017-02-10 Thread Martin Kosek
On 02/09/2017 10:44 PM, Fraser Tweedale wrote: > On Thu, Feb 09, 2017 at 08:37:23AM +0100, Martin Kosek wrote: >> On 02/09/2017 02:12 AM, Fraser Tweedale wrote: >>> On Wed, Feb 08, 2017 at 10:19:54AM +0200, Alexander Bokovoy wrote: On ke, 08 helmi 2017, Martin Kosek wrote: > Hi Fraser and

[Freeipa-devel] [freeipa PR#444][comment] Allow nsaccountlock to be searched in user-find commands

2017-02-10 Thread HonzaCholasta
URL: https://github.com/freeipa/freeipa/pull/444 Title: #444: Allow nsaccountlock to be searched in user-find commands HonzaCholasta commented: """ Replacing `flags=['no_option']` with `flags=['no_create', 'no_update']` is not backward compatible - the `no_option` flag only hides the option in