Re: [Freeipa-devel] [PATCH] 463-530 First part of RCUE adoption

2013-11-29 Thread Ana Krivokapic
On 11/29/2013 02:45 PM, Ana Krivokapic wrote: > On 11/25/2013 04:48 PM, Ana Krivokapic wrote: >> On 11/15/2013 02:26 PM, Petr Vobornik wrote: >>> Hello list, >>> >>> this is a first part of RCUE adoption effort. Main themes of this patch set >>&

Re: [Freeipa-devel] [PATCH] 463-530 First part of RCUE adoption

2013-11-29 Thread Ana Krivokapic
On 11/25/2013 04:48 PM, Ana Krivokapic wrote: > On 11/15/2013 02:26 PM, Petr Vobornik wrote: >> Hello list, >> >> this is a first part of RCUE adoption effort. Main themes of this patch set >> are: >> >> - use RCUE navigation <https://fedorahosted.or

Re: [Freeipa-devel] [PATCH] 0079 Enable Retro Changelog and Content Synchronization DS plugins

2013-11-28 Thread Ana Krivokapic
On 10/29/2013 06:57 PM, Ana Krivokapic wrote: > On 10/29/2013 12:46 PM, Martin Kosek wrote: >> On 10/25/2013 05:03 PM, Ana Krivokapic wrote: >>> Hello, >>> >>> This patch addresses ticket https://fedorahosted.org/freeipa/ticket/3967. >>> >> NAC

[Freeipa-devel] [PATCH] 0086 Make Expression field required when adding automember condition

2013-11-26 Thread Ana Krivokapic
Hello, This patch addresses ticket https://fedorahosted.org/freeipa/ticket/4053. -- Regards, Ana Krivokapic Associate Software Engineer FreeIPA team Red Hat Inc. From 32fe5becfa530e629602433e0942fccb1a06e677 Mon Sep 17 00:00:00 2001 From: Ana Krivokapic Date: Tue, 26 Nov 2013 12:09:44 +0100

Re: [Freeipa-devel] [PATCH] 463-530 First part of RCUE adoption

2013-11-25 Thread Ana Krivokapic
1) Two ui integration tests are failing, I guess this is due to the re-arranging of elements on the automember page. So the tests should be amended to reflect that change. 2) In the 'Add Host' dialog, validation error messages do not have the proper styles. E.g. if you don't fil

Re: [Freeipa-devel] [PATCHES] 0276-0277 Break long doc strings for translations

2013-11-20 Thread Ana Krivokapic
_ > Freeipa-devel mailing list > Freeipa-devel@redhat.com > https://www.redhat.com/mailman/listinfo/freeipa-devel Looks good to me. ACK. -- Regards, Ana Krivokapic Associate Software Engineer FreeIPA team Red Hat Inc. ___ Freeipa-devel mailing list Freeipa-devel@redhat.com https://www.redhat.com/mailman/listinfo/freeipa-devel

Re: [Freeipa-devel] [PATCH 111] ipa-client-install: Publish CA certificate to systemwide store

2013-11-20 Thread Ana Krivokapic
On 11/18/2013 01:54 PM, Tomas Babej wrote: > On 11/15/2013 03:36 PM, Rob Crittenden wrote: >> Tomas Babej wrote: >>> On 11/15/2013 02:46 PM, Ana Krivokapic wrote: >>>> On 11/13/2013 02:57 PM, Tomas Babej wrote: >>>>> On 09/27/2013 10:14 AM, Martin Ko

Re: [Freeipa-devel] [PATCHES] 0080-0081 Add userClass attributes for users and hosts

2013-11-19 Thread Ana Krivokapic
On 11/19/2013 12:52 PM, Ana Krivokapic wrote: > On 11/14/2013 10:04 AM, Petr Vobornik wrote: >> On 11/13/2013 01:33 PM, Ana Krivokapic wrote: >>> On 11/12/2013 01:27 PM, Ana Krivokapic wrote: >>>> On 10/30/2013 09:56 PM, Martin Kosek wrote: >>>>> --

Re: [Freeipa-devel] [PATCHES] 0080-0081 Add userClass attributes for users and hosts

2013-11-19 Thread Ana Krivokapic
On 11/14/2013 10:04 AM, Petr Vobornik wrote: > On 11/13/2013 01:33 PM, Ana Krivokapic wrote: >> On 11/12/2013 01:27 PM, Ana Krivokapic wrote: >>> On 10/30/2013 09:56 PM, Martin Kosek wrote: >>>> - Original Message - >>>>> From: "Simo Sor

Re: [Freeipa-devel] [PATCHES] 0258-0265 Add schema updater based on IPA schema files

2013-11-18 Thread Ana Krivokapic
On 11/15/2013 05:28 PM, Petr Viktorin wrote: > On 11/15/2013 02:09 PM, Petr Viktorin wrote: >> On 11/11/2013 04:18 PM, Ana Krivokapic wrote: >>> On 11/11/2013 02:53 PM, Ana Krivokapic wrote: >>>> On 11/11/2013 12:32 PM, Petr Viktorin wrote: >>>>>

Re: [Freeipa-devel] [PATCH] 0084 Make sure state of services is preserved after client uninstall

2013-11-18 Thread Ana Krivokapic
On 11/15/2013 05:03 PM, Tomas Babej wrote: > On 11/07/2013 05:25 PM, Ana Krivokapic wrote: >> Hello, >> >> This patch addresses ticket https://fedorahosted.org/freeipa/ticket/3790. >> >> >> >> ___ >> Fre

Re: [Freeipa-devel] [PATCH 111] ipa-client-install: Publish CA certificate to systemwide store

2013-11-15 Thread Ana Krivokapic
exists before using it, for the sake of cross-distro compatibility. >>> >> >> Right. I am also thinking if this functionality should not be somehow >> integrated into the platform files so that it can be overriden in platforms &

Re: [Freeipa-devel] [PATCH 0130] platform: Add Fedora 19 platform file

2013-11-15 Thread Ana Krivokapic
On 11/13/2013 02:56 PM, Tomas Babej wrote: > Hi, > > Part of: https://fedorahosted.org/freeipa/ticket/3504 > > > > ___ > Freeipa-devel mailing list > Freeipa-devel@redhat.com > https://www.redhat.com/mailman/listinfo/freeipa

Re: [Freeipa-devel] [PATCHES] 0068-0070 Automember rebuild membership

2013-11-14 Thread Ana Krivokapic
On 11/14/2013 03:11 PM, Martin Kosek wrote: > On 11/13/2013 04:56 PM, Ana Krivokapic wrote: >> On 11/13/2013 03:08 PM, Martin Kosek wrote: >>> On 10/29/2013 12:30 PM, Ana Krivokapic wrote: >>>> On 10/15/2013 06:09 PM, Ana Krivokapic wrote: >>>>>

Re: [Freeipa-devel] [PATCH 0113] ipa-client: Set NIS domain name in the installer

2013-11-14 Thread Ana Krivokapic
lso revert the nisdomain authconfig setting on client uninstall? -- Regards, Ana Krivokapic Associate Software Engineer FreeIPA team Red Hat Inc. ___ Freeipa-devel mailing list Freeipa-devel@redhat.com https://www.redhat.com/mailman/listinfo/freeipa-devel

Re: [Freeipa-devel] [PATCHES] 0068-0070 Automember rebuild membership

2013-11-13 Thread Ana Krivokapic
On 11/13/2013 03:08 PM, Martin Kosek wrote: > On 10/29/2013 12:30 PM, Ana Krivokapic wrote: >> On 10/15/2013 06:09 PM, Ana Krivokapic wrote: >>> On 09/30/2013 10:02 AM, Petr Viktorin wrote: >>>> On 09/27/2013 03:12 PM, Martin Kosek wrote: >>>>> On 09/27

Re: [Freeipa-devel] [PATCHES] 0080-0081 Add userClass attributes for users and hosts

2013-11-13 Thread Ana Krivokapic
On 11/12/2013 01:27 PM, Ana Krivokapic wrote: > On 10/30/2013 09:56 PM, Martin Kosek wrote: >> - Original Message - >>> From: "Simo Sorce" >>> To: "Ana Krivokapic" >>> Cc: "Martin Kosek" , "freeipa-devel" >

Re: [Freeipa-devel] [PATCH] 0127 Map NT_STATUS_INVALID_PARAMETER to a most likely error cause

2013-11-12 Thread Ana Krivokapic
On 11/12/2013 04:55 PM, Alexander Bokovoy wrote: > On Tue, 12 Nov 2013, Ana Krivokapic wrote: >> On 11/12/2013 10:41 AM, Alexander Bokovoy wrote: >>> +-1073741811: # NT_STATUS_INVALID_PARAMETER >>> +error.RemoteRetrieveError( >>

Re: [Freeipa-devel] [PATCH] 0127 Map NT_STATUS_INVALID_PARAMETER to a most likely error cause

2013-11-12 Thread Ana Krivokapic
mean unsynchronized time on both sides, for example')), With this change, the patch works fine. -- Regards, Ana Krivokapic Associate Software Engineer FreeIPA team Red Hat Inc. ___ Freeipa-devel mailing list Freeipa-devel@redhat.com https://www.red

[Freeipa-devel] [PATCH] 0085 Fix regression which prevents creating a winsync agreement

2013-11-12 Thread Ana Krivokapic
Hello, This patch should fix the regression introduced by the original fix for ticket https://fedorahosted.org/freeipa/ticket/3989. -- Regards, Ana Krivokapic Associate Software Engineer FreeIPA team Red Hat Inc. From 43309fd81f2ac2b46fb1908c79aef2d77fdf39ca Mon Sep 17 00:00:00 2001 From: Ana

Re: [Freeipa-devel] [PATCHES] 0080-0081 Add userClass attributes for users and hosts

2013-11-12 Thread Ana Krivokapic
On 10/30/2013 09:56 PM, Martin Kosek wrote: > - Original Message - >> From: "Simo Sorce" >> To: "Ana Krivokapic" >> Cc: "Martin Kosek" , "freeipa-devel" >> >> Sent: Wednesday, October 30, 2013 7:11:20 PM >

Re: [Freeipa-devel] [PATCHES] 0258-0265 Add schema updater based on IPA schema files

2013-11-11 Thread Ana Krivokapic
On 11/11/2013 02:53 PM, Ana Krivokapic wrote: > On 11/11/2013 12:32 PM, Petr Viktorin wrote: >> On 11/07/2013 02:34 PM, Ana Krivokapic wrote: >>> On 11/01/2013 03:26 PM, Petr Viktorin wrote: >>>> On 09/13/2013 06:44 PM, Petr Viktorin wrote: >>>>>

Re: [Freeipa-devel] [PATCHES] 0258-0265 Add schema updater based on IPA schema files

2013-11-11 Thread Ana Krivokapic
On 11/11/2013 12:32 PM, Petr Viktorin wrote: > On 11/07/2013 02:34 PM, Ana Krivokapic wrote: >> On 11/01/2013 03:26 PM, Petr Viktorin wrote: >>> On 09/13/2013 06:44 PM, Petr Viktorin wrote: >>>> On 08/01/2013 04:52 PM, Petr Viktorin wrote: >>>>> Hello,

Re: [Freeipa-devel] [PATCH] 440 Server does not detect different server and IPA domain

2013-11-08 Thread Ana Krivokapic
list Freeipa-devel@redhat.com https://www.redhat.com/mailman/listinfo/freeipa-devel ACK -- Regards, Ana Krivokapic Associate Software Engineer FreeIPA team Red Hat Inc. ___ Freeipa-devel mailing list Freeipa-devel@redhat.com https://www.redhat.com/ma

[Freeipa-devel] [PATCH] 0084 Make sure state of services is preserved after client uninstall

2013-11-07 Thread Ana Krivokapic
Hello, This patch addresses ticket https://fedorahosted.org/freeipa/ticket/3790. -- Regards, Ana Krivokapic Associate Software Engineer FreeIPA team Red Hat Inc. From ca950b2f6efe9c73288818667bfd618f4a2fd689 Mon Sep 17 00:00:00 2001 From: Ana Krivokapic Date: Thu, 7 Nov 2013 17:18:32 +0100

Re: [Freeipa-devel] [PATCHES] 0258-0265 Add schema updater based on IPA schema files

2013-11-07 Thread Ana Krivokapic
not force_replace: +modlist.append((ldap.MOD_DELETE, key, removes)) +elif new_values == []: # delete an empty value +modlist.append((ldap.MOD_DELETE, key, removes)) can be combined into one: +if not force_replace or not new_value

Re: [Freeipa-devel] [PATCH] 0316 Remove unused utf8_encode_value functions

2013-11-06 Thread Ana Krivokapic
; https://www.redhat.com/mailman/listinfo/freeipa-devel ACK -- Regards, Ana Krivokapic Associate Software Engineer FreeIPA team Red Hat Inc. ___ Freeipa-devel mailing list Freeipa-devel@redhat.com https://www.redhat.com/mailman/listinfo/freeipa-devel

Re: [Freeipa-devel] [PATCH] 0083 Remove internaldb pasword from password.conf

2013-11-06 Thread Ana Krivokapic
On 11/06/2013 01:34 PM, Ana Krivokapic wrote: > Hello, > > This patch addresses ticket https://fedorahosted.org/freeipa/ticket/4005. > > > > ___ > Freeipa-devel mailing list > Freeipa-devel@redhat.com > https://www.redha

[Freeipa-devel] [PATCH] 0083 Remove internaldb pasword from password.conf

2013-11-06 Thread Ana Krivokapic
Hello, This patch addresses ticket https://fedorahosted.org/freeipa/ticket/4005. -- Regards, Ana Krivokapic Associate Software Engineer FreeIPA team Red Hat Inc. From d79edbb9b2224a38636639944ffd9e51d095e920 Mon Sep 17 00:00:00 2001 From: Ana Krivokapic Date: Wed, 6 Nov 2013 13:29:09 +0100

[Freeipa-devel] [PATCH] 0082 Use EXTERNAL auth mechanism in ldapmodify

2013-11-05 Thread Ana Krivokapic
Hello, This patch addresses ticket https://fedorahosted.org/freeipa/ticket/3895. -- Regards, Ana Krivokapic Associate Software Engineer FreeIPA team Red Hat Inc. From 3bd13d7424a05d3900c13c911bf58899baa8d429 Mon Sep 17 00:00:00 2001 From: Ana Krivokapic Date: Tue, 5 Nov 2013 18:38:55 +0100

Re: [Freeipa-devel] [PATCH 0125] ipatests: Add which package to legacy client advice

2013-11-01 Thread Ana Krivokapic
On 11/01/2013 03:30 PM, Tomas Babej wrote: > On 11/01/2013 03:27 PM, Ana Krivokapic wrote: >> On 11/01/2013 03:18 PM, Tomas Babej wrote: >>> On 10/31/2013 12:10 PM, Ana Krivokapic wrote: >>>> On 10/30/2013 04:18 PM, Tomas Babej wrote: >>>>> Hi, >&

Re: [Freeipa-devel] [PATCH 0125] ipatests: Add which package to legacy client advice

2013-11-01 Thread Ana Krivokapic
On 11/01/2013 03:18 PM, Tomas Babej wrote: > On 10/31/2013 12:10 PM, Ana Krivokapic wrote: >> On 10/30/2013 04:18 PM, Tomas Babej wrote: >>> Hi, >>> >>> Adds which package to the requirements, since older distros do not have it >>> by default. >

Re: [Freeipa-devel] Reminder: Patchwork

2013-11-01 Thread Ana Krivokapic
On 10/31/2013 07:24 PM, Simo Sorce wrote: > On Thu, 2013-10-31 at 18:52 +0100, Ana Krivokapic wrote: >> Hello IPA developers, >> >> I would like to remind everyone about our Patchwork instance[1]. This tool >> helps >> us to better coordinate work and be more ef

[Freeipa-devel] Reminder: Patchwork

2013-10-31 Thread Ana Krivokapic
eIPA/list/ [2] http://www.freeipa.org/page/Contribute/Code#Tracking_patches_.28Experimental.29 -- Regards, Ana Krivokapic Associate Software Engineer FreeIPA team Red Hat Inc. ___ Freeipa-devel mailing list Freeipa-devel@redhat.com https://www.redhat.

Re: [Freeipa-devel] [PATCH 0123] ipatests: Do not use /usr/bin hardcoded paths

2013-10-31 Thread Ana Krivokapic
Freeipa-devel@redhat.com > https://www.redhat.com/mailman/listinfo/freeipa-devel ACK -- Regards, Ana Krivokapic Associate Software Engineer FreeIPA team Red Hat Inc. ___ Freeipa-devel mailing list Freeipa-devel@redhat.com https://www.redhat.com/mailman/listinfo/freeipa-devel

Re: [Freeipa-devel] [PATCH 0126] ipatests: Restore SELinux context after restoring files from

2013-10-31 Thread Ana Krivokapic
ist > Freeipa-devel@redhat.com > https://www.redhat.com/mailman/listinfo/freeipa-devel ACK -- Regards, Ana Krivokapic Associate Software Engineer FreeIPA team Red Hat Inc. ___ Freeipa-devel mailing list Freeipa-devel@redhat.com https://www.redhat.com/mailman/listinfo/freeipa-devel

Re: [Freeipa-devel] [PATCH 0124] ipatests: Extend clear_sssd_cache to support non-systemd

2013-10-31 Thread Ana Krivokapic
Freeipa-devel@redhat.com > https://www.redhat.com/mailman/listinfo/freeipa-devel Looks good, ACK. -- Regards, Ana Krivokapic Associate Software Engineer FreeIPA team Red Hat Inc. ___ Freeipa-devel mailing list Freeipa-devel@redhat.com https://www

Re: [Freeipa-devel] [PATCH 0125] ipatests: Add which package to legacy client advice

2013-10-31 Thread Ana Krivokapic
ere's no need to install any additional packages. -- Regards, Ana Krivokapic Associate Software Engineer FreeIPA team Red Hat Inc. ___ Freeipa-devel mailing list Freeipa-devel@redhat.com https://www.redhat.com/mailman/listinfo/freeipa-devel

Re: [Freeipa-devel] [PATCHES] 0080-0081 Add userClass attributes for users and hosts

2013-10-30 Thread Ana Krivokapic
On 10/29/2013 02:04 PM, Simo Sorce wrote: > On Tue, 2013-10-29 at 12:42 +0100, Martin Kosek wrote: >> On 10/29/2013 10:49 AM, Ana Krivokapic wrote: >>> Hello, >>> >>> Patch 0080 adds userClass attribute for users to IPA CLI. >>> Patch 0081 adds userClas

Re: [Freeipa-devel] [PATCHES] 0080-0081 Add userClass attributes for users and hosts

2013-10-30 Thread Ana Krivokapic
On 10/29/2013 11:08 PM, Dmitri Pal wrote: > On 10/29/2013 08:04 AM, Petr Vobornik wrote: >> On 10/29/2013 10:49 AM, Ana Krivokapic wrote: >>> Hello, >>> >>> Patch 0080 adds userClass attribute for users to IPA CLI. >>> Patch 0081 adds userClas

Re: [Freeipa-devel] [PATCH] 462 Fix password expiration notification

2013-10-30 Thread Ana Krivokapic
On 10/30/2013 01:24 PM, Petr Vobornik wrote: > On 10/30/2013 01:18 PM, Ana Krivokapic wrote: >> The patch fixes the issue. >> >> I have just one nitpick: >> >> >>> +# reset password if needed

Re: [Freeipa-devel] [PATCH] 462 Fix password expiration notification

2013-10-30 Thread Ana Krivokapic
The patch fixes the issue. I have just one nitpick: > +# reset password if needed > +if (self.get_auth_dialog()): ^^ ^^ <- redundant parentheses -- Regards, Ana Krivokapic Associate Software Engineer FreeIPA team Re

Re: [Freeipa-devel] [PATCH] 0079 Enable Retro Changelog and Content Synchronization DS plugins

2013-10-29 Thread Ana Krivokapic
On 10/29/2013 12:46 PM, Martin Kosek wrote: > On 10/25/2013 05:03 PM, Ana Krivokapic wrote: >> Hello, >> >> This patch addresses ticket https://fedorahosted.org/freeipa/ticket/3967. >> > NACK. I do not think this will work well with the case when DNS is not used.

Re: [Freeipa-devel] [PATCHES] 0072-0074 Add automember rebuild membership to the web UI

2013-10-29 Thread Ana Krivokapic
On 10/24/2013 03:48 PM, Petr Vobornik wrote: > On 10/16/2013 11:37 PM, Ana Krivokapic wrote: >> On 09/27/2013 04:38 PM, Petr Vobornik wrote: >>> On 09/25/2013 11:51 AM, Ana Krivokapic wrote: >>>> Hello, >>>> >>>> This patch set addresses ti

Re: [Freeipa-devel] [PATCHES] 0068-0070 Automember rebuild membership

2013-10-29 Thread Ana Krivokapic
On 10/15/2013 06:09 PM, Ana Krivokapic wrote: > On 09/30/2013 10:02 AM, Petr Viktorin wrote: >> On 09/27/2013 03:12 PM, Martin Kosek wrote: >>> On 09/27/2013 03:00 PM, Jan Cholasta wrote: >>>> On 23.9.2013 19:41, Ana Krivokapic wrote: >>>>>

[Freeipa-devel] [PATCHES] 0080-0081 Add userClass attributes for users and hosts

2013-10-29 Thread Ana Krivokapic
://fedorahosted.org/freeipa/ticket/3590 -- Regards, Ana Krivokapic Associate Software Engineer FreeIPA team Red Hat Inc. From df9c93c145671094fe85401a96c490dd60cf0671 Mon Sep 17 00:00:00 2001 From: Ana Krivokapic Date: Fri, 25 Oct 2013 16:29:26 +0200 Subject: [PATCH] Add userClass attribute for users This new

[Freeipa-devel] [PATCH] 0079 Enable Retro Changelog and Content Synchronization DS plugins

2013-10-25 Thread Ana Krivokapic
Hello, This patch addresses ticket https://fedorahosted.org/freeipa/ticket/3967. -- Regards, Ana Krivokapic Associate Software Engineer FreeIPA team Red Hat Inc. From c09bba5cc537d2925d7d6498204a403931ba908e Mon Sep 17 00:00:00 2001 From: Ana Krivokapic Date: Fri, 25 Oct 2013 12:41:25 +0200

[Freeipa-devel] [PATCH] 0078 Make sure nsds5ReplicaStripAttrs is set on agreements

2013-10-24 Thread Ana Krivokapic
Hello, This patch addresses ticket https://fedorahosted.org/freeipa/ticket/3989 -- Regards, Ana Krivokapic Associate Software Engineer FreeIPA team Red Hat Inc. From ea2d6ce79b674ddaa681fc64d1fa4de3ee308ebd Mon Sep 17 00:00:00 2001 From: Ana Krivokapic Date: Thu, 24 Oct 2013 20:36:30 +0200

[Freeipa-devel] [PATCH] 0077 Do not roll back failed client installation on server

2013-10-24 Thread Ana Krivokapic
Hello, This patch addresses ticket https://fedorahosted.org/freeipa/ticket/3990 -- Regards, Ana Krivokapic Associate Software Engineer FreeIPA team Red Hat Inc. From 2ec44821d5f422c6ab20202fcdc9e1f1eaad7ab1 Mon Sep 17 00:00:00 2001 From: Ana Krivokapic Date: Thu, 24 Oct 2013 17:43:21 +0200

[Freeipa-devel] [PATCH] 0076 Add test for external CA installation

2013-10-22 Thread Ana Krivokapic
Hello, This patch addresses ticket https://fedorahosted.org/freeipa/ticket/3819 -- Regards, Ana Krivokapic Associate Software Engineer FreeIPA team Red Hat Inc. From 0bc373fe9a8d6f7ed1cc2cd82bf9a69f0a8613d5 Mon Sep 17 00:00:00 2001 From: Ana Krivokapic Date: Tue, 22 Oct 2013 20:00:18 +0200

Re: [Freeipa-devel] Old tickets to close

2013-10-21 Thread Ana Krivokapic
ve useful in future. > Currently, > Web UI cannot search only on a specific user entry, AFAIR. > >>>> #126 - I think we should close WONTFIX >> I agree. We have how-to for people who insist on chroot. > +1 > >>>> #908 - I do not think we care much for the op

Re: [Freeipa-devel] [PATCH] 0274 test_simple_replication: Fix waiting for replication

2013-10-18 Thread Ana Krivokapic
See commit message for details. > > > > ___ > Freeipa-devel mailing list > Freeipa-devel@redhat.com > https://www.redhat.com/mailman/listinfo/freeipa-devel The simple replication test seems to work fine with the patch applied, the code changes look sane, so A

Re: [Freeipa-devel] [PATCH] 0288 Use a user result template in tests

2013-10-18 Thread Ana Krivokapic
in``overrides``. ^ missing space +""" +# sn can be None; this should only used from `get_admin_result` ... this should only *be* used ... -- Regards, Ana Krivokapic Associate Software Engineer FreeIPA team Red Hat Inc. __

Re: [Freeipa-devel] [PATCH] 0075 Add ipa-advise plugins for nss-pam-ldapd legacy clients

2013-10-18 Thread Ana Krivokapic
On 10/18/2013 01:31 PM, Ana Krivokapic wrote: > On 10/18/2013 09:48 AM, Martin Kosek wrote: >> On 10/17/2013 10:29 PM, Alexander Bokovoy wrote: >>> On Thu, 17 Oct 2013, Ana Krivokapic wrote: >>> >>>> Hello, >>>> >>>> This patch adds i

Re: [Freeipa-devel] [PATCH] 0075 Add ipa-advise plugins for nss-pam-ldapd legacy clients

2013-10-18 Thread Ana Krivokapic
On 10/18/2013 09:48 AM, Martin Kosek wrote: > On 10/17/2013 10:29 PM, Alexander Bokovoy wrote: >> On Thu, 17 Oct 2013, Ana Krivokapic wrote: >> >>> Hello, >>> >>> This patch adds ipa-advise plugins for configuring legacy clients using >>> nss-

[Freeipa-devel] [PATCH] 0075 Add ipa-advise plugins for nss-pam-ldapd legacy clients

2013-10-17 Thread Ana Krivokapic
Hello, This patch adds ipa-advise plugins for configuring legacy clients using nss-pam-ldapd. https://fedorahosted.org/freeipa/ticket/3672 -- Regards, Ana Krivokapic Associate Software Engineer FreeIPA team Red Hat Inc. From faa1247c6fd954aadcf7f4ea47a20e106e672bab Mon Sep 17 00:00:00 2001

Re: [Freeipa-devel] [PATCHES] 0072-0074 Add automember rebuild membership to the web UI

2013-10-16 Thread Ana Krivokapic
On 09/27/2013 04:38 PM, Petr Vobornik wrote: On 09/25/2013 11:51 AM, Ana Krivokapic wrote: Hello, This patch set addresses ticket https://fedorahosted.org/freeipa/ticket/3928. Patch 0072 hooks the new automember-rebuild command to the web UI (user and host pages). Patch 0073 adds some

Re: [Freeipa-devel] [PATCHES] 0068-0070 Automember rebuild membership

2013-10-15 Thread Ana Krivokapic
On 09/30/2013 10:02 AM, Petr Viktorin wrote: > On 09/27/2013 03:12 PM, Martin Kosek wrote: >> On 09/27/2013 03:00 PM, Jan Cholasta wrote: >>> On 23.9.2013 19:41, Ana Krivokapic wrote: >>>> On 09/19/2013 03:29 PM, Ana Krivokapic wrote: >> ... >>> Patch

Re: [Freeipa-devel] [PATCH] 451-458 Web UI devel and source code documentation

2013-10-15 Thread Ana Krivokapic
On 10/02/2013 02:20 PM, Petr Vobornik wrote: > On 09/16/2013 05:24 PM, Ana Krivokapic wrote: >> On 09/11/2013 12:44 PM, Petr Vobornik wrote: >>> Hello, >>> > > snip > >>> >> >> I looked into the documentation effort and (ruby dependency disc

Re: [Freeipa-devel] [PATCH] 448 Load updated Web UI files after server upgrade

2013-10-15 Thread Ana Krivokapic
On 10/02/2013 12:45 PM, Petr Vobornik wrote: > On 09/27/2013 09:16 AM, Ana Krivokapic wrote: >> On 08/30/2013 05:21 PM, Petr Vobornik wrote: > > snip > >>> >>> https://fedorahosted.org/freeipa/ticket/3798 >>> >> >> I tested the patch and i

Re: [Freeipa-devel] [PATCH] 448 Load updated Web UI files after server upgrade

2013-09-27 Thread Ana Krivokapic
> Freeipa-devel mailing list > Freeipa-devel@redhat.com > https://www.redhat.com/mailman/listinfo/freeipa-devel I tested the patch and it seems to work fine. Code-wise it looks good as well. Nitpick: There is an unused function 'updated()' in the new loader.js.in file. -- Regards, Ana Krivokapic Associate Software Engineer FreeIPA team Red Hat Inc. ___ Freeipa-devel mailing list Freeipa-devel@redhat.com https://www.redhat.com/mailman/listinfo/freeipa-devel

Re: [Freeipa-devel] [PATCH] 459 Allow edit of ipakrbokasdelegate in Web UI when attrlevelrights are unknown

2013-09-25 Thread Ana Krivokapic
On 09/25/2013 05:44 PM, Petr Vobornik wrote: > On 09/25/2013 02:17 PM, Ana Krivokapic wrote: >> On 09/24/2013 04:31 PM, Petr Vobornik wrote: >>> Old host entries are missing object class with krbticketflags attribute. >>> Therefore UI does not receive attrlevelrights fo

Re: [Freeipa-devel] [PATCH] 459 Allow edit of ipakrbokasdelegate in Web UI when attrlevelrights are unknown

2013-09-25 Thread Ana Krivokapic
for such cases. > > https://fedorahosted.org/freeipa/ticket/3940 > > > ___ > Freeipa-devel mailing list > Freeipa-devel@redhat.com > https://www.redhat.com/mailman/listinfo/freeipa-devel The patch works well. Could you please also ad

[Freeipa-devel] [PATCHES] 0072-0074 Add automember rebuild membership to the web UI

2013-09-25 Thread Ana Krivokapic
integration tests for the new feature. The patch set applies on top of my patches 0068-0071 -- Regards, Ana Krivokapic Associate Software Engineer FreeIPA team Red Hat Inc. From 917c0bbd3ac45ff307f899dd50d5d44fac68c6e9 Mon Sep 17 00:00:00 2001 From: Ana Krivokapic Date: Wed, 25 Sep 2013 11:38:07 +0200

Re: [Freeipa-devel] [PATCHES] 0068-0070 Automember rebuild membership

2013-09-23 Thread Ana Krivokapic
On 09/19/2013 03:29 PM, Ana Krivokapic wrote: > Hello, > > This patch set adds automember rebuild membership functionality to IPA CLI. > > Design: http://www.freeipa.org/page/V3/Automember_rebuild_membership > Ticket: https://fedorahosted.org/f

Re: [Freeipa-devel] [RFE] Support for automember rebuild membership

2013-09-23 Thread Ana Krivokapic
On 09/23/2013 09:57 AM, Jan Cholasta wrote: > On 23.9.2013 09:18, Martin Kosek wrote: >> On 09/19/2013 03:43 PM, Ana Krivokapic wrote: >>> On 09/19/2013 03:26 PM, Jan Cholasta wrote: >>>> Hi, >>>> >>>> On 12.9.2013 19:59, Ana Krivokapic w

Re: [Freeipa-devel] [RFE] Support for automember rebuild membership

2013-09-20 Thread Ana Krivokapic
jr.aqu...@citrix.com > > Powering mobile workstyles and cloud services > >> On Sep 20, 2013, at 3:37 AM, "Ana Krivokapic" wrote: >> >>> On 09/19/2013 07:34 PM, JR Aquino wrote: >>> Does the rebuild support the notion of members belonging to multip

Re: [Freeipa-devel] [RFE] Support for automember rebuild membership

2013-09-20 Thread Ana Krivokapic
117 > T: +1 805.690.3478 > C: +1 805.717.0365 > jr.aqu...@citrix.com<mailto:jr.aqu...@citrixonline.com> > http://www.citrixonline.com<http://www.citrixonline.com/> > > On Sep 19, 2013, at 6:43 AM, Ana Krivokapic > mailto:akriv...@redhat.com>> wrote: > > On

Re: [Freeipa-devel] [PATCH 109] Use getent admin@domain for nss check in, ipa-client-install

2013-09-19 Thread Ana Krivokapic
es/freeipa-devel/2013-September/msg00085.html > > And I did the same mistake. Fixed patched attached. > > > > > ___ > Freeipa-devel mailing list > Freeipa-devel@redhat.com > https://www.redhat.com/mailman/listinfo/freeipa-devel ACK -- Regards, Ana Krivokapic Associate Sof

Re: [Freeipa-devel] [RFE] Support for automember rebuild membership

2013-09-19 Thread Ana Krivokapic
On 09/19/2013 03:26 PM, Jan Cholasta wrote: > Hi, > > On 12.9.2013 19:59, Ana Krivokapic wrote: >> Hello, >> >> The design document for $SUBJECT can be found at: >> http://www.freeipa.org/page/V3/Automember_rebuild_membership >> >> Related tickets: &g

[Freeipa-devel] [PATCHES] 0068-0070 Automember rebuild membership

2013-09-19 Thread Ana Krivokapic
Hello, This patch set adds automember rebuild membership functionality to IPA CLI. Design: http://www.freeipa.org/page/V3/Automember_rebuild_membership Ticket: https://fedorahosted.org/freeipa/ticket/3752 -- Regards, Ana Krivokapic Associate Software Engineer FreeIPA team Red Hat Inc. From

Re: [Freeipa-devel] [RFE] Support for automember rebuild membership

2013-09-19 Thread Ana Krivokapic
On 09/19/2013 12:01 PM, Martin Kosek wrote: > - Original Message - >> From: "Ana Krivokapic" >> To: "Nathan Kinder" >> Cc: "Martin Kosek" , "freeipa-devel" >> , "Mark Reynolds" >> >> Sent: T

Re: [Freeipa-devel] [RFE] Support for automember rebuild membership

2013-09-19 Thread Ana Krivokapic
On 09/18/2013 06:51 PM, Nathan Kinder wrote: > On 09/18/2013 07:26 AM, Martin Kosek wrote: >> On 09/18/2013 01:37 PM, Ana Krivokapic wrote: >>> On 09/13/2013 10:48 AM, Martin Kosek wrote: >>>> On 09/12/2013 07:59 PM, Ana Krivokapic wrote: >> ... >>&g

[Freeipa-devel] [PATCH] 0067 Use fqdn when creating msdcs SRV records

2013-09-18 Thread Ana Krivokapic
Hello, This patch addresses ticket https://fedorahosted.org/freeipa/ticket/3908. -- Regards, Ana Krivokapic Associate Software Engineer FreeIPA team Red Hat Inc. From e04aa1b7c19ec7cbef7ef0b8c29d6fca6a890fd5 Mon Sep 17 00:00:00 2001 From: Ana Krivokapic Date: Wed, 18 Sep 2013 18:39:11 +0200

Re: [Freeipa-devel] [RFE] Support for automember rebuild membership

2013-09-18 Thread Ana Krivokapic
On 09/13/2013 10:48 AM, Martin Kosek wrote: > On 09/12/2013 07:59 PM, Ana Krivokapic wrote: >> Hello, >> >> The design document for $SUBJECT can be found at: >> http://www.freeipa.org/page/V3/Automember_rebuild_membership >> >> Related tickets: >>

Re: [Freeipa-devel] [PATCH] 451-458 Web UI devel and source code documentation

2013-09-16 Thread Ana Krivokapic
'element2' * */ as opposed to this: /** * This is a list: * - 'element1' * - 'element2' */ -- Regards, Ana Krivokapic Associate Software Engineer FreeIPA team Red Hat Inc. ___ Freeipa-devel mailing list Freeipa-devel@redhat.com https://www.redhat.com/mailman/listinfo/freeipa-devel

Re: [Freeipa-devel] [RFE] Support for automember rebuild membership

2013-09-13 Thread Ana Krivokapic
On 09/13/2013 10:48 AM, Martin Kosek wrote: > On 09/12/2013 07:59 PM, Ana Krivokapic wrote: >> Hello, >> >> The design document for $SUBJECT can be found at: >> http://www.freeipa.org/page/V3/Automember_rebuild_membership >> >> Related tickets: >>

Re: [Freeipa-devel] [RFE] Support for automember rebuild membership

2013-09-13 Thread Ana Krivokapic
On 09/13/2013 10:16 AM, Martin Kosek wrote: > On 09/12/2013 09:46 PM, Dmitri Pal wrote: >> On 09/12/2013 03:23 PM, Rob Crittenden wrote: >>> Dmitri Pal wrote: >>>> On 09/12/2013 01:59 PM, Ana Krivokapic wrote: >>>>> Hello, >>>>> >&g

[Freeipa-devel] [RFE] Support for automember rebuild membership

2013-09-12 Thread Ana Krivokapic
Hello, The design document for $SUBJECT can be found at: http://www.freeipa.org/page/V3/Automember_rebuild_membership Related tickets: https://fedorahosted.org/freeipa/ticket/3752 https://fedorahosted.org/freeipa/ticket/3928 Thoughts, comments, questions welcome. -- Regards, Ana Krivokapic

Re: [Freeipa-devel] [PATCH] IPA-CLIENT: NSS test needs to check against the domain name

2013-09-06 Thread Ana Krivokapic
e 'cli_realm' with 'cli_domain' in the 'if not found:' block that follows. -- Regards, Ana Krivokapic Associate Software Engineer FreeIPA team Red Hat Inc. ___ Freeipa-devel mailing list Freeipa-devel@redhat.com https://www.redhat.com/mailman/listinfo/freeipa-devel

Re: [Freeipa-devel] [PATCH] 450 Fix redirection on deletion of last dns record entry

2013-09-06 Thread Ana Krivokapic
On 09/06/2013 02:30 PM, Petr Vobornik wrote: > https://fedorahosted.org/freeipa/ticket/3907 > > > ___ > Freeipa-devel mailing list > Freeipa-devel@redhat.com > https://www.redhat.com/mailman/listinfo/freeipa-devel ACK -- Reg

[Freeipa-devel] [PATCH] 0066 Do not crash if DS is down during server uninstall

2013-09-06 Thread Ana Krivokapic
Hello, This patch fixes the regression introduced by the original fix for ticket #3867. https://fedorahosted.org/freeipa/ticket/3867 -- Regards, Ana Krivokapic Associate Software Engineer FreeIPA team Red Hat Inc. From 0ad82d43314ef7e8d9538de76b118ce0922e512d Mon Sep 17 00:00:00 2001 From

[Freeipa-devel] [PATCH] 0065 Follow tmpfiles.d packaging guidelines

2013-09-04 Thread Ana Krivokapic
Hello, This patch addresses ticket https://fedorahosted.org/freeipa/ticket/3881. -- Regards, Ana Krivokapic Associate Software Engineer FreeIPA team Red Hat Inc. From 21264f8da8f0fa9d01b319b33c2b18daea52198a Mon Sep 17 00:00:00 2001 From: Ana Krivokapic Date: Wed, 4 Sep 2013 18:18:13 +0200

[Freeipa-devel] [PATCH] 0064 Fix invocations of FileError in ipa-client-install

2013-09-04 Thread Ana Krivokapic
Hello, This patch addresses ticket https://fedorahosted.org/freeipa/ticket/3758. -- Regards, Ana Krivokapic Associate Software Engineer FreeIPA team Red Hat Inc. From aa8c36c9bf5f3a349fdf319f3e08a8b56081abef Mon Sep 17 00:00:00 2001 From: Ana Krivokapic Date: Wed, 4 Sep 2013 16:04:59 +0200

Re: [Freeipa-devel] [PATCH] 0062 Replace ntpdate calls with ntpd

2013-09-04 Thread Ana Krivokapic
On 09/03/2013 01:15 PM, Petr Viktorin wrote: > On 09/02/2013 05:05 PM, Ana Krivokapic wrote: >> Hello, >> >> This patch addresses tickethttps://fedorahosted.org/freeipa/ticket/3797. >> > > Thanks! I have a question. > >> -# retry several

Re: [Freeipa-devel] [PATCH] 0060 Add warning when uninstalling active replica

2013-09-03 Thread Ana Krivokapic
On 09/03/2013 08:25 AM, Martin Kosek wrote: > On 09/02/2013 06:21 PM, Tomas Babej wrote: >> On 09/02/2013 06:07 PM, Petr Viktorin wrote: >>> On 08/29/2013 05:56 PM, Ana Krivokapic wrote: >>>> Hello, >>>> >>>> This patch addresses ticket https:

Re: [Freeipa-devel] [PATCH] 0061 Add option to ipa-client-install to configure automount

2013-09-03 Thread Ana Krivokapic
On 09/03/2013 12:27 PM, Petr Viktorin wrote: > On 09/02/2013 01:31 PM, Ana Krivokapic wrote: >> On 09/02/2013 12:55 PM, Petr Viktorin wrote: >>> On 08/30/2013 04:10 PM, Ana Krivokapic wrote: >>>> Hello, >>>> >>>> The attached patch addresses ti

[Freeipa-devel] [PATCH] 0063 Do not show unexpected error in ipa-ldap-updater

2013-09-03 Thread Ana Krivokapic
Hello, This patch addresses ticket https://fedorahosted.org/freeipa/ticket/3825. -- Regards, Ana Krivokapic Associate Software Engineer FreeIPA team Red Hat Inc. From f71bace581340667d27a0ad0f1b47eb2b7b9d870 Mon Sep 17 00:00:00 2001 From: Ana Krivokapic Date: Tue, 3 Sep 2013 12:42:48 +0200

[Freeipa-devel] [PATCH] 0062 Replace ntpdate calls with ntpd

2013-09-02 Thread Ana Krivokapic
Hello, This patch addresses ticket https://fedorahosted.org/freeipa/ticket/3797. -- Regards, Ana Krivokapic Associate Software Engineer FreeIPA team Red Hat Inc. From cfbf21ce24c677712d8f74a29ff5896cb2ad9396 Mon Sep 17 00:00:00 2001 From: Ana Krivokapic Date: Mon, 2 Sep 2013 16:40:55 +0200

Re: [Freeipa-devel] [PATCH] 0061 Add option to ipa-client-install to configure automount

2013-09-02 Thread Ana Krivokapic
On 09/02/2013 12:55 PM, Petr Viktorin wrote: > On 08/30/2013 04:10 PM, Ana Krivokapic wrote: >> Hello, >> >> The attached patch addresses ticket >> https://fedorahosted.org/freeipa/ticket/3740. > > Hello, > Please write a design doc for this RFE. I updat

Re: [Freeipa-devel] [PATCH] 0059 Create DS user and group during ipa-restore

2013-09-02 Thread Ana Krivokapic
On 08/30/2013 04:37 PM, Petr Viktorin wrote: > On 08/29/2013 02:16 PM, Ana Krivokapic wrote: >> Hello, >> >> This patch addresses tickethttps://fedorahosted.org/freeipa/ticket/3856. >> > > Thanks for the patch! > I haven't tested it yet, but I've read

Re: [Freeipa-devel] [PATCH] 0058 Add integration tests for forced client re-enrollment

2013-08-30 Thread Ana Krivokapic
On 08/30/2013 03:28 PM, Petr Viktorin wrote: > On 08/28/2013 03:04 PM, Ana Krivokapic wrote: >> Hello, >> >> This patch adds integration tests for the forced client re-enrollment >> feature, according to the test plan at: >> http://www.freeipa.org/page/V3/Forc

[Freeipa-devel] [PATCH] 0061 Add option to ipa-client-install to configure automount

2013-08-30 Thread Ana Krivokapic
Hello, The attached patch addresses ticket https://fedorahosted.org/freeipa/ticket/3740. -- Regards, Ana Krivokapic Associate Software Engineer FreeIPA team Red Hat Inc. From 5d86c02b4bf99e701899caff3d9b7d1bd2240621 Mon Sep 17 00:00:00 2001 From: Ana Krivokapic Date: Fri, 30 Aug 2013 16:05

[Freeipa-devel] [PATCH] 0060 Add warning when uninstalling active replica

2013-08-29 Thread Ana Krivokapic
Hello, This patch addresses ticket https://fedorahosted.org/freeipa/ticket/3867. -- Regards, Ana Krivokapic Associate Software Engineer FreeIPA team Red Hat Inc. From 29732542431dfa3d2a41607f6537690655a7a027 Mon Sep 17 00:00:00 2001 From: Ana Krivokapic Date: Thu, 29 Aug 2013 17:44:02 +0200

[Freeipa-devel] [PATCH] 0059 Create DS user and group during ipa-restore

2013-08-29 Thread Ana Krivokapic
Hello, This patch addresses ticket https://fedorahosted.org/freeipa/ticket/3856. -- Regards, Ana Krivokapic Associate Software Engineer FreeIPA team Red Hat Inc. From f1a2a00f72961c88530be8aa1a62fb15758d90b5 Mon Sep 17 00:00:00 2001 From: Ana Krivokapic Date: Thu, 29 Aug 2013 12:11:55 +0200

[Freeipa-devel] [PATCH] 0058 Add integration tests for forced client re-enrollment

2013-08-28 Thread Ana Krivokapic
Hello, This patch adds integration tests for the forced client re-enrollment feature, according to the test plan at: http://www.freeipa.org/page/V3/Forced_client_re-enrollment#Test_Plan https://fedorahosted.org/freeipa/ticket/3832 -- Regards, Ana Krivokapic Associate Software Engineer

Re: [Freeipa-devel] [PATCH] 446 Update idrange search facet after trust creation

2013-08-28 Thread Ana Krivokapic
eeipa-devel@redhat.com > https://www.redhat.com/mailman/listinfo/freeipa-devel ACK -- Regards, Ana Krivokapic Associate Software Engineer FreeIPA team Red Hat Inc. ___ Freeipa-devel mailing list Freeipa-devel@redhat.com https://www.redhat.com/mailman/listinfo/freeipa-devel

Re: [Freeipa-devel] [PATCH] 0057 Add integration tests for Kerberos Flags

2013-08-27 Thread Ana Krivokapic
On 08/27/2013 10:45 AM, Petr Viktorin wrote: > On 08/25/2013 08:56 PM, Ana Krivokapic wrote: >> Hello, >> >> This patch adds integration tests for the Kerberos Flags feature (except the >> web >> UI tests), according to the test plan at: >> http://www.freei

[Freeipa-devel] [PATCH] 0057 Add integration tests for Kerberos Flags

2013-08-25 Thread Ana Krivokapic
Hello, This patch adds integration tests for the Kerberos Flags feature (except the web UI tests), according to the test plan at: http://www.freeipa.org/page/V3/Kerberos_Flags#Test_Plan. https://fedorahosted.org/freeipa/ticket/3831 -- Regards, Ana Krivokapic Associate Software Engineer

Re: [Freeipa-devel] [PATCH] 445 Web UI integration tests: ID range types

2013-08-21 Thread Ana Krivokapic
Technically, I don't think this is a PEP8 violation as blank lines are allowed inside functions. The patch works fine and I have no objections to the code, so ACK from me. -- Regards, Ana Krivokapic Associate Software Engineer FreeIPA team Red Hat Inc. ___

  1   2   3   >