Re: [Freeipa-devel] [PATCH] 0304 ipapython.nsslib: Name arguments to NSPRError

2013-10-04 Thread Petr Viktorin
On 10/02/2013 05:49 PM, Petr Vobornik wrote: On 10/02/2013 04:34 PM, Petr Viktorin wrote: As I found out when installing on a misconfigured system, we use wrong argument order for NSPRError in nsslib. This patch corrects the problem. ACK A nitpick: $ git diff HEAD~1 | pep8 --diff

[Freeipa-devel] [PATCH] 0304 ipapython.nsslib: Name arguments to NSPRError

2013-10-02 Thread Petr Viktorin
As I found out when installing on a misconfigured system, we use wrong argument order for NSPRError in nsslib. This patch corrects the problem. FWIW raising NSPRError might not be correct; the nss.error.NSPRError docstring states: Raised internally, there should be no need to raise this

Re: [Freeipa-devel] [PATCH] 0304 ipapython.nsslib: Name arguments to NSPRError

2013-10-02 Thread Petr Vobornik
On 10/02/2013 04:34 PM, Petr Viktorin wrote: As I found out when installing on a misconfigured system, we use wrong argument order for NSPRError in nsslib. This patch corrects the problem. ACK A nitpick: $ git diff HEAD~1 | pep8 --diff ./ipapython/nsslib.py:145:14: E111 indentation is not a