[Freeipa-devel] [PATCH] 065 Replace only if old and new have nothing in common

2011-02-23 Thread Jakub Hrozek
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 https://fedorahosted.org/freeipa/ticket/1000 I hope this doesn't break anything..my testing went OK. I've seen some unit test failures (group tests, for instance), but they don't seem to be related. -BEGIN PGP SIGNATURE- Version: GnuPG v1.4.11

Re: [Freeipa-devel] [PATCH] 065 Replace only if old and new have nothing in common

2011-02-23 Thread Rob Crittenden
Jakub Hrozek wrote: Replace only if old and new have nothing in common This has problems when removing the last member. There is no adds, rems has a single value (the member being removed). The intersection is 0 so force_replace gets set to True and nothing ends up getting done. I added a

Re: [Freeipa-devel] [PATCH] 065 Replace only if old and new have nothing in common

2011-02-23 Thread Jakub Hrozek
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 02/23/2011 04:47 PM, Rob Crittenden wrote: > Jakub Hrozek wrote: >> Replace only if old and new have nothing in common >> > > This has problems when removing the last member. There is no adds, rems > has a single value (the member being removed). T

Re: [Freeipa-devel] [PATCH] 065 Replace only if old and new have nothing in common

2011-02-23 Thread Rob Crittenden
Jakub Hrozek wrote: -BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 02/23/2011 04:47 PM, Rob Crittenden wrote: Jakub Hrozek wrote: Replace only if old and new have nothing in common This has problems when removing the last member. There is no adds, rems has a single value (the member being

Re: [Freeipa-devel] [PATCH] 065 Replace only if old and new have nothing in common

2011-03-02 Thread Jakub Hrozek
On Wed, Feb 23, 2011 at 12:36:06PM -0500, Rob Crittenden wrote: > Jakub Hrozek wrote: > >-BEGIN PGP SIGNED MESSAGE- > >Hash: SHA1 > > > >On 02/23/2011 04:47 PM, Rob Crittenden wrote: > >>Jakub Hrozek wrote: > >>>Replace only if old and new have nothing in common > >>> > >> > >>This has prob

Re: [Freeipa-devel] [PATCH] 065 Replace only if old and new have nothing in common

2011-03-03 Thread Pavel Zuna
On 03/02/2011 08:50 PM, Jakub Hrozek wrote: On Wed, Feb 23, 2011 at 12:36:06PM -0500, Rob Crittenden wrote: Jakub Hrozek wrote: -BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 02/23/2011 04:47 PM, Rob Crittenden wrote: Jakub Hrozek wrote: Replace only if old and new have nothing in common

Re: [Freeipa-devel] [PATCH] 065 Replace only if old and new have nothing in common

2011-03-03 Thread Rob Crittenden
Pavel Zuna wrote: On 03/02/2011 08:50 PM, Jakub Hrozek wrote: On Wed, Feb 23, 2011 at 12:36:06PM -0500, Rob Crittenden wrote: Jakub Hrozek wrote: -BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 02/23/2011 04:47 PM, Rob Crittenden wrote: Jakub Hrozek wrote: Replace only if old and new have