Re: [Freeipa-devel] [PATCH] 1005 fix password history

2012-04-10 Thread Martin Kosek
On Mon, 2012-04-09 at 23:54 -0400, Rob Crittenden wrote: Password history wasn't working because the qsort comparison function was comparing pointers, not data. This resulted in a random element being removed from the history on overflow rather than the oldest. We sort in reverse so we

[Freeipa-devel] [PATCH] 1005 fix password history

2012-04-09 Thread Rob Crittenden
Password history wasn't working because the qsort comparison function was comparing pointers, not data. This resulted in a random element being removed from the history on overflow rather than the oldest. We sort in reverse so we don't have to move elements inside the list when removing to

Re: [Freeipa-devel] [PATCH] 1005 fix password history

2012-04-09 Thread yi zhang
On 04/09/2012 08:54 PM, Rob Crittenden wrote: Password history wasn't working because the qsort comparison function was comparing pointers, not data. This resulted in a random element being removed from the history on overflow rather than the oldest. We sort in reverse so we don't have to