Re: [Freeipa-devel] [PATCH] manage replication topology in the shared tree

2015-05-26 Thread Petr Vobornik
On 05/22/2015 04:20 PM, Petr Vobornik wrote: On 05/21/2015 12:55 PM, thierry bordaz wrote: On 05/20/2015 05:40 PM, Ludwig Krispenz wrote: please find new versions of patches 0003 and 0005 for the topology plugin. the ds plugin patch includes - changes to match domain level patch - remove

Re: [Freeipa-devel] [PATCH] manage replication topology in the shared tree

2015-05-22 Thread Petr Vobornik
On 05/21/2015 12:55 PM, thierry bordaz wrote: On 05/20/2015 05:40 PM, Ludwig Krispenz wrote: please find new versions of patches 0003 and 0005 for the topology plugin. the ds plugin patch includes - changes to match domain level patch - remove trailing white spaces - use proper oids for

Re: [Freeipa-devel] [PATCH] manage replication topology in the shared tree

2015-05-21 Thread thierry bordaz
On 05/20/2015 05:40 PM, Ludwig Krispenz wrote: please find new versions of patches 0003 and 0005 for the topology plugin. the ds plugin patch includes - changes to match domain level patch - remove trailing white spaces - use proper oids for topology schema the install patch - has the

Re: [Freeipa-devel] [PATCH] manage replication topology in the shared tree

2015-05-20 Thread Ludwig Krispenz
On 05/20/2015 02:52 PM, Oleg Fayans wrote: Is this patch to be applied on top of the vanilla upstream tree, or does it require your previous patches applied before? it requires the install (0005) and ipa-command (0006) patch as well, submitted on 05/12 On 05/19/2015 02:16 PM, Ludwig

Re: [Freeipa-devel] [PATCH] manage replication topology in the shared tree

2015-05-20 Thread Oleg Fayans
Is this patch to be applied on top of the vanilla upstream tree, or does it require your previous patches applied before? On 05/19/2015 02:16 PM, Ludwig Krispenz wrote: Hi, here is the latest patch for the plugin part, trying to address all problems found in the review Regards, Ludwig PS

Re: [Freeipa-devel] [PATCH] manage replication topology in the shared tree

2015-05-20 Thread Petr Vobornik
On 05/20/2015 02:58 PM, Ludwig Krispenz wrote: On 05/20/2015 02:52 PM, Oleg Fayans wrote: Is this patch to be applied on top of the vanilla upstream tree, or does it require your previous patches applied before? it requires the install (0005) and ipa-command (0006) patch as well, submitted on

Re: [Freeipa-devel] [PATCH] manage replication topology in the shared tree

2015-05-20 Thread Ludwig Krispenz
On 05/20/2015 03:07 PM, Petr Vobornik wrote: On 05/20/2015 02:58 PM, Ludwig Krispenz wrote: On 05/20/2015 02:52 PM, Oleg Fayans wrote: Is this patch to be applied on top of the vanilla upstream tree, or does it require your previous patches applied before? it requires the install (0005) and

Re: [Freeipa-devel] [PATCH] manage replication topology in the shared tree

2015-05-07 Thread thierry bordaz
On 04/29/2015 11:18 AM, Ludwig Krispenz wrote: Hi, thanks again, so there is some work to do, but see some answers inline On 04/27/2015 10:18 AM, thierry bordaz wrote: On 04/21/2015 10:49 AM, Ludwig Krispenz wrote: On 04/20/2015 06:00 PM, thierry bordaz wrote: On 04/13/2015 10:56 AM, Ludwig

Re: [Freeipa-devel] [PATCH] manage replication topology in the shared tree

2015-05-07 Thread Ludwig Krispenz
Thanks, I will look into it and try to add what's missing and also try to make the design a bit more clear. Ludwig On 05/07/2015 04:32 PM, thierry bordaz wrote: On 04/29/2015 11:18 AM, Ludwig Krispenz wrote: Hi, thanks again, so there is some work to do, but see some answers inline On

Re: [Freeipa-devel] [PATCH] manage replication topology in the shared tree

2015-04-29 Thread Ludwig Krispenz
Hi, thanks again, so there is some work to do, but see some answers inline On 04/27/2015 10:18 AM, thierry bordaz wrote: On 04/21/2015 10:49 AM, Ludwig Krispenz wrote: On 04/20/2015 06:00 PM, thierry bordaz wrote: On 04/13/2015 10:56 AM, Ludwig Krispenz wrote: Hi, in the attachment you find

Re: [Freeipa-devel] [PATCH] manage replication topology in the shared tree

2015-04-27 Thread thierry bordaz
On 04/21/2015 10:49 AM, Ludwig Krispenz wrote: On 04/20/2015 06:00 PM, thierry bordaz wrote: On 04/13/2015 10:56 AM, Ludwig Krispenz wrote: Hi, in the attachment you find the latest state of the topology plugin, it implements what is defined in the design page:

Re: [Freeipa-devel] [PATCH] manage replication topology in the shared tree

2015-04-21 Thread Ludwig Krispenz
On 04/20/2015 06:00 PM, thierry bordaz wrote: On 04/13/2015 10:56 AM, Ludwig Krispenz wrote: Hi, in the attachment you find the latest state of the topology plugin, it implements what is defined in the design page: http://www.freeipa.org/page/V4/Manage_replication_topology (which is also

Re: [Freeipa-devel] [PATCH] manage replication topology in the shared tree

2015-04-21 Thread Petr Vobornik
On 04/13/2015 10:56 AM, Ludwig Krispenz wrote: Hi, in the attachment you find the latest state of the topology plugin, it implements what is defined in the design page: http://www.freeipa.org/page/V4/Manage_replication_topology (which is also waiting for a reviewer) It contains the plugin

Re: [Freeipa-devel] [PATCH] manage replication topology in the shared tree

2015-04-21 Thread Petr Vobornik
On 04/21/2015 12:53 PM, Petr Vobornik wrote: On 04/13/2015 10:56 AM, Ludwig Krispenz wrote: Hi, in the attachment you find the latest state of the topology plugin, it implements what is defined in the design page: http://www.freeipa.org/page/V4/Manage_replication_topology (which is also

Re: [Freeipa-devel] [PATCH] manage replication topology in the shared tree

2015-04-20 Thread thierry bordaz
On 04/13/2015 10:56 AM, Ludwig Krispenz wrote: Hi, in the attachment you find the latest state of the topology plugin, it implements what is defined in the design page: http://www.freeipa.org/page/V4/Manage_replication_topology (which is also waiting for a reviewer) It contains the plugin

Re: [Freeipa-devel] [PATCH] manage replication topology in the shared tree

2015-04-14 Thread Martin Kosek
On 04/13/2015 10:56 AM, Ludwig Krispenz wrote: Hi, in the attachment you find the latest state of the topology plugin, it implements what is defined in the design page: http://www.freeipa.org/page/V4/Manage_replication_topology (which is also waiting for a reviewer) It contains the

Re: [Freeipa-devel] [PATCH] manage replication topology in the shared tree

2015-04-14 Thread thierry bordaz
On 04/14/2015 01:39 PM, Martin Kosek wrote: On 04/13/2015 10:56 AM, Ludwig Krispenz wrote: Hi, in the attachment you find the latest state of the topology plugin, it implements what is defined in the design page: http://www.freeipa.org/page/V4/Manage_replication_topology (which is also waiting

Re: [Freeipa-devel] [PATCH] manage replication topology in the shared tree

2015-04-14 Thread Ludwig Krispenz
Hi Martin, thanks for your time and comments. The design page should match the current implemtation, but as you said there were some iterations and I will check again and address the points you raised. Ludwig On 04/14/2015 01:39 PM, Martin Kosek wrote: On 04/13/2015 10:56 AM, Ludwig