Re: [Freeipa-devel] [PATCH 0070] Normalization check only for IDNA domains

2014-07-01 Thread Martin Kosek
On 06/30/2014 03:16 PM, Alexander Bokovoy wrote: On Mon, 30 Jun 2014, Martin Basti wrote: We can use 'label = label.encode(ascii)' to detect if IDNA is needed, without idna.ToASCII() conversion, and then use: is_nonnorm = any(encodings.idna.nameprep(x) != x for x in labels) Sounds good but

Re: [Freeipa-devel] [PATCH 0070] Normalization check only for IDNA domains

2014-06-30 Thread Martin Basti
On Fri, 2014-06-27 at 12:21 +0200, Petr Spacek wrote: On 27.6.2014 12:20, Alexander Bokovoy wrote: On Fri, 27 Jun 2014, Petr Spacek wrote: On 27.6.2014 12:04, Alexander Bokovoy wrote: diff --git a/ipalib/parameters.py b/ipalib/parameters.py index 1dff13c..09fed28 100644 ---

Re: [Freeipa-devel] [PATCH 0070] Normalization check only for IDNA domains

2014-06-30 Thread Martin Basti
On Fri, 2014-06-27 at 14:03 +0300, Alexander Bokovoy wrote: On Fri, 27 Jun 2014, Martin Kosek wrote: On 06/27/2014 12:10 PM, Alexander Bokovoy wrote: On Fri, 27 Jun 2014, Petr Spacek wrote: On 27.6.2014 11:21, Jan Cholasta wrote: On 27.6.2014 10:58, Alexander Bokovoy wrote: On Fri, 27

Re: [Freeipa-devel] [PATCH 0070] Normalization check only for IDNA domains

2014-06-30 Thread Alexander Bokovoy
On Mon, 30 Jun 2014, Martin Basti wrote: On Fri, 2014-06-27 at 14:03 +0300, Alexander Bokovoy wrote: On Fri, 27 Jun 2014, Martin Kosek wrote: On 06/27/2014 12:10 PM, Alexander Bokovoy wrote: On Fri, 27 Jun 2014, Petr Spacek wrote: On 27.6.2014 11:21, Jan Cholasta wrote: On 27.6.2014 10:58,

Re: [Freeipa-devel] [PATCH 0070] Normalization check only for IDNA domains

2014-06-30 Thread Martin Basti
On Mon, 2014-06-30 at 11:43 +0300, Alexander Bokovoy wrote: On Mon, 30 Jun 2014, Martin Basti wrote: On Fri, 2014-06-27 at 14:03 +0300, Alexander Bokovoy wrote: On Fri, 27 Jun 2014, Martin Kosek wrote: On 06/27/2014 12:10 PM, Alexander Bokovoy wrote: On Fri, 27 Jun 2014, Petr Spacek

Re: [Freeipa-devel] [PATCH 0070] Normalization check only for IDNA domains

2014-06-30 Thread Alexander Bokovoy
On Mon, 30 Jun 2014, Martin Basti wrote: We can use 'label = label.encode(ascii)' to detect if IDNA is needed, without idna.ToASCII() conversion, and then use: is_nonnorm = any(encodings.idna.nameprep(x) != x for x in labels) Sounds good but don't forget exceptions' handling. :) Updated

Re: [Freeipa-devel] [PATCH 0070] Normalization check only for IDNA domains

2014-06-27 Thread Alexander Bokovoy
On Fri, 20 Jun 2014, Martin Basti wrote: On Fri, 2014-06-20 at 10:32 +0200, Jan Cholasta wrote: On 18.6.2014 16:49, Martin Basti wrote: Due to compability with older versions, only IDNA domains should be checked Patch attached. I'm not particularly happy about the u'\xdf' special case.

Re: [Freeipa-devel] [PATCH 0070] Normalization check only for IDNA domains

2014-06-27 Thread Jan Cholasta
On 27.6.2014 10:15, Alexander Bokovoy wrote: On Fri, 20 Jun 2014, Martin Basti wrote: On Fri, 2014-06-20 at 10:32 +0200, Jan Cholasta wrote: On 18.6.2014 16:49, Martin Basti wrote: Due to compability with older versions, only IDNA domains should be checked Patch attached. I'm not

Re: [Freeipa-devel] [PATCH 0070] Normalization check only for IDNA domains

2014-06-27 Thread Alexander Bokovoy
On Fri, 27 Jun 2014, Jan Cholasta wrote: On 27.6.2014 10:15, Alexander Bokovoy wrote: On Fri, 20 Jun 2014, Martin Basti wrote: On Fri, 2014-06-20 at 10:32 +0200, Jan Cholasta wrote: On 18.6.2014 16:49, Martin Basti wrote: Due to compability with older versions, only IDNA domains should be

Re: [Freeipa-devel] [PATCH 0070] Normalization check only for IDNA domains

2014-06-27 Thread Jan Cholasta
On 27.6.2014 10:29, Alexander Bokovoy wrote: On Fri, 27 Jun 2014, Jan Cholasta wrote: On 27.6.2014 10:15, Alexander Bokovoy wrote: On Fri, 20 Jun 2014, Martin Basti wrote: On Fri, 2014-06-20 at 10:32 +0200, Jan Cholasta wrote: On 18.6.2014 16:49, Martin Basti wrote: Due to compability with

Re: [Freeipa-devel] [PATCH 0070] Normalization check only for IDNA domains

2014-06-27 Thread Alexander Bokovoy
On Fri, 27 Jun 2014, Jan Cholasta wrote: On 27.6.2014 10:29, Alexander Bokovoy wrote: On Fri, 27 Jun 2014, Jan Cholasta wrote: On 27.6.2014 10:15, Alexander Bokovoy wrote: On Fri, 20 Jun 2014, Martin Basti wrote: On Fri, 2014-06-20 at 10:32 +0200, Jan Cholasta wrote: On 18.6.2014 16:49,

Re: [Freeipa-devel] [PATCH 0070] Normalization check only for IDNA domains

2014-06-27 Thread Jan Cholasta
On 27.6.2014 10:58, Alexander Bokovoy wrote: On Fri, 27 Jun 2014, Jan Cholasta wrote: On 27.6.2014 10:29, Alexander Bokovoy wrote: On Fri, 27 Jun 2014, Jan Cholasta wrote: On 27.6.2014 10:15, Alexander Bokovoy wrote: On Fri, 20 Jun 2014, Martin Basti wrote: On Fri, 2014-06-20 at 10:32

Re: [Freeipa-devel] [PATCH 0070] Normalization check only for IDNA domains

2014-06-27 Thread Alexander Bokovoy
On Fri, 27 Jun 2014, Jan Cholasta wrote: On 27.6.2014 10:58, Alexander Bokovoy wrote: On Fri, 27 Jun 2014, Jan Cholasta wrote: On 27.6.2014 10:29, Alexander Bokovoy wrote: On Fri, 27 Jun 2014, Jan Cholasta wrote: On 27.6.2014 10:15, Alexander Bokovoy wrote: On Fri, 20 Jun 2014, Martin Basti

Re: [Freeipa-devel] [PATCH 0070] Normalization check only for IDNA domains

2014-06-27 Thread Petr Spacek
On 27.6.2014 11:21, Jan Cholasta wrote: On 27.6.2014 10:58, Alexander Bokovoy wrote: On Fri, 27 Jun 2014, Jan Cholasta wrote: On 27.6.2014 10:29, Alexander Bokovoy wrote: On Fri, 27 Jun 2014, Jan Cholasta wrote: On 27.6.2014 10:15, Alexander Bokovoy wrote: On Fri, 20 Jun 2014, Martin Basti

Re: [Freeipa-devel] [PATCH 0070] Normalization check only for IDNA domains

2014-06-27 Thread Jan Cholasta
On 27.6.2014 12:04, Alexander Bokovoy wrote: On Fri, 27 Jun 2014, Jan Cholasta wrote: On 27.6.2014 10:58, Alexander Bokovoy wrote: On Fri, 27 Jun 2014, Jan Cholasta wrote: On 27.6.2014 10:29, Alexander Bokovoy wrote: On Fri, 27 Jun 2014, Jan Cholasta wrote: On 27.6.2014 10:15, Alexander

Re: [Freeipa-devel] [PATCH 0070] Normalization check only for IDNA domains

2014-06-27 Thread Petr Spacek
On 27.6.2014 12:04, Alexander Bokovoy wrote: diff --git a/ipalib/parameters.py b/ipalib/parameters.py index 1dff13c..09fed28 100644 --- a/ipalib/parameters.py +++ b/ipalib/parameters.py @@ -1965,12 +1965,15 @@ class DNSNameParam(Param): #compare if IDN normalized and original

Re: [Freeipa-devel] [PATCH 0070] Normalization check only for IDNA domains

2014-06-27 Thread Alexander Bokovoy
On Fri, 27 Jun 2014, Petr Spacek wrote: On 27.6.2014 11:21, Jan Cholasta wrote: On 27.6.2014 10:58, Alexander Bokovoy wrote: On Fri, 27 Jun 2014, Jan Cholasta wrote: On 27.6.2014 10:29, Alexander Bokovoy wrote: On Fri, 27 Jun 2014, Jan Cholasta wrote: On 27.6.2014 10:15, Alexander Bokovoy

Re: [Freeipa-devel] [PATCH 0070] Normalization check only for IDNA domains

2014-06-27 Thread Alexander Bokovoy
On Fri, 27 Jun 2014, Petr Spacek wrote: On 27.6.2014 12:04, Alexander Bokovoy wrote: diff --git a/ipalib/parameters.py b/ipalib/parameters.py index 1dff13c..09fed28 100644 --- a/ipalib/parameters.py +++ b/ipalib/parameters.py @@ -1965,12 +1965,15 @@ class DNSNameParam(Param):

Re: [Freeipa-devel] [PATCH 0070] Normalization check only for IDNA domains

2014-06-27 Thread Petr Spacek
On 27.6.2014 12:20, Alexander Bokovoy wrote: On Fri, 27 Jun 2014, Petr Spacek wrote: On 27.6.2014 12:04, Alexander Bokovoy wrote: diff --git a/ipalib/parameters.py b/ipalib/parameters.py index 1dff13c..09fed28 100644 --- a/ipalib/parameters.py +++ b/ipalib/parameters.py @@ -1965,12 +1965,15 @@

Re: [Freeipa-devel] [PATCH 0070] Normalization check only for IDNA domains

2014-06-27 Thread Martin Kosek
On 06/27/2014 12:10 PM, Alexander Bokovoy wrote: On Fri, 27 Jun 2014, Petr Spacek wrote: On 27.6.2014 11:21, Jan Cholasta wrote: On 27.6.2014 10:58, Alexander Bokovoy wrote: On Fri, 27 Jun 2014, Jan Cholasta wrote: On 27.6.2014 10:29, Alexander Bokovoy wrote: On Fri, 27 Jun 2014, Jan

Re: [Freeipa-devel] [PATCH 0070] Normalization check only for IDNA domains

2014-06-27 Thread Martin Basti
On Fri, 2014-06-27 at 13:04 +0300, Alexander Bokovoy wrote: On Fri, 27 Jun 2014, Jan Cholasta wrote: On 27.6.2014 10:58, Alexander Bokovoy wrote: On Fri, 27 Jun 2014, Jan Cholasta wrote: On 27.6.2014 10:29, Alexander Bokovoy wrote: On Fri, 27 Jun 2014, Jan Cholasta wrote: On 27.6.2014 10:15,

Re: [Freeipa-devel] [PATCH 0070] Normalization check only for IDNA domains

2014-06-27 Thread Alexander Bokovoy
On Fri, 27 Jun 2014, Martin Basti wrote: On Fri, 2014-06-27 at 13:04 +0300, Alexander Bokovoy wrote: On Fri, 27 Jun 2014, Jan Cholasta wrote: On 27.6.2014 10:58, Alexander Bokovoy wrote: On Fri, 27 Jun 2014, Jan Cholasta wrote: On 27.6.2014 10:29, Alexander Bokovoy wrote: On Fri, 27 Jun 2014,

Re: [Freeipa-devel] [PATCH 0070] Normalization check only for IDNA domains

2014-06-20 Thread Jan Cholasta
On 18.6.2014 16:49, Martin Basti wrote: Due to compability with older versions, only IDNA domains should be checked Patch attached. I'm not particularly happy about the u'\xdf' special case. Isn't there a better way to do this check? (BTW I really think this should be a warning, not an

Re: [Freeipa-devel] [PATCH 0070] Normalization check only for IDNA domains

2014-06-20 Thread Martin Basti
On Fri, 2014-06-20 at 10:32 +0200, Jan Cholasta wrote: On 18.6.2014 16:49, Martin Basti wrote: Due to compability with older versions, only IDNA domains should be checked Patch attached. I'm not particularly happy about the u'\xdf' special case. Isn't there a better way to do this

[Freeipa-devel] [PATCH 0070] Normalization check only for IDNA domains

2014-06-18 Thread Martin Basti
Due to compability with older versions, only IDNA domains should be checked Patch attached. -- Martin^2 Basti From fd329148639ce5b5707f37d1b450597f3ca4bcb7 Mon Sep 17 00:00:00 2001 From: Martin Basti mba...@redhat.com Date: Wed, 18 Jun 2014 15:58:17 +0200 Subject: [PATCH] Check normalization only