Re: [FreeRDP-devel] Review of WIP pull request

Hi Armin, 2016-05-23 14:38 GMT+02:00 Armin Novak : > Hey Ondrej, > > On 05/23/2016 02:00 PM, Ondrej Holy wrote: > > > > The problem is that freerdp_image_copy can't return bitmap in such > > format, which is needed by X11 under big endian. Bitmaps are received > > in little endian order, but need

Re: [FreeRDP-devel] Review of WIP pull request

Hey Ondrej, On 05/23/2016 02:00 PM, Ondrej Holy wrote: > > The problem is that freerdp_image_copy can't return bitmap in such > format, which is needed by X11 under big endian. Bitmaps are received > in little endian order, but needs to be written in the big endian > order in certain cases. It see

Re: [FreeRDP-devel] Review of WIP pull request

Hi Armin, thanks for the quick response... 2016-05-23 12:05 GMT+02:00 Armin Novak : > Hey Ondrej, > > On 05/23/2016 11:51 AM, Ondrej Holy wrote: > > Hi Armin, > > 2016-05-19 9:18 GMT+02:00 Armin Novak : > >> Hey Ondrej, >> >> sorry for the late reply, did indeed missed to reply. >> > > nevermind

Re: [FreeRDP-devel] Review of WIP pull request

Hey Ondrej, On 05/23/2016 11:51 AM, Ondrej Holy wrote: > Hi Armin, > > 2016-05-19 9:18 GMT+02:00 Armin Novak >: > > Hey Ondrej, > > sorry for the late reply, did indeed missed to reply. > > > neverminds, thanks for the replay. > > > Most of the code wo

Re: [FreeRDP-devel] Review of WIP pull request

Hi Armin, 2016-05-19 9:18 GMT+02:00 Armin Novak : > Hey Ondrej, > > sorry for the late reply, did indeed missed to reply. > neverminds, thanks for the replay. > Most of the code works on a big endian, because > > Stream_Read_/Stream_Write_ macros are used to read/write data from/to > > server.

Re: [FreeRDP-devel] Review of WIP pull request

No, I didn't disable SSE, but I've rebuilt it for sure and xfreerdp fails in the same way regardless value of -DWITH_SSE2= :-( 2016-05-21 11:46 GMT+02:00 Armin Novak : > did you disable sse/neon? > did not habe time to check the optimised functions. > > > On 20 May 2016 17:00:48 CEST, Ondrej Holy

Re: [FreeRDP-devel] Review of WIP pull request

did you disable sse/neon? did not habe time to check the optimised functions. On 20 May 2016 17:00:48 CEST, Ondrej Holy wrote: >Hi Armin, > >I've tried your color_conversion_fix_v3 branch on Fedora 24 and it >fails to >me with the following ouput: >[16:46:20:397] [6168:6169] [INFO][com.freerdp.gd

Re: [FreeRDP-devel] Review of WIP pull request

Hi Armin, I've tried your color_conversion_fix_v3 branch on Fedora 24 and it fails to me with the following ouput: [16:46:20:397] [6168:6169] [INFO][com.freerdp.gdi] - Local framebuffer format PIXEL_FORMAT_BGRX32 [16:46:20:397] [6168:6169] [INFO][com.freerdp.gdi] - Remote framebuffer format PIXEL

Re: [FreeRDP-devel] Review of WIP pull request

Hey Ondrej, sorry for the late reply, did indeed missed to reply. > > > Most of the code works on a big endian, because > Stream_Read_/Stream_Write_ macros are used to read/write data from/to > server. There is a problem if Stream_Pointer is used to read raw data, > because the data are always st

Re: [FreeRDP-devel] Review of WIP pull request

Hi Armin, I am not FreeRDP upstream maintainer, but I glad to see you are working on color conversions overhaul. Current state with color conversions seems pretty nonuniform and complicated. I am preparing fixes for big endian architectures, because there are corrupted colors and several other pro

[FreeRDP-devel] Review of WIP pull request

Hi there, I'm working on a overhaul of the software GDI color conversion. My current work is here: https://github.com/akallabeth/freerdp/tree/color_conversion_fix_v3 This pull requires refactoring of most of libfreerdp and there are still a few issues left (listing later on) but it is aimed at fi