Re: [Freerdp-devel] RemoteFX software decoding

2011-06-07 Thread Marc-André Moreau
Hi Vic, My stuff is merged, since apparently people started using it instead of the real master branch :P On Tue, Jun 7, 2011 at 8:18 PM, Vic Lee wrote: > Hi Steve, > > I think it looks like it might be not just affecting fullscreen toggling > only (depending on the window manager I guess it mi

Re: [Freerdp-devel] RemoteFX software decoding

2011-06-07 Thread S. Erisman
Vic, On 6/7/2011 7:18 PM, Vic Lee wrote: > Hi Steve, > > I think it looks like it might be not just affecting fullscreen > toggling only (depending on the window manager I guess it might happen > other cases). This patch should fix it more properly. > > diff --git a/X11/xf_decode.c b/X11/xf_deco

Re: [Freerdp-devel] RemoteFX software decoding

2011-06-07 Thread Vic Lee
Hi Steve, I think it looks like it might be not just affecting fullscreen toggling only (depending on the window manager I guess it might happen other cases). This patch should fix it more properly. diff --git a/X11/xf_decode.c b/X11/xf_decode.c index 092aced..acd40c8 100644 --- a/X11/xf_decode

Re: [Freerdp-devel] RemoteFX software decoding

2011-06-07 Thread S. Erisman
Marc, I vote to merge your github fork. I tried it out last night, and it seems pretty stable. Could you also include a fix for the fullscreen toggle (while using RemoteFX) issue that I sent to the list the other day? It should be as simple as clearing or resetting the clip region at the b

Re: [Freerdp-devel] RemoteFX software decoding

2011-06-07 Thread Marc-André Moreau
Hi Vic, On Tue, Jun 7, 2011 at 8:50 AM, Vic Lee wrote: > Hi Marc, > > I just saw another memory allocation can be completely eliminated and > should have big improvement. Please try attach patch. > Great! I integrated your patch, it is now on my github fork. Maybe we should merge my pull reques

Re: [Freerdp-devel] RemoteFX software decoding

2011-06-07 Thread Vic Lee
Hi Marc, I just saw another memory allocation can be completely eliminated and should have big improvement. Please try attach patch. Vic On 06/07/2011 07:57 AM, Marc-André Moreau wrote: And boom, here's a memory pool for RemoteFX tiles :P (my last commit) It can play youtube videos when not

Re: [Freerdp-devel] RemoteFX software decoding

2011-06-06 Thread Roman Barabanov
Good day, Marc-Andre. Did you try tcmalloc from Google? As I know - it is specially optimized for small object allocation and to be efficient in multi-threaded programs. http://goog-perftools.sourceforge.net/doc/tcmalloc.html Maybe it will be more simple and general method to boost memory alloca

Re: [Freerdp-devel] RemoteFX software decoding

2011-06-06 Thread Marc-André Moreau
Hi Vic, On Mon, Jun 6, 2011 at 8:34 PM, Vic Lee wrote: > Hi Marc, > > Thanks for a nice improvement! Yes I believe there will be various way to > improve it. Things like SSE could be interesting and worth investigating, as > I saw a lot of similar stuff in FFmpeg decoder. > Yes, SSE does look v

Re: [Freerdp-devel] RemoteFX software decoding

2011-06-06 Thread Vic Lee
Hi Marc, Thanks for a nice improvement! Yes I believe there will be various way to improve it. Things like SSE could be interesting and worth investigating, as I saw a lot of similar stuff in FFmpeg decoder. Vic On 06/07/2011 07:57 AM, Marc-André Moreau wrote: > And boom, here's a memory pool

Re: [Freerdp-devel] RemoteFX software decoding

2011-06-06 Thread Marc-André Moreau
And boom, here's a memory pool for RemoteFX tiles :P (my last commit) It can play youtube videos when not in fullscreen mode very smoothly, I don't recall if that was the case prior to optimizations though. In all cases, it does feel much better. There are still others places that need optimizatio

Re: [Freerdp-devel] RemoteFX software decoding

2011-06-06 Thread Marc-André Moreau
Hi all, I started refactoring and optimizing the RemoteFX decoder. https://github.com/awakecoding/FreeRDP I changed various data types so that they match the ones defined in MS-RDPRFX. I have spotted different areas of the code which can definitely be impro

Re: [Freerdp-devel] RemoteFX software decoding

2011-06-06 Thread Marc-André Moreau
Does anybody know if there is a way to force the server into sending RemoteFX messages only, without any GDI messages? I'd be interested in experimenting with ways of saving the RemoteFX stream to a file for later use, which would be much easier to do than recording GDI messages. One could likely i

Re: [Freerdp-devel] RemoteFX software decoding

2011-06-05 Thread S. Erisman
On 6/5/2011 9:50 PM, Otavio Salvador wrote: > On Mon, Jun 6, 2011 at 02:25, S. Erisman wrote: >> I tried out your RemoteFX code over the weekend, and it works very nicely. > It didn't work for me. How did you configure the Windows Server to use > it? What worries me is that the Microsoft Windows c

Re: [Freerdp-devel] RemoteFX software decoding

2011-06-05 Thread Otavio Salvador
On Mon, Jun 6, 2011 at 02:25, S. Erisman wrote: > I tried out your RemoteFX code over the weekend, and it works very nicely. It didn't work for me. How did you configure the Windows Server to use it? What worries me is that the Microsoft Windows client works on the same server and FreeRDP does no

Re: [Freerdp-devel] RemoteFX software decoding

2011-06-05 Thread S. Erisman
On 5/25/2011 8:42 PM, Vic Lee wrote: > Hi, > > I have finally completed RemoteFX software decoding feature. It's writen > as a separate and relatively independent library librfx. I only added it > to xfreerdp, but the library is portable, so there shouldn't be problem > to use it in other UI. > > I

Re: [Freerdp-devel] RemoteFX software decoding

2011-06-05 Thread Vic Lee
Hi Marc, Thanks for your correction, I should say most, not all. :) Vic On 06/06/2011 01:47 AM, Marc-André Moreau wrote: > Hi Vic, > > I would have to confirm, but apparently *some* (very few) GDI messages > still get sent when RemoteFX is in use. libfreerdp-gdi supports both, > but from my test

Re: [Freerdp-devel] RemoteFX software decoding

2011-06-05 Thread Marc-André Moreau
Hi Vic, I would have to confirm, but apparently *some* (very few) GDI messages still get sent when RemoteFX is in use. libfreerdp-gdi supports both, but from my testing the server kept sending some GDI messages even with RemoteFX. On Sun, Jun 5, 2011 at 1:17 PM, Petr Novodvorskiy wrote: > Hi! >

Re: [Freerdp-devel] RemoteFX software decoding

2011-06-05 Thread Petr Novodvorskiy
Hi! On Sun, Jun 5, 2011 at 01:20, Vic Lee wrote: > 1. RemoteFX is a codec to turn all GDI drawing intructions into video > frames. In a normal RDP session, it's known that the server will send > GDI drawing commands to the client (like lines, rectangles, etc). In a > RemoteFX session, all the dr

Re: [Freerdp-devel] RemoteFX software decoding

2011-06-05 Thread Vic Lee
Just in case someone still not clear about the difference between RemoteFX and Multimedia Redirection, here is my comments. 1. RemoteFX is a codec to turn all GDI drawing intructions into video frames. In a normal RDP session, it's known that the server will send GDI drawing commands to the cli

Re: [Freerdp-devel] RemoteFX software decoding

2011-05-31 Thread Marc-André Moreau
Hi Gerry, On Tue, May 31, 2011 at 9:55 AM, Gerry Reno wrote: > Does RemoteFX require multimedia redirection? Or does it make use of it > if available? > > RemoteFX does not require multimedia redirection. It should make use of it if available though. > I didn't see any multimedia redirection

Re: [Freerdp-devel] RemoteFX software decoding

2011-05-31 Thread Gerry Reno
Does RemoteFX require multimedia redirection? Or does it make use of it if available? I didn't see any multimedia redirection available for DirectFB. Looks like only thing available is XVideo for X11 UI only. Is there any other solution available? Gerry On 05/30/2011 04:59 PM, Marc-André

Re: [Freerdp-devel] RemoteFX software decoding

2011-05-30 Thread Marc-André Moreau
Hi Vic, I have merged your pull request, and I have also updated the DirectFB UI + libgdi to make use of librfx :) On Thu, May 26, 2011 at 10:00 PM, Vic Lee wrote: > Hi Marc, > > On 05/27/2011 06:23 AM, Marc-André Moreau wrote: > > Hi Vic, > > > > I added a couple of comments on github > > > >

Re: [Freerdp-devel] RemoteFX software decoding

2011-05-26 Thread Vic Lee
Hi Marc, On 05/27/2011 06:23 AM, Marc-André Moreau wrote: > Hi Vic, > > I added a couple of comments on github > > two main questions: > > 1) "decode" is used to "decode" either no codec or RemoteFX. Are there > any other known codecs to be supported in the future, or this could > named "remotefx"

Re: [Freerdp-devel] RemoteFX software decoding

2011-05-26 Thread Marc-André Moreau
Hi Vic, I added a couple of comments on github two main questions: 1) "decode" is used to "decode" either no codec or RemoteFX. Are there any other known codecs to be supported in the future, or this could named "remotefx" and work out pretty much the same? 2) I'd like to extend libgdi such tha

Re: [Freerdp-devel] RemoteFX software decoding

2011-05-25 Thread Marc-André Moreau
Hi Vic! On Thu, May 26, 2011 at 3:42 AM, Vic Lee wrote: > Hi, > > I have finally completed RemoteFX software decoding feature. It's writen > as a separate and relatively independent library librfx. I only added it > to xfreerdp, but the library is portable, so there shouldn't be problem > to use

[Freerdp-devel] RemoteFX software decoding

2011-05-25 Thread Vic Lee
Hi, I have finally completed RemoteFX software decoding feature. It's writen as a separate and relatively independent library librfx. I only added it to xfreerdp, but the library is portable, so there shouldn't be problem to use it in other UI. I have started the pull request, please review an