Re: [ft-devel] [patch] clean up MulDiv in bytecode interpreter

2012-12-04 Thread Werner LEMBERG
Hello Alexei! > 1) TT_MULDIV macros are replaced with to direct calls to FT_MulDiv > because they do not do anything useful Good idea. Please commit this (as a separate patch). > 2) TT_MulFix14 is now a macro that uses FT_MulFix, no need to > duplicate the code Please be very careful here.

[ft-devel] [patch] clean up MulDiv in bytecode interpreter

2012-12-04 Thread Alexei Podtelezhnikov
Werner, As it stands right now, ttinterp.c uses multiple forms of multiplication-division calls: macro TT_MULDIV, direct FT_MulDiv, and custom TT_MulFix14. This is confusing and unjustified IMHO, so I wanted to consolidate and harmonize those calls. The attached patch mostly does the following 1)