Re: [ft-devel] GF's cmap fails

2018-08-21 Thread Parth Wazurkar
> > Well, the glyphs aren't `loaded'; you are rather collecting the file > offsets in an array. > Yes. > > It loads glyphs in the increasing order of their character code. > > Not necessarily: The order of `char_loc' commands could be arbitrary, > say, > > Character 3: dx 3801088 (58), width 7

Re: [ft-devel] GF's cmap fails

2018-08-20 Thread Werner LEMBERG
>> GF provides a natural order of glyphs within the font file, we call >> this `glyph indices'. Each glyph index is associated with a file >> offset. For each glyph, GF assigns a character code to it. We >> thus have immediately a mapping from glyph indices to character >> codes. > > My changes

Re: [ft-devel] GF's cmap fails

2018-08-20 Thread Parth Wazurkar
> > > After some debugging, I found out that, I was using binary search on > > the encodings array in the `char_index' function, although it wasn't > > sorted (so foolish of me :( ). Now, fixed! Thanks. > > In the commit message, you write > > Use `linear search' instead of `binary search' in th

Re: [ft-devel] GF's cmap fails

2018-08-15 Thread Werner LEMBERG
> After some debugging, I found out that, I was using binary search on > the encodings array in the `char_index' function, although it wasn't > sorted (so foolish of me :( ). Now, fixed! Thanks. In the commit message, you write Use `linear search' instead of `binary search' in the encoding ta

Re: [ft-devel] GF's cmap fails

2018-08-14 Thread Parth Wazurkar
> > >> ./ftview -e "" 20 cmr10.600gf > >> > >> only shows `A' glyphs. [...] > > > > Ok. Currently the GF's cmap is like, the first glyph in the file is > > indexed to 0, and so on. So in cmr10.600gf, `ABCD...' appear first > > so they are now indexed from `0,1,2..' > > This is correct. > > > wh

Re: [ft-devel] GF's cmap fails

2018-08-12 Thread Werner LEMBERG
>> ./ftview -e "" 20 cmr10.600gf >> >> only shows `A' glyphs. [...] > > Ok. Currently the GF's cmap is like, the first glyph in the file is > indexed to 0, and so on. So in cmr10.600gf, `ABCD...' appear first > so they are now indexed from `0,1,2..' This is correct. > what happened previousl

Re: [ft-devel] GF's cmap fails

2018-08-12 Thread Parth Wazurkar
> > [commit 401ce90 -> parthw-cleaned, origin/parthw-cleaned)] > > Parth, > > > calling > > ./ftview -e "" 20 cmr10.600gf > > only shows `A' glyphs. This is incorrect. It should rather start > with `ΓΔΘΛΞΠ...' since `-e ""' invokes the font's internal cmap (this > is, the only cmap that GF curr

[ft-devel] GF's cmap fails

2018-08-12 Thread Werner LEMBERG
[commit 401ce90 -> parthw-cleaned, origin/parthw-cleaned)] Parth, calling ./ftview -e "" 20 cmr10.600gf only shows `A' glyphs. This is incorrect. It should rather start with `ΓΔΘΛΞΠ...' since `-e ""' invokes the font's internal cmap (this is, the only cmap that GF currently implements).