Re: [Freevo-devel] Patches and Coding Style

2007-09-16 Thread Dirk Meyer
Jason Tackaberry wrote: > On 2007-09-06 11:53, Dirk Meyer wrote: >> Right. Doc inside the source is also very helpfull. Besides that, I >> wrote down some coding style rules. Not every rule is as important as >> the other one and not every dev uses these rules, but it is a good >> guideline: > > I

Re: [Freevo-devel] Patches and Coding Style

2007-09-09 Thread Duncan Webb
> Does the 1.7.x branch still have an SVN version? Freevo-1.7.x is the main freevo-1.x branch and is here: svn co svn://svn.freevo.org/freevo/branches/rel-1 freevo-1.x Duncan > --- Duncan Webb <[EMAIL PROTECTED]> wrote: > >> Michael Beal wrote: >> > Well Being that I'm working on doing some

Re: [Freevo-devel] Patches and Coding Style

2007-09-09 Thread Michael Beal
Does the 1.7.x branch still have an SVN version? --- Duncan Webb <[EMAIL PROTECTED]> wrote: > Michael Beal wrote: > > Well Being that I'm working on doing some minor fix-ups for > the > > 1.7.x code branch, I'm not sure exactly _how_much_ help I'll be but > I > > can certainly be of use t

Re: [Freevo-devel] Patches and Coding Style

2007-09-09 Thread Michael Beal
Actually, I'm working on a running system which makes the changes doubly difficult for me to track since I have no unmodified version of the 1.7.x branch to run the diff against. I'll fix-up my code base and get it all sorted out soon. Thanx for the help, everyone!!! --- Jason Tackaberry <[EMAIL

Re: [Freevo-devel] Patches and Coding Style

2007-09-09 Thread Michael Beal
GREAT!!! Thanx!!! I haven't had time this weekend to research out unified DIFFs. You, sir, are a time saver --- Evan Hisey <[EMAIL PROTECTED]> wrote: > Micheal- > Here is a good starting point on making diff patches: > http://drupal.org/patch/create > > Evan > > On 9/6/07, Michael Beal

Re: [Freevo-devel] Patches and Coding Style

2007-09-07 Thread Duncan Webb
Michael Beal wrote: > Well Being that I'm working on doing some minor fix-ups for the > 1.7.x code branch, I'm not sure exactly _how_much_ help I'll be but I > can certainly be of use tracking down bugs. > > I'll figure out how to do unified diffs and send up the encodingcore.py > fix-up as w

Re: [Freevo-devel] Patches and Coding Style

2007-09-07 Thread Jason Tackaberry
On Thu, 2007-09-06 at 20:52 -0700, Michael Beal wrote: > Now to learn unified diffs!!! I believe with the svn diff command, the default is unified. So just make your changes to a local checkout, and do svn diff in the tree. It will output all the changes (recursively) between your local copy and

Re: [Freevo-devel] Patches and Coding Style

2007-09-06 Thread Evan Hisey
Micheal- Here is a good starting point on making diff patches: http://drupal.org/patch/create Evan On 9/6/07, Michael Beal <[EMAIL PROTECTED]> wrote: > Thanx! That's pretty much how I'm doing things now. I can say I may > tend to _over-document_ the source. I'm sure that's not a problem > th

Re: [Freevo-devel] Patches and Coding Style

2007-09-06 Thread Michael Beal
Thanx! That's pretty much how I'm doing things now. I can say I may tend to _over-document_ the source. I'm sure that's not a problem though. Now to learn unified diffs!!! --- Dirk Meyer <[EMAIL PROTECTED]> wrote: > Jason Tackaberry wrote: > > Hi Michael, > > > > On 2007-09-06 11:37, Michael

Re: [Freevo-devel] Patches and Coding Style

2007-09-06 Thread Michael Beal
Well Being that I'm working on doing some minor fix-ups for the 1.7.x code branch, I'm not sure exactly _how_much_ help I'll be but I can certainly be of use tracking down bugs. I'll figure out how to do unified diffs and send up the encodingcore.py fix-up as well as any other stuff I find an

Re: [Freevo-devel] Patches and Coding Style

2007-09-06 Thread Michael Beal
Valid point. Hadn't thought of it that way. Thanx --- Andrew Flegg <[EMAIL PROTECTED]> wrote: > On 9/6/07, Michael Beal <[EMAIL PROTECTED]> wrote: > > > > When attempting to send a patch upstream some time ago, someone > > suggested I do a diff and send that so everyone could see the > cha

Re: [Freevo-devel] Patches and Coding Style

2007-09-06 Thread Jason Tackaberry
On 2007-09-06 11:53, Dirk Meyer wrote: > Right. Doc inside the source is also very helpfull. Besides that, I > wrote down some coding style rules. Not every rule is as important as > the other one and not every dev uses these rules, but it is a good > guideline: I know we've argued about some of t

Re: [Freevo-devel] Patches and Coding Style

2007-09-06 Thread Dirk Meyer
Jason Tackaberry wrote: > Hi Michael, > > On 2007-09-06 11:37, Michael Beal wrote: >> When attempting to send a patch upstream some time ago, someone >> suggested I do a diff and send that so everyone could see the change. >> I don't much care for doing diffs. Seems a lot cryptic to me. >> Personal

Re: [Freevo-devel] Patches and Coding Style

2007-09-06 Thread Andrew Flegg
On 9/6/07, Michael Beal <[EMAIL PROTECTED]> wrote: > > When attempting to send a patch upstream some time ago, someone > suggested I do a diff and send that so everyone could see the change. > I don't much care for doing diffs. Seems a lot cryptic to me. The advantage of a diff over any other opt

Re: [Freevo-devel] Patches and Coding Style

2007-09-06 Thread Jason Tackaberry
Hi Michael, On 2007-09-06 11:37, Michael Beal wrote: > When attempting to send a patch upstream some time ago, someone > suggested I do a diff and send that so everyone could see the change. > I don't much care for doing diffs. Seems a lot cryptic to me. > Personally, I prefer to mark up code with

[Freevo-devel] Patches and Coding Style

2007-09-06 Thread Michael Beal
When attempting to send a patch upstream some time ago, someone suggested I do a diff and send that so everyone could see the change. I don't much care for doing diffs. Seems a lot cryptic to me. Personally, I prefer to mark up code with comments about changes. So, to all the primary devs, I as