You beat me to it :)
However, the bug caused by arbitrary indexed matrix is
still there:
diff --git a/src/algebra/mama.spad b/src/algebra/mama.spad
index 33a6a32..9dd7a38 100644
--- a/src/algebra/mama.spad
+++ b/src/algebra/mama.spad
@@ -114,7 +114,7 @@
rows(A : M, lst : LI) : M ==
oldk1331 wrote:
> OK, I'll fix subMatrix to allow LIST INT, I'm doing that,
> which means almost all signatures in mama.spad
> need fixing.
I have just commited changes to mama.spad. I also generalised
it to allow not only matrices but also arrays.
> Meanwhile, new problems:
>
> rows(A:M,
OK, I'll fix subMatrix to allow LIST INT, I'm doing that,
which means almost all signatures in mama.spad
need fixing.
Meanwhile, new problems:
rows(A:M, lst:LI) : M ==
nc := ncols(A)
nc = 0 => zero(#lst, nc)$M
Should we allow matrix that have zero rows or zero columns?
>
> minRowIndex returns INT, but one of subMatrix's signature is:
> [1] (D1,List(PositiveInteger),List(PositiveInteger)) -> D1
>
> That means subMatrix can't take matrices that with negative
> index. One way is to fix subMatrix to let it take LIST INT
> as arguments, but I want to go with the
On 06/07/2016 06:54 AM, oldk1331 wrote:
> minRowIndex returns INT, but one of subMatrix's signature is:
> [1] (D1,List(PositiveInteger),List(PositiveInteger)) -> D1
Oh, that code must be by Raoul Bourquin. I don't think it is in the
spirit of the original Axiom developers' idea for "Indexed...".
minRowIndex returns INT, but one of subMatrix's signature is:
[1] (D1,List(PositiveInteger),List(PositiveInteger)) -> D1
That means subMatrix can't take matrices that with negative
index. One way is to fix subMatrix to let it take LIST INT
as arguments, but I want to go with the other way.
I
