Re: Status fvwm-menu-desktop

2011-12-20 Thread Thomas Adam
On Mon, Dec 19, 2011 at 06:11:57PM -0500, Dan Espen wrote: I think TA mentioned it was slow. I don't know if he measured it or not. Yeah: http://xteddy.org/~n6tadam/fvwm/nytprof/ Note interpret_menu() is the culprit -- the scan_AppDir() and read_desktop_entry() subroutines don't help, but I

Re: Status fvwm-menu-desktop

2011-12-20 Thread Dan Espen
Thomas Adam tho...@fvwm.org writes: On Mon, Dec 19, 2011 at 06:11:57PM -0500, Dan Espen wrote: I think TA mentioned it was slow. I don't know if he measured it or not. Yeah: http://xteddy.org/~n6tadam/fvwm/nytprof/ Nice! Note interpret_menu() is the culprit -- the scan_AppDir() and

Re: Status fvwm-menu-desktop

2011-12-20 Thread Dan Espen
Thomas Adam tho...@fvwm.org writes: On Tue, Dec 20, 2011 at 01:57:37PM -0500, Dan Espen wrote: Thomas Adam tho...@fvwm.org writes: On Mon, Dec 19, 2011 at 06:11:57PM -0500, Dan Espen wrote: I think TA mentioned it was slow. I don't know if he measured it or not. Yeah:

Re: Status fvwm-menu-desktop

2011-12-20 Thread Thomas Adam
On Tue, Dec 20, 2011 at 06:14:54PM -0500, Dan Espen wrote: After removing the ones we don't need (above), there's not many calls left. We only deal with a few directories. We could readdir and build a hash. Yes, but the recusiveness of those subroutines before the hashing I added in the patch

Re: Status fvwm-menu-desktop

2011-12-20 Thread Dan Espen
Thomas Adam tho...@fvwm.org writes: Timings with the patch attached applied are here: http://xteddy.org/~n6tadam/fvwm/nytprof-updated/ That's what I call impressive improvments! I applied the patch, works well for me. -- Dan Espen