Re: Snapping issue

2021-11-21 Thread Dominik Vogt
On Sun, Nov 21, 2021 at 02:09:53AM -0700, Jaimos Skriletz wrote: > On Sat, Nov 20, 2021 at 5:22 PM Dominik Vogt wrote: > > 2) Please break up the calculations in DoSnapGrid into multiple > >lines unsing temp variable. It's too hard to read = hard to > >maintain. The previous un-readabili

Re: Snapping issue

2021-11-21 Thread Dominik Vogt
On Sun, Nov 21, 2021 at 02:09:53AM -0700, Jaimos Skriletz wrote: > On Sat, Nov 20, 2021 at 5:22 PM Dominik Vogt wrote: > > > > > > 1) Can we safely assume that the "bool" C type is available in > >every relevant compiler? > > The bool type is used elsewhere in the fvwm code, so I would assume

Re: Snapping issue

2021-11-21 Thread Jaimos Skriletz
On Sun, Nov 21, 2021 at 11:32 AM Jaimos Skriletz wrote: > > On Sun, Nov 21, 2021 at 2:09 AM Jaimos Skriletz > wrote: > > > > All of the updates have been pushed to js/snapattract. > > > > I noticed a bug, though I think it is elsewhere in the code. Arg, the bug was me, I wasn't typing my Style l

Re: Snapping issue

2021-11-21 Thread Jaimos Skriletz
On Sun, Nov 21, 2021 at 2:09 AM Jaimos Skriletz wrote: > > All of the updates have been pushed to js/snapattract. > I noticed a bug, though I think it is elsewhere in the code. I was not able to set the resistance to move a window between RandR screens correctly. But if I modify the fw->edge_resi

Re: Snapping issue

2021-11-21 Thread Jaimos Skriletz
On Sat, Nov 20, 2021 at 5:22 PM Dominik Vogt wrote: > > > 1) Can we safely assume that the "bool" C type is available in >every relevant compiler? The bool type is used elsewhere in the fvwm code, so I would assume it is okay. > 2) Please break up the calculations in DoSnapGrid into multiple

Re: Snapping issue

2021-11-20 Thread Dominik Vogt
And there's still a bug that had been present in the old code: Assume you have a window on screen and a button bar aligned with the bottom of the screen. Grab the window at the top border and move it past the button bar towards the bottom of the screen. When the top of the window gets close to th

Re: Snapping issue

2021-11-20 Thread Dominik Vogt
On Sat, Nov 20, 2021 at 04:17:41PM -0700, Jaimos Skriletz wrote: > On Sun, Nov 14, 2021 at 10:57 AM Dominik Vogt wrote: > > > > The snapping code is really an unmaintainable mess. Some thoughts > > on how it might be rewritten: > > > > Here are some thoughts I have, you can see them in js/snapatt

Re: Snapping issue

2021-11-20 Thread Jaimos Skriletz
On Sun, Nov 14, 2021 at 10:57 AM Dominik Vogt wrote: > > The snapping code is really an unmaintainable mess. Some thoughts > on how it might be rewritten: > Here are some thoughts I have, you can see them in js/snapattract branch. I have split the three different snapping checks into individual

Re: Snapping issue

2021-11-14 Thread Dominik Vogt
The snapping code is really an unmaintainable mess. Some thoughts on how it might be rewritten: Situation: 1. There are three different snapping mechanisms: a) Snapping to windows or icons. b) Snapping to screen edges. c) Snapping to the grid. Each one has some distance defined at which sna

Snapping issue

2021-11-14 Thread Dominik Vogt
Snapping to the grid, other windows and screen edges hat a nasty interaction that has been bugging me for years, but I don't know how to fix it. Suppose you have this: Style * SnapAttraction 12 Sametype, SnapGrid 4 4 EdgeResistance 500 Style * EdgeMoveDelay 500, EdgeMoveResistance 128 Edg