Re: [fw-general] Committing to milestones branch

2010-09-24 Thread Daniel Latter
Thanks, Ive submitted another pull request to the changes I have made to my master (zf2) fork on GitHub, indicating the milestones/exceptions branch. I'll await to get response then go from there. Thanks again for your patience.

Re: [fw-general] Committing to milestones branch

2010-09-24 Thread Ralph Schindler
As far as I know, you can make the pull request and I'll still get it. What I suggest is that you put a message in there that refers to the branch of milestones/exceptions. There are not alot of pull requests coming in currently, so it is easy enough to see what is what. Thanks! Ralph On 9/

Re: [fw-general] Committing to milestones branch

2010-09-24 Thread Michael Ridgway
There is currently a bug in Github's pull request system that doesn't allow us to make a request using the milestone/exception branch as a base: http://support.github.com/discussions/repos/4165-bug-in-pull-request-base-selection Is there another option that we have until this is fixed? - Michael

Re: [fw-general] Committing to milestones branch

2010-09-24 Thread Matthew Weier O'Phinney
-- Daniel Latter wrote (on Friday, 24 September 2010, 09:12 AM +0100): > I have made the amendments you suggested. Sorry to say I only scan read the > post you linked to the other day on zfdev so im gonna read that properly > tonight :) > > I am using Git Bash for windows with Github as my remote

[fw-general] Committing to milestones branch

2010-09-24 Thread Daniel Latter
RE: Ralph Thanks for the reply on github I have made the amendments you suggested. Sorry to say I only scan read the post you linked to the other day on zfdev so im gonna read that properly tonight :) I am using Git Bash for windows with Github as my remote repo. I currently have all the changes