Re: [PATCH master] Remove useless lock in recreate-disks

2012-09-14 Thread Michael Hanselmann
2012/9/14 Bernardo Dal Seno : > On Fri, Sep 14, 2012 at 12:08 PM, Michael Hanselmann > wrote: >> 2012/9/14 Guido Trotter : >>> I believe we lock or don't lock depending on the RPC type, what it >>> does, and how compatible it is with other RPCs, right? >> >> Recreating disks involves DRBD (or oth

Re: [PATCH master] Remove useless lock in recreate-disks

2012-09-14 Thread Bernardo Dal Seno
On Fri, Sep 14, 2012 at 12:08 PM, Michael Hanselmann wrote: > 2012/9/14 Guido Trotter : >> I believe we lock or don't lock depending on the RPC type, what it >> does, and how compatible it is with other RPCs, right? > > Recreating disks involves DRBD (or other block device types) and > unless othe

Re: [PATCH master] Remove useless lock in recreate-disks

2012-09-14 Thread Michael Hanselmann
2012/9/14 Guido Trotter : > I believe we lock or don't lock depending on the RPC type, what it > does, and how compatible it is with other RPCs, right? Recreating disks involves DRBD (or other block device types) and unless other measures have been taken, locks must be used. You don't want an inst

Re: [PATCH master] Remove useless lock in recreate-disks

2012-09-14 Thread Guido Trotter
I believe we lock or don't lock depending on the RPC type, what it does, and how compatible it is with other RPCs, right? Guido On Fri, Sep 14, 2012 at 10:13 AM, Michael Hanselmann wrote: > 2012/9/13 Bernardo Dal Seno : >> The old primary node was being locked to do RPC, but we don't lock nodes

Re: [PATCH master] Remove useless lock in recreate-disks

2012-09-14 Thread Michael Hanselmann
2012/9/13 Bernardo Dal Seno : > The old primary node was being locked to do RPC, but we don't lock nodes > for RPC anymore, so the lock is useless. We don't lock nodes for RPC? What did I miss? Michael

Re: [PATCH master] Remove useless lock in recreate-disks

2012-09-13 Thread Guido Trotter
LGTM, Thanks Guido On 13 Sep 2012 16:59, "Bernardo Dal Seno" wrote: > The old primary node was being locked to do RPC, but we don't lock nodes > for RPC anymore, so the lock is useless. > > Signed-off-by: Bernardo Dal Seno > --- > lib/cmdlib.py | 16 ++-- > 1 files changed, 6 in

[PATCH master] Remove useless lock in recreate-disks

2012-09-13 Thread Bernardo Dal Seno
The old primary node was being locked to do RPC, but we don't lock nodes for RPC anymore, so the lock is useless. Signed-off-by: Bernardo Dal Seno --- lib/cmdlib.py | 16 ++-- 1 files changed, 6 insertions(+), 10 deletions(-) diff --git a/lib/cmdlib.py b/lib/cmdlib.py index 2e4da4