Re: [Ganglia-developers] Bug with 3.1.0 gmetad aggregating another3.1.0 gmetad?

2008-08-07 Thread Bernard Li
Hi Brad: On Thu, Aug 7, 2008 at 4:09 PM, Brad Nicholes <[EMAIL PROTECTED]> wrote: > The backport is already in the STATUS file. It does include the revert of > hash.c, but I can create a patch that just applies to process_xml.c. Where > should be put the patch file? Should it go into www.gan

Re: [Ganglia-developers] Bug with 3.1.0 gmetad aggregating another3.1.0 gmetad?

2008-08-07 Thread Brad Nicholes
>>> On 8/7/2008 at 11:44 AM, in message <[EMAIL PROTECTED]>, Carlo Marcelo Arenas Belon <[EMAIL PROTECTED]> wrote: > On Thu, Aug 07, 2008 at 09:51:14AM -0600, Brad Nicholes wrote: >> I reverted the workaround in hash.c > > I think we should leave that one in there anyway (maybe as an assert?) as a

Re: [Ganglia-developers] Bug with 3.1.0 gmetad aggregating another3.1.0 gmetad?

2008-08-07 Thread Carlo Marcelo Arenas Belon
On Thu, Aug 07, 2008 at 09:51:14AM -0600, Brad Nicholes wrote: > I reverted the workaround in hash.c I think we should leave that one in there anyway (maybe as an assert?) as a hash lookup in a NULL pointer hash is invalid anyway and will result in a segfault (if we make a mistake somewhere else t

Re: [Ganglia-developers] Bug with 3.1.0 gmetad aggregating another3.1.0 gmetad?

2008-08-07 Thread Bernard Li
On Thu, Aug 7, 2008 at 8:51 AM, Brad Nicholes <[EMAIL PROTECTED]> wrote: > I reverted the workaround in hash.c and fixed process_xml.c to process the > EXTRA_ELEMENT tag correctly. The problem was the fact that the EXTRA_ELEMENT > data should only be processing this tag if gmetad is in authori

Re: [Ganglia-developers] Bug with 3.1.0 gmetad aggregating another3.1.0 gmetad?

2008-08-07 Thread Brad Nicholes
I reverted the workaround in hash.c and fixed process_xml.c to process the EXTRA_ELEMENT tag correctly. The problem was the fact that the EXTRA_ELEMENT data should only be processing this tag if gmetad is in authority mode. It was missing a simple check for authority mode that the other tags