Re: [Ganglia-developers] bug#128: combine integers and floats into one double sum

2008-03-24 Thread Witham, Timothy D
> i think the current code also allows for gmetad hierarchies to do the summary > right, because 3.1 will use (unless I misunderstood the code) float types for > memory metrics anyway, but haven't yet test that. > do you have any probe otherwise? Imagine that I have many grids around the globe a

Re: [Ganglia-developers] bug#128: combine integers and floats into one double sum

2008-03-20 Thread Carlo Marcelo Arenas Belon
On Thu, Mar 20, 2008 at 11:52:58AM -0700, Witham, Timothy D wrote: > Ok, if you can guarantee that a gmetad will never hear from an old and a > new gmond at the same time, then you might be right. no, the objective is to allow a gmetad to pull and summarize correctly from 3.0 or 3.1 gmond. the cu

Re: [Ganglia-developers] bug#128: combine integers and floats into one double sum

2008-03-20 Thread Witham, Timothy D
Marcelo Arenas Belon [mailto:[EMAIL PROTECTED] Sent: Thursday, March 20, 2008 1:19 PM To: Witham, Timothy D Cc: ganglia-developers@lists.sourceforge.net; Brad Nicholes Subject: Re: [Ganglia-developers] bug#128: combine integers and floats into one double sum On Thu, Mar 20, 2008 at 10:26:36AM

Re: [Ganglia-developers] bug#128: combine integers and floats into one double sum

2008-03-20 Thread Carlo Marcelo Arenas Belon
On Thu, Mar 20, 2008 at 10:26:36AM -0700, Witham, Timothy D wrote: > Without this, folks would have to upgrade > all gmonds to 3.1 simultaneously or they would get incorrect totals. I haven't yet validated this by testing the setup, but from my understanding of the code, you should be able to upg

[Ganglia-developers] bug#128: combine integers and floats into one double sum

2008-03-20 Thread Witham, Timothy D
Thank you Carlo. I updated the title on bug#128 and attached a final patch which corrects the math in process_xml.c too. This was needed to get the total right in the summary graphs. I cleaned up the code by removing the no longer needed integer addition. This allows sources to be integers from