On Feb 12, 2008 11:43 AM, [EMAIL PROTECTED] wrote:
Quoting Jesse Becker [EMAIL PROTECTED]:
In the meantime, I started on a patch to put all of the variable
checks and sanitation in one place.
Do you mean move the checks out of get_context.php and graph.php?
Yes, pretty much all of it.
Quoting Jesse Becker [EMAIL PROTECTED]:
On Feb 11, 2008 6:46 PM, Bernard Li [EMAIL PROTECTED] wrote:
Hi Alex:
BTW, I am going to check in the patches for trunk, however, I will
rename clean_float() to clean_number() since the function name and the
comment seems a bit misleading based on its
On Feb 11, 2008 6:46 PM, Bernard Li [EMAIL PROTECTED] wrote:
Hi Alex:
BTW, I am going to check in the patches for trunk, however, I will
rename clean_float() to clean_number() since the function name and the
comment seems a bit misleading based on its call to is_numeric (i.e.
it is not really
Hi Jesse:
On 2/11/08, Jesse Becker [EMAIL PROTECTED] wrote:
Depends. There are cases where we need to distinguish between floats
and integers. For example, the start time for graphs should be
integers (only), while other things can be either floats or ints (the
'vl' URL parameter,for
On Feb 11, 2008 5:23 PM, Bernard Li [EMAIL PROTECTED] wrote:
Hi Jesse:
On 2/11/08, Jesse Becker [EMAIL PROTECTED] wrote:
Depends. There are cases where we need to distinguish between floats
and integers. For example, the start time for graphs should be
integers (only), while other
On Feb 11, 2008 5:12 PM, Bernard Li [EMAIL PROTECTED] wrote:
http://bugzilla.ganglia.info/cgi-bin/bugzilla/show_bug.cgi?id=178
So basically after applying the patch, there will only be one function
left, i.e. clean_float() that could handle both float and integers.
If that's the case,
Hi Jesse:
On 2/11/08, Jesse Becker [EMAIL PROTECTED] wrote:
There are two issues here: the immediate problem with clean_float not
working correctly, and a more general input validiation problem.
We need clean_int() to fix the bug where the Show Hosts radio button
stopped working. Well,
Quoting Jesse Becker [EMAIL PROTECTED]:
On Feb 11, 2008 6:16 PM, Bernard Li [EMAIL PROTECTED] wrote:
On 2/11/08, Jesse Becker [EMAIL PROTECTED] wrote:
There are two issues here: the immediate problem with clean_float not
working correctly, and a more general input validiation problem.
Hi Alex:
On 2/11/08, [EMAIL PROTECTED] [EMAIL PROTECTED] wrote:
A clean_int() function would allow $showhosts to be 2, 3, 4, etc.
which are also bad values. Not likely to be harmful, but still bogus.
Since $showhosts has only 2 legitimate values, what about filtering it
as a boolean, and
