Re: [Ganglia-developers] fix for gmetric/gmond and slope setting/printing (bugzilla 136)

2007-04-25 Thread Nick Galbreath
hello all, Thanks everyone for the review. Re: Matt / Conflicts Ag the conflicts, mostly svn being silly. I generated this about 3 weeks ago and posted it to bugzilla which went nowhere since I think the email was busted. Attached is a refreshed version. RE: Paul / gmetad changes Actually

Re: [Ganglia-developers] fix for gmetric/gmond and slope setting/printing (bugzilla 136)

2007-04-25 Thread Paul Millar
On Wednesday 25 April 2007 02:44, Nick Galbreath wrote: > Attached is a patch to fix a small gmetric/gmond bug. [...] > Comments most welcome! Hi Nick, I've not tried applying your patch; but, by eye, it looks fine. Apologies if I'm pointing out the obvious, but I don't imagine it'll have much

Re: [Ganglia-developers] fix for gmetric/gmond and slope setting/printing (bugzilla 136)

2007-04-25 Thread Matt Massie
i reviewed this patch and decided to patch trunk with it since the patch is a simple smart update. however, it doesn't the diff doesn't work against the current trunk. libgmond.c and gmond.c hunks were rejected. can you update your trunk, generate your patch and resubmit? thanks! -matt On Tu

[Ganglia-developers] fix for gmetric/gmond and slope setting/printing (bugzilla 136)

2007-04-24 Thread Nick Galbreath
Hi there, Attached is a patch to fix a small gmetric/gmond bug. It turns out that gmetric doesn't let you set slope correctly, and gmond doesn't print the slope from gmetric correctly (well, it only allows 2 values instead of 4). I originally filed it in http://bugzilla.ganglia.info/cgi-bin/bu