Re: [Ganglia-developers] gmond Spoof memory leak fix

2008-02-25 Thread Carlo Marcelo Arenas Belon
On Mon, Feb 25, 2008 at 10:56:33AM -0600, Martin Hicks wrote: > > Ah okay. I don't see those warnings. Thanks for the update. Committed revision 1003. Carlo - This SF.net email is sponsored by: Microsoft Defy all challeng

Re: [Ganglia-developers] gmond Spoof memory leak fix

2008-02-25 Thread Martin Hicks
On Sat, Feb 23, 2008 at 04:32:20PM -0600, Carlo Marcelo Arenas Belon wrote: > > gmond.c: In function 'Ganglia_message_save': > gmond.c:840: warning: passing argument 1 of 'xdr_free' from incompatible > pointer type > gmond.c:840: warning: passing argument 2 of 'xdr_free' from incompatible

Re: [Ganglia-developers] gmond Spoof memory leak fix

2008-02-23 Thread Carlo Marcelo Arenas Belon
On Wed, Feb 20, 2008 at 12:18:41PM -0800, Bernard Li wrote: > > On 2/20/08, Martin Knoblauch <[EMAIL PROTECTED]> wrote: > > > I just committed the fix for the spoofing leak from Martin Hicks. Can you > > run a [final] snapshot for 3.0.7? I have something brewing to fix the > > petabyte/sec sp

Re: [Ganglia-developers] gmond Spoof memory leak fix

2008-02-21 Thread Kumar Vaibhav
Hi All, Thjumbs up from my side. I don't see any memory leak on my systems. So It is ok for my configuration. Vaibhav Bernard Li wrote: > Hi guys: > > On 2/20/08, Martin Knoblauch <[EMAIL PROTECTED]> wrote: > >> I just committed the fix for the spoofing leak from Martin Hicks. Can you >> r

Re: [Ganglia-developers] gmond Spoof memory leak fix

2008-02-20 Thread Martin Hicks
On Wed, Feb 20, 2008 at 01:18:33PM -0700, Brad Nicholes wrote: > I don't believe that we have the same problem in trunk, however some > additional testing couldn't hurt. The spoof packet handling as well > as the way that the XDR data is handled in general, has changed > significantly in

Re: [Ganglia-developers] gmond Spoof memory leak fix

2008-02-20 Thread Bernard Li
Hi guys: On 2/20/08, Martin Knoblauch <[EMAIL PROTECTED]> wrote: > I just committed the fix for the spoofing leak from Martin Hicks. Can you > run a [final] snapshot for 3.0.7? I have something brewing to fix the > petabyte/sec spikes that one of our customers is seeing, but that needs more

Re: [Ganglia-developers] gmond Spoof memory leak fix

2008-02-20 Thread Brad Nicholes
lt;[EMAIL PROTECTED]>; Bernard Li <[EMAIL PROTECTED]> >> Cc: Ganglia Developers >> Sent: Wednesday, February 20, 2008 7:58:20 PM >> Subject: Re: [Ganglia-developers] gmond Spoof memory leak fix >> >> Bernard, all, >> >> I just committed the fix fo

Re: [Ganglia-developers] gmond Spoof memory leak fix

2008-02-20 Thread Martin Knoblauch
- Original Message > > From: Martin Knoblauch > > To: Martin Hicks > > Cc: Ganglia Developers > > Sent: Wednesday, February 20, 2008 7:44:04 PM > > Subject: Re: [Ganglia-developers] gmond Spoof memory leak fix > > > > - Original Message

Re: [Ganglia-developers] gmond Spoof memory leak fix

2008-02-20 Thread Martin Knoblauch
ent: Wednesday, February 20, 2008 7:44:04 PM > Subject: Re: [Ganglia-developers] gmond Spoof memory leak fix > > - Original Message > > From: Martin Hicks > > To: Martin Knoblauch > > Cc: Ganglia Developers > > Sent: Wednesday, February 20, 2008 7:3

Re: [Ganglia-developers] gmond Spoof memory leak fix

2008-02-20 Thread Martin Knoblauch
- Original Message > From: Martin Hicks <[EMAIL PROTECTED]> > To: Martin Knoblauch <[EMAIL PROTECTED]> > Cc: Ganglia Developers > Sent: Wednesday, February 20, 2008 7:33:32 PM > Subject: Re: [Ganglia-developers] gmond Spoof memory leak fix > > > On W

Re: [Ganglia-developers] gmond Spoof memory leak fix

2008-02-20 Thread Martin Hicks
On Wed, Feb 20, 2008 at 10:27:33AM -0800, Martin Knoblauch wrote: > Hi, > > if you resend it as an attachment, I would apply the fix. You can apply it with my blabbering at the beginning. :) patch ignores the stuff before the --- The patch is attached for your convenience. > > Cheers > Marti

Re: [Ganglia-developers] gmond Spoof memory leak fix

2008-02-20 Thread Martin Knoblauch
tin Hicks <[EMAIL PROTECTED]> > To: Ganglia Developers > Sent: Wednesday, February 20, 2008 7:06:41 PM > Subject: [Ganglia-developers] gmond Spoof memory leak fix > > > Hi, > > Here's a patch against ganglia-3.0.6.200802141157 that fixes a memory > leak when

[Ganglia-developers] gmond Spoof memory leak fix

2008-02-20 Thread Martin Hicks
Hi, Here's a patch against ganglia-3.0.6.200802141157 that fixes a memory leak when using user defined metrics with spoofing. The problem was that the spmetric was being copied out, ignoring the spheader. The strings that were allocated inside the spheader were dropped. mh --- ganglia-3.0.6.2