On Thu, 2022-10-27 at 19:16 -0400, Ben Boeckel wrote:
> This simplifies the interface for other UTF-8 validity detections
> when a
> simple "yes" or "no" answer is sufficient.
>
> Signed-off-by: Ben Boeckel
> ---
> libcpp/ChangeLog | 6 ++
> libcpp/charset.cc | 18 ++
>
On Thu, 2022-10-27 at 19:16 -0400, Ben Boeckel wrote:
> Unicode does not support such values because they are unrepresentable
> in
> UTF-16.
Wikipedia pointed me to RFC 3629, which was when UTF-8 introduced this
restriction, whereas libcpp was implementing the higher upper limit
from the earlier,
Successfully bootstrapped & regrtested on x86_64-pc-linux-gnu.
Pushed to trunk as r13-3515-g57bbf3a403bb1e.
gcc/analyzer/ChangeLog:
* sm-fd.cc (fd_state_machine::on_open): Transition to "unchecked"
when the mode is symbolic, rather than just on integer constants.
Add a .dot file to document the file descriptor state machine.
gcc/analyzer/ChangeLog:
* sm-fd.dot: New file.
Signed-off-by: David Malcolm
---
gcc/analyzer/sm-fd.dot | 109 +
1 file changed, 109 insertions(+)
create mode 100644
On Wed, 2022-10-26 at 10:17 +0200, arthur.co...@embecosm.com wrote:
> This is the fixed version of our previous patch set for gccrs - We've
> adressed
> the comments raised in our previous emails.
[...snip...]
(Caveat: I'm not a global reviewer)
Sorry if this is answered in the docs in the
%{On Wed, 2022-10-26 at 10:18 +0200, arthur.co...@embecosm.com wrote:
> From: Philip Herron
>
> Extern crates statements to tell the front-end to look for another
> library.
> The mechanism here is heavily inspired from gccgo, so when we compile
> a
> library for example we invoke:
>
On Wed, 2022-10-26 at 10:17 +0200, arthur.co...@embecosm.com wrote:
> From: Philip Herron
>
> This is a wrapper for make_unique we can likely get rid of this as
> there
> are other implementations available or simply keep using the
> unique_ptr
> constructor.
[CCing Jonathan]
As it happens, I
Changed in v3: added include of
v2: https://gcc.gnu.org/pipermail/gcc-patches/2022-October/604137.html
v1: https://gcc.gnu.org/pipermail/gcc-patches/2022-July/598189.html
On Tue, 2022-07-12 at 07:48 +0100, Jonathan Wakely wrote:
> On Tue, 12 Jul 2022, 01:25 David Malcolm,
> wrote:
>
> > On
On Fri, 2022-10-21 at 12:01 -0400, David Malcolm wrote:
> This patch adds gcc/make-unique.h, containing a minimal C++11
> implementation of make_unique (std::make_unique is C++14).
>
> The followup patch uses this in dozens of places within the analyzer.
>
> Successfully bootstrapped &
Successfully bootstrapped & regrtested on x86_64-pc-linux-gnu.
Lightly tested with aarch64-unknown-linux.
Pushed to trunk as r13-3470-g687d11fd74e7de
gcc/analyzer/ChangeLog:
PR analyzer/107349
* varargs.cc (get_va_copy_arg): Fix the non-pointer case.
gcc/testsuite/ChangeLog:
Successfully bootstrapped & regrtested on x86_64-pc-linux-gnu.
Pushed to trunk as r13-3469-g2e8a0553918adc.
gcc/ChangeLog:
PR analyzer/107366
* diagnostic-format-sarif.cc
(sarif_builder::maybe_make_physical_location_object): Gracefully
reject locations with NULL
Successfully bootstrapped & regrtested on x86_64-pc-linux-gnu.
Pushed to trunk as r13-3468-g18faaeb3af42f3.
gcc/analyzer/ChangeLog:
PR analyzer/107345
* region-model.cc (region_model::eval_condition_without_cm):
Ensure that constants are on the right-hand side before
Successfully bootstrapped & regrtested on x86_64-pc-linux-gnu.
Pushed to trunk as r13-3467-g53881c47e4b357.
gcc/analyzer/ChangeLog:
* engine.cc (impl_region_model_context::get_malloc_map): Replace
with...
(impl_region_model_context::get_state_map_by_name): ...this.
Successfully bootstrapped & regrtested on x86_64-pc-linux-gnu.
Pushed to trunk as r13-3466-g792f039fc37faa.
gcc/analyzer/ChangeLog:
PR analyzer/106300
* engine.cc (impl_region_model_context::get_fd_map): New.
* exploded-graph.h (impl_region_model_context::get_fd_map): New
Successfully bootstrapped & regrtested on x86_64-pc-linux-gnu.
I can self-approve this, but it requires the patch adding make-unique.h
as a prerequisite.
gcc/analyzer/ChangeLog:
* call-info.cc: Add define of INCLUDE_MEMORY.
* call-summary.cc: Likewise.
* checker-path.cc:
This patch adds gcc/make-unique.h, containing a minimal C++11
implementation of make_unique (std::make_unique is C++14).
The followup patch uses this in dozens of places within the analyzer.
Successfully bootstrapped & regrtested on x86_64-pc-linux-gnu.
OK for trunk?
gcc/ChangeLog:
*
Successfully bootstrapped & regrtested on x86_64-pc-linux-gnu.
Pushed to trunk as r13-3390-gebe87edadc4a3f.
gcc/analyzer/ChangeLog:
PR analyzer/105765
* varargs.cc (get_BT_VALIST_ARG): Rename to...
(get_va_copy_arg): ...this, and update logic for determining level
Successfully bootstrapped & regrtested on x86_64-pc-linux-gnu.
Pushed to trunk as r13-3285-g99da523359e933.
gcc/analyzer/ChangeLog:
PR analyzer/107210
* svalue.cc (constant_svalue::maybe_fold_bits_within): Only
attempt to extract individual bits when tree_fits_uhwi_p.
On Thu, 2022-10-13 at 11:44 +0200, Gerald Pfeifer wrote:
> Hi Martin,
>
> On Thu, 13 Oct 2022, Martin Liška wrote:
> > I think we should add how Python scripts should be formatted. I
> > noticed
> > that while reading the Modula-2 patchset where it follows the C/C++
> > style
> > when it comes to
On Mon, 2022-10-10 at 16:21 -0400, Jason Merrill wrote:
> On 10/4/22 11:11, Ben Boeckel wrote:
> > This patch adds initial support for ISO C++'s [P1689R5][], a format
> > for
> > describing C++ module requirements and provisions based on the
> > source
> > code. This is required because compiling
Fix a false positive from -Wanalyzer-null-dereference due to -fanalyzer
failing to grok the value of a particular boolean field initialized to a
constant.
Successfully bootstrapped & regrtested on x86_64-pc-linux-gnu.
Pushed to trunk as r13-3168-gf09b99550a3c6c.
gcc/analyzer/ChangeLog:
Successfully bootstrapped & regrtested on x86_64-pc-linux-gnu.
Pushed to trunk as r13-3137-g30d6356773a838.
gcc/analyzer/ChangeLog:
* call-summary.cc (call_summary_replay::dump_to_pp): Bulletproof
against NULL caller regions/svalues.
Signed-off-by: David Malcolm
---
I overreduced PR analyzer/107158 in r13-3096-gef878564140cbc, and there
was another ICE in the original reproducer, which this patch fixes.
Successfully bootstrapped & regrtested on x86_64-pc-linux-gnu.
Pushed to trunk as r13-3138-g629b4813e91aba.
gcc/analyzer/ChangeLog:
PR
PR analyzer/107158 reports an ICE when using
-fanalyzer -fanalyzer-call-summaries
on a particular source file.
It turns out I just fixed this ICE in r13-3094-g6832c95c0e1a58.
This followup patch adds a somewhat reduced reproducer as a regression
test. Unfortunately, although the ICE is fixed,
Successfully bootstrapped & regrtested on x86_64-pc-linux-gnu.
Pushed to trunk as r13-3095-g2eff4fe383a59d.
gcc/analyzer/ChangeLog:
* analysis-plan.cc: Simplify includes.
* analyzer-pass.cc: Likewise.
* analyzer-selftests.cc: Likewise.
* analyzer.cc: Likewise.
This doesn't fix the various false positives seen with
-fanalyzer-call-summaries on PR 107060, but stops it crashing at -O2.
Successfully bootstrapped & regrtested on x86_64-pc-linux-gnu.
Pushed to trunk as r13-3094-g6832c95c0e1a58.
gcc/analyzer/ChangeLog:
PR analyzer/107060
*
Successfully bootstrapped & regrtested on x86_64-pc-linux-gnu.
Pushed to trunk as r13-3076-g0167154cdd02c9.
gcc/analyzer/ChangeLog:
* region-model.h: Include "analyzer/region-model-manager.h"
(class region_model_manager): Move decl to...
* region-model-manager.h: ...this
With -fanalyzer-call-summaries the analyzer canl attempt to summarize
the effects of some function calls at their call site, rather than
simulate the call directly, which can avoid big slowdowns during
analysis.
Previously, this summarization was extremely simplistic: no attempt
was made to
Successfully bootstrapped & regrtested on x86_64-pc-linux-gnu.
Pushed to trunk as r13-3075-g7f42f7adfa69fe.
gcc/analyzer/ChangeLog:
* region-model-manager.cc
(region_model_manager::maybe_fold_unaryop): Fold -(-(VAL)) to VAL.
Signed-off-by: David Malcolm
---
Enabling work towrads better call summarization.
Successfully bootstrapped & regrtested on x86_64-pc-linux-gnu.
Pushed to trunk as r13-3074-ge6fe02d8322093.
gcc/analyzer/ChangeLog:
* region-model-manager.cc
(region_model_manager::get_or_create_widening_svalue): Use a
On Tue, 2022-10-04 at 11:11 +0200, Jakub Jelinek wrote:
> Hi!
>
> In these spots, the error/error_at has some inform afterwards which
> are
> explanation part of the same diagnostics, so should be tied with
> auto_diagnostic_group with it.
>
> Bootstrapped/regtested on x86_64-linux and
On Tue, 2022-09-27 at 14:02 +0800, Lulu Cheng wrote:
> SARIF support was added in r13-967 but libvtv wasn't updated.
Sorry about breaking this. The patch looks reasonable to me, FWIW,
assuming that it fixes the issue, of course!
Looks like my normal testing process missed this when I
On Sun, 2022-09-11 at 10:21 +0200, Bernhard Reutner-Fischer wrote:
> On 11 September 2022 10:04:51 CEST, David Malcolm via Gcc-patches
> wrote:
>
> > > +++ b/gcc/testsuite/gcc.dg/analyzer/pr106845.c
> > > @@ -0,0 +1,11 @@
> > > +int buf_size;
On Sun, 2022-09-11 at 00:19 +0200, Tim Lange wrote:
> Hi,
>
> see my patch below for a fix of pr106845. I decided to allow
> bit_ranges
> and byte_ranges to have a size of zero and rather only add an
> assertion
> to the functions that assume a non-zero size. That way is more
> elegant in
> the
This is a less ambitious version of:
[PATCH 0/6] RFC: adding support to GCC for detecting trust boundaries
https://gcc.gnu.org/pipermail/gcc-patches/2021-November/584372.html
Earlier versions of this patch attempted:
(a) various ways of identifying "untrusted" memory regions
(b) providing a
This patch adds the ability for plugins to register "known functions"
with the analyzer, identified by name. If -fanalyzer sees a call to
such a function (with no body), it will use a plugin-provided subclass
of the new known_function abstract base class to model the possible
outcomes of the
Successfully bootstrapped & regrtested on x86_64-pc-linux-gnu.
Pushed to trunk as r13-2571-g084dc9a0c6cec1.
gcc/testsuite/ChangeLog:
PR analyzer/98247
* gcc.dg/analyzer/flexible-array-member-1.c: New test.
Signed-off-by: David Malcolm
---
On Wed, 2022-09-07 at 17:51 +0200, Tim Lange wrote:
> Hi Dave,
>
> while re-reading that patch, I noticed a small mistake. I accidently
> did
> not move the op == PLUS_EXPR or MULT_EXPR guard in
> symbolic_greater_than
> when implementing the "eliminate operands on both sides" feature,
> which
>
I added c_expr::m_decimal in r13-2386-gbedfca647a9e9c1a as part of the
implementation of -Wxor-used-as-pow, but I missed various places where
the field needed to be initialized.
Fixed thusly (based on searching for places that assign to
the original_code field).
Successfully bootstrapped &
On Mon, 2022-09-05 at 23:16 +0200, Tim Lange wrote:
> Hi,
>
> below is my patch, adding support for reasoning about buffer
> overflows and
> overreads with symbolic offsets and capacities.
Thanks for the updated patch.
Various comments inline below...
>
> I've already had one off-list
On Sun, 2022-09-04 at 21:17 +0200, Tim Lange wrote:
> Hi Dave,
>
> sorry about the strncpy thing, I should've been more careful. Below
> is the
> patch with just the strcpy part.
Thanks - this patch looks OK for trunk.
Dave
On Tue, 2022-08-30 at 16:40 -0400, Marek Polacek wrote:
> This looks good to me, one thing though:
>
> On Thu, Aug 11, 2022 at 09:38:12PM -0400, David Malcolm via Gcc-
> patches wrote:
> > --- a/gcc/c-family/c.opt
> > +++ b/gcc/c-family/c.opt
> > @@ -1439,6 +1439,10
On Fri, 2022-09-02 at 16:08 +0200, Tim Lange wrote:
> Hi,
>
> below is my patch for the strcpy and strncpy semantics inside the
> analyzer, enabling the out-of-bounds checker to also complain about
> overflows caused by those two functions.
>
> As the plan is to reason about the inequality of
On Fri, 2022-09-02 at 16:08 +0200, Tim Lange wrote:
> This patch fixes a bug where maybe_fold_sub_svalue did not fold the
> access of a single char from a string to a char when the offset was
> zero
> because get_relative_concrete_offset did return false for
> cast_regions.
>
> Regrtested on
On Fri, 2022-08-19 at 13:27 -0700, Paul Hollinsky wrote:
> Hi all,
>
> Would love some feedback on this patch!
>
> Thanks,
> Paul
Hi Paul. Sorry for not getting back to you before. I'm listed as a
libcpp maintainer, but this happens to be a part of libcpp I've not
looked at (I'm mostly just
On Thu, 2022-08-18 at 11:44 +0200, Tim Lange wrote:
> Hi,
>
> this is the revised version of my patch. I had trouble to get your
> point regarding the float_visitor:
>
> > If the constant is seen first, then the non-constant won't be
> > favored
> > (though perhaps binary ops get canonicalized
Fix a read/write typo.
Also, add more test coverage of -Wanalyzer-out-of-bounds to help
establish a baseline for experiments on tweaking the wording of
the warning (PR analyzer/106626).
Successfully bootstrapped & regrtested on x86_64-pc-linux-gnu.
Pushed to trunk as r13-2054-g23e8c0b0d99f58.
Successfully bootstrapped & regrtested on x86_64-pc-linux-gnu.
Pushed to trunk as r13-2053-gca123e019bb92f.
gcc/analyzer/ChangeLog:
PR analyzer/106573
* region-model.cc (region_model::on_call_pre): Use check_call_args
when ensuring that we call get_arg_svalue on all args.
On Mon, 2022-08-15 at 14:35 +0200, Tim Lange wrote:
> This patch fixes the ICE reported in PR106181 and adds a new warning
> to
> the analyzer complaining about the use of floating point operands.
Thanks for the patch.
Various comments inline...
>
> I decided to move the warning for floats
On Mon, 2022-08-15 at 14:02 +0530, Immad Mir wrote:
> This patch fixes the ICE caused by valid_to_unchecked_state
> in sm-fd.cc by exiting early if first argument of any "dup"
> functions is invalid.
>
> gcc/analyzer/ChangeLog:
> PR analyzer/106551
> * sm-fd.cc (check_for_dup):
PR c/90885 notes various places in real-world code where people have
written C/C++ code that uses ^ (exclusive or) where presumbably they
meant exponentiation.
For example
https://codesearch.isocpp.org/cgi-bin/cgi_ppsearch?q=2%5E32=Search
currently finds 11 places using "2^32", and all of them
On Thu, 2022-08-11 at 19:24 +0200, Tim Lange wrote:
> This patch adds an experimental out-of-bounds checker to the
> analyzer.
>
> The checker was tested on coreutils, curl, httpd and openssh. It is
> mostly
> accurate but does produce false-positives on yacc-generated files and
> sometimes when
On Thu, 2022-08-11 at 19:24 +0200, Tim Lange wrote:
> This patch adds the "shrinks buffer" case to the success_with_move
> modelling of realloc.
Thanks for the updated patch.
>
> Regression-tested on Linux x86-64, further ran the analyzer tests
> with
> the -m32 option.
[...snip...]
> ---
On Thu, 2022-08-11 at 14:41 +0530, Immad Mir wrote:
> This patch fixes the ICE caused by valid_to_unchecked_state,
> at analyzer/sm-fd.cc by handling the m_start state in
> check_for_dup.
>
> Tested lightly on x86_64.
>
> gcc/analyzer/ChangeLog:
> PR analyzer/106551
> * sm-fd.cc
On Wed, 2022-08-10 at 19:56 +0100, Philip Herron wrote:
> Hi everyone
>
> For my v2 of the patches, I've been spending a lot of time ensuring
> each patch is buildable. It would end up being simpler if it was
> possible if each patch did not have to be like this so I could split
> up the
On Wed, 2022-08-10 at 22:51 +0530, Mir Immad wrote:
> > Can you please rebase and see if your patch
> > does fix it?
>
> No, the patch that I sent did not attempt to fix this. Now that I
> have made
> the correction, XFAIL in fd-uninit-1.c has changed to XPASS.
Great - that means that, with
On Wed, 2022-08-10 at 20:34 +0530, Mir Immad wrote:
> > if you convert the "int m;" locals into an extern global, like in
> > comment #0 of bug 106551, does that still trigger the crash on the
> > unpatched sm-fd.cc?
>
> Yes, it does, since m would be in "m_start" state. I'm sending an
> updated
We were missing checks for uninitialized params on calls to functions
that the analyzer has hardcoded knowledge of - both for those that are
handled just by state machines, and for those that are handled in
region-model-impl-calls.cc (for those arguments for which the svalue
wasn't accessed in
On Tue, 2022-08-09 at 11:39 -0400, David Malcolm wrote:
> On Sat, 2022-07-30 at 19:18 +0530, Vibhav Pant wrote:
> > I don't have push rights to the repo, so this would need to be
> > applied manually.
>
> I've gone ahead and pushed your fix to trunk (for GCC 13) as r13-
> 2004-
> g9385cd9c74cf66.
On Tue, 2022-08-09 at 23:19 +0200, Tim Lange wrote:
> This patch adds an experimental out-of-bounds checker to the
> analyzer.
>
> The checker was tested on coreutils, curl, httpd and openssh. It is
> mostly
> accurate but does produce false-positives on yacc-generated files and
> sometimes when
On Tue, 2022-08-09 at 23:19 +0200, Tim Lange wrote:
> This patch adds the "shrinks buffer" case to the success_with_move
> modelling of realloc.
Hi Tim, thanks for the patch.
>
> 2022-08-09 Tim Lange
>
> gcc/analyzer/ChangeLog:
>
> PR analyzer/106539
> *
On Tue, 2022-08-09 at 21:42 +0530, Immad Mir wrote:
> This patch fixes the ICE caused by valid_to_unchecked_state,
> at analyzer/sm-fd.cc by handling the m_start state in
> check_for_dup.
>
> Tested lightly on x86_64.
>
> gcc/analyzer/ChangeLog:
> PR analyzer/106551
> * sm-fd.cc
On Sat, 2022-07-30 at 19:18 +0530, Vibhav Pant wrote:
> I don't have push rights to the repo, so this would need to be
> applied manually.
I've gone ahead and pushed your fix to trunk (for GCC 13) as r13-2004-
g9385cd9c74cf66.
I plan to also push it to the gcc 12 branch shortly (for gcc 12.2)
Successfully bootstrapped & regrtested on x86_64-pc-linux-gnu.
Pushed to trunk as r13-2003-g16877cc2006ede.
gcc/ChangeLog:
* doc/invoke.texi (Static Analyzer Options): Add notes on which
functions the analyzer has hardcoded knowledge of.
Signed-off-by: David Malcolm
---
On Tue, 2022-08-09 at 13:16 +0530, Immad Mir wrote:
> This patch fixes the ICE caused by valid_to_unchecked_state,
> at analyzer/sm-fd.cc by handling the m_start state in
> check_for_dup.
>
> Tested lightly on x86_64.
>
> gcc/analyzer/ChangeLog:
> PR analyzer/106551
> * sm-fd.cc
This patch adds a new warning to -fanalyzer for jumps through NULL
function pointers.
Successfully bootstrapped & regrtested on x86_64-pc-linux-gnu.
Pushed to trunk as r13-1979-ge1a9168153d2bf.
gcc/analyzer/ChangeLog:
PR analyzer/105947
* analyzer.opt
On Tue, 2022-08-02 at 22:08 +0530, Mir Immad wrote:
> The above patch is bootstrapped, lightly tested (on x86_64 Linux) and
> approved for trunk by David.
For reference, Immad sent that version to me off-list to me for review,
and I approved it.
He's committed it to trunk now (as
This adds a clarifying "note" to address space mismatch diagnostics.
For example, it improves the diagnostic for
gcc.target/i386/addr-space-typeck-2.c from:
addr-space-typeck-2.c: In function 'test_bad_call':
addr-space-typeck-2.c:12:22: error: passing argument 2 of 'expects_seg_gs'
from
Pushed to trunk as r13-1921-gffd12be1394a49.
gcc/ChangeLog:
* doc/invoke.texi (-Wanalyzer-putenv-of-auto-var): Fix copy
error.
Signed-off-by: David Malcolm
---
gcc/doc/invoke.texi | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/gcc/doc/invoke.texi
On Fri, 2022-07-29 at 21:59 +0530, Immad Mir wrote:
> This patch extends the state machine in sm-fd.cc to support
> creat, dup, dup2 and dup3 functions.
Thanks for the patch.
Please can you use PR 106298 for this (in the ChangeLog and subject
line), rather than 106300, as it's more specific.
Successfully bootstrapped & regrtested on x86_64-pc-linux-gnu.
Pushed to trunk as r13-1879-g9cac6811cf0d6c.
gcc/analyzer/ChangeLog:
* region.h: Add notes to the comment describing the region
class hierarchy.
Signed-off-by: David Malcolm
---
gcc/analyzer/region.h | 52
This patch implements a new -fanalyzer warning:
-Wanalyzer-putenv-of-auto-var
which complains about stack pointers passed to putenv(3) calls, as
per SEI CERT C Coding Standard rule POS34-C ("Do not call putenv() with
a pointer to an automatic variable as the argument").
For example, given:
Successfully bootstrapped & regrtested on x86_64-pc-linux-gnu.
Pushed to trunk as r13-1880-g9c60338061bf36.
gcc/analyzer/ChangeLog:
* sm-malloc.cc (free_of_non_heap::emit): Add comment about CWE.
* sm-taint.cc (tainted_size::emit): Likewise.
gcc/ChangeLog:
*
Successfully bootstrapped & regrtested on x86_64-pc-linux-gnu.
Pushed to trunk as r13-1878-gb8ce0c4361c267.
gcc/jit/ChangeLog:
* docs/internals/index.rst: Remove reference to ".c" extensions
of source files.
Signed-off-by: David Malcolm
---
gcc/jit/docs/internals/index.rst | 3
I've backported the following patches to the releases/gcc-12 branch:
r12-8631-g1321183a13540b:
"analyzer: add .fpath.txt dumps to -fdump-analyzer-feasibility"
from r13-6-gd8586b00dd00a1783862da5f0c8811a740400074
r12-8632-g05530fcea07a9e:
"analyzer: handle repeated accesses after init of
On Wed, 2022-07-27 at 14:40 +0100, herron.philip--- via Gcc-patches
wrote:
> This is the initial version 1 patch set for the Rust front-end. There
> are more changes that need to be extracted out for all the target
> hooks we have implemented. The goal is to see if we are implementing
> the target
Successfully bootstrapped & regrtested on x86_64-pc-linux-gnu.
Pushed to trunk as r13-1848-gdb613e8fa84125.
gcc/analyzer/ChangeLog:
PR analyzer/106319
* store.cc (store::set_value): Don't strip away casts if the
region has NULL type.
gcc/testsuite/ChangeLog:
PR
These were copy errors.
Successfully bootstrapped & regrtested on x86_64-pc-linux-gnu.
Pushed to trunk as r13-1847-g0460ba622e833d.
gcc/analyzer/ChangeLog:
* region.h (code_region::get_element): Remove stray decl.
(function_region::get_element): Likewise.
Signed-off-by: David
On Tue, 2022-07-26 at 22:07 +0530, Immad Mir wrote:
> This patch adds get_meaning_for_state_change vfunc to
> fd_diagnostic in sm-fd.cc which could be used by SARIF output.
>
> Lightly tested on x86_64 Linux.
Thanks - looks good for trunk.
Dave
On Tue, 2022-07-26 at 06:55 +0200, Martin Liška wrote:
> gcc/jit/ChangeLog:
>
> * docs/index.rst: Remove reference to module index
> as we don't emit any.
Patch is OK
Thanks
Dave
> ---
> gcc/jit/docs/index.rst | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git
On Tue, 2022-07-26 at 06:50 +0200, Martin Liška wrote:
> On 7/26/22 00:41, David Malcolm wrote:
> > On Mon, 2022-07-25 at 14:39 +0200, Martin Liska wrote:
> > > gcc/jit/ChangeLog:
> > >
> > > * docs/cp/intro/tutorial02.rst: Use :expr:`type *` for
> > > pointers to a type
> > > *
On Tue, 2022-07-26 at 06:48 +0200, Martin Liška wrote:
> On 7/26/22 00:37, David Malcolm wrote:
> > On Mon, 2022-07-25 at 11:03 +0200, Martin Liska wrote:
> > > Use expression that work fine for basic type.
> >
> > What's the motivation for this change? Surely the things being
> > marked
> > up
On Tue, 2022-07-26 at 08:42 +0200, Martin Liška wrote:
> Shorten the assembly example so that there is not slider.
>
> Ready for master?
OK, thanks
Dave
On Sat, 2022-07-23 at 13:31 +0530, Vibhav Pant via Jit wrote:
> The macro definition for LIBGCCJIT_HAVE_gcc-jit_context_new_bitcast
> was earlier located in the documentation comment for
> gcc_jit_context_new_bitcast, making it unavailable to code that
> consumed libgccjit.h. This patch moves the
On Mon, 2022-07-25 at 14:39 +0200, Martin Liska wrote:
> gcc/jit/ChangeLog:
>
> * docs/cp/intro/tutorial02.rst: Use :expr:`type *` for
> pointers to a type
> * docs/cp/topics/asm.rst: Likewise.
> * docs/cp/topics/contexts.rst: Likewise.
> *
On Mon, 2022-07-25 at 12:35 +0200, Martin Liska wrote:
> Use rather list-table that is easible to maintainer and one
> does not have to wrap lines. Moreover, it provides great
> attribute :widths: that correctly works (tested for HTML and PDF).
>
> gcc/jit/ChangeLog:
>
> *
On Mon, 2022-07-25 at 11:51 +0200, Martin Liska wrote:
> gcc/jit/ChangeLog:
>
> * docs/cp/topics/expressions.rst: Compact so that the
> generated
> output is also more compact.
OK; thanks
Dave
On Mon, 2022-07-25 at 11:15 +0200, Martin Liska wrote:
> gcc/jit/ChangeLog:
>
> * docs/cp/intro/tutorial02.rst: Use proper reference.
> * docs/cp/topics/contexts.rst: Likewise.
> * docs/cp/topics/functions.rst: Put `class` directive before
> a
> function as it is
On Mon, 2022-07-25 at 11:03 +0200, Martin Liska wrote:
> Use expression that work fine for basic type.
What's the motivation for this change? Surely the things being marked
up are types, rather than expressions?
Dave
>
> gcc/jit/ChangeLog:
>
> * docs/cp/topics/expressions.rst: Use
On Mon, 2022-07-25 at 10:52 +0200, Martin Liska wrote:
> gcc/jit/ChangeLog:
>
> * docs/conf.py: Add needs_sphinx = '3.0' where c:type was
> added.
Looking at the footer of https://gcc.gnu.org/onlinedocs/jit/index.html
I see we currently only have sphinx 1.7.6 installed.
Have you been
On Mon, 2022-07-25 at 08:44 +0200, Martin Liška wrote:
> Hi.
>
> First, thanks Mir for your contribution. The following patch
> addresses
> coding style issues I let you know in:
> https://gcc.gnu.org/bugzilla/show_bug.cgi?id=106003#c3
>
> Most notably, I converted Windows endlines to Unix
On Mon, 2022-07-25 at 08:45 +0200, Martin Liška wrote:
> Ready for master?
Yes, thanks.
Dave
> Thanks,
> Martin
>
> gcc/testsuite/ChangeLog:
>
> * gcc.dg/analyzer/fd-2.c: Convert Windows endlines to Unix
> style.
> * gcc.dg/analyzer/fd-3.c: Likewise.
> *
On Sat, 2022-07-23 at 22:08 +0530, Immad Mir wrote:
> This patch adds get_meaning_for_state_change vfunc to
> fd_diagnostic in sm-fd.cc which could be used by SARIF output.
>
> Lightly tested in x86_64 Linux.
>
> gcc/analyzer/ChangeLog:
> PR analyzer/106286
> * sm-fd.cc:
>
Fix state explosion on va_arg when the call to va_start is in the
top-level function of the analysis.
Successfully bootstrapped & regrtested on x86_64-pc-linux-gnu.
Pushed to trunk as r13-1807-g6d5194a10dc103.
gcc/analyzer/ChangeLog:
PR analyzer/106413
* varargs.cc
Successfully bootstrapped & regrtested on x86_64-pc-linux-gnu.
Pushed to trunk as r13-1806-g0fb35a45a28c67.
gcc/analyzer/ChangeLog:
PR analyzer/106401
* store.cc (binding_cluster::binding_cluster): Remove overzealous
assertion; we're checking for tracked_p in
On Fri, 2022-07-22 at 21:25 +0530, Immad Mir wrote:
> This patch adds three new function attributes to GCC that
> are used for static analysis of usage of file descriptors:
>
> 1) __attribute__ ((fd_arg(N))): The attributes may be applied to a
> function that
> takes an open file descriptor at
On Thu, 2022-07-21 at 18:35 -0700, skpan...@sc.intel.com wrote:
> On Linux/x86_64,
>
> b852aa7f265424c8e2036899da5d8306ff06a16c is the first bad commit
> commit b852aa7f265424c8e2036899da5d8306ff06a16c
> Author: David Malcolm
> Date: Thu Jul 21 17:29:26 2022 -0400
>
> analyzer: fix
On Fri, 2022-07-22 at 16:27 +0200, Tim Lange wrote:
> This patch unifies the handling of zero capacity regions for structs
> and other types in the allocation size checker.
> Regression-tested on x86_64 Linux.
Thanks; looks good for trunk.
Dave
Successfully bootstrapped & regrtested on x86_64-pc-linux-gnu.
Pushed to trunk as r13-1786-gb852aa7f265424.
gcc/analyzer/ChangeLog:
PR analyzer/106383
* varargs.cc (region_model::impl_call_va_arg): When determining if
we're doing interprocedural analysis, use the stack
Successfully bootstrapped & regrtested on x86_64-pc-linux-gnu.
Pushed to trunk as r13-1774-g742377ed0f0931.
gcc/analyzer/ChangeLog:
* sm-taint.cc (tainted_array_index::emit): Bulletproof against
NULL m_arg.
(tainted_array_index::describe_final_event): Likewise.
301 - 400 of 1147 matches
Mail list logo
