Re: State of AutoFDO in GCC

2021-04-26 Thread Xinliang David Li via Gcc
On Mon, Apr 26, 2021 at 11:00 AM Andi Kleen wrote: > >There are multiple directional changes in this new tool: > >1) it uses perf-script trace output (in text) as input profile data; > > I suspect this will break regularly too > > (I personally did numerous changes to perf script output,

Re: State of AutoFDO in GCC

2021-04-26 Thread Xinliang David Li via Gcc
On Mon, Apr 26, 2021 at 8:12 AM Andi Kleen wrote: > Jan Hubicka writes: > > > > Is there a way to get this working w/o using older perf? > > It's usually rather simple to fix up autofdo for new perf. > I did it before here > > https://github.com/andikleen/autofdo/commits/perf4-3 > > I think it

Re: State of AutoFDO in GCC

2021-04-25 Thread Xinliang David Li via Gcc
On Sun, Apr 25, 2021 at 12:07 PM Jan Hubicka wrote: > David, > > > > The text format is documented here: > > https://clang.llvm.org/docs/UsersManual.html > > The binary format is not documented. The binary format is not guaranteed > to > > be backward compatible, so sharing the same format may

Re: State of AutoFDO in GCC

2021-04-23 Thread Xinliang David Li via Gcc
On Fri, Apr 23, 2021 at 12:28 PM Jan Hubicka wrote: > > On Fri, Apr 23, 2021 at 10:27 AM Xinliang David Li > > wrote: > > > > > > > > > > > On Fri, Apr 23, 2021 at 10:16 AM Jan Hubicka wrote: > > > > > >> > > > >> > It uses create_llvm_prof tool which is in the same git repo. The > data > > >>

Re: State of AutoFDO in GCC

2021-04-23 Thread Xinliang David Li via Gcc
On Fri, Apr 23, 2021 at 10:27 AM Xinliang David Li wrote: > > > On Fri, Apr 23, 2021 at 10:16 AM Jan Hubicka wrote: > >> > >> > It uses create_llvm_prof tool which is in the same git repo. The data >> > parsing part is shared with create_gcov, but the writer is obviously >> > different for the

Re: State of AutoFDO in GCC

2021-04-23 Thread Xinliang David Li via Gcc
On Fri, Apr 23, 2021 at 10:16 AM Jan Hubicka wrote: > > > > It uses create_llvm_prof tool which is in the same git repo. The data > > parsing part is shared with create_gcov, but the writer is obviously > > different for the two tools. > > OK and what are the main differences between llvmand gcc

Re: State of AutoFDO in GCC

2021-04-23 Thread Xinliang David Li via Gcc
On Fri, Apr 23, 2021 at 9:54 AM Jan Hubicka wrote: > > On Fri, Apr 23, 2021 at 12:18 AM Martin Liška wrote: > > > > > On 4/23/21 9:00 AM, Richard Biener via Gcc wrote: > > > > On Fri, Apr 23, 2021 at 7:28 AM Xinliang David Li via Gcc > > > > wrot

Re: State of AutoFDO in GCC

2021-04-23 Thread Xinliang David Li via Gcc
On Fri, Apr 23, 2021 at 12:18 AM Martin Liška wrote: > On 4/23/21 9:00 AM, Richard Biener via Gcc wrote: > > On Fri, Apr 23, 2021 at 7:28 AM Xinliang David Li via Gcc > > wrote: > >> > >> Hi, the create_gcov tool was probably removed with the assumption that &g

Re: State of AutoFDO in GCC

2021-04-23 Thread Xinliang David Li via Gcc
On Fri, Apr 23, 2021 at 12:00 AM Richard Biener wrote: > On Fri, Apr 23, 2021 at 7:28 AM Xinliang David Li via Gcc > wrote: > > > > Hi, the create_gcov tool was probably removed with the assumption that it > > was only used with Google GCC branch, but it is actually

Re: State of AutoFDO in GCC

2021-04-22 Thread Xinliang David Li via Gcc
Hi, the create_gcov tool was probably removed with the assumption that it was only used with Google GCC branch, but it is actually used with GCC trunk as well. Given that, the tool will be restored in the github repo. It seems to build and work fine with the regression test. The tool may ust