Re: [RFC] -Weverything

2019-01-28 Thread Segher Boessenkool
On Sun, Jan 27, 2019 at 01:19:08PM -0800, Andrew Pinski wrote: > On Sun, Jan 27, 2019 at 1:02 PM Thomas König wrote: > > > > Am 27.01.19 um 21:52 schrieb Steve Kargl: > > > > > In fact, I would be in favor of removing -Wall, as it is misnamed, > > > in favor of -Wlevel=0,1,2,3... -Wlevel=0 defaul

Re: [RFC] -Weverything

2019-01-28 Thread N.M. Maclaren
On Jan 27 2019, Steve Kargl wrote: On Sun, Jan 27, 2019 at 01:19:08PM -0800, Andrew Pinski wrote: On Sun, Jan 27, 2019 at 1:02 PM Thomas König wrote: > > > In fact, I would be in favor of removing -Wall, as it is misnamed, > > in favor of -Wlevel=0,1,2,3... -Wlevel=0 default warnings. > > -Wle

Re: [RFC] -Weverything

2019-01-27 Thread Steve Kargl
On Sun, Jan 27, 2019 at 01:19:08PM -0800, Andrew Pinski wrote: > On Sun, Jan 27, 2019 at 1:02 PM Thomas König wrote: > > > > Am 27.01.19 um 21:52 schrieb Steve Kargl: > > > > > In fact, I would be in favor of removing -Wall, as it is misnamed, > > > in favor of -Wlevel=0,1,2,3... -Wlevel=0 defaul

Re: [RFC] -Weverything

2019-01-27 Thread Andrew Pinski
On Sun, Jan 27, 2019 at 1:02 PM Thomas König wrote: > > Am 27.01.19 um 21:52 schrieb Steve Kargl: > > > In fact, I would be in favor of removing -Wall, as it is misnamed, > > in favor of -Wlevel=0,1,2,3... -Wlevel=0 default warnings. > > -Wlevel=1 is equivalent to -Wall. -Wlevel=2 is -Wall -Wext

Re: [RFC] -Weverything

2019-01-27 Thread Thomas König
Am 27.01.19 um 21:52 schrieb Steve Kargl: In fact, I would be in favor of removing -Wall, as it is misnamed, in favor of -Wlevel=0,1,2,3... -Wlevel=0 default warnings. -Wlevel=1 is equivalent to -Wall. -Wlevel=2 is -Wall -Wextra (and maybe -Wsurprising). ... and -Wlevel=3 could then be -Wkit

Re: [RFC] -Weverything

2019-01-27 Thread Steve Kargl
On Sun, Jan 27, 2019 at 08:34:57PM +, Jonathan Wakely wrote: > On Sun, 27 Jan 2019 at 13:56, N.M. Maclaren wrote: > > > > So I think that there is a strong argument for such an option in gfortran, > > irrespective of whether there is for gcc and g++. > > Then -Wall should enable them for Fort

Re: [RFC] -Weverything

2019-01-27 Thread Jonathan Wakely
On Sun, 27 Jan 2019 at 13:56, N.M. Maclaren wrote: > > On Jan 23 2019, Thomas König wrote: > > > >> Am 23.01.2019 um 12:36 schrieb Jonathan Wakely : > >> > >> When there are new warnings that aren't enabled by -Wall -Wextra, > >> there's probably a reason they aren't enabled by default. > >are a h

Re: [RFC] -Weverything

2019-01-27 Thread N.M. Maclaren
On Jan 23 2019, Thomas König wrote: Am 23.01.2019 um 12:36 schrieb Jonathan Wakely : When there are new warnings that aren't enabled by -Wall -Wextra, there's probably a reason they aren't enabled by default. are a higher form of life than mere Fortran -Wconversion-extra is an example of suc

Re: [RFC] -Weverything

2019-01-23 Thread Paul Richard Thomas
Hi Thomas, Thanks for initiating this discussion. The responses are very useful. That said, wouldn't a -ffix-everything option be more useful? :-) Cheers Paul On Wed, 23 Jan 2019 at 13:27, Thomas König wrote: > > > > > Am 23.01.2019 um 12:36 schrieb Jonathan Wakely : > > > > When there are ne

Re: [RFC] -Weverything

2019-01-23 Thread Thomas König
> Am 23.01.2019 um 12:36 schrieb Jonathan Wakely : > > When there are new warnings that aren't enabled by -Wall -Wextra, > there's probably a reason they aren't enabled by default. -Wconversion-extra is an example of such a warning. It catches a very common error people make in Fortran, see

Re: [RFC] -Weverything

2019-01-23 Thread Jonathan Wakely
On Wed, 23 Jan 2019 at 11:21, Franz Sirl wrote: > The LLVM devs may hate it, but as maintainer of a multi-platform > multi-compiler automated build framework I _love_ -Weverything. It's > much easier to handle a compiler upgrade this way without missing any > new warnings not enabled by -Wall -Wext

Re: [RFC] -Weverything

2019-01-23 Thread Franz Sirl
Am 2019-01-22 um 19:56 schrieb Jonathan Wakely: On Tue, 22 Jan 2019 at 18:46, Marc Glisse wrote: On Tue, 22 Jan 2019, Thomas Koenig wrote: Hi, What would people think about a -Weverything option which turns on every warning there is? I think that could be quite useful in some circumstances

Re: [RFC] -Weverything

2019-01-23 Thread Jonathan Wakely
On Wed, 23 Jan 2019 at 07:17, Thomas König wrote: > > > > Am 23.01.2019 um 01:53 schrieb Martin Sebor : > > > I often wish GCC supported it -- not in the hopes of finding every > > conceivable bug or transgression against known coding styles but > > as a tool to discover warnings that have to be

Re: [RFC] -Weverything

2019-01-23 Thread Marc Glisse
On Wed, 23 Jan 2019, Jakub Jelinek wrote: We have that, gcc -Q --help=warning Of course, for warnings which do require arguments (numerical, or enumeration/string), one still needs to pick up his choices of those arguments; no idea what -Weverything would do here, while some warnings have differ

Re: [RFC] -Weverything

2019-01-22 Thread Jakub Jelinek
On Wed, Jan 23, 2019 at 08:17:00AM +0100, Thomas König wrote: > > > > Am 23.01.2019 um 01:53 schrieb Martin Sebor : > > > I often wish GCC supported it -- not in the hopes of finding every > > conceivable bug or transgression against known coding styles but > > as a tool to discover warnings tha

Re: [RFC] -Weverything

2019-01-22 Thread Thomas König
> Am 23.01.2019 um 01:53 schrieb Martin Sebor : > I often wish GCC supported it -- not in the hopes of finding every > conceivable bug or transgression against known coding styles but > as a tool to discover warnings that have to be explicitly enabled > either by using their own options or by s

Re: [RFC] -Weverything

2019-01-22 Thread Martin Sebor
On 1/22/19 11:34 AM, Thomas Koenig wrote: Hi, What would people think about a -Weverything option which turns on every warning there is? I think that could be quite useful in some circumstances, especially to find potential bugs with warnings that people, for some reason or other, found too noi

Re: [RFC] -Weverything

2019-01-22 Thread Jeffrey Walton
On Tue, Jan 22, 2019 at 1:35 PM Thomas Koenig wrote: > > What would people think about a -Weverything option which turns on > every warning there is? I tried to use -Weverything on a C++ project with about 350 source files. It was a failed experiment. It created too much noise to be useful. Your

Re: [RFC] -Weverything

2019-01-22 Thread Jonathan Wakely
On Tue, 22 Jan 2019 at 18:56, Jonathan Wakely wrote: > > On Tue, 22 Jan 2019 at 18:46, Marc Glisse wrote: > > > > On Tue, 22 Jan 2019, Thomas Koenig wrote: > > > > > Hi, > > > > > > What would people think about a -Weverything option which turns on > > > every warning there is? > > > > > > I thin

Re: [RFC] -Weverything

2019-01-22 Thread Jonathan Wakely
On Tue, 22 Jan 2019 at 18:46, Marc Glisse wrote: > > On Tue, 22 Jan 2019, Thomas Koenig wrote: > > > Hi, > > > > What would people think about a -Weverything option which turns on > > every warning there is? > > > > I think that could be quite useful in some circumstances, especially > > to find p

Re: [RFC] -Weverything

2019-01-22 Thread Marc Glisse
On Tue, 22 Jan 2019, Thomas Koenig wrote: Hi, What would people think about a -Weverything option which turns on every warning there is? I think that could be quite useful in some circumstances, especially to find potential bugs with warnings that people, for some reason or other, found too no

[RFC] -Weverything

2019-01-22 Thread Thomas Koenig
Hi, What would people think about a -Weverything option which turns on every warning there is? I think that could be quite useful in some circumstances, especially to find potential bugs with warnings that people, for some reason or other, found too noisy for -Wextra. The name could be somethin