RE: resolving backslash newline whisky tango foxtrot: a proposal

2005-11-01 Thread Dave Korn
Per Bothner wrote: Joe Buck wrote: So you want the compiler to only consider '\\$ a continuation, Not my preference, but that is my proposal, in the interest of compatibility. but to have an unsilenceable warning about '\\ *$'? Not unsilenceable - but on-by-default. It could be

Re: resolving backslash newline whisky tango foxtrot: a proposal

2005-11-01 Thread Per Bothner
Dave Korn wrote: Per, please. We've been through these ***exact*** interchanges before. You're now just reiterating the entire thread. You aren't adding anything new, I didn't see my specific proposal ('\\' follow by space is not a line continuation *and* an improved -Wcomment defaults to on

RE: resolving backslash newline whisky tango foxtrot: a proposal

2005-11-01 Thread Dave Korn
Per Bothner wrote: Dave Korn wrote: Per, please. We've been through these ***exact*** interchanges before. You're now just reiterating the entire thread. You aren't adding anything new, I didn't see my specific proposal ('\\' follow by space is not a line continuation *and* an improved

Re: resolving backslash newline whisky tango foxtrot: a proposal

2005-11-01 Thread Joe Buck
On Tue, Nov 01, 2005 at 06:28:21PM -, Dave Korn wrote: Per Bothner wrote: Dave Korn wrote: Per, please. We've been through these ***exact*** interchanges before. You're now just reiterating the entire thread. You aren't adding anything new, I didn't see my specific proposal

Re: resolving backslash newline whisky tango foxtrot: a proposal

2005-10-31 Thread Joe Buck
On Sat, Oct 29, 2005 at 03:45:33AM -0700, Per Bothner wrote: Rather than adding new flags, I'd think I'd prefer: 1. Change the behavior (back) so only '\\$', not '\\ *$', causes a line to be continued. 2. Make -Wcomment more useful to it only warns when it might matter: The following

Re: resolving backslash newline whisky tango foxtrot: a proposal

2005-10-31 Thread Per Bothner
Joe Buck wrote: On Sat, Oct 29, 2005 at 03:45:33AM -0700, Per Bothner wrote: 1. Change the behavior (back) so only '\\$', not '\\ *$', causes a line to be continued. The problem with your item #1 is that there is then no way of flagging code that won't work with the large numbers of

Re: resolving backslash newline whisky tango foxtrot: a proposal

2005-10-31 Thread Joe Buck
On Mon, Oct 31, 2005 at 11:35:45AM -0800, Per Bothner wrote: Joe Buck wrote: On Sat, Oct 29, 2005 at 03:45:33AM -0700, Per Bothner wrote: 1. Change the behavior (back) so only '\\$', not '\\ *$', causes a line to be continued. The problem with your item #1 is that there is then no way

Re: resolving backslash newline whisky tango foxtrot: a proposal

2005-10-31 Thread Per Bothner
Joe Buck wrote: So you want the compiler to only consider '\\$ a continuation, Not my preference, but that is my proposal, in the interest of compatibility. but to have an unsilenceable warning about '\\ *$'? Not unsilenceable - but on-by-default. It could be silenced with an explicit

Re: resolving backslash newline whisky tango foxtrot: a proposal

2005-10-29 Thread Per Bothner
Rather than adding new flags, I'd think I'd prefer: 1. Change the behavior (back) so only '\\$', not '\\ *$', causes a line to be continued. 2. Make -Wcomment more useful to it only warns when it might matter: The following line contains non-comment whitespace. 3. Make -Wcomment the

Re: resolving backslash newline whisky tango foxtrot: a proposal

2005-10-29 Thread Gabriel Dos Reis
Per Bothner [EMAIL PROTECTED] writes: | Rather than adding new flags, I'd think I'd prefer: | | 1. Change the behavior (back) so only '\\$', not '\\ *$', causes a | line to be continued. | 2. Make -Wcomment more useful to it only warns when it might matter: | The following line contains

Re: resolving backslash newline whisky tango foxtrot: a proposal

2005-10-28 Thread Mark Mitchell
Joe Buck wrote: So the amended suggestion is to fix -Wcomment to shut up about continued comments that don't matter, and also to add the new -f option to switch the handling of spaces-at-the-end. I think your proposal, as amended, is the right approach. I generally don't much like new

Re: resolving backslash newline whisky tango foxtrot: a proposal

2005-10-28 Thread Mike Stump
On Oct 27, 2005, at 3:48 PM, Gabriel Dos Reis wrote: | // this is a continued comment \ | // but who cares, because this is a comment too | % gcc -Wall -c foo.C | foo.C:1:1: warning: multi-line comment | Perhaps the thing to do is to fix -Wcomment to eliminate the noise, | so it will be

resolving backslash newline whisky tango foxtrot: a proposal

2005-10-27 Thread Joe Buck
Daniel was right in that the discussion has degenerated. So, here's a concrete proposal. Think of it as a start on a documentation patch. Since there is no consensus, it seems that the right solution is to have options. I think that the following concept can solve the problems.

Re: resolving backslash newline whisky tango foxtrot: a proposal

2005-10-27 Thread Andrew Pinski
-Wcontinued-cpp-comment Warn if there is a C++-style comment that is continued by a backslash at the end of the line, and the following line contains something other than whitespace and comments. The current setting of -f{no-}eol-whitespace-strip is used to decide what is a

Re: resolving backslash newline whisky tango foxtrot: a proposal

2005-10-27 Thread Eric Christopher
I'm good with this proposal. I was against the flag in the first place for a desire to pick something and let's do that, but it seems like with so much furor over it we should probably just have a flag. :) -eric

Re: resolving backslash newline whisky tango foxtrot: a proposal

2005-10-27 Thread Joe Buck
-Wcontinued-cpp-comment Warn if there is a C++-style comment that is continued by a backslash at the end of the line, and the following line contains something other than whitespace and comments. The current setting of -f{no-}eol-whitespace-strip is used to decide what is a

Re: resolving backslash newline whisky tango foxtrot: a proposal

2005-10-27 Thread Gabriel Dos Reis
Joe Buck [EMAIL PROTECTED] writes: | -Wcontinued-cpp-comment | | Warn if there is a C++-style comment that is continued by a backslash at | the end of the line, and the following line contains something other | than whitespace and comments. The current setting of |