Re: [patch, fortran] Eliminate duplicate function calls with rank>0 and unknown shape

2011-05-13 Thread Jerry DeLisle
On 05/01/2011 02:49 AM, Thomas Koenig wrote: Hello world, after Paul's fix for allocate on assignment (thanks Paul!), here is a patch for the original test case from PR 22572, where the bounds of the function are unknown at compile time. This uses an allocatable temporary. In the long run, anot

Re: [patch, fortran] Eliminate duplicate function calls with rank>0 and unknown shape

2011-05-13 Thread Steve Kargl
On Fri, May 13, 2011 at 10:18:57PM +0200, Thomas Koenig wrote: > Am 03.05.2011 22:12, schrieb Thomas Koenig: > >Am 01.05.2011 11:49, schrieb Thomas Koenig: > >>Hello world, > >> > >>after Paul's fix for allocate on assignment (thanks Paul!), here is a > >>patch for the original test case from PR 22

Re: [Patch, Fortran] Fixes for scalar coarrays

2011-05-13 Thread Steve Kargl
On Sat, May 07, 2011 at 07:21:14AM +0200, Tobias Burnus wrote: > The interface.c patch is to avoid a strange error ("actual argument must > be simply contiguous") which is a bit odd if the actual argument is a > scalar. As the dummy was an array, a rank mismatch would have been the > proper erro

Re: [Patch, libfortran] PR 48915 Fix incorrect return code with -fdump-core, error handling changes

2011-05-13 Thread Steve Kargl
On Sat, May 07, 2011 at 10:52:13PM +0300, Janne Blomqvist wrote: > > this simple bug led me to rethink normal and error termination and > thus the patch changes some other related stuff as well. So the > original problem was that when -fdump-core was enabled, STOP with a > numeric stop code made t

Re: [Patch, libfortran] Thread safety and simplification of error printing

2011-05-13 Thread Steve Kargl
On Sun, May 08, 2011 at 07:53:43PM +0300, Janne Blomqvist wrote: > > 2011-05-08 Janne Blomqvist > > * gfortran.texi: Remove GFORTRAN_USE_STDERR documentation. > > > library ChangeLog: > > 2011-05-08 Janne Blomqvist > > * io/unix.c (st_vprintf,st_printf): Move to runtime/erro

Re: [Patch, Fortran] PR 48961 - Fix EXECUTE_COMMAND_LINE w/ wait=.false. for non-fork systems

2011-05-13 Thread Steve Kargl
On Thu, May 12, 2011 at 12:23:36AM +0200, Tobias Burnus wrote: > The attached patch fixes three issues: > > a) If fork() is not supported, CMDSTAT is -2 (as required by the > standard) - and everything is executed synchronously. However, > set_cmdstat will abort if the cmdstat value is not 0. >

Re: [PATCH] C++0x, implement final on classes

2011-05-13 Thread Ville Voutilainen
At Fri, 13 May 2011 14:13:52 -0400, Jason Merrill wrote: > Yes, the order affects the handling of > struct Undeclared final { }; > Add the error after the call to cp_parser_commit_to_tentative_parse, at > which point we've decided that we're dealing with a class definition. Here's a new patch. Ho

Go patch committed: Fix bug with multiple results

2011-05-13 Thread Ian Lance Taylor
This patch to the Go frontend fixes a bug in which a function returns multiple results and at least one of those results is a named struct. For multiple results the Go frontend builds a struct. In some cases the function type may be built before the named struct type is completed, in which case th

Re: [patch gimplifier]: Make sure TRUTH_NOT_EXPR has boolean_type_node type and argument

2011-05-13 Thread Eric Botcazou
kg.adb:23:1: error: type mismatch in binary truth expression boolean boolean boolean D.2419_18 = D.2417_16 || D.2418_17; +===GNAT BUG DETECTED==+ | 4.7.0 20110513 (experimental) [trunk revision 173737] (i586-suse-linux-gnu) GCC error:| | verify_gi

Re: [patch] Split Parse Timevar (rev 2) (issue4433076)

2011-05-13 Thread Lawrence Crowl
On 5/13/11, Jason Merrill wrote: > I'm applying this patch to fix a crash that I get when running cc1plus > directly without -quiet; all the other TV_OVERLOAD bits use > timevar_cond_*, so it seems that these should too. > > Tested x86_64-pc-linux-gnu, applying to trunk. Looks good to me. -- La

Re: [patch] Split Parse Timevar (rev 2) (issue4433076)

2011-05-13 Thread Jason Merrill
I'm applying this patch to fix a crash that I get when running cc1plus directly without -quiet; all the other TV_OVERLOAD bits use timevar_cond_*, so it seems that these should too. Tested x86_64-pc-linux-gnu, applying to trunk. commit 8de1530fc6ca07e3ca37ff7689c65931025d9f0d Author: Jason Mer

C++ PATCH for c++/48969 (infinite template recursion with enum scope)

2011-05-13 Thread Jason Merrill
In C++0x there are a couple of ways for a function signature to depend on itself, leading to infinite recursion in substitution during template argument deduction. This patch adds checking for that. My initial implementation used a VEC to keep track of current deductions in process, but I swi

Re: [PATCH] Fix PR46728 (move pow/powi folds to tree phases)

2011-05-13 Thread William J. Schmidt
On Fri, 2011-05-13 at 10:52 -0500, William J. Schmidt wrote: > On Fri, 2011-05-13 at 17:26 +0200, Richard Guenther wrote: -- snip -- > > > > The position of the pass is odd - why did you place it there? I would > > have placed it alongside pass_cse_sincos and pass_optimize_bswap. > > That was

Re: [Patch, Fortran] Reject non-default-kind characters as flags to I/O statements

2011-05-13 Thread H.J. Lu
On Thu, May 12, 2011 at 2:56 PM, Tobias Burnus wrote: > The patch is a correctness issue as the Fortran standard has those as > constraints - and the results of passing kind=4 strings is also odd ... > > I used also the chance to resolve INQUIRE's decimal ... > > Build and partially regtested on x

Re: C6X port 12/11: htdocs

2011-05-13 Thread Gerald Pfeifer
On Fri, 13 May 2011, Bernd Schmidt wrote: >> I forgot about it in my previous message, but there should be a release >> note in gcc-4.7/changes.html as well. > New version below. This looks good, thank you! If you later want to refer to that part of the release notes directly, you could write

Re: [patch, fortran] Eliminate duplicate function calls with rank>0 and unknown shape

2011-05-13 Thread Thomas Koenig
Am 03.05.2011 22:12, schrieb Thomas Koenig: Am 01.05.2011 11:49, schrieb Thomas Koenig: Hello world, after Paul's fix for allocate on assignment (thanks Paul!), here is a patch for the original test case from PR 22572, where the bounds of the function are unknown at compile time. This uses an a

Minor tweaks

2011-05-13 Thread Eric Botcazou
The attached patch contains 3 minor tweaks: 1. Jeff moved a dump message in cfg_layout_redirect_edge_and_branch up to before the call to redirect_edge_succ_nodup. So the "redirected" is not fully true anymore and can be confusing since the call to redirect_edge_succ_nodup can dump messages t

Re: [C++0x] contiguous bitfields race implementation

2011-05-13 Thread Aldy Hernandez
On 05/09/11 14:23, Jason Merrill wrote: From a quick look it seems that this patch considers bitfields following the one we're deliberately touching, but not previous bitfields in the same memory location; we need to include those as well. With your struct foo, the bits touched are the same rega

Re: [google] support for building Linux kernel with FDO (issue4523061)

2011-05-13 Thread Rong Xu
Thanks for the comments. This particular patch is not intended for trunk. But we do want to hear your feedback on our designs. On Fri, May 13, 2011 at 9:31 AM, Xinliang David Li wrote: > On Fri, May 13, 2011 at 5:54 AM, Paolo Bonzini wrote: >> On 05/13/2011 03:03 AM, Rong Xu wrote: >>> >>>      

Re: [google] support for building Linux kernel with FDO (issue4523061)

2011-05-13 Thread Rong Xu
Thanks for the comments. This particular patch is not intended for trunk. But we do want to hear your feedback on our designs. On Fri, May 13, 2011 at 9:31 AM, Xinliang David Li wrote: > On Fri, May 13, 2011 at 5:54 AM, Paolo Bonzini wrote: >> On 05/13/2011 03:03 AM, Rong Xu wrote: >>> >>>      

Re: [patch gimplifier]: Make sure TRUTH_NOT_EXPR has boolean_type_node type and argument

2011-05-13 Thread Andrew Pinski
On Fri, May 13, 2011 at 11:24 AM, Kai Tietz wrote: > boolean_types direct). Or B) We relax tree-cfg checks for logical ops > to allow also BOOLEAN types with wider size then 1-bit. The Boolean types which fortran produces are 1bit wide in precision but not always the same width as the C _Bool ty

Re: [patch gimplifier]: Make sure TRUTH_NOT_EXPR has boolean_type_node type and argument

2011-05-13 Thread Kai Tietz
2011/5/13 Kai Tietz : > 2011/5/13 Andrew Pinski : >> On Fri, May 13, 2011 at 4:31 AM, Kai Tietz wrote: >>> >>>     case TRUTH_NOT_EXPR: >>> +      if (!useless_type_conversion_p (boolean_type_node,  rhs1_type) >>> +          || !useless_type_conversion_p (boolean_type_node,  lhs_type)) >> >> In Fo

Re: [PATCH] C++0x, implement final on classes

2011-05-13 Thread Jason Merrill
On 05/13/2011 01:53 PM, Ville Voutilainen wrote: On 13 May 2011 20:46, Jason Merrill wrote: Why did you put this before the invalid template-id check, rather than after? For no particular reason. Is it significant? Yes, the order affects the handling of struct Undeclared final { }; Also,

Re: [PATCH] C++0x, implement final on classes

2011-05-13 Thread Ville Voutilainen
On 13 May 2011 20:46, Jason Merrill wrote: > Why did you put this before the invalid template-id check, rather than > after? For no particular reason. Is it significant? > Also, shouldn't we reject "override" on classes? You can have stuff like struct blah override{}; where struct blah is an e

Re: [PATCH] C++0x, implement final on classes

2011-05-13 Thread Jason Merrill
On 05/13/2011 01:24 PM, Ville Voutilainen wrote: +error ("cannot derive from from final base %qT in derived type %qT", Let's use % here. if (id) -cp_parser_check_for_invalid_template_id (parser, id, -type_start_token->location); +

[PATCH] C++0x, implement final on classes

2011-05-13 Thread Ville Voutilainen
Tested on Linux/X86-32. 2011-05-13 Ville Voutilainen Implement final on class. * class.c (check_bases): Diagnose derivation from a final class. * cp-tree.h (lang_type_class): Add is_final and adjust dummy. * cp-tree.h (CLASSTYPE_FINAL): New. *

Don't let search bots look at buglist.cgi

2011-05-13 Thread Ian Lance Taylor
I noticed that buglist.cgi was taking quite a bit of CPU time. I looked at some of the long running instances, and they were coming from searchbots. I can't think of a good reason for this, so I have committed this patch to the gcc.gnu.org robots.txt file to not let searchbots search through list

Re: [google] support for building Linux kernel with FDO (issue4523061)

2011-05-13 Thread Paolo Bonzini
On 05/13/2011 06:31 PM, Xinliang David Li wrote: > 1) add a new TLS model -ftls-model=none and make the kernel uses it. The > model would simply force targetm.have_tls to false. > This is a good idea. > 2) as Richi mentioned, gcov-io and libgcov changes then can move to the > kernel, and

Re: [PATCH] ARM fixed-point support [6/6]: target-specific parts

2011-05-13 Thread Julian Brown
On Fri, 13 May 2011 14:54:47 + (UTC) "Joseph S. Myers" wrote: > On Fri, 13 May 2011, Julian Brown wrote: > > > although Joseph's comments have (hopefully) all been addressed. One > > must now configure with "--enable-fixed-point" to enable the > > fixed-point support. > > No, that's not how

Re: [google] support for building Linux kernel with FDO (issue4523061)

2011-05-13 Thread Xinliang David Li
On Fri, May 13, 2011 at 5:54 AM, Paolo Bonzini wrote: > On 05/13/2011 03:03 AM, Rong Xu wrote: >> >>        * gcc/coverage.c        (revision 173717): set a flag if building >> for Linux kernel. >>        * gcc/tree-profile.c    (revision 173717): don't emit TLS >> declarations for Linux kernel bu

Re: [patch gimplifier]: Make sure TRUTH_NOT_EXPR has boolean_type_node type and argument

2011-05-13 Thread Kai Tietz
2011/5/13 Andrew Pinski : > On Fri, May 13, 2011 at 4:31 AM, Kai Tietz wrote: >> >>     case TRUTH_NOT_EXPR: >> +      if (!useless_type_conversion_p (boolean_type_node,  rhs1_type) >> +          || !useless_type_conversion_p (boolean_type_node,  lhs_type)) > > In Fortran (and maybe other langauge

RFA: patch to fix PR48633.

2011-05-13 Thread Vladimir Makarov
The patch fixes PR48633 described on http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48633. The patch was successfully bootstrapped on x86-64. Ok to commit? 2011-05-13 Vladimir Makarov PR rtl-optimization/48633 * ira-build.c (loop_with_eh_edge_p): New function. (mark_loo

Re: [patch gimplifier]: Make sure TRUTH_NOT_EXPR has boolean_type_node type and argument

2011-05-13 Thread Andrew Pinski
On Fri, May 13, 2011 at 4:31 AM, Kai Tietz wrote: > >     case TRUTH_NOT_EXPR: > +      if (!useless_type_conversion_p (boolean_type_node,  rhs1_type) > +          || !useless_type_conversion_p (boolean_type_node,  lhs_type)) In Fortran (and maybe other langauges) there are booleans with differen

Re: [patch gimplifier]: Make sure TRUTH_NOT_EXPR has boolean_type_node type and argument

2011-05-13 Thread H.J. Lu
On Fri, May 13, 2011 at 6:38 AM, Kai Tietz wrote: > 2011/5/13 Richard Guenther : >> On Fri, May 13, 2011 at 1:31 PM, Kai Tietz wrote: >>> Hello, >>> >>> this patch adds a check to >>> >>> ChangeLog >>> >>> 2011-05-13  Kai Tietz >>> >>>          * gimplify.c (gimplify_expr): Make sure operand is b

Re: [PATCH] Fix PR46728 (move pow/powi folds to tree phases)

2011-05-13 Thread Nathan Froyd
On 05/13/2011 11:26 AM, Richard Guenther wrote: > On Fri, May 13, 2011 at 5:01 PM, Nathan Froyd > wrote: >> On 05/13/2011 10:52 AM, William J. Schmidt wrote: >>> This patch addresses PR46728, which notes that pow and powi need to be >>> lowered in tree phases to restore lost FMA opportunities and

Re: [google] support for building Linux kernel with FDO (issue4523061)

2011-05-13 Thread Andi Kleen
On Fri, May 13, 2011 at 11:43:42AM +0200, Jan Hubicka wrote: > > On Fri, May 13, 2011 at 6:53 AM, Xinliang David Li > > wrote: > > > Ok for google/main. > > > > Seems to be very special and not appropriate for GCC trunk. Instead > > an adjusted copy providing the interface GCC needs should belo

RFA: patch to fix PR48971

2011-05-13 Thread Vladimir Makarov
The following patch solves the problem described on http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48971 The patch was successfully bootstrapped on x86-64 and checked for ppc64, ia64, i686-linux, i686-apple-darwin, mips, arm, s390x, and sparc with and without -msoft-float. Is it ok to submit to

Re: [PATCH] Fix PR46728 (move pow/powi folds to tree phases)

2011-05-13 Thread William J. Schmidt
On Fri, 2011-05-13 at 17:26 +0200, Richard Guenther wrote: > On Fri, May 13, 2011 at 5:01 PM, Nathan Froyd > wrote: > > On 05/13/2011 10:52 AM, William J. Schmidt wrote: > >> This patch addresses PR46728, which notes that pow and powi need to be > >> lowered in tree phases to restore lost FMA op

Re: [PATCH] Fix PR46728 (move pow/powi folds to tree phases)

2011-05-13 Thread Richard Guenther
On Fri, May 13, 2011 at 5:01 PM, Nathan Froyd wrote: > On 05/13/2011 10:52 AM, William J. Schmidt wrote: >> This patch addresses PR46728, which notes that pow and powi need to be >> lowered in tree phases to restore lost FMA opportunities and expose >> vectorization opportunities. >> >> +struct gi

Re: C6X port 12/11: htdocs

2011-05-13 Thread Bernd Schmidt
On 05/13/2011 04:47 PM, Joseph S. Myers wrote: > I forgot about it in my previous message, but there should be a release > note in gcc-4.7/changes.html as well. New version below. Bernd Index: backends.html === RCS file: /cvs/gcc/w

Re: [PATCH] Fix PR46728 (move pow/powi folds to tree phases)

2011-05-13 Thread Nathan Froyd
On 05/13/2011 10:52 AM, William J. Schmidt wrote: > This patch addresses PR46728, which notes that pow and powi need to be > lowered in tree phases to restore lost FMA opportunities and expose > vectorization opportunities. > > +struct gimple_opt_pass pass_lower_pow = > +{ > + { > + GIMPLE_PASS, >

Re: C6X port 10/11: The port

2011-05-13 Thread Joseph S. Myers
On Fri, 13 May 2011, Bernd Schmidt wrote: > >> +#define PREFERRED_RELOAD_CLASS(x, class) (class) > > > > This macro is being phased out and replaced by a target hook. In general > > any target macro whose only use is in targhooks.c to provide a default > > transitional version of a hook should

Re: [PATCH, ARM] ISO/IEC TR 18037 fixed-point support

2011-05-13 Thread Joseph S. Myers
On Fri, 13 May 2011, Julian Brown wrote: > On Wed, 11 May 2011 15:27:37 + (UTC) > "Joseph S. Myers" wrote: > > > On Wed, 11 May 2011, Julian Brown wrote: > > > > > There's currently no support for "long long" fixed-point types, > > > since those imply support for TImode arithmetic, which is

Re: [PATCH] ARM fixed-point support [6/6]: target-specific parts

2011-05-13 Thread Joseph S. Myers
On Fri, 13 May 2011, Julian Brown wrote: > although Joseph's comments have (hopefully) all been addressed. One > must now configure with "--enable-fixed-point" to enable the > fixed-point support. No, that's not how this configure logic works; it enables fixed point by default for the given targ

Re: C6X port 10/11: The port

2011-05-13 Thread Bernd Schmidt
On 05/13/2011 04:46 PM, Joseph S. Myers wrote: > There shouldn't be lots of errors; Joern does such builds frequently. > Note that you need to start with a *current native trunk compiler* and use > that when building the cross compiler; GCC is only expected to build > cleanly with -Werror when

Re: C6X port 12/11: htdocs

2011-05-13 Thread Joseph S. Myers
I forgot about it in my previous message, but there should be a release note in gcc-4.7/changes.html as well. -- Joseph S. Myers jos...@codesourcery.com

Re: C6X port 10/11: The port

2011-05-13 Thread Joseph S. Myers
On Fri, 13 May 2011, Bernd Schmidt wrote: > On 05/10/2011 09:53 PM, Joseph S. Myers wrote: > > General comment: there are lots of new files here that are built for the > > target, and if possible it's preferable for such sources to be under > > libgcc/config/ with associated build rules also loc

Re: [patch, ARM] Fix PR42017, LR not used in leaf functions

2011-05-13 Thread Richard Sandiford
Richard Sandiford writes: > Chung-Lin Tang writes: >> My fix here simply adds 'reload_completed' as an additional condition >> for EPILOGUE_USES to return true for LR_REGNUM. I think this should be >> valid, as correct LR save/restoring is handled by the epilogue/prologue >> code; it should be sa

Re: Prefixes for libgcc symbols (C6X 9.5/11)

2011-05-13 Thread Joseph S. Myers
On Fri, 13 May 2011, Bernd Schmidt wrote: > The following patch adds a target hook and a corresponding LIBGCC2_ > macro which control the generation of library function names. It also > makes libgcc-std.ver a generated file, built from libgcc-std.ver.in by > replacing some placeholders with the co

Re: [PATCH, ARM] ISO/IEC TR 18037 fixed-point support

2011-05-13 Thread Julian Brown
On Wed, 11 May 2011 15:27:37 + (UTC) "Joseph S. Myers" wrote: > On Wed, 11 May 2011, Julian Brown wrote: > > > There's currently no support for "long long" fixed-point types, > > since those imply support for TImode arithmetic, which isn't > > sensible on ARM. I've modified tests to make opt

[PATCH][?/n] Cleanup LTO type merging

2011-05-13 Thread Richard Guenther
This gets rid of type pair caching in the canonical type comparison. Bootstrapped and tested on x86_64-unknown-linux-gnu, applied. Richard. 2011-05-13 Richard Guenther * gimple.c (gimple_canonical_types_compatible_p): Do not use type-pair caching, do not compare hashes. Ind

C6X port 13/11: MAINTAINERS

2011-05-13 Thread Bernd Schmidt
On 05/10/2011 06:51 PM, Joseph S. Myers wrote: > * If you are volunteering to be maintainer of the port, make that explicit > (and probably post to gcc@ for the attention of the SC; maintainership > needs approving by the SC, separately from the technical review of the > patches). Patch append

[PATCH] ARM fixed-point support [6/6]: target-specific parts

2011-05-13 Thread Julian Brown
This is the last patch to add fixed-point support to the ARM backend, the actual ARM-specific backend parts. It's functionally unchanged from the earlier patch: http://gcc.gnu.org/ml/gcc-patches/2011-05/msg00837.html although Joseph's comments have (hopefully) all been addressed. One must now con

[PATCH] ARM fixed-point support [4/6]: allow overriding of fixed-point helper function names

2011-05-13 Thread Julian Brown
This patch allows the decoration of helper function names for fixed-point support to be changed from the default "__foo" to a different scheme, as required by the ARM EABI (these are "vendor-specific" helpers, so should go in a particular namespace). These are only the machine-independent changes:

[PATCH] ARM fixed-point support [3/6]: missing FIXED_CST in tree-ssa-sccvn.c:copy_reference_ops_from_ref

2011-05-13 Thread Julian Brown
This patch adds FIXED_CST to copy_reference_ops_from_ref in tree-ssa-sccvn.c. Some test code (using fixed-point constants) failed for me without it. This looks obvious to me, unless there's some particular reason fixed-point constants need to be handled differently (or not at all) in that function.

[PATCH] ARM fixed-point support [2/6]: assembler format for fixed-point constants

2011-05-13 Thread Julian Brown
This patch changes the format used to print fixed-point constants from hex to decimal. For instance a negative "short fract" fixed-point constant may be represented as a signed HOST_WIDE_INT from -1 to -128, which would currently be printed as e.g. 0xfffffxx, resulting in a "bignum truncated to

[PATCH] ARM fixed-point support [1/6]: comparison optab biasing

2011-05-13 Thread Julian Brown
As per Joseph's suggestion here: http://gcc.gnu.org/ml/gcc-patches/2011-05/msg00846.html I am re-posting machine-independent parts of my ARM fixed-point support patches, with explanations as to why each part is necessary. This is the first: on ARM, TARGET_LIB_INT_CMP_BIASED is false for TARGET_B

C6X port 12/11: htdocs

2011-05-13 Thread Bernd Schmidt
As requested by Joseph, here are wwwdocs changes for the C6X port. Bernd Index: htdocs/backends.html === RCS file: /cvs/gcc/wwwdocs/htdocs/backends.html,v retrieving revision 1.39 diff -c -p -r1.39 backends.html *** htdocs/backends.

Re: Cgraph thunk reorg

2011-05-13 Thread Jan Hubicka
Hi, I built a cros with --enable-languages=c,c++ --disable-bootstrap --target=powerpc-ibm-aix5.3.0.0 and tried to compile covariant2.C and some of the other testcases you mention, but I don't get the ICE. Anything that could help me to reproduce this? Honza > Honza, > > This patch seems to have

Re: [patch gimplify]: Fix for PR/48984

2011-05-13 Thread Richard Guenther
On Fri, May 13, 2011 at 3:17 PM, H.J. Lu wrote: > On Thu, May 12, 2011 at 11:59 PM, Kai Tietz wrote: >> Hello, >> >> this patch fixes the issue reported in PR/48984.  Issue is that >> fortran has multiple BOOLEAN_TYPE'ed types with different modes. So >> the check for BOOLEAN_TYPE in gimplificati

Re: [patch gimplifier]: Make sure TRUTH_NOT_EXPR has boolean_type_node type and argument

2011-05-13 Thread Kai Tietz
2011/5/13 Richard Guenther : > On Fri, May 13, 2011 at 1:31 PM, Kai Tietz wrote: >> Hello, >> >> this patch adds a check to >> >> ChangeLog >> >> 2011-05-13  Kai Tietz >> >>          * gimplify.c (gimplify_expr): Make sure operand is boolified. >>          * tree-cfg.c (verify_gimple_assign_unary)

Re: [patch gimplify]: Fix for PR/48984

2011-05-13 Thread H.J. Lu
On Thu, May 12, 2011 at 11:59 PM, Kai Tietz wrote: > Hello, > > this patch fixes the issue reported in PR/48984.  Issue is that > fortran has multiple BOOLEAN_TYPE'ed types with different modes. So > the check for BOOLEAN_TYPE in gimplification is wrong and instead we > need to check for identify

Re: [google] support for building Linux kernel with FDO (issue4523061)

2011-05-13 Thread Paolo Bonzini
On 05/13/2011 03:03 AM, Rong Xu wrote: * gcc/coverage.c(revision 173717): set a flag if building for Linux kernel. * gcc/tree-profile.c(revision 173717): don't emit TLS declarations for Linux kernel builds. I think this should be done without touching at all the pr

Re: [patch gimplifier]: Make sure TRUTH_NOT_EXPR has boolean_type_node type and argument

2011-05-13 Thread Richard Guenther
On Fri, May 13, 2011 at 1:31 PM, Kai Tietz wrote: > Hello, > > this patch adds a check to > > ChangeLog > > 2011-05-13  Kai Tietz > >          * gimplify.c (gimplify_expr): Make sure operand is boolified. >          * tree-cfg.c (verify_gimple_assign_unary): Check for boolean > compatible type >  

[patch gimplifier]: Make sure TRUTH_NOT_EXPR has boolean_type_node type and argument

2011-05-13 Thread Kai Tietz
Hello, this patch adds a check to ChangeLog 2011-05-13 Kai Tietz * gimplify.c (gimplify_expr): Make sure operand is boolified. * tree-cfg.c (verify_gimple_assign_unary): Check for boolean compatible type for TRUTH_NOT_EXPR. Bootstrapped for x86_64-pc-linux-gnu (m

Re: [PATCH, ARM] ISO/IEC TR 18037 fixed-point support

2011-05-13 Thread Julian Brown
On Wed, 11 May 2011 15:45:52 +0100 Richard Sandiford wrote: > Julian Brown writes: > > Tested with cross to ARM Linux. OK to apply? > > Just out of interest, are you able to test the patch on MIPS as well? > I was wondering whether the fixed-point results there change after the > target-indepen

[PATCH] Fix PR48978

2011-05-13 Thread Richard Guenther
The change to pointer and function type hashing has made hashing a lot weaker (contrary to what I expected) because if either type resides in a SCC then we do _not_ take the hash of the visited target types into account (I'm currently trying to think about a way around that), so we are effectively

Re: [wwwdocs] Use regular markup for java/projects.html

2011-05-13 Thread Gerald Pfeifer
On Mon, 9 May 2011, Gerald Pfeifer wrote: > I was hoping my patch made it easier for someone with more background > to update this page in terms of contents, but seeing that nobody took > action on your analysis I cooked up the patch below which I plan on > committing in a couple of days. > > Ger

[wwwdocs,java] Simplify gcc-3.3/gcj-status.html

2011-05-13 Thread Gerald Pfeifer
Remove incomplete table entries and adjust a link description from gcj to GCJ. Applied. Gerald Index: gcc-3.3/gcj-status.html === RCS file: /cvs/gcc/wwwdocs/htdocs/gcc-3.3/gcj-status.html,v retrieving revision 1.4 diff -u -r1.4 gcj-

[PATCH, i386]: Trivial, use can_create_pseudo_p () some more

2011-05-13 Thread Uros Bizjak
Hello! Use can_create_pseudo_p () for things that happen strictly before reload. 2011-05-13 Uros Bizjak * config/i386/i386.md (*movxf_internal): Use !can_create_pseudo (). (*movxf_internal_nointeger): Ditto. (*movdf_internal_rex64): Ditto. (*movdf_internal): Di

Re: [Patch, Fortran] Reject non-default-kind characters as flags to I/O statements

2011-05-13 Thread Tobias Burnus
Thanks for the review, Janne! Janne Blomqvist wrote: > Ok, thanks for the patch. And especially thanks for the exhaustive > test cases! They turned out to be quite useful to find other bugs ;-) (INQUIRE with stream= is not implemented, INQUIRE with decimal= was not resolved.) > However, can you

[wwwdocs,Java] Simplify design and markup of gcc-3.1/gcj-status.html

2011-05-13 Thread Gerald Pfeifer
Consistently use white (default) background for successfull tests, avoiding bgcolor attributes. Applied. Gerald Index: gcc-3.1/gcj-status.html === RCS file: /cvs/gcc/wwwdocs/htdocs/gcc-3.1/gcj-status.html,v retrieving revision 1.2

Re: x86 option handling cleanup, use more .opt features

2011-05-13 Thread Jan Hubicka
> > Various options with enumerated string arguments are changed to use > Enum. Some checking of those arguments was still needed, because the > valid values depend on e.g. the -m64 setting, but that checking now > works with the enumerated values not strings. I didn't change the > existing logi

Re: [google] support for building Linux kernel with FDO (issue4523061)

2011-05-13 Thread Jan Hubicka
> On Fri, May 13, 2011 at 6:53 AM, Xinliang David Li wrote: > > Ok for google/main. > > Seems to be very special and not appropriate for GCC trunk. Instead > an adjusted copy providing the interface GCC needs should belong to > the kernel tree. Andi Kleen also did work in this direction. We prob

RX: Fix thinkos in previous tidy up

2011-05-13 Thread Nick Clifton
Hi Guys, When I applied my RX tidy up patch yesterday I forgot to rebuild the toolchain and thus missed a couple of thinkos with my rename of the rx_legitimate_constant_p function. I therefore applying the patch below to fix this problem. Cheers Nick gcc/ChangeLog 2011-05-13 Nick Cli

Re: [Patch, Fortran] Reject non-default-kind characters as flags to I/O statements

2011-05-13 Thread Janne Blomqvist
On Fri, May 13, 2011 at 00:56, Tobias Burnus wrote: > The patch is a correctness issue as the Fortran standard has those as > constraints - and the results of passing kind=4 strings is also odd ... > > I used also the chance to resolve INQUIRE's decimal ... > > Build and partially regtested on x86

Re: [Patch, libfortran] Thread safety and simplification of error printing

2011-05-13 Thread Janne Blomqvist
PING On Sun, May 8, 2011 at 19:53, Janne Blomqvist wrote: > On Sun, May 8, 2011 at 14:40, Janne Blomqvist > wrote: >> On Sat, May 7, 2011 at 19:35, Janne Blomqvist >> wrote: >>> Hi, >>> >>> the error printing functionality (in io/unix.c) st_printf and >>> st_vprintf are not thread-safe as the

Re: [Patch, libfortran] PR 48915 Fix incorrect return code with -fdump-core, error handling changes

2011-05-13 Thread Janne Blomqvist
PING. On Sat, May 7, 2011 at 22:52, Janne Blomqvist wrote: > Hi, > > this simple bug led me to rethink normal and error termination and > thus the patch changes some other related stuff as well. So the > original problem was that when -fdump-core was enabled, STOP with a > numeric stop code made

Re: [patch gimplify]: Fix for PR/48984

2011-05-13 Thread Kai Tietz
2011/5/13 Richard Guenther : > On Fri, May 13, 2011 at 8:56 AM, Eric Botcazou wrote: >>> 2011-05-13  Kai Tietz >>> >>>         * gimplify.c (gimplify_expr): Check for boolean_type_node instead >>>         for BOOLEAN_TYPE for TRUTH-NOT/AND/OR/XOR. >>>         (gimple_boolify): Check for cast for b

Re: [patch gimplify]: Fix for PR/48984

2011-05-13 Thread Richard Guenther
On Fri, May 13, 2011 at 8:56 AM, Eric Botcazou wrote: >> 2011-05-13  Kai Tietz >> >>         * gimplify.c (gimplify_expr): Check for boolean_type_node instead >>         for BOOLEAN_TYPE for TRUTH-NOT/AND/OR/XOR. >>         (gimple_boolify): Check for cast for boolean_type_node instead for >>    

Re: [google] support for building Linux kernel with FDO (issue4523061)

2011-05-13 Thread Richard Guenther
On Fri, May 13, 2011 at 6:53 AM, Xinliang David Li wrote: > Ok for google/main. Seems to be very special and not appropriate for GCC trunk. Instead an adjusted copy providing the interface GCC needs should belong to the kernel tree. Richard.

Re: [patch gimplifier]: Boolify more strict conditional expressions and transform simple form to binary

2011-05-13 Thread Richard Guenther
On Thu, May 12, 2011 at 9:59 PM, H.J. Lu wrote: > On Thu, May 12, 2011 at 11:19 AM, Kai Tietz wrote: >> 2011/5/12 Richard Guenther : >>> On Thu, May 12, 2011 at 3:29 PM, Kai Tietz wrote: While testing some other issues with C++'s __java_boolean type occurred. So I adjusted check in tes

[PATCH] Optimize fix for PR48172

2011-05-13 Thread Richard Guenther
The following avoids the multiplication by niters when the step is equal. Boostrapped and tested on x86_64-unknown-linux-gnu, applied to trunk. Richard. 2011-05-13 Richard Guenther PR tree-optimization/48172 * tree-vect-loop-manip.c (vect_vfa_segment_size): Avoid mul

Re: [PATCH] use AS_HELP_STRING throughout gcc/configure.ac

2011-05-13 Thread Andreas Schwab
"Ralf Wildenhues" writes: > Yes, if you visually compared the diff of configure and of './configure > --help' before and after the change, to only contain intended changes. Yes, I did. The help texts are now nicely aligned and folded, except for a few which come from outside (more to follow).

Re: [Patch,AVR]: Fix PR27663

2011-05-13 Thread Denis Chertykov
2011/5/11 Georg-Johann Lay : > Denis Chertykov schrieb: >> >> 2011/5/2 Georg-Johann Lay : >> >>> This is a fix for an optimization flaw when a long value is composed >>> from byte values. >>> >>> For -fsplit-wide-types (which is still default for avr) the code is >>> worse than with -fno-split-wide

Re: PATCH: Change maybe_eh_return to bool

2011-05-13 Thread Uros Bizjak
On Thu, May 12, 2011 at 11:58 PM, H.J. Lu wrote: >> FWIW, the return type of ix86_save_reg (and ix86_hard_regno_mode_ok >> and perhaps many others...) can also be changed to bool. > > This patch changes the return type of ix86_save_reg to bool and return > value of ix86_hard_regno_mode_ok to bool

Re: [patch gimplify]: Fix for PR/48984

2011-05-13 Thread Eric Botcazou
> 2011-05-13 Kai Tietz > > * gimplify.c (gimplify_expr): Check for boolean_type_node instead > for BOOLEAN_TYPE for TRUTH-NOT/AND/OR/XOR. > (gimple_boolify): Check for cast for boolean_type_node instead for > BOOLEAN_TYPE. Missing PR middle-end/48984 at the top. -

[patch gimplify]: Fix for PR/48984

2011-05-13 Thread Kai Tietz
Hello, this patch fixes the issue reported in PR/48984. Issue is that fortran has multiple BOOLEAN_TYPE'ed types with different modes. So the check for BOOLEAN_TYPE in gimplification is wrong and instead we need to check for identify to boolean_type_node. ChangeLog 2011-05-13 Kai Tietz