Re: [Patch, AVR]: AVR backend cleanup: use elfos.h

2011-06-27 Thread Denis Chertykov
2011/6/27 Georg-Johann Lay : > or > > [ ] Remove the undefs so that we have .ident. >    There's nothing terrific about it, it just adds >    some text to .comment section.  I guess it's missing >    because noone ever added it. This one. Denis.

Re: [RFC] Fix full memory barrier on SPARC-V8

2011-06-27 Thread David Miller
From: Geert Bosch Date: Mon, 27 Jun 2011 23:17:18 -0400 >> \You then go on to speak about LEON, does LEON implement PSO? > No, I'm not talking about PSO anywhere or SPARCv9 anywhere. > Just plain old SPARCv8, using the TSO model. This requires a > load-store instruction to guarantee a full memor

Re: [RFC] Fix full memory barrier on SPARC-V8

2011-06-27 Thread Geert Bosch
On Jun 27, 2011, at 22:45, David Miller wrote: > From: Geert Bosch > Date: Mon, 27 Jun 2011 22:21:47 -0400 > >> On Jun 27, 2011, at 19:53, David Miller wrote: >> >>> Adding a ldstub here is going to be really expensive, on UltraSparc >>> that can be 36+ cycles even on a cache hit. >> >> Yes,

Re: [RFC] Fix full memory barrier on SPARC-V8

2011-06-27 Thread David Miller
From: David Miller Date: Mon, 27 Jun 2011 19:45:33 -0700 (PDT) > You then go on to speak about LEON, does LEON implement PSO? BTW, even if it does, I would be encouraging the person who submits LEON kernel patches to not run the chip in this mode. We don't even use PSO for v9 chips, it's just n

Re: [RFC] Fix full memory barrier on SPARC-V8

2011-06-27 Thread David Miller
From: Geert Bosch Date: Mon, 27 Jun 2011 22:21:47 -0400 > On Jun 27, 2011, at 19:53, David Miller wrote: > >> Adding a ldstub here is going to be really expensive, on UltraSparc >> that can be 36+ cycles even on a cache hit. > > Yes, synchronization in multi-CPU systems is expensive. > If it's

Re: [RFC] Fix full memory barrier on SPARC-V8

2011-06-27 Thread Geert Bosch
On Jun 27, 2011, at 19:53, David Miller wrote: > I'm trying to find the part of the v8 manual that says there is > a situation where we should use "stbar" and a "ldstub" to implement > proper memory barriers. In particular I'm looking in Appendix J, > "Programming with the memory models." Where

Re: [patch, fortran] Fix PR 49479, reshape with optional arg

2011-06-27 Thread Jerry DeLisle
On 06/27/2011 03:18 PM, Thomas Koenig wrote: Hello world, the attached patch fixes PR 49479, a regression for 4.7 and 4.6. Test case was supplied by Joost, the approach to the patch was suggested by Tobias in comment#4 of the PR. The patch certainly looks safe enough. Regression-tested. OK for

[pph] Update Tests (issue4636066)

2011-06-27 Thread Lawrence Crowl
Add missing mappings in pph.map. These new mappings result in changes to assembly difference expectations. Remove namespace issues from x1template test. Copy that test to a new test x1namespace. Add a new test x1dynarray, which is executable, when existing failures get fixed. Index: gcc/tests

Re: Split insn-attr.h

2011-06-27 Thread Bernd Schmidt
On 06/28/11 02:24, Joseph S. Myers wrote: > > * genattr-common.c: New. Based on genattr.c. > * Makefile.in (INSN_ATTR_H): Include insn-attr-common.h. > (MOSTLYCLEANFILES): Add insn-attr-common.h. > (opts.o): Update dependencies. > (.PRECIOUS): Add insn-attr-common.h.

[pph] Fix var order when streaming in. (issue4635074)

2011-06-27 Thread Gabriel Charette
The names and namespaces chains are built by adding each new element to the front of the list. When streaming it in we traverse the list of names and re-add them to the current chains; thus reversing the order in which they were defined in the header file. Since this is a singly linked-list we

Split insn-attr.h

2011-06-27 Thread Joseph S. Myers
opts.c includes insn-attr.h to get the definitions of INSN_SCHEDULING and DELAY_SLOTS, used to determine whether to enable certain options by default at certain -O levels. insn-attr.h in turn requires rtl.h to have been included first (and rtl.h requires tm.h, although there are other tm.h depende

Re: [testsuite] ARM: don't specify unneeded -march

2011-06-27 Thread Mike Stump
On Jun 21, 2011, at 2:48 PM, Janis Johnson wrote: > I modified these tests last week to check for thumb support and to > ignore messages about conflicting options, but -march isn't needed > and so there shouldn't be any conflicting options. > > OK? Ok.

Re: [RFC] Fix full memory barrier on SPARC-V8

2011-06-27 Thread David Miller
From: Geert Bosch Date: Mon, 27 Jun 2011 19:36:06 -0400 > On Jun 27, 2011, at 19:00, David Miller wrote: > >> V8 can only reorder stores, that's why it only has a 'stbar' >> instruction. I'm not so sure I agree with trying to paper over the >> fact that someone has compiled code for v8 that's

Re: [RFC] Fix full memory barrier on SPARC-V8

2011-06-27 Thread Geert Bosch
On Jun 27, 2011, at 19:00, David Miller wrote: > V8 can only reorder stores, that's why it only has a 'stbar' > instruction. I'm not so sure I agree with trying to paper over the > fact that someone has compiled code for v8 that's going to run on a v9 > cpu. That's not the issue. While it is t

Re: [google] Enable both ld and gold in gcc (issue4664051)

2011-06-27 Thread H.J. Lu
On Mon, Jun 27, 2011 at 4:09 PM, Doug Kwan wrote: > This patch enables both ld and gold in gcc using the -fuse-ld switch.  The > original patch use written by Nick Clifton and was subsequently updated by > Matthias Klose.  The patch currently does not work with LTO but that is > okay for now and i

[google] Enable both ld and gold in gcc (issue4664051)

2011-06-27 Thread Doug Kwan
This patch enables both ld and gold in gcc using the -fuse-ld switch. The original patch use written by Nick Clifton and was subsequently updated by Matthias Klose. The patch currently does not work with LTO but that is okay for now and it is no worse than its counterpart in an older gcc version.

Re: [RFC] Fix full memory barrier on SPARC-V8

2011-06-27 Thread David Miller
From: Eric Botcazou Date: Mon, 27 Jun 2011 18:11:10 +0200 > * config/sparc/sync.md (*stbar): Delete. > (*membar_v8): New insn to implement UNSPEC_MEMBAR in SPARC-V8. Code which cares about memory ordering etc. really has to know the kind of cpu it is running on. This is why atomic a

Re: PATCH [10/n]: Prepare x32: PR rtl-optimization/49114: Reload failed to handle (set reg:X (plus:X (subreg:X (reg:Y) 0) (const

2011-06-27 Thread H.J. Lu
On Mon, Jun 27, 2011 at 3:25 PM, H.J. Lu wrote: > On Mon, Jun 27, 2011 at 3:19 PM, H.J. Lu wrote: >> On Mon, Jun 27, 2011 at 3:08 PM, Ulrich Weigand wrote: >>> H.J. Lu wrote: >>> reload generates: (insn 914 912 0 (set (reg:SI 0 ax)         (plus:SI (subreg:SI (reg/v/f:DI 182

RE: [PATCH, i386] Enable -mprefer-avx128 by default for Bulldozer

2011-06-27 Thread Fang, Changpeng
Is this patch OK to commit to trunk? Also I would like to backport this patch to gcc 4.6 branch. Do I have to send a separate request or use this one? Thanks, Changpeng From: Fang, Changpeng Sent: Friday, June 24, 2011 7:12 PM To: Jan Hubicka Cc: Ur

RE: Backport AVX256 load/store split patches to gcc 4.6 for performance boost on latest AMD/Intel hardware.

2011-06-27 Thread Fang, Changpeng
Hi, Attached are the patches we propose to backport to gcc 4.6 branch which are related to avx256 unaligned load/store splitting. As we mentioned before, The combined effect of these patches are positive on both AMD and Intel CPUs on cpu2006 and polyhedron 2005. 0001-Split-32-byte-AVX-unaligne

Re: [pph] Rename token cache and identifiers streaming functions to reflect pph naming scheme (issue4636065)

2011-06-27 Thread Gabriel Charette
On Mon, Jun 27, 2011 at 1:40 PM, wrote: > > On 2011/06/27 20:33:26, Gabriel Charette wrote: >> >> 2011-06-27  Gabriel Charette   > > Remove the 'mailto:' prefix. Weird, that's not in the actual patch, probably gmail putting it in... Commited as rev r175568. Gab > > >

Re: PATCH [10/n]: Prepare x32: PR rtl-optimization/49114: Reload failed to handle (set reg:X (plus:X (subreg:X (reg:Y) 0) (const

2011-06-27 Thread H.J. Lu
On Mon, Jun 27, 2011 at 3:19 PM, H.J. Lu wrote: > On Mon, Jun 27, 2011 at 3:08 PM, Ulrich Weigand wrote: >> H.J. Lu wrote: >> >>> reload generates: >>> >>> (insn 914 912 0 (set (reg:SI 0 ax) >>>         (plus:SI (subreg:SI (reg/v/f:DI 182 [ b ]) 0) >>>             (const_int 8 [0x8]))) 248 {*lea_

Re: PATCH [10/n]: Prepare x32: PR rtl-optimization/49114: Reload failed to handle (set reg:X (plus:X (subreg:X (reg:Y) 0) (const

2011-06-27 Thread H.J. Lu
On Mon, Jun 27, 2011 at 3:08 PM, Ulrich Weigand wrote: > H.J. Lu wrote: > >> reload generates: >> >> (insn 914 912 0 (set (reg:SI 0 ax) >>         (plus:SI (subreg:SI (reg/v/f:DI 182 [ b ]) 0) >>             (const_int 8 [0x8]))) 248 {*lea_1_x32} >>      (nil)) >> >> from >> >> insn = emit_insn_if

[patch, fortran] Fix PR 49479, reshape with optional arg

2011-06-27 Thread Thomas Koenig
Hello world, the attached patch fixes PR 49479, a regression for 4.7 and 4.6. Test case was supplied by Joost, the approach to the patch was suggested by Tobias in comment#4 of the PR. The patch certainly looks safe enough. Regression-tested. OK for trunk and, after a couple of days, for 4.6?

Re: PATCH [10/n]: Prepare x32: PR rtl-optimization/49114: Reload failed to handle (set reg:X (plus:X (subreg:X (reg:Y) 0) (const

2011-06-27 Thread Ulrich Weigand
H.J. Lu wrote: > reload generates: > > (insn 914 912 0 (set (reg:SI 0 ax) > (plus:SI (subreg:SI (reg/v/f:DI 182 [ b ]) 0) > (const_int 8 [0x8]))) 248 {*lea_1_x32} > (nil)) > > from > > insn = emit_insn_if_valid_for_reload (gen_rtx_SET (VOIDmode, out, in)); Interesting.

Add Gabriel Charette to Write After Approval list (issue4626079)

2011-06-27 Thread Gabriel Charette
Added myself to write after approval maintainers list. 2011-06-27 Gabriel Charette * MAINTAINERS (Write After Approval): Add myself. diff --git a/MAINTAINERS b/MAINTAINERS index 9dead4f..f6a768e 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -324,6 +324,7 @@ Christian Bruel

Re: PATCH [10/n]: Prepare x32: PR rtl-optimization/49114: Reload failed to handle (set reg:X (plus:X (subreg:X (reg:Y) 0) (const

2011-06-27 Thread H.J. Lu
On Mon, Jun 27, 2011 at 1:42 PM, H.J. Lu wrote: > On Mon, Jun 27, 2011 at 11:59 AM, Ulrich Weigand wrote: >> H.J. Lu wrote: >> >>> Reloads for insn # 588 >>> Reload 0: reload_in (DI) =3D (reg/v/f:DI 182 [ b ]) >>>         GENERAL_REGS, RELOAD_FOR_OPERAND_ADDRESS (opnum =3D 0) >>>         reload_i

Re: Fix cgraph_address_taken_from_non_vtable_p

2011-06-27 Thread Richard Guenther
On Mon, 27 Jun 2011, Jan Hubicka wrote: > Hi, > this patch fixes thinko in cgraph_address_taken_from_non_vtable_p that valks > references in NODE instead of references of NODE. > It fixes the testcase in http://sourceware.org/bugzilla/show_bug.cgi?id=12942 > in non-plugin LTO and Gold, but not wit

Re: [PATCH][RFC][2/2] Bitfield lowering

2011-06-27 Thread Richard Guenther
On Mon, 27 Jun 2011, Richard Henderson wrote: > On 06/23/2011 02:49 AM, Richard Guenther wrote: > > So, do you know of a target that can do insv with a memory > > target? I would expect extv on memory to be easily doable. > > Depends on what you mean by that. INSV is the traditional > md patter

Re: [RFA:] Removing target-libiberty on branches

2011-06-27 Thread Hans-Peter Nilsson
> Date: Fri, 24 Jun 2011 10:14:13 +0200 > From: Richard Guenther > On Thu, Jun 23, 2011 at 8:23 PM, Hans-Peter Nilsson > wrote: > > Here's the patch I tested for 4.6, native > > x86_64-unknown-linux-gnu, cross to cris-axis-elf, both with old > > and new ("breaking") newlib. > > > > Ok for 4.6 an

Re: [PATCH 0/4] Docs: extend.texi

2011-06-27 Thread Michael Witten
On Thu, Apr 28, 2011 at 01:20, Michael Witten wrote: > See the following emails for a few inlined patches > to /trunk/gcc/doc/extend.texi (revision 172911): > > [1] Docs: extend.texi: Add missing semicolon for consistency > [2] Docs: extend.texi: Remove trailing blanks from lines > [3] Docs: e

Re: PATCH [10/n]: Prepare x32: PR rtl-optimization/49114: Reload failed to handle (set reg:X (plus:X (subreg:X (reg:Y) 0) (const

2011-06-27 Thread H.J. Lu
On Mon, Jun 27, 2011 at 11:59 AM, Ulrich Weigand wrote: > H.J. Lu wrote: > >> Reloads for insn # 588 >> Reload 0: reload_in (DI) =3D (reg/v/f:DI 182 [ b ]) >>         GENERAL_REGS, RELOAD_FOR_OPERAND_ADDRESS (opnum =3D 0) >>         reload_in_reg: (reg/v/f:DI 182 [ b ]) >>         reload_reg_rtx:

Re: [pph] Rename token cache and identifiers streaming functions to reflect pph naming scheme (issue4636065)

2011-06-27 Thread dnovillo
On 2011/06/27 20:33:26, Gabriel Charette wrote: 2011-06-27 Gabriel Charette Remove the 'mailto:' prefix. * pph-streamer-in.c (pph_get_type_from_index): Rename from pth_get_type_from_index. Update all users. (pph_in_number): Rename from pth

[pph] Rename token cache and identifiers streaming functions to reflect pph naming scheme (issue4636065)

2011-06-27 Thread Gabriel Charette
Renamed all functions to reflect pph naming schemes (pph_in/out_*). Also reordered parameters so that the first parameter is always pph_stream* Tested with bootstrap and pph regression testing. 2011-06-27 Gabriel Charette * pph-streamer-in.c (pph_get_type_from_index): Rename

Re: [pph] Moved token cache streaming to in/out respectively (issue4635073)

2011-06-27 Thread Diego Novillo
On Mon, Jun 27, 2011 at 15:32, wrote: > On 2011/06/27 18:51:22, Gabriel Charette wrote: > >> 2011-06-27  Gabriel Charette   > >>        * pph-streamer-in.c (pth_get_type_from_index): Moved from pph.c. >>        (pth_load_number): Moved from pph.c. >>        (pth_load_tok

New German PO file for 'gcc' (version 4.6.0)

2011-06-27 Thread Translation Project Robot
Hello, gentle maintainer. This is a message from the Translation Project robot. A revised PO file for textual domain 'gcc' has been submitted by the German team of translators. The file is available at: http://translationproject.org/latest/gcc/de.po (This file, 'gcc-4.6.0.de.po', has just

Fix cgraph_address_taken_from_non_vtable_p

2011-06-27 Thread Jan Hubicka
Hi, this patch fixes thinko in cgraph_address_taken_from_non_vtable_p that valks references in NODE instead of references of NODE. It fixes the testcase in http://sourceware.org/bugzilla/show_bug.cgi?id=12942 in non-plugin LTO and Gold, but not with GNU LD that presently handle resolution info inco

Re: ia64-linux build broken

2011-06-27 Thread Richard Henderson
On 06/27/2011 12:23 PM, Richard Henderson wrote: > On 06/27/2011 12:11 PM, Richard Henderson wrote: >> gcc -c -DUSE_LIBUNWIND_EXCEPTIONS -g -DIN_GCC -DCROSS_DIRECTORY_STRUCTURE >> -W -Wall -Wwrite-strings -Wcast-qual -Wstrict-prototypes >> -Wmissing-prototypes -Wmissing-format-attribute -pedan

Re: Unreviewed build/libgcc, mudflap patches

2011-06-27 Thread Mike Stump
On Jun 27, 2011, at 9:54 AM, Iain Sandoe wrote: > On 27 Jun 2011, at 12:32, Rainer Orth wrote: > >> The following three patches have remained unreviewed for a week: >> >> [build] Move unwinder to toplevel libgcc >> http://gcc.gnu.org/ml/gcc-patches/2011-06/msg01452.html > As far as Da

Re: [pph] Moved token cache streaming to in/out respectively (issue4635073)

2011-06-27 Thread dnovillo
On 2011/06/27 18:51:22, Gabriel Charette wrote: 2011-06-27 Gabriel Charette * pph-streamer-in.c (pth_get_type_from_index): Moved from pph.c. (pth_load_number): Moved from pph.c. (pth_load_token_value): Moved from pph.c. (pth_load_to

Re: ia64-linux build broken

2011-06-27 Thread Richard Henderson
On 06/27/2011 12:11 PM, Richard Henderson wrote: > gcc -c -DUSE_LIBUNWIND_EXCEPTIONS -g -DIN_GCC -DCROSS_DIRECTORY_STRUCTURE > -W -Wall -Wwrite-strings -Wcast-qual -Wstrict-prototypes -Wmissing-prototypes > -Wmissing-format-attribute -pedantic -Wno-long-long -Wno-variadic-macros > -Wno-overle

Re: [Patch, AVR]: AVR backend cleanup: use elfos.h

2011-06-27 Thread Georg-Johann Lay
Denis Chertykov schrieb: 2011/6/27 Georg-Johann Lay: http://gcc.gnu.org/ml/gcc-patches/2011-06/msg02011.html [...] Is there a specific reason not to emit .ident? If not, I would remove the #undefs of IDENT_ASM_OP and ASM_OUTPUT_IDENT from avr/elf.h. Sorry, I forgot. Denis. It's just a m

ia64-linux build broken

2011-06-27 Thread Richard Henderson
2011-06-27 Tristan Gingold PR target/44241 * config/vms/vms-protos.h: New file. * config/vms/vms-crtlmap.map: New file. * config/vms/vms.c: New file. * config/vms/make-crtlmap.awk: New file. * config/vms/vms-crtl.h: File removed. * config/

Re: [pph] Add header files to pph.map (issue4639073)

2011-06-27 Thread Lawrence Crowl
On 6/27/11, Gabriel Charette wrote: > On Jun 27, 2011 Diego Novillo wrote: > > On Jun 27, 2011 Gabriel Charette wrote: > > > Couldn't we have headers look for their corresponding .pph > > > file by default when -fpph-map is on? (especially since > > > pph.map is only temporary for the implementa

Re: PATCH [10/n]: Prepare x32: PR rtl-optimization/49114: Reload failed to handle (set reg:X (plus:X (subreg:X (reg:Y) 0) (const

2011-06-27 Thread Ulrich Weigand
H.J. Lu wrote: > Reloads for insn # 588 > Reload 0: reload_in (DI) =3D (reg/v/f:DI 182 [ b ]) > GENERAL_REGS, RELOAD_FOR_OPERAND_ADDRESS (opnum =3D 0) > reload_in_reg: (reg/v/f:DI 182 [ b ]) > reload_reg_rtx: (reg:DI 1 dx) > Reload 1: reload_in (DI) =3D (zero_extend:DI (plu

Re: [pph] New test (issue4629075)

2011-06-27 Thread Diego Novillo
On Mon, Jun 27, 2011 at 14:56, Lawrence Crowl wrote: > On 6/27/11, Diego Novillo wrote: >> On Jun 27, 2011 Gabriel Charette wrote: >> > Just wondering why you're naming x finishing by an underscore >> > "x_", this is a valid name, but just thinking it's tricky syntax, >> > does this test anythin

Re: [pph] New test (issue4629075)

2011-06-27 Thread Lawrence Crowl
On 6/27/11, Diego Novillo wrote: > On Jun 27, 2011 Gabriel Charette wrote: > > Just wondering why you're naming x finishing by an underscore > > "x_", this is a valid name, but just thinking it's tricky syntax, > > does this test anything more? or is it just a preference for > > private members?

[patch tree-optimization]: Try to do type sinking on comparisons

2011-06-27 Thread Kai Tietz
Hello, this patch tries to sink conversions for comparisons patterns: a) (type) X cmp (type) Y => x cmp y. b) (type) X cmp CST => x cmp ((type-x) CST). c) CST cmp (type) X => ((type-x) CST) cmp x. This patch just allows type sinking for the case that type-precision of type is wider or equal to t

[pph] Moved token cache streaming to in/out respectively (issue4635073)

2011-06-27 Thread Gabriel Charette
Moved all token cache streaming to it's respective in/out streamer. They were non-static exposed methods, but were only used in pph-streamer-in/out.c This is a pure copy/paste patch. I will change the functions names to reflect the pph naming scheme in a subsequent patch. Tested with bootstrap

Re: PATCH [10/n]: Prepare x32: PR rtl-optimization/49114: Reload failed to handle (set reg:X (plus:X (subreg:X (reg:Y) 0) (const

2011-06-27 Thread H.J. Lu
On Mon, Jun 27, 2011 at 11:28 AM, Ulrich Weigand wrote: > H.J. Lu wrote: >> On Mon, Jun 27, 2011 at 7:47 AM, Ulrich Weigand wrote: >> > The actual problem >> > here is that this part of gen_reload takes the approach to transform >> > >> >  out <- op0 + op1 >> > >> > into >> > >> >  out <- op0 >>

Re: [RFC, ARM] Convert thumb1 prologue completely to rtl

2011-06-27 Thread Richard Henderson
On 06/24/2011 02:59 AM, Richard Earnshaw wrote: > On 18/06/11 20:02, Richard Henderson wrote: >> I couldn't find anything terribly tricky about the conversion. >> >> The existing push_mult pattern would service thumb1 with just >> a tweak or two to the memory predicate and the length. >> >> The exi

Re: PATCH [10/n]: Prepare x32: PR rtl-optimization/49114: Reload failed to handle (set reg:X (plus:X (subreg:X (reg:Y) 0) (const

2011-06-27 Thread Ulrich Weigand
H.J. Lu wrote: > On Mon, Jun 27, 2011 at 7:47 AM, Ulrich Weigand wrote: > > The actual problem > > here is that this part of gen_reload takes the approach to transform > > > > out <- op0 + op1 > > > > into > > > > out <- op0 > > out <- out + op1 > > > > which is invalid if writing to out clobbe

Re: [PATCH][RFC][2/2] Bitfield lowering

2011-06-27 Thread Richard Henderson
On 06/23/2011 02:49 AM, Richard Guenther wrote: > So, do you know of a target that can do insv with a memory > target? I would expect extv on memory to be easily doable. Depends on what you mean by that. INSV is the traditional md pattern that performs unaligned stores. So, many targets can han

Re: PATCH [10/n]: Prepare x32: PR rtl-optimization/49114: Reload failed to handle (set reg:X (plus:X (subreg:X (reg:Y) 0) (const_int

2011-06-27 Thread H.J. Lu
On Mon, Jun 27, 2011 at 7:47 AM, Ulrich Weigand wrote: > H.J. Lu wrote: > >> When reload gets: >> >> (insn 588 587 589 28 (set (mem:DF (zero_extend:DI (plus:SI (subreg:SI >> (reg/v/f:DI 182 [ b ]) 0) >>                     (const_int 8 [0x8]))) [4 MEM[base: b_96(D), index: >> D.15020_278, step: 8,

Re: Simplify Solaris configuration

2011-06-27 Thread Eric Botcazou
> sorry about that: I don't test the 64-bit default configurations so far, > and didn't even have the necessary support libs around to do so. The > problem was that sparc/sol2-64.h was included too late and > DEFAULT_ARCH32_P was wrong for those configurations. > > The following patch should fix t

Re: Unreviewed build/libgcc, mudflap patches

2011-06-27 Thread Rainer Orth
Hi Iain, >> The following three patches have remained unreviewed for a week: >> >> [build] Move unwinder to toplevel libgcc >>http://gcc.gnu.org/ml/gcc-patches/2011-06/msg01452.html >> >> This needs at least a build and/or libgcc maintainer, though a global >> reviewer might be helpfu

Re: [Patch, AVR]: AVR backend cleanup: use elfos.h

2011-06-27 Thread Denis Chertykov
2011/6/27 Georg-Johann Lay : > Denis Chertykov wrote: >> 2011/6/27 Georg-Johann Lay : >>> This patch removes ELF dependencies from avr.h and redundancies from >>> avr.h and avr.c >>> >>> The AVR BE defines many things that are readily available in elfos.h. >>> ELF is the only target supported by av

Re: [gcc patch] Re: C++ member function template id not matching linkage name (PR debug/49408)

2011-06-27 Thread Jason Merrill
On 06/27/2011 11:04 AM, Jan Kratochvil wrote: Had to restrict the patch very much for the template function reference case as otherwise the parameter types are required even in templates there. They should be supressed whenever the function appears in an expression context, either as a pointer

Re: Unreviewed build/libgcc, mudflap patches

2011-06-27 Thread Rainer Orth
Hi Frank, > Sure. Transcribing: > >> One generic issue came up with the port: enabling or disabling >> libmudflap depends on a factor (linker support for --wrap/-z wrap) >> that is best checked dynamically, thus doesn't really seem to belong >> at the toplevel. Is there any precedent for perform

Re: [Patch, AVR]: AVR backend cleanup: use elfos.h

2011-06-27 Thread Bernd Schmidt
On 06/27/11 19:34, Georg-Johann Lay wrote: > Denis Chertykov wrote: >> Approved. >> > http://gcc.gnu.org/ml/gcc-patches/2011-06/msg02011.html > > Is that also for the config.gcc part? > Or does it need review from global reviewer? Denis can approve AVR changes in config.gcc. Bernd

Re: Unreviewed build/libgcc, mudflap patches

2011-06-27 Thread Rainer Orth
Hi Frank, >> Support libmudflap on Solaris (PR libmudflap/38738) >> http://gcc.gnu.org/ml/gcc-patches/2011-06/msg01446.html > > Looks good to me, thanks for taking a look at the area. I've installed the patch as it, since it at least fixes the libmudflap build on Solaris. Thanks.

Re: [Patch, AVR]: AVR backend cleanup: use elfos.h

2011-06-27 Thread Georg-Johann Lay
Denis Chertykov wrote: > 2011/6/27 Georg-Johann Lay : >> This patch removes ELF dependencies from avr.h and redundancies from >> avr.h and avr.c >> >> The AVR BE defines many things that are readily available in elfos.h. >> ELF is the only target supported by avr-gcc. >> >> The patch includes elfos

{patch tree-ssa-math-opts]: Change searching direction for bswap

2011-06-27 Thread Kai Tietz
Hello, this is the separated patch for issues noticed by doing type-sinking on bitwise-operations. The tests exposed that bswap pattern-matching searches from top to down for each BB. As it replaces the found match for a bswap in tree, but doesn't know about handling its inserted builtin-swap

Re: [pph] Add header files to pph.map (issue4639073)

2011-06-27 Thread Gabriel Charette
On Mon, Jun 27, 2011 at 10:18 AM, Diego Novillo wrote: > On Mon, Jun 27, 2011 at 13:13, Gabriel Charette wrote: >> On Mon, Jun 27, 2011 at 10:06 AM, Diego Novillo wrote: >>> On Mon, Jun 27, 2011 at 13:01, Gabriel Charette wrote: Couldn't we have headers look for their corresponding .pph fi

[google] Do not execute pass_warn_function_return after a syntax error (issue4629076)

2011-06-27 Thread Diego Novillo
This patch is the compromise solution for the problem described in http://gcc.gnu.org/ml/gcc/2011-06/msg00213.html. We should not try to analyze the IL in the presence of syntax errors. The full solution is simpler, but it changes diagnostic behaviour too much for the release branch, so this patc

Re: [pph] Add header files to pph.map (issue4639073)

2011-06-27 Thread Diego Novillo
On Mon, Jun 27, 2011 at 13:13, Gabriel Charette wrote: > On Mon, Jun 27, 2011 at 10:06 AM, Diego Novillo wrote: >> On Mon, Jun 27, 2011 at 13:01, Gabriel Charette wrote: >>> Couldn't we have headers look for their corresponding .pph file by >>> default when -fpph-map is on? (especially since pph

Re: [patch tree-optimization]: Try to sink type-casts for binary and/or/xor operations

2011-06-27 Thread Kai Tietz
Ups, missed to update patch. Kai - Original Message - From: "Kai Tietz" To: "Richard Guenther" Cc: gcc-patches@gcc.gnu.org Sent: Monday, June 27, 2011 7:04:04 PM Subject: Re: [patch tree-optimization]: Try to sink type-casts for binary and/or/xor operations Hi, so I modified patch to

Re: [pph] Add header files to pph.map (issue4639073)

2011-06-27 Thread Gabriel Charette
On Mon, Jun 27, 2011 at 10:06 AM, Diego Novillo wrote: > On Mon, Jun 27, 2011 at 13:01, Gabriel Charette wrote: >> Couldn't we have headers look for their corresponding .pph file by >> default when -fpph-map is on? (especially since pph.map is only >> temporary for the implementation phase) > > T

Re: [PING] [PATCH, libstdc++-v3] Add newlib specific ctype_members.cc

2011-06-27 Thread Paolo Carlini
Hi, Ping for: http://gcc.gnu.org/ml/gcc-patches/2011-06/msg00440.html personally, I have only minor comments, like only 2011 as Copyright year for new files, and please also regtest on a gnu-linux system. Before going ahead, however, you should send the patch also to the libstdc++ mailing lis

Re: [pph] New test (issue4629075)

2011-06-27 Thread Diego Novillo
On Mon, Jun 27, 2011 at 13:06, Gabriel Charette wrote: > Just wondering why you're naming x finishing by an underscore "x_", > this is a valid name, but just thinking it's tricky syntax, does this > test anything more? or is it just a preference for private members? No real reason. Just a quick

Re: [pph] New test (issue4629075)

2011-06-27 Thread Gabriel Charette
Just wondering why you're naming x finishing by an underscore "x_", this is a valid name, but just thinking it's tricky syntax, does this test anything more? or is it just a preference for private members? LGTM On Mon, Jun 27, 2011 at 9:39 AM, Diego Novillo wrote: > We are very close to having t

Re: [pph] Add header files to pph.map (issue4639073)

2011-06-27 Thread Diego Novillo
On Mon, Jun 27, 2011 at 13:01, Gabriel Charette wrote: > Couldn't we have headers look for their corresponding .pph file by > default when -fpph-map is on? (especially since pph.map is only > temporary for the implementation phase) The problem is with headers that include other headers. We want

Re: [patch tree-optimization]: Try to sink type-casts for binary and/or/xor operations

2011-06-27 Thread Kai Tietz
Hi, so I modified patch to use int_fits_type_p() for integer CST checking. Well, this approach is - as discussed on IRC suboptimal - as my intial approach was for and-operations with precision type > precision type-x and unsigned type-x for constant values bigger then (type-x)~0. But well, tho

Re: PATCH [11/n]: Prepare x32: PR rtl-optimization/48155: Reload doesn't handle subreg properly

2011-06-27 Thread Ulrich Weigand
H.J. Lu wrote: > On Mon, Jun 27, 2011 at 7:52 AM, Ulrich Weigand wrote: > > H.J. Lu wrote: > > > >> Given input: > >> > >> (plus:SI (subreg:SI (plus:DI (reg/f:DI 7 sp) > >> =A0 =A0 =A0 =A0 =A0 =A0 (const_int 16 [0x10])) 0) > >> =A0 =A0 (const_int -1 [0x])) > > > > Once again, this

Re: [pph] Add header files to pph.map (issue4639073)

2011-06-27 Thread Gabriel Charette
Couldn't we have headers look for their corresponding .pph file by default when -fpph-map is on? (especially since pph.map is only temporary for the implementation phase) I would see it like this: if -fpph-map is not NULL: look for mapping in file if not found: look for default mapping (i.

Re: [Patch, AVR]: AVR backend cleanup: use elfos.h

2011-06-27 Thread Denis Chertykov
2011/6/27 Georg-Johann Lay : > This patch removes ELF dependencies from avr.h and redundancies from > avr.h and avr.c > > The AVR BE defines many things that are readily available in elfos.h. > ELF is the only target supported by avr-gcc. > > The patch includes elfos.h in config.gcc for all avr* ta

Re: Unreviewed build/libgcc, mudflap patches

2011-06-27 Thread Iain Sandoe
Hi Rainer, On 27 Jun 2011, at 12:32, Rainer Orth wrote: The following three patches have remained unreviewed for a week: [build] Move unwinder to toplevel libgcc http://gcc.gnu.org/ml/gcc-patches/2011-06/msg01452.html This needs at least a build and/or libgcc maintainer, though

Re: [PATCH] __builtin_assume_aligned

2011-06-27 Thread Jakub Jelinek
On Mon, Jun 27, 2011 at 12:17:40PM +0200, Richard Guenther wrote: > Ok if you remove the builtins.c folding and instead verify arguments > from check_builtin_function_arguments. Thanks, here is what I've committed after bootstrapping/regtesting again on x86_64-linux and i686-linux. 2011-06-27 Ja

Re: [PATCH] Use TYPE_NEXT_VARIANT instead of TREE_CHAIN as chain_next for types during GC (PR c++/46400)

2011-06-27 Thread Richard Henderson
On 06/27/2011 09:42 AM, Jakub Jelinek wrote: > 2011-06-27 Jakub Jelinek > > * c-common.h (c_tree_chain_next): New static inline function. > > * c-decl.c (union lang_tree_node): Use it in chain_next expression. > > * cp-tree.h (union lang_tree_node): Use it in chain_next expr

[committed] Fix promote_debug_loc (PR debug/49544)

2011-06-27 Thread Jakub Jelinek
Hi! When I've added adding subregs of wider value to cselib_lookup_1 in http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=174508, I've mistakenly only adjusted the assertion, while we need in that case to adjust the second location's setting_insn as well. Fixed thusly, bootstrapped/regtested on x8

[Patch, AVR]: AVR backend cleanup: use elfos.h

2011-06-27 Thread Georg-Johann Lay
This patch removes ELF dependencies from avr.h and redundancies from avr.h and avr.c The AVR BE defines many things that are readily available in elfos.h. ELF is the only target supported by avr-gcc. The patch includes elfos.h in config.gcc for all avr* targets together with a new file avr/elf.h.

Re: [PATCH] Use TYPE_NEXT_VARIANT instead of TREE_CHAIN as chain_next for types during GC (PR c++/46400)

2011-06-27 Thread Jakub Jelinek
On Fri, Jun 24, 2011 at 03:21:07PM -0700, Richard Henderson wrote: > On 06/24/2011 07:43 AM, Jakub Jelinek wrote: > > + chain_next ("CODE_CONTAINS_STRUCT (TREE_CODE (&%h.generic), > > TS_TYPE_COMMON) ? ((union lang_tree_node *) TYPE_NEXT_VARIANT > > (&%h.generic)) : CODE_CONTAINS_STRUCT (TR

[pph] New test (issue4629075)

2011-06-27 Thread Diego Novillo
We are very close to having the first simple C++ program working from a PPH image. Adding a runnable test case. This produces assembly miscomparisons and does not link. I'll be working on it this week. Diego. * g++.dg/pph/x1ten-hellos.cc: New. * g++.dg/pph/x1ten-hellos.h: New.

[pph] Add header files to pph.map (issue4639073)

2011-06-27 Thread Diego Novillo
When I added these tests, I forgot to add them to pph.map, so the header files were being generated into an image, but not used in the second compilation. Most of the failures are in the form of different asm output. There is one new ICE, though. Committed to branch. Diego. * g++.dg/

Re: Simplify Solaris configuration

2011-06-27 Thread Rainer Orth
Eric, >> All bootstraps completed without regressions, so I've installed the >> patch. I'll address eventual issues and further simplifications as a >> followup. > > I cannot bootstrap SPARC64/Solaris anymore though: [...] > from /nile.build/botcazou/gcc-head/src/libgcc/../gcc/libgcc2.c:29: > /us

[RFC] Fix full memory barrier on SPARC-V8

2011-06-27 Thread Eric Botcazou
The memory_barrier pattern expands to UNSPEC_MEMBAR on the SPARC and the latter is implemented differently for V8 and V9: (define_insn "*stbar" [(set (match_operand:BLK 0 "" "") (unspec:BLK [(match_dup 0)] UNSPEC_MEMBAR))] "TARGET_V8" "stbar" [(set_attr "type" "multi")]) ;; memba

Re: varpool alias reorg

2011-06-27 Thread Michael Matz
Hi, On Mon, 27 Jun 2011, Jan Hubicka wrote: > > I still like to stream unmodified builtins as builtins, as that is > > similar to pre-loading the streamer caches with things like > > void_type_node or sizetype. > > Doing so will need us to solve the other one decl rules probly. I didn't > rea

Re: PATCH [11/n]: Prepare x32: PR rtl-optimization/48155: Reload doesn't handle subreg properly

2011-06-27 Thread H.J. Lu
On Mon, Jun 27, 2011 at 7:52 AM, Ulrich Weigand wrote: > H.J. Lu wrote: > >> Given input: >> >> (plus:SI (subreg:SI (plus:DI (reg/f:DI 7 sp) >>             (const_int 16 [0x10])) 0) >>     (const_int -1 [0x])) > > Once again, this seems weird as legitimate address ...  If this real

Re: varpool alias reorg

2011-06-27 Thread Jan Hubicka
> On Fri, 24 Jun 2011, Jan Hubicka wrote: > > > Hi, > > this is yet another variant of the fix. This time we stream builtins decls > > as > > usually, but at fixup time we copy the assembler names (if set) into the > > builtin decls used by folders. Not sure if it is any better than breaking >

Re: [patch tree-optimization]: Try to sink type-casts for binary and/or/xor operations

2011-06-27 Thread Kai Tietz
- Original Message - From: "Richard Guenther" To: "Kai Tietz" Cc: gcc-patches@gcc.gnu.org Sent: Monday, June 27, 2011 4:08:41 PM Subject: Re: [patch tree-optimization]: Try to sink type-casts for binary and/or/xor operations On Mon, Jun 27, 2011 at 3:46 PM, Kai Tietz wrote: > Hello, >

Re: [patch tree-optimization]: Try to sink type-casts for binary and/or/xor operations

2011-06-27 Thread Kai Tietz
2011/6/27 Richard Guenther : > On Mon, Jun 27, 2011 at 3:46 PM, Kai Tietz wrote: >> Hello, >> >> this patch sink type conversions in forward-propagate for the following >> patterns: >> - ((type) X) op ((type) Y): If X and Y have compatible types. >> - ((type) X) op CST: If the conversion of (type

PING Re: PATCH: fix collect2 handling of --demangle and --no-demangle

2011-06-27 Thread Sandra Loosemore
Ping? http://gcc.gnu.org/ml/gcc-patches/2011-06/msg01368.html We had a bug report from a customer that the linker was ignoring the --demangle and --no-demangle options when generating map files. Moreover, it was failing in a host-dependent way; on Windows hosts, it was always emitting demangled

Re: [PATCH] Fixup current_pass after running IPA transforms

2011-06-27 Thread Jan Hubicka
> > Running IPA transforms will mess up current_pass (and reset it > to NULL), ICEing later for IPA PTA. I also don't see any > code that would avoid doing IPA transforms twice in case > we put another small IPA pass in the late IPA pass queue. Honza, > I guess we need to add some PROP_ipa_trans

[gcc patch] Re: C++ member function template id not matching linkage name (PR debug/49408)

2011-06-27 Thread Jan Kratochvil
On Wed, 22 Jun 2011 17:42:34 +0200, Jason Merrill wrote: > Well, the basic issue is that the "linkage name" is produced by > libiberty/cp-demangle.c and the DW_AT_name is produced by > gcc/cp/error.c, and they don't always agree on the same > pretty-printed representation of a C++ expression. File

Re: RFA; MN10300: Fix AM33 clzsi2 pattern

2011-06-27 Thread Richard Henderson
On 06/25/2011 09:29 PM, Nick Clifton wrote: > * mn10300.md (clzsi2): Use XOR after BSCH to convert bit position > of highest bit set into a count of the high zero bits. Ok. r~

Re: PATCH [8/n]: Prepare x32: PR other/48007: Unwind library doesn't work with UNITS_PER_WORD > sizeof (void *)

2011-06-27 Thread Jason Merrill
On 06/26/2011 05:58 PM, H.J. Lu wrote: The current unwind library scheme provides only one unwind context and is backward compatible with multiple different unwind contexts from multiple unwind libraries: http://gcc.gnu.org/ml/gcc-patches/2006-12/msg01769.html My patch fixes UNITS_PER_WORD > si

Re: PATCH [11/n]: Prepare x32: PR rtl-optimization/48155: Reload doesn't handle subreg properly

2011-06-27 Thread Ulrich Weigand
H.J. Lu wrote: > Given input: > > (plus:SI (subreg:SI (plus:DI (reg/f:DI 7 sp) > (const_int 16 [0x10])) 0) > (const_int -1 [0x])) Once again, this seems weird as legitimate address ... If this really can occur validly, there'll probably need to be an insn+splitte

Re: PATCH [10/n]: Prepare x32: PR rtl-optimization/49114: Reload failed to handle (set reg:X (plus:X (subreg:X (reg:Y) 0) (const_int

2011-06-27 Thread Ulrich Weigand
H.J. Lu wrote: > When reload gets: > > (insn 588 587 589 28 (set (mem:DF (zero_extend:DI (plus:SI (subreg:SI > (reg/v/f:DI 182 [ b ]) 0) > (const_int 8 [0x8]))) [4 MEM[base: b_96(D), index: > D.15020_278, step: 8, offset: 0B]+0 S8 A64]) > (reg:DF 340 [ D.14980 ])) spo

Re: Unreviewed build/libgcc, mudflap patches

2011-06-27 Thread Frank Ch. Eigler
Hi - > >> http://gcc.gnu.org/ml/gcc-patches/2011-06/msg01446.html > > Looks good to me, thanks for taking a look at the area. > > Could you also comment on the open questions in the submission so > mudflap support on Solaris can be improved further? Sure. Transcribing: > One generic is

Re: [pph] Stream chain of struct fields (issue4631072)

2011-06-27 Thread Diego Novillo
On Fri, Jun 24, 2011 at 19:13, Gabriel Charette wrote: > We were only streaming the first field of every struct. Struct fields have a > chain link to the next field, thus we need to stream the DECL_CHAIN of every > field as well recursively. > > I limited this to VAR_DECL and FUNCTION_DECL for n

  1   2   >