Re: [PATCH, LTO] Re-assign BINFOs when unifying types

2011-08-11 Thread Richard Guenther
On Wed, 10 Aug 2011, Martin Jambor wrote: > Hi, > > the following patch sets BINFOs of prevailing but non-main-variant > types to what the main variant has, so that for a type t with a binfo > the following is always true: > > TYPE_BINFO (t) == TYPE_BINFO (TYPE_MAIN_VARIANT (t)) > > as I I beli

RE: [wwwdocs] Announce new ARM/embedded-4_6-branch branch

2011-08-11 Thread Terry Guo
Hi Gerald, Thanks for your review. Here I attached the updated one. Is it ok to commit? BR, Terry > -Original Message- > From: Gerald Pfeifer [mailto:ger...@pfeifer.com] > Sent: Monday, August 08, 2011 5:43 PM > To: Terry Guo > Cc: gcc-patches@gcc.gnu.org; Richard Earnshaw; Matthew Grett

Re: Linemap force location and remove LINEMAP_POSITION_FOR_COLUMN (issue4801090)

2011-08-11 Thread Richard Guenther
On Wed, Aug 10, 2011 at 8:22 PM, Gabriel Charette wrote: > There was a bug where c_finish_options would create some builtins and assign > them source_locations in the linemap other than BUILTINS_LOCATION == 1. > > Thus, when calling DECL_IS_BUILTIN to know if a decl is a builtin, some of > them

Re: Allowing filename-style globs in define_bypass

2011-08-11 Thread Richard Sandiford
Bernd Schmidt writes: > On 07/21/11 13:28, Richard Sandiford wrote: >> +static void >> +process_bypass_2 (decl_t model, decl_t out_insn_reserv, void *data) >> +{ >> + struct bypass_decl *bypass; >> + decl_t in_insn_reserv; >> + >> + in_insn_reserv = (decl_t) data; >> + bypass = XCNEW (struct b

Re: [PATCH][C++] Remove last use of can_trust_pointer_alignment

2011-08-11 Thread Richard Guenther
On Wed, 10 Aug 2011, Richard Guenther wrote: > On Wed, 10 Aug 2011, Richard Guenther wrote: > > > On Wed, 10 Aug 2011, Jason Merrill wrote: > > > > > On 08/10/2011 08:35 AM, Richard Guenther wrote: > > > > * call.c (build_over_call): Call memcpy unconditionally. > > > > > > OK. Have yo

Re: [PATCH, testsuite, i386] AVX2 support for GCC

2011-08-11 Thread Kirill Yukhin
Hi Uros, Thanks for patience reviewing my English :) and for finding a bug in souces. Updated patch is attached. It was bootstrapped successfully. updated ChangeLog entry: 2011-08-11 Kirill Yukhin * common/config/i386/i386-common.c (OPTION_MASK_ISA_AVX2_SET): New. (OPTION_MAS

RE: [PATCH, ARM] Generate conditional compares in Thumb2 state

2011-08-11 Thread Jiangning Liu
Ramana, I only see the following three combinations are meaningful, * cmp l, lPy // keep cmp, and length is 2, on thumb * cmp r, rI // keep cmp, and length is 4 * cmp r, L // convert to cmn, and length is 4 According to ARM ARM, for negative immediate, all encodings for cmp/cmn are 4-byte lo

Re: CFT: [build] Move shlib support to toplevel libgcc

2011-08-11 Thread Paolo Bonzini
On 08/10/2011 01:14 PM, Rainer Orth wrote: * At the moment, SHLIB_LINK is used in gcc/Makefile.in and the various Make-lang.in fragments to check if the target supports a shared libgcc_s. I've introduced gcc/config/t-slibgcc (from t-slibgcc-dummy) for this, which sets SHLIB = true, addi

Re: [build] Move unwinder to toplevel libgcc (v2)

2011-08-11 Thread Paolo Bonzini
On 08/10/2011 06:50 PM, Pedro Alves wrote: On Wednesday 10 August 2011 17:05:08, Rainer Orth wrote: > Paolo Bonzini writes: > > >> True: it is called once per multilib. > > > > Just to doublecheck, are we sure that unwind.h is always the same? > > Yep: it's unwind-generic.h for almost

[ARM] Fix minipool handling of aligned labels

2011-08-11 Thread Richard Sandiford
Trying to compile a certain embedded benchmark with -falign-loops=8 or above fails due to out-of-range references to the literal pool. This is because arm_reorg doesn't take label alignment into account. Fixed with the patch below. Tested on arm-linux-gnueabi. I also tried compiling libav with a

Re: [build] Move unwinder to toplevel libgcc (v2)

2011-08-11 Thread Rainer Orth
Paolo Bonzini writes: > On 08/10/2011 06:50 PM, Pedro Alves wrote: >> On Wednesday 10 August 2011 17:05:08, Rainer Orth wrote: >>> > Paolo Bonzini writes: >>> > > > >> True: it is called once per multilib. > > > > Just to doublecheck, are we sure that unwind.h is always the s

Commit: RX: Add support for conditional register moves

2011-08-11 Thread Nick Clifton
Hi Guys, I am applying the patch below on behalf of Renesas. It adds support to the RX backend for conditional register moves. Tested without any regressions on an rx-elf toolchain. Cheers Nick gcc/ChangeLog 2011-08-11 Kazuhiro Inaoka * config/rx/rx.md (movsicc): Allow reg

Re: [lto] Remove most streamer hooks. (issue4863041)

2011-08-11 Thread Michael Matz
Hi, On Wed, 10 Aug 2011, Diego Novillo wrote: >The API in the tree streamer offers functions to read/write the >tree header and the body, a streamer cache and everything that >used to be inside the LTO streamer. This makes no difference to >LTO, since it simply means that some fo

Re: [lto] Remove most streamer hooks. (issue4863041)

2011-08-11 Thread Diego Novillo
On Thu, Aug 11, 2011 at 08:23, Michael Matz wrote: > The obvious question: have you measured performance (with an optimized > cc1) on a medium sized exectutable, say cc1 itself?  (I'm worrying about > inlining that doesn't happen anymore). Ah, good point. No, I haven't. I'll measure it. Dieg

[PATCH, middle end]: Introduce BUILT_IN_I{CEIL_FLOOR_ROUND_RINT} FP-to-int conversion functions

2011-08-11 Thread Uros Bizjak
Hello! Currently, conversion from floating point to integer on 64bit targets goes through DImode temporary, due to missing BUILT_IN_ICEIL (and other) builtins that can convert directly from FP to integer. Attached patch introduces these builtins and improves i.e.: int test (double a) { return

Re: [lto] Remove most streamer hooks. (issue4863041)

2011-08-11 Thread Diego Novillo
On Thu, Aug 11, 2011 at 04:45, Richard Guenther wrote: >> 5- Handle CALL_EXPR in lto_materialize_tree.  Despite the name this is >>    a generic tree streaming function (the renaming patch will come >>    in the next few days).  Handling CALL_EXPR does not >>    affect LTO (since those nodes are

Re: [PATCH, middle end]: Introduce BUILT_IN_I{CEIL_FLOOR_ROUND_RINT} FP-to-int conversion functions

2011-08-11 Thread Richard Guenther
On Thu, 11 Aug 2011, Uros Bizjak wrote: > Hello! > > Currently, conversion from floating point to integer on 64bit targets > goes through DImode temporary, due to missing BUILT_IN_ICEIL (and > other) builtins that can convert directly from FP to integer. > > Attached patch introduces these built

[PATCH] Fix PR50040

2011-08-11 Thread Richard Guenther
This restores some of the uninitialized warnings for memory and applies some TLC to the machinery. Any idea why the C++ FE prints that funny setbuf.a::mode instead of simply setbuf.mode for g++.dg/warn/unit-1.C!? The latter is what debug_generic_expr dumps. Bootstrapped and tested on x86_64-unk

Re: plugin event for C/C++ declarations

2011-08-11 Thread Romain Geissler
On 08/10/2011 05:20 PM, Diego Novillo wrote: On Mon, Aug 8, 2011 at 07:39, Romain Geissler wrote: 2011/7/20 Diego Novillo: On Mon, Jul 18, 2011 at 03:06, Romain Geissler I will commit this patch shortly. Diego. Ping ! Romain, please send me a current patch against today's trunk. Thank

[PATCH, libstdc++-v3] Enable to cross-test libstdc++ on simulator.

2011-08-11 Thread Terry Guo
Hello, In order to run regression test on simulator, the testglue.c will be compiled and linked to return the return status of cases executed on simulator. In my recent work, I built a cross compiler for arm-none-eabi. When run regression test for libstdc++-v3 using command "make check-target "RUN

Re: Linemap force location and remove LINEMAP_POSITION_FOR_COLUMN (issue4801090)

2011-08-11 Thread Diego Novillo
On Thu, Aug 11, 2011 at 03:27, Richard Guenther wrote: > On Wed, Aug 10, 2011 at 8:22 PM, Gabriel Charette wrote: >> There was a bug where c_finish_options would create some builtins and assign >> them source_locations in the linemap other than BUILTINS_LOCATION == 1. >> >> Thus, when calling DE

Re: PATCH: PR middle-end/49721: convert_memory_address_addr_space may generate invalid new insns

2011-08-11 Thread H.J. Lu
Hi, This is the last patch needed for x32 support. convert_memory_address_addr_space is called to convert a memory address without overflow/underflow. It should be safe to transform (zero_extend:DI (plus:SI (FOO:SI) (const_int Y))) to (plus:DI (zero_extend:DI (FOO:SI)) (const_int Y)) GCC only

Re: Linemap force location and remove LINEMAP_POSITION_FOR_COLUMN (issue4801090)

2011-08-11 Thread Richard Guenther
On Thu, Aug 11, 2011 at 3:01 PM, Diego Novillo wrote: > On Thu, Aug 11, 2011 at 03:27, Richard Guenther > wrote: >> On Wed, Aug 10, 2011 at 8:22 PM, Gabriel Charette wrote: >>> There was a bug where c_finish_options would create some builtins and >>> assign them source_locations in the linemap

Re: Linemap force location and remove LINEMAP_POSITION_FOR_COLUMN (issue4801090)

2011-08-11 Thread Diego Novillo
On Thu, Aug 11, 2011 at 09:32, Richard Guenther wrote: > Well, they both make sense - you should just not confuse them. > DECL_IS_BUILTIN should probably renamed to > DECL_HAS_BUILTIN_SOURCE_LOCATION or similar. Exactly. The problem is that now they both *seem* to have the same semantics. > I'

Re: [PATCH] Fix PR50040

2011-08-11 Thread Jason Merrill
On 08/11/2011 08:57 AM, Richard Guenther wrote: Any idea why the C++ FE prints that funny setbuf.a::mode instead of simply setbuf.mode for g++.dg/warn/unit-1.C!? Because by the time we're printing the FIELD_DECL, we've forgotten that we're in a COMPONENT_REF context. We could do better, but i

[obvious] Remove -m32 from testcase

2011-08-11 Thread Michael Matz
Hi, gcc.dg/graphite/run-id-pr47593.c (included for PR47653) hardcodes -m32 in dg-options. That's not supported everywhere and the testcase is just as valid without -m32. If it was the case that it needed -m32 for breaking that would be catched by normal multilib testing. Committed as obvious

Re: [ARM] Fix minipool handling of aligned labels

2011-08-11 Thread Richard Earnshaw
On 11/08/11 12:56, Richard Sandiford wrote: > Trying to compile a certain embedded benchmark with -falign-loops=8 > or above fails due to out-of-range references to the literal pool. > This is because arm_reorg doesn't take label alignment into account. > > Fixed with the patch below. Tested on a

Re: Linemap force location and remove LINEMAP_POSITION_FOR_COLUMN (issue4801090)

2011-08-11 Thread Dodji Seketeli
Hello, gch...@google.com (Gabriel Charette) a écrit: > diff --git a/gcc/c-family/c-opts.c b/gcc/c-family/c-opts.c > index 3227f7b..1af8e7b 100644 > --- a/gcc/c-family/c-opts.c > +++ b/gcc/c-family/c-opts.c > @@ -1306,13 +1306,15 @@ c_finish_options (void) > { >size_t i; > > -

Re: [build] Move unwinder to toplevel libgcc (v2)

2011-08-11 Thread Joseph S. Myers
On Thu, 11 Aug 2011, Rainer Orth wrote: > The actual problem are not the runtime libraries, which already know to > search $builddir/.../libgcc for unwind.h and related files. The > copyback is only for the benefit of the testsuite (gcc.target, g++.dg, > gnat.dg, and gcc.dg) where I was too lazy

[PATCH] Fix DECL_IS_BUILTIN uses

2011-08-11 Thread Richard Guenther
This fixes three ones that are clearly wrong. Bootstrapped and tested on x86_64-unknown-linux-gnu, applied. Richard. 2011-08-11 Richard Guenther * lto-cgraph.c (input_node): Use DECL_BUILT_IN. * tree-vrp.c (stmt_interesting_for_vrp): Likewise. (vrp_visit_stmt): Likew

Re: [build] Move unwinder to toplevel libgcc (v2)

2011-08-11 Thread Paolo Bonzini
On 08/11/2011 04:25 PM, Joseph S. Myers wrote: > The actual problem are not the runtime libraries, which already know to > search $builddir/.../libgcc for unwind.h and related files. The > copyback is only for the benefit of the testsuite (gcc.target, g++.dg, > gnat.dg, and gcc.dg) where I w

Re: [build] Move unwinder to toplevel libgcc (v2)

2011-08-11 Thread Rainer Orth
"Joseph S. Myers" writes: > On Thu, 11 Aug 2011, Rainer Orth wrote: > >> The actual problem are not the runtime libraries, which already know to >> search $builddir/.../libgcc for unwind.h and related files. The >> copyback is only for the benefit of the testsuite (gcc.target, g++.dg, >> gnat.dg

Re: [build] Move unwinder to toplevel libgcc (v2)

2011-08-11 Thread Joseph S. Myers
On Thu, 11 Aug 2011, Paolo Bonzini wrote: > On 08/11/2011 04:25 PM, Joseph S. Myers wrote: > > > The actual problem are not the runtime libraries, which already know to > > > search $builddir/.../libgcc for unwind.h and related files. The > > > copyback is only for the benefit of the testsuite

Re: [c++] Keep tm, div_t, ldiv_t, lconv mangling on Solaris (PR libstdc++-v3/1773)

2011-08-11 Thread Rainer Orth
Hi Paolo, > All in all it seems to me that we are pretty close to be able to fix this > old issue now and we are even in Stage 1, thus we can afford to take a bit > of risk and handle possible fallout, thus I would recommend we do for now > the above preprocessor dance (we are talking only about 4

Re: [c++] Keep tm, div_t, ldiv_t, lconv mangling on Solaris (PR libstdc++-v3/1773)

2011-08-11 Thread Marc Glisse
On Thu, 11 Aug 2011, Rainer Orth wrote: I could, but am a bit reluctant to do so since such a fix feels quite fragile, and `fixes' the Solaris headers in many places where they are completely correct. I'll also have to touch , , , and , that all have using std::tm etc. clauses. Actually, you

Re: [c++] Keep tm, div_t, ldiv_t, lconv mangling on Solaris (PR libstdc++-v3/1773)

2011-08-11 Thread Rainer Orth
Marc, > On Thu, 11 Aug 2011, Rainer Orth wrote: > >> I could, but am a bit reluctant to do so since such a fix feels quite >> fragile, and `fixes' the Solaris headers in many places where they are >> completely correct. I'll also have to touch , , >> , and , that all have using std::tm etc. claus

Fix boot/50018

2011-08-11 Thread Richard Henderson
The reduced test case for m68k showed a TLS symbol given to emit_single_push_insn, which resulted in a call insn inside a sequence that I didn't expect. We don't see this on i686 because we pretend that the TLS call isn't a call. Or something. Bootstrapped on i586 for sanity. Committed. r~

Re: [build] Move unwinder to toplevel libgcc (v2)

2011-08-11 Thread Rainer Orth
Paolo Bonzini writes: > On 08/10/2011 06:05 PM, Rainer Orth wrote: >> True: it is called once per multilib. >>> > >>> > Just to doublecheck, are we sure that unwind.h is always the same? >> Yep: it's unwind-generic.h for almost all targets, just a few arm >> targets use config/arm/unwind-a

Re: [build] Move unwinder to toplevel libgcc (v2)

2011-08-11 Thread Rainer Orth
"Joseph S. Myers" writes: > Actually I think the installation of all the installed target headers > should move to libgcc's Makefiles (and the headers themselves should move > under the libgcc/ directory). Agreed, added to my ever-growing todo list for the libgcc move. This would be * gcc/gi

Re: [obvious] Remove -m32 from testcase

2011-08-11 Thread Sebastian Pop
On Thu, Aug 11, 2011 at 08:43, Michael Matz wrote: > Hi, > > gcc.dg/graphite/run-id-pr47593.c (included for PR47653) hardcodes -m32 in > dg-options.  That's not supported everywhere and the testcase is just as > valid without -m32.  If it was the case that it needed -m32 for breaking > that would

[PATCH] Fix SCCVN aggregate copy code some more

2011-08-11 Thread Richard Guenther
When adjusting the C++ FE code generation for base type copies I noticed the XFAILs on g++.dg/tree-ssa/pr41186.C and investigated things a bit. We can fix the testcase easily iff the frontend emits the MEM_REF variants, thus the following patch. Bootstrapped and tested on x86_64-unknown-linux-gn

Re: [build] Move unwinder to toplevel libgcc (v2)

2011-08-11 Thread Paolo Bonzini
On 08/11/2011 05:26 PM, Rainer Orth wrote: > Actually I think the installation of all the installed target headers > should move to libgcc's Makefiles (and the headers themselves should move > under the libgcc/ directory). Agreed, added to my ever-growing todo list for the libgcc move. Thi

[Patch,AVR]: Fix PR49903

2011-08-11 Thread Georg-Johann Lay
This is an optimization in machine dependent reorg to remove redundant comparisons like in cc0 = compare (Reg, Num) if (cc0 == 0) goto L1 cc0 = compare (Reg, Num) if (cc0 > 0) goto L2 The second comparison is redundant an can be removed. Code like this can be seen in binary

Re: plugin event for C/C++ declarations

2011-08-11 Thread Diego Novillo
On Thu, Aug 11, 2011 at 08:59, Romain Geissler wrote: > Find attached the updated patch. Retested for regression on x86_64. Thanks. Committed at rev 177674. Diego.

Re: [build] Move unwinder to toplevel libgcc (v2)

2011-08-11 Thread Rainer Orth
Paolo Bonzini writes: > Writing that down in a wiki page (even as unformatted text) would be > useful. While I'm not too fond of WiKis, I've added some text to http://gcc.gnu.org/wiki/Top-Level_Libgcc_Migration It's ugly right now, but better than nothing. Rainer -- ---

Re: [lto] Remove most streamer hooks. (issue4863041)

2011-08-11 Thread Diego Novillo
On Thu, Aug 11, 2011 at 08:23, Michael Matz wrote: > The obvious question: have you measured performance (with an optimized > cc1) on a medium sized exectutable, say cc1 itself?  (I'm worrying about > inlining that doesn't happen anymore). I compared three things: profiled bootstrap time for C,

Re: Linemap force location and remove LINEMAP_POSITION_FOR_COLUMN (issue4801090)

2011-08-11 Thread Gabriel Charette
On Thu, Aug 11, 2011 at 7:22 AM, Dodji Seketeli wrote: > Hello, > > gch...@google.com (Gabriel Charette) a écrit: > >> diff --git a/gcc/c-family/c-opts.c b/gcc/c-family/c-opts.c >> index 3227f7b..1af8e7b 100644 >> --- a/gcc/c-family/c-opts.c >> +++ b/gcc/c-family/c-opts.c >> @@ -1306,13 +1306,15 @

Re: Linemap force location and remove LINEMAP_POSITION_FOR_COLUMN (issue4801090)

2011-08-11 Thread Gabriel Charette
On Thu, Aug 11, 2011 at 12:27 AM, Richard Guenther wrote: > On Wed, Aug 10, 2011 at 8:22 PM, Gabriel Charette wrote: >> There was a bug where c_finish_options would create some builtins and assign >> them source_locations in the linemap other than BUILTINS_LOCATION == 1. >> >> Thus, when calling

[pph] Remove unnecessary one liner functions (issue4867044)

2011-08-11 Thread Diego Novillo
Small cleanup patch to remove two functions that just dispatched to pph cache functions. It was useless and confusing. Tested on x86_64. Committed. Diego. * pph-streamer-in.c (pph_in_shared_data): Remove. Update all users. (pph_register_shared_data): Remove. Update all user

Re: Linemap force location and remove LINEMAP_POSITION_FOR_COLUMN (issue4801090)

2011-08-11 Thread Richard Guenther
On Thu, Aug 11, 2011 at 6:54 PM, Gabriel Charette wrote: > On Thu, Aug 11, 2011 at 12:27 AM, Richard Guenther > wrote: >> On Wed, Aug 10, 2011 at 8:22 PM, Gabriel Charette wrote: >>> There was a bug where c_finish_options would create some builtins and >>> assign them source_locations in the li

Re: Linemap force location and remove LINEMAP_POSITION_FOR_COLUMN (issue4801090)

2011-08-11 Thread Dodji Seketeli
Gabriel Charette a écrit: > On Thu, Aug 11, 2011 at 12:27 AM, Richard Guenther > wrote: >> On Wed, Aug 10, 2011 at 8:22 PM, Gabriel Charette wrote: >>> There was a bug where c_finish_options would create some builtins and >>> assign them source_locations in the linemap other than BUILTINS_LOCA

Re: Linemap force location and remove LINEMAP_POSITION_FOR_COLUMN (issue4801090)

2011-08-11 Thread Dodji Seketeli
Gabriel Charette a écrit: > That could work given _cpp_lex_direct does receive a cpp_reader as a > parameter. We would need to add logic in _cpp_lex_direct to support > this new field. Correct. > > As I mentioned, we have the same problem in pph where we need to force > a location (i.e. the lex

Re: [PATCH][C++] Remove last use of can_trust_pointer_alignment

2011-08-11 Thread Jason Merrill
OK. Jason

Re: [graphite] Move to cloog.org interface

2011-08-11 Thread Tobias Grosser
On 08/10/2011 11:41 PM, Sebastian Pop wrote: Hi Tobi, The patch looks good modulo some formatting changes: Thanks for your review. I attached the updated patch. I will commit this patch after the configure changes are in (and meanwhile no further improvements were suggested for this patch).

[v3] Remove some redundant inline together with constexpr

2011-08-11 Thread Paolo Carlini
Hi, straightforward (7.1.5/2). Tested x86_64-linux, committed to mainline. Paolo. PS: one could also imagine adding a macro like # ifdef __GXX_EXPERIMENTAL_CXX0X__ # define _GLIBCXX_INLINE_OR_CONSTEXPR constexpr # else # define _GLIBCXX_INLINE_OR_CONSTEXPR inline # endif to be used where no

Re: Linemap force location and remove LINEMAP_POSITION_FOR_COLUMN (issue4801090)

2011-08-11 Thread Gabriel Charette
On Thu, Aug 11, 2011 at 10:14 AM, Richard Guenther wrote: > On Thu, Aug 11, 2011 at 6:54 PM, Gabriel Charette wrote: >> On Thu, Aug 11, 2011 at 12:27 AM, Richard Guenther >> wrote: >>> On Wed, Aug 10, 2011 at 8:22 PM, Gabriel Charette wrote: There was a bug where c_finish_options would cre

Re: [graphite] Move to cloog.org interface

2011-08-11 Thread Sebastian Pop
On Thu, Aug 11, 2011 at 12:52, Tobias Grosser wrote: > I will commit this patch after the configure changes are in (and meanwhile > no further improvements were suggested for this patch). Ok, thanks. Let's hope we will have a configure maintainer that has some spare cycles to go over your first

Re: [graphite] Move to cloog.org interface

2011-08-11 Thread Tobias Grosser
On 08/11/2011 07:03 PM, Sebastian Pop wrote: On Thu, Aug 11, 2011 at 12:52, Tobias Grosser wrote: I will commit this patch after the configure changes are in (and meanwhile no further improvements were suggested for this patch). Ok, thanks. Let's hope we will have a configure maintainer that

[pph] Stream locations in LAMBDA_EXPR and STATIC_ASSERT_EXPR (issue4876042)

2011-08-11 Thread Diego Novillo
No tests depended on this, but since we can now stream locations properly, I added them. Tested on x86_64. Committed. Diego. * pph-streamer-in.c (pph_read_tree_body): Read STATIC_ASSERT_SOURCE_LOCATION and tree_lambda_expr::locus. * pph-streamer-out.c (pph_write_tree_

Re: [build] Move unwinder to toplevel libgcc (v2)

2011-08-11 Thread H.J. Lu
On Thu, Aug 11, 2011 at 8:23 AM, Rainer Orth wrote: > Paolo Bonzini writes: > >> On 08/10/2011 06:05 PM, Rainer Orth wrote: > >>  True: it is called once per multilib. > >  Just to doublecheck, are we sure that unwind.h is always the same? >>> Yep: it's unwind-generic.h for almost a

Re: [build] Move unwinder to toplevel libgcc (v2)

2011-08-11 Thread H.J. Lu
On Thu, Aug 11, 2011 at 11:19 AM, H.J. Lu wrote: > On Thu, Aug 11, 2011 at 8:23 AM, Rainer Orth > wrote: >> Paolo Bonzini writes: >> >>> On 08/10/2011 06:05 PM, Rainer Orth wrote: >> >>  True: it is called once per multilib. > > > >  Just to doublecheck, are we sure that unwind.h is

Re: [Patch,AVR]: Fix PR49903

2011-08-11 Thread Denis Chertykov
2011/8/11 Georg-Johann Lay : > This is an optimization in machine dependent reorg to > remove redundant comparisons like in > >   cc0 = compare (Reg, Num) >   if (cc0 == 0) >     goto L1 > >   cc0 = compare (Reg, Num) >   if (cc0 > 0) >     goto L2 > > The second comparison is redundant an can be r

[PATCH] PR ada/50048: "cc1: note: obsolete option -I- used, please use -iquote instead" during bootstrap

2011-08-11 Thread Ludovic Brenta
OK to apply as trivial? 2011-08-11 Ludovic Brenta PR ada/50048 * gcc-interface/Makefile.in (INCLUDES): replace -I- with -iquote. --- a/src/gcc/ada/gcc-interface/Makefile.in +++ b/src/gcc/ada/gcc-interface/Makefile.in @@ -247,7 +247,7 @@ # Both . and srcdir are used,

Re: [PATCH] PR ada/50048: "cc1: note: obsolete option -I- used, please use -iquote instead" during bootstrap

2011-08-11 Thread Andrew Pinski
On Thu, Aug 11, 2011 at 11:59 AM, Ludovic Brenta wrote: > OK to apply as trivial? > > > 2011-08-11  Ludovic Brenta   > >        PR ada/50048 >        * gcc-interface/Makefile.in (INCLUDES): replace -I- with >        -iquote. > > --- a/src/gcc/ada/gcc-interface/Makefile.in > +++ b/src/gcc/ada/gcc-i

Re: [graphite] Move to cloog.org interface

2011-08-11 Thread Tobias Grosser
On 08/11/2011 07:16 PM, Sebastian Pop wrote: On Thu, Aug 11, 2011 at 13:03, Sebastian Pop wrote: > On Thu, Aug 11, 2011 at 12:52, Tobias Grosser wrote: >> I will commit this patch after the configure changes are in (and meanwhile >> no further improvements were suggested for this patch).

Re: [graphite] Move to cloog.org interface

2011-08-11 Thread Sven Verdoolaege
On Thu, Aug 11, 2011 at 01:16:45PM -0500, Sebastian Pop wrote: > + if (1) > +{ > + /* For now remove the isl_id's from the context before > + translating to CLooG: this code will be removed when the > + domain will also contain isl_id's. */ > + isl_set *context = isl_set_p

Re: [build] Move unwinder to toplevel libgcc (v2)

2011-08-11 Thread Paolo Bonzini
On Thu, Aug 11, 2011 at 20:19, H.J. Lu wrote: > On Thu, Aug 11, 2011 at 8:23 AM, Rainer Orth > wrote: >> Paolo Bonzini writes: >> >>> On 08/10/2011 06:05 PM, Rainer Orth wrote: >> >>  True: it is called once per multilib. > > > >  Just to doublecheck, are we sure that unwind.h is alw

Re: Linemap force location and remove LINEMAP_POSITION_FOR_COLUMN (issue4801090)

2011-08-11 Thread Gabriel Charette
On Thu, Aug 11, 2011 at 10:45 AM, Dodji Seketeli wrote: >> As I mentioned, we have the same problem in pph where we need to force >> a location (i.e. the lexer is assigning new locations, but we don't >> want it to when we are replaying pre-processor tokens), so just a >> "builtin_location" field

[google] fix a static promotion bug -- not handling aliases in LIPO mode (issue4879042)

2011-08-11 Thread David Li
The following patch will be applied to google branches. 2011-08-11 David Li * l-ipo.c (process_module_scope_static_func): Promote aliases of static symbol in LIPO mode. Index: l-ipo.c === --- l-ipo.c (revision

Re: [graphite] Move to cloog.org interface

2011-08-11 Thread Sebastian Pop
On Thu, Aug 11, 2011 at 14:28, Sven Verdoolaege wrote: > On Thu, Aug 11, 2011 at 01:16:45PM -0500, Sebastian Pop wrote: >> +  if (1) >> +    { >> +      /* For now remove the isl_id's from the context before >> +      translating to CLooG: this code will be removed when the >> +      domain will a

Re: [graphite] Move to cloog.org interface

2011-08-11 Thread Sebastian Pop
On Thu, Aug 11, 2011 at 14:14, Tobias Grosser wrote: > This needs to be adapted to my cloog.org interface patch. I will adapt my patch set to be on top of your patch. >> +/* Return an ISL identifier from the name of the ssa_name E.  */ >> + >> +static isl_id * >> +isl_id_for_ssa_name (scop_p s,

Re: [PATCH, middle end]: Introduce BUILT_IN_I{CEIL_FLOOR_ROUND_RINT} FP-to-int conversion functions

2011-08-11 Thread Uros Bizjak
On Thu, Aug 11, 2011 at 2:50 PM, Richard Guenther wrote: >> Currently, conversion from floating point to integer on 64bit targets >> goes through DImode temporary, due to missing BUILT_IN_ICEIL (and >> other) builtins that can convert directly from FP to integer. > I'm not sure about the naming

Re: [c++] Keep tm, div_t, ldiv_t, lconv mangling on Solaris (PR libstdc++-v3/1773)

2011-08-11 Thread Jason Merrill
On 08/11/2011 10:49 AM, Rainer Orth wrote: There might be an alternative implementation that is less invasive to the C++ frontend, though: add && TARGET_DECL_NAMESPACE_STD_P (decl) in write_unscoped_name, defaulting to true, override it in sol2.h (which gets included via tm.h) and have

Remove LINEMAP_POSITION_FOR_COLUMN macro (issue4874043)

2011-08-11 Thread Gabriel Charette
Removed LINEMAP_POSITION_FOR_COLUMN, it did the EXACT same thing as linemap_position_for_column, so maintaining both in parallel seems like overkill to me. The only thing I can think of is that it's more optimal as it's inlined (but if that's really needed we can always make linemap_position_fo

Re: Linemap force location and remove LINEMAP_POSITION_FOR_COLUMN (issue4801090)

2011-08-11 Thread Gabriel Charette
> I also removed LINEMAP_POSITION_FOR_COLUMN, it did the EXACT same thing as > linemap_position_for_column, so maintaining both in parallel seems like > overkill to me. The only thing I can think of is that it's more optimal as > it's inlined (but if that's really needed we can always make > li

Re: [graphite] Move to cloog.org interface

2011-08-11 Thread Sven Verdoolaege
On Thu, Aug 11, 2011 at 08:14:05PM +0100, Tobias Grosser wrote: > I think the best would be to provide our ctx to cloog when allocating > the CloogState. Yes. skimo

Re: [graphite] Move to cloog.org interface

2011-08-11 Thread Sven Verdoolaege
On Thu, Aug 11, 2011 at 03:10:30PM -0500, Sebastian Pop wrote: > On Thu, Aug 11, 2011 at 14:28, Sven Verdoolaege wrote: > > On Thu, Aug 11, 2011 at 01:16:45PM -0500, Sebastian Pop wrote: > >> + > >> +  /* FIXME: This function will be renamed isl_map_insert_dims and > >> +     documented in a later

Re: [graphite] Move to cloog.org interface

2011-08-11 Thread Sven Verdoolaege
On Thu, Aug 11, 2011 at 03:23:13PM -0500, Sebastian Pop wrote: > As we are using this function only on parameters, get_name should > return a unique name. I guess that the name in isl_id is only used > for debugging purposes, as the ISL manual states that "Identifiers > with the same name but diff

Re: [graphite] Move to cloog.org interface

2011-08-11 Thread Sebastian Pop
On Thu, Aug 11, 2011 at 16:00, Sven Verdoolaege wrote: > On Thu, Aug 11, 2011 at 03:10:30PM -0500, Sebastian Pop wrote: >> On Thu, Aug 11, 2011 at 14:28, Sven Verdoolaege wrote: >> > On Thu, Aug 11, 2011 at 01:16:45PM -0500, Sebastian Pop wrote: >> >> + >> >> +  /* FIXME: This function will be re

Re: [graphite] Move to cloog.org interface

2011-08-11 Thread Sebastian Pop
>>> +  { >>> +    isl_dim *dc = isl_set_get_dim (scop->context); >>> +    int nb_in = isl_dim_size (dc, isl_dim_set); >>> +    int nb_out = 1 + DR_NUM_DIMENSIONS (dr); >>> +    int nbp = scop_nb_params (scop); >>> +    isl_dim *dim = isl_dim_alloc (scop->ctx, nbp, nb_in, nb_out); >>> +    int i; >>

Re: [graphite] Move to cloog.org interface

2011-08-11 Thread Sven Verdoolaege
On Thu, Aug 11, 2011 at 04:59:43PM -0500, Sebastian Pop wrote: > >>> +  { > >>> +    isl_dim *dc = isl_set_get_dim (scop->context); > >>> +    int nb_in = isl_dim_size (dc, isl_dim_set); > >>> +    int nb_out = 1 + DR_NUM_DIMENSIONS (dr); > >>> +    int nbp = scop_nb_params (scop); > >>> +    isl_d

[PATCH 00/11] Partial conversion of Graphite to ISL

2011-08-11 Thread Sebastian Pop
Hi, here are the updated patches for the conversion of Graphite to ISL following the comments from Tobias and Sven. The patches are passing regression testing on amd64-linux. cd .../build/gcc/ make -k check RUNTESTFLAGS=graphite.exp cd .../build/x86_64-unknown-linux-gnu/libgomp/testsuite make -k

[PATCH 02/11] Require cloog 0.16.3

2011-08-11 Thread Sebastian Pop
2011-07-21 Tobias Grosser * configure: Regenerated. * configure.ac: Require cloog isl 0.16.3 Signed-off-by: Sebastian Pop --- ChangeLog|5 + configure|6 +++--- configure.ac |2 +- 3 files changed, 9 insertions(+), 4 deletions(-) diff --git a/ChangeLo

[PATCH 04/11] Document CLooG-ISL requirement for Graphite

2011-08-11 Thread Sebastian Pop
2011-07-26 Sebastian Pop * doc/invoke.texi: Document CLooG-ISL requirement for Graphite. Signed-off-by: Sebastian Pop --- gcc/doc/install.texi | 24 1 files changed, 8 insertions(+), 16 deletions(-) diff --git a/gcc/doc/install.texi b/gcc/doc/install.texi

[PATCH 06/11] Remove ATTRIBUTE_UNUSED

2011-08-11 Thread Sebastian Pop
Signed-off-by: Sebastian Pop --- gcc/graphite-cloog-util.c | 10 +- 1 files changed, 5 insertions(+), 5 deletions(-) diff --git a/gcc/graphite-cloog-util.c b/gcc/graphite-cloog-util.c index 9bc24a0..83cfb54 100644 --- a/gcc/graphite-cloog-util.c +++ b/gcc/graphite-cloog-util.c @@ -236

[PATCH 01/11] Make CLooG-ISL the only supported CLooG version.

2011-08-11 Thread Sebastian Pop
2011-07-21 Tobias Grosser * configure: Regenerated. * config/cloog.m4: Remove support for CLooG-ppl and CLooG-parma, both cloog.org and legacy versions. The only supported version will be CLooG with the isl backend. Signed-off-by: Sebastian Pop --- ChangeLog

[PATCH 07/11] fix memory leak

2011-08-11 Thread Sebastian Pop
Signed-off-by: Sebastian Pop --- gcc/graphite-sese-to-poly.c |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/gcc/graphite-sese-to-poly.c b/gcc/graphite-sese-to-poly.c index 7e23c9d..05280e7 100644 --- a/gcc/graphite-sese-to-poly.c +++ b/gcc/graphite-sese-to-poly.c @@ -19

[PATCH 05/11] Move to new Cloog interface.

2011-08-11 Thread Sebastian Pop
* graphite-clast-to-gimple.c (new_clast_name_index): Store a copy of the string, no just a reference. (clast_name_index): Add a new field, that specifies if we need to free the name. (free_clast_name_index): If necessary, free the name string. (clast_name_index_elt_info): Calculate the

[PATCH 03/11] Remove code that supported legacy CLooG.

2011-08-11 Thread Sebastian Pop
2011-07-21 Tobias Grosser * configure: Regenerated. * config/cloog.m4: Do not define CLOOG_ORG and in gcc/ 2011-07-21 Tobias Grosser * Makefile.in (graphite-clast-to-gimple.o, graphite-cloog-util.o): Remove graphite-cloog-util.h. * graphite-clast-to

[PATCH 10/11] add pbb->domain

2011-08-11 Thread Sebastian Pop
Signed-off-by: Sebastian Pop --- gcc/graphite-poly.c | 12 - gcc/graphite-poly.h |6 ++ gcc/graphite-sese-to-poly.c | 122 ++ 3 files changed, 104 insertions(+), 36 deletions(-) diff --git a/gcc/graphite-poly.c b/gcc/graphite-po

[PATCH 08/11] Add ISL data structures

2011-08-11 Thread Sebastian Pop
Signed-off-by: Sebastian Pop --- gcc/graphite-blocking.c| 12 +++- gcc/graphite-clast-to-gimple.c |9 + gcc/graphite-cloog-util.c | 11 ++- gcc/graphite-cloog-util.h |2 -- gcc/graphite-dependences.c | 11 ++- gcc/graphite-flatt

[PATCH 11/11] add pdr->accesses and pdr->extent

2011-08-11 Thread Sebastian Pop
Signed-off-by: Sebastian Pop --- gcc/graphite-poly.c |7 ++- gcc/graphite-poly.h |4 +- gcc/graphite-sese-to-poly.c | 146 --- 3 files changed, 145 insertions(+), 12 deletions(-) diff --git a/gcc/graphite-poly.c b/gcc/graphite-pol

[PATCH 09/11] Add scop->context

2011-08-11 Thread Sebastian Pop
Signed-off-by: Sebastian Pop --- gcc/graphite-clast-to-gimple.c | 55 ++-- gcc/graphite-cloog-util.c |1 + gcc/graphite-poly.c|8 + gcc/graphite-poly.h|3 + gcc/graphite-sese-to-poly.c| 301 +++- gcc/graphite

Re: [cxx-mem-model] alternate fetch operations

2011-08-11 Thread Lawrence Crowl
On 8/11/11, Andrew MacLeod wrote: > The __sync_mem_fetch_{add,sub,and,xor,or} routines perform the operation > atomically, and return the value that was in memory before the operation > was performed. As I was working on switching the c++ wrappers to use > these new routines, I discovered we also

[PATCH] PR42554/49992: avoid use of '-c' flag with ranlib on darwin10 and later

2011-08-11 Thread Jack Howarth
The following patch addresses http://gcc.gnu.org/bugzilla/show_bug.cgi?id=42554#c15 by extending the logic used in... Author: mrs Date: Fri Mar 19 10:19:52 2010 New Revision: 157563 URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=157563 Log: PR ada/42554 * configure.ac: Only pas

primary vtable not initialized properly

2011-08-11 Thread Xinliang David Li
Compile the following program using 4.6 or trunk compiler and run it, the program will seg fault. The problem is that the D3_Spec's primary vtable has a null entry for virtual function id which it overrides. The root cause is that the base class's virtual function list for the derived class is cop

Re: primary vtable not initialized properly

2011-08-11 Thread Xinliang David Li
A new patch with lightly modified the test case. David On Thu, Aug 11, 2011 at 5:02 PM, Xinliang David Li wrote: > Compile the following program using 4.6 or trunk compiler and run it, > the program will seg fault. The problem is that the D3_Spec's primary > vtable has a null entry for virtual f

Re: [PATCH 09/11] Add scop->context

2011-08-11 Thread Jack Howarth
t;context = isl_set_add_constraint (scop->context, c); > + } > } > >if (ub) > @@ -1474,6 +1750,25 @@ add_param_constraints (scop_p scop, ppl_Polyhedron_t > context, graphite_dim_t p) >ppl_Polyhedron_add_constraint (context, cstr); >ppl_delete_Li

Re: [PATCH, ARM] Fix PR target/49437 Thumb2 epilog with stack realignment

2011-08-11 Thread Ye Joey
Ping ^ 2 On Fri, Aug 5, 2011 at 8:56 AM, Ye Joey wrote: > Ping > > On Wed, Aug 3, 2011 at 8:44 AM, Joey Ye wrote: >> >> This patch fixes PR49437 with a single line change in ARM backend >> and a regression test case for ARM target >> >> ChangeLog: >> 2011-08-02  Matthew Gretton-Dann   >>        

Re: [PATCH 09/11] Add scop->context

2011-08-11 Thread Sebastian Pop
>    This patch falls to compile under clang3.0svn with the error... > > ../../gcc-4.7-20110811/gcc/graphite-sese-to-poly.c:643:8: error: unknown type > name 'isl_id' > static isl_id * >       ^ > ../../gcc-4.7-20110811/gcc/graphite-sese-to-poly.c:647:3: error:

  1   2   >