Re: libsanitizer merge from upstream r175042

2013-02-14 Thread Konstantin Serebryany
On Wed, Feb 13, 2013 at 10:29 PM, H.J. Lu wrote: > On Wed, Feb 13, 2013 at 1:19 AM, Konstantin Serebryany > wrote: >> Hi, >> >> The attached patch is the libsanitizer merge from upstream r175042. >> >> Lots of changes. Among other things: >> - x86_64 linux: change the shadow offset to 0x7fff8000

Re: [PATCH] Backport asan_test.cc changes from upstream

2013-02-14 Thread Jakub Jelinek
On Thu, Feb 14, 2013 at 12:17:27PM +0400, Konstantin Serebryany wrote: > On Wed, Feb 13, 2013 at 8:03 PM, Jakub Jelinek wrote: > > Hi! > > > > This patch backports the asan_test.cc changes since 2013-01-10 from > > upstream. Unfortunately, it seems the tests can't really go standalone, > > the 3

Re: [committed] Revert 0x7fff8000 shadow offset for now

2013-02-14 Thread Konstantin Serebryany
Thanks! This'll let us think about fixing 7fff8000+prelink w/o a rush. Still, can we switch to using asan-rt in ASAN_FLEXIBLE_MAPPING_AND_OFFSET=1 mode? This way we will have fewer differences between gcc variant and upstream and will be able to change the offset w/o changing the rt at all. (and t

Re: [PATCH] Backport asan_test.cc changes from upstream

2013-02-14 Thread Konstantin Serebryany
On Thu, Feb 14, 2013 at 12:41 PM, Jakub Jelinek wrote: > On Thu, Feb 14, 2013 at 12:17:27PM +0400, Konstantin Serebryany wrote: >> On Wed, Feb 13, 2013 at 8:03 PM, Jakub Jelinek wrote: >> > Hi! >> > >> > This patch backports the asan_test.cc changes since 2013-01-10 from >> > upstream. Unfortuna

Re: libsanitizer merge from upstream r175042

2013-02-14 Thread Jakub Jelinek
On Wed, Feb 13, 2013 at 04:19:14PM +0100, Jakub Jelinek wrote: > Here is the patch, works just fine for me here during asan.exp testing. > You can very easily either install and enable prelink on one of your > x86_64-linux testing boxes, or just install it and add test that > will say prelink -r 0x

Re: [cxx-conversion] Add Record Builder Class

2013-02-14 Thread Richard Biener
On Tue, Feb 12, 2013 at 8:47 PM, Lawrence Crowl wrote: > Add class record_builder to ease construction of records and unions. Use it > in some appropriate places. > > Nathan please review the vxworks changes. > > tree.h > New class record_builder. > > tree.c > Implement record_bui

Re: [PING^2] Allow widening multiplication in tree-ssa/slsr-*.c

2013-02-14 Thread Richard Biener
On Thu, Feb 14, 2013 at 7:29 AM, Hurugalawadi, Naveen wrote: > Hi, > > Please consider this as a gentle reminder to review the patch > posted at following link:- > http://gcc.gnu.org/ml/gcc-patches/2013-01/msg00823.html > > Please review the patch and let me know if its okay? Ok. Thanks, Richard

Re: RFC: [MIPS] Add an option to disable ldc1/sdc1

2013-02-14 Thread Richard Sandiford
Chao-Ying Fu writes: > Hello All, > > Once in a while we got reports about programs (ex: WebKit, FireFox) > crash due to ldc1/sdc1 unaligned accesses on MIPS targets. The root > cause is that programmers neglect the alignment issue and cast > arbitrary pointers to point to double variables. > >

[testsuite] Fix gcc.dg/debug/dwarf2/pr53948.c with Sun as

2013-02-14 Thread Rainer Orth
The new gcc.dg/debug/dwarf2/pr53948.c test was failing on Solaris with Sun as: i386 uses / as comment character, while sparc uses !. The following patch accounts for that. Tested on i386-pc-solaris2.10, sparc-sun-solaris2.11, and x86_64-unknown-linux-gnu, installed on mainline. Rainer

[Patch, Fortran, committed] PR56138 - fix deferred-length character result

2013-02-14 Thread Tobias Burnus
This patch undoes the patch http://gcc.gnu.org/ml/fortran/2013-01/msg00219.html which doesn't fix the original problem. (The ICE only occurs if the function is not an internal or module procedure!) As Paul's variant (cf. PR) fixes the issue, this patch now undoes my patch and uses his. Additi

Re: [PATCH] Temporarily revert Steven's PCH changes for 4.8 (PR pch/54117)

2013-02-14 Thread Steven Bosscher
On Thu, Feb 14, 2013 at 12:48 AM, Jakub Jelinek wrote: > On Thu, Feb 14, 2013 at 12:41:30AM +0100, Steven Bosscher wrote: >> > I agree with David that it might be better to give up pch. >> >> That'd be a really a good start. > > You can do it with say following patch instead, PCH is just a compile

Re: [PATCH] Temporarily revert Steven's PCH changes for 4.8 (PR pch/54117)

2013-02-14 Thread Jakub Jelinek
On Thu, Feb 14, 2013 at 11:19:22AM +0100, Steven Bosscher wrote: > On Thu, Feb 14, 2013 at 12:48 AM, Jakub Jelinek wrote: > > On Thu, Feb 14, 2013 at 12:41:30AM +0100, Steven Bosscher wrote: > >> > I agree with David that it might be better to give up pch. > >> > >> That'd be a really a good start.

RE: [patch][wwwdocs] gcc 4.8 changes - AMD new cores

2013-02-14 Thread Gopalasubramanian, Ganesh
Thank you Gerald! Committed with the changes. Regards Ganesh -Original Message- From: Gerald Pfeifer [mailto:ger...@pfeifer.com] Sent: Thursday, February 14, 2013 2:40 PM To: Gopalasubramanian, Ganesh Cc: gcc-patchesUros Bizjak Subject: RE: [patch][wwwdocs] gcc 4.8 changes - AMD new co

Re: [PATCH] Temporarily revert Steven's PCH changes for 4.8 (PR pch/54117)

2013-02-14 Thread Steven Bosscher
On Wed, Feb 13, 2013 at 10:33 PM, David Edelsohn wrote: > The AIX system supports DWARF debugging, but GCC does not generate it > on AIX and GDB does not consume it on AIX. Is there a description for what has to be done in GCC to enable DWARF with AIX as/ld? E.g. is it required to support the ".dw

Re: [PATCH] Fix PR50494

2013-02-14 Thread Jakub Jelinek
On Wed, Feb 13, 2013 at 01:04:04PM +0100, Richard Biener wrote: > 2013-02-13 Richard Biener > > PR lto/50494 > * varasm.c (output_constant_def_1): Get the decl representing > the constant as argument. > (output_constant_def): Wrap output_constant_def_1. > (make_dec

Re: [testsuite] Fix gcc.dg/debug/dwarf2/pr53948.c with Sun as

2013-02-14 Thread Rainer Orth
Rainer Orth writes: > The new gcc.dg/debug/dwarf2/pr53948.c test was failing on Solaris with > Sun as: i386 uses / as comment character, while sparc uses !. The > following patch accounts for that. > > Tested on i386-pc-solaris2.10, sparc-sun-solaris2.11, and > x86_64-unknown-linux-gnu, installe

Re: [PATCH] Fix PR50494

2013-02-14 Thread Richard Biener
On Thu, 14 Feb 2013, Jakub Jelinek wrote: > On Wed, Feb 13, 2013 at 01:04:04PM +0100, Richard Biener wrote: > > 2013-02-13 Richard Biener > > > > PR lto/50494 > > * varasm.c (output_constant_def_1): Get the decl representing > > the constant as argument. > > (output_constant_de

Re: libsanitizer merge from upstream r175042

2013-02-14 Thread Konstantin Serebryany
The patch seems to work on a simple test. Let me digest it. I am trying to understand if there are problems with it other than the added complexity (which is what I don't like the most). -Wl,-Ttext-segment=0x36 does not work with binutils-gold. gold understands -Wl,-Ttext=0x36, but

Re: [cxx-conversion] Add Record Builder Class

2013-02-14 Thread Diego Novillo
On Thu, Feb 14, 2013 at 4:26 AM, Richard Biener wrote: > Note that tag_name does not allow the way C++ uses this (it can be > a TYPE_DECL). > > Overall I'm not sure this is a good abstraction unless you manage to > make the frontends use it. I think that is a mistake. This is a pure gimple faci

Re: C++ PATCH for c++/56135 (wrong 'this' capture)

2013-02-14 Thread Dominique Dhumieres
Hi jason, The test g++.dg/cpp0x/lambda/lambda-this8.C fails on x86_64-apple-darwin10: FAIL: g++.dg/cpp0x/lambda/lambda-this8.C -std=c++11 (test for excess errors) Excess errors: /opt/gcc/work/gcc/testsuite/g++.dg/cpp0x/lambda/lambda-this8.C:6:31: error: declaration of 'void abort() throw ()' has

Re: [PATCH] Fix PR50494

2013-02-14 Thread Jakub Jelinek
On Thu, Feb 14, 2013 at 12:53:47PM +0100, Richard Biener wrote: > > (completely untested). Because, if we force the constant to be aligned > > more than it would be by default, the RTL optimizers should be told about > > that too. > > At the moment the vectorizer refuses to bump alignment for any

[patch] fix build of cross-compiler to AIX

2013-02-14 Thread Steven Bosscher
Hello, Building a cross-compiler from powerpc-linux to powerpc-aix fails with: ../../combined/gcc/collect2.c: In function 'void scan_prog_file(const char*, scanpass, scanfilter)': ../../combined/gcc/collect2.c:2860:8: error: 'F_LOADONLY' was not declared in this scope This is due to: 2013-02-03

Re: libsanitizer merge from upstream r175042

2013-02-14 Thread Jakub Jelinek
On Thu, Feb 14, 2013 at 03:55:47PM +0400, Konstantin Serebryany wrote: > The patch seems to work on a simple test. Let me digest it. > I am trying to understand if there are problems with it other than the > added complexity (which is what I don't like the most). Yes, it is some added complexity,

Re: [PATCH] Temporarily revert Steven's PCH changes for 4.8 (PR pch/54117)

2013-02-14 Thread Jeff Law
On 02/13/13 16:17, John David Anglin wrote: On 2013-02-13 3:33 PM, David Edelsohn wrote: Perhaps Dave can explain what would have to be done to move this platform to DWARF2...? I had looked at this a bit in the past. I don't think it's that difficult to add DWARF2 support to GCC on hppa. Al

Re: [PATCH] Temporarily revert Steven's PCH changes for 4.8 (PR pch/54117)

2013-02-14 Thread Jeff Law
On 02/14/13 03:52, Jakub Jelinek wrote: No, it prevents *reading* of PCH files with -gstabs, so whatever you write into the PCH file is uninteresting. The patch can surely be acompanied by a patch to warn that writing a PCH file is useless in that case, as in your patch, though the spot you cho

Re: [cxx-conversion] Add Record Builder Class

2013-02-14 Thread Richard Biener
On Thu, Feb 14, 2013 at 12:56 PM, Diego Novillo wrote: > On Thu, Feb 14, 2013 at 4:26 AM, Richard Biener > wrote: > >> Note that tag_name does not allow the way C++ uses this (it can be >> a TYPE_DECL). >> >> Overall I'm not sure this is a good abstraction unless you manage to >> make the fronten

Re: [patch] fix build of cross-compiler to AIX

2013-02-14 Thread Richard Biener
On Thu, Feb 14, 2013 at 1:16 PM, Steven Bosscher wrote: > Hello, > > Building a cross-compiler from powerpc-linux to powerpc-aix fails with: > > ../../combined/gcc/collect2.c: In function 'void scan_prog_file(const > char*, scanpass, scanfilter)': > ../../combined/gcc/collect2.c:2860:8: error: 'F_

Re: libsanitizer merge from upstream r175042

2013-02-14 Thread Konstantin Serebryany
On Thu, Feb 14, 2013 at 4:19 PM, Jakub Jelinek wrote: > On Thu, Feb 14, 2013 at 03:55:47PM +0400, Konstantin Serebryany wrote: >> The patch seems to work on a simple test. Let me digest it. >> I am trying to understand if there are problems with it other than the >> added complexity (which is what

Re: [cxx-conversion] Add Record Builder Class

2013-02-14 Thread Diego Novillo
On Thu, Feb 14, 2013 at 7:52 AM, Richard Biener wrote: > Because it's otherwise almost unused. No "usual" gimple pass builds > up record types. What's the point in introducing the abstraction if > most of the users cannot use it? There may be few users on the gimple side, but you are mixing tw

Re: [cxx-conversion] Add Record Builder Class

2013-02-14 Thread Richard Biener
On Thu, Feb 14, 2013 at 2:01 PM, Diego Novillo wrote: > On Thu, Feb 14, 2013 at 7:52 AM, Richard Biener > wrote: > >> Because it's otherwise almost unused. No "usual" gimple pass builds >> up record types. What's the point in introducing the abstraction if >> most of the users cannot use it? >

Re: [patch] fix build of cross-compiler to AIX

2013-02-14 Thread David Edelsohn
On Thu, Feb 14, 2013 at 7:16 AM, Steven Bosscher wrote: > Hello, > > Building a cross-compiler from powerpc-linux to powerpc-aix fails with: > > ../../combined/gcc/collect2.c: In function 'void scan_prog_file(const > char*, scanpass, scanfilter)': > ../../combined/gcc/collect2.c:2860:8: error: 'F_

Re: [PATCH] Temporarily revert Steven's PCH changes for 4.8 (PR pch/54117)

2013-02-14 Thread Tristan Gingold
On Feb 14, 2013, at 12:26 PM, Steven Bosscher wrote: > On Wed, Feb 13, 2013 at 10:33 PM, David Edelsohn wrote: >> The AIX system supports DWARF debugging, but GCC does not generate it >> on AIX and GDB does not consume it on AIX. > > Is there a description for what has to be done in GCC to enabl

Re: [PATCH] Temporarily revert Steven's PCH changes for 4.8 (PR pch/54117)

2013-02-14 Thread David Edelsohn
On Thu, Feb 14, 2013 at 8:21 AM, Tristan Gingold wrote: > > On Feb 14, 2013, at 12:26 PM, Steven Bosscher wrote: > >> On Wed, Feb 13, 2013 at 10:33 PM, David Edelsohn wrote: >>> The AIX system supports DWARF debugging, but GCC does not generate it >>> on AIX and GDB does not consume it on AIX. >>

Re: [cxx-conversion] Add Record Builder Class

2013-02-14 Thread Diego Novillo
On Thu, Feb 14, 2013 at 8:06 AM, Richard Biener wrote: > On Thu, Feb 14, 2013 at 2:01 PM, Diego Novillo wrote: >> On Thu, Feb 14, 2013 at 7:52 AM, Richard Biener >> wrote: >> >>> Because it's otherwise almost unused. No "usual" gimple pass builds >>> up record types. What's the point in introd

Re: [testsuite] Fix gcc.dg/debug/dwarf2/pr53948.c with Sun as

2013-02-14 Thread Jakub Jelinek
On Thu, Feb 14, 2013 at 12:48:01PM +0100, Rainer Orth wrote: > Rainer Orth writes: > --- a/gcc/testsuite/gcc.dg/debug/dwarf2/pr53948.c > +++ b/gcc/testsuite/gcc.dg/debug/dwarf2/pr53948.c > @@ -1,7 +1,7 @@ > /* Test that we have line information for the line > with local variable initializatio

[PATCH,ARM] Set attribute predicable

2013-02-14 Thread Greta Yorsh
This patch sets attribute "predicable" to "yes" for patterns that handle add with carry and already use %? in their output statements. Ok for trunk? Thanks, Greta gcc/ 2013-02-14 Greta Yorsh * config/arm/arm.md (addsi3_carryin_): Set attribute "predicable" to yes. (ad

C++ PATCH for c++/55680 (wrong error for lambda initializing data member specialization)

2013-02-14 Thread Jason Merrill
When we have a lambda-expression in the initializer for a specialization of a class template static data member, we end up in maybe_process_partial_specialization, which sees that processing_specialization is set and concludes that we're trying to specialize the lambda. But we aren't. Tested

Re: [PATCH] Temporarily revert Steven's PCH changes for 4.8 (PR pch/54117)

2013-02-14 Thread Steven Bosscher
On Thu, Feb 14, 2013 at 2:21 PM, Tristan Gingold wrote: >> Is there a description for what has to be done in GCC to enable DWARF >> with AIX as/ld? E.g. is it required to support the ".dwsect" pseudo? >> Is there already a plan from someone to make GCC produce DWARF on >> AIX7? > > Yes, you need to

[Patch, Fortran] PR56318 - Fix MATMUL regression

2013-02-14 Thread Tobias Burnus
This patch fixes the matmul bug, which was reported this morning. Seemingly, the code never worked correctly. Regarding the result patch: Mikael and I came independently to the same result thus it must be right (or not?); additionally, I tested and found out that matrix-scalar/scalar-matrix wa

Re: [Patch, Fortran] PR56318 - Fix MATMUL regression

2013-02-14 Thread Richard Biener
On Thu, Feb 14, 2013 at 3:50 PM, Tobias Burnus wrote: > This patch fixes the matmul bug, which was reported this morning. Seemingly, > the code never worked correctly. > > Regarding the result patch: Mikael and I came independently to the same > result thus it must be right (or not?); additionally

Re: [PATCH] Temporarily revert Steven's PCH changes for 4.8 (PR pch/54117)

2013-02-14 Thread Tristan Gingold
On Feb 14, 2013, at 3:47 PM, Steven Bosscher wrote: > On Thu, Feb 14, 2013 at 2:21 PM, Tristan Gingold wrote: >>> Is there a description for what has to be done in GCC to enable DWARF >>> with AIX as/ld? E.g. is it required to support the ".dwsect" pseudo? >>> Is there already a plan from someone

[AArch64] __atomic_thread_fence and release memory model

2013-02-14 Thread Yvan Roux
Hi, a call to the builtin __atomic_thread_fence with the memory model __ATOMIC_RELEASE generates a data memory barrier with the option ish whereas I think that the one which has the "release" semantic is ishst (store before store). The attached patch implements my proposal. Thanks, Yvan -- gcc/

Re: RFA: v3 PATCH to add on_quick_exit/quick_exit to std

2013-02-14 Thread Rainer Orth
Jason Merrill writes: > While I was going over the C++11 status page, I noticed that quick_exit is > implemented by glibc, it just needed to be added to the libstdc++ cstdlib > header. The test fails on Solaris 9: FAIL: 18_support/quick_exit/quick_exit.cc (test for excess errors) Excess errors:

Re: [PATCH,ARM] Set attribute predicable

2013-02-14 Thread Richard Earnshaw
On 14/02/13 13:53, Greta Yorsh wrote: This patch sets attribute "predicable" to "yes" for patterns that handle add with carry and already use %? in their output statements. Ok for trunk? Thanks, Greta gcc/ 2013-02-14 Greta Yorsh * config/arm/arm.md (addsi3_carryin_): Set attribute

Re: [AArch64] __atomic_thread_fence and release memory model

2013-02-14 Thread Yvan Roux
Oops, I missed that the release semantics is not just store before store but also load before store, sorry for that :( Yvan On 14 February 2013 16:40, Yvan Roux wrote: > Hi, > > a call to the builtin __atomic_thread_fence with the memory model > __ATOMIC_RELEASE generates a data memory barrier w

PATCH: PR bootstrap/56327: [4.8 Regression] Revision 196009 breaks bootstrap on x3

2013-02-14 Thread H.J. Lu
On Thu, Feb 14, 2013 at 12:07 AM, Konstantin Serebryany wrote: > On Wed, Feb 13, 2013 at 10:29 PM, H.J. Lu wrote: >> On Wed, Feb 13, 2013 at 1:19 AM, Konstantin Serebryany >> wrote: >>> Hi, >>> >>> The attached patch is the libsanitizer merge from upstream r175042. >>> >>> Lots of changes. Among

Re: PATCH: PR bootstrap/56327: [4.8 Regression] Revision 196009 breaks bootstrap on x3

2013-02-14 Thread Jakub Jelinek
On Thu, Feb 14, 2013 at 08:33:27AM -0800, H.J. Lu wrote: > 2013-02-14 H.J. Lu > > PR bootstrap/56327 > * interception/interception.h (OFF_T): Merged from upstream > r175140. Ok. > diff --git a/libsanitizer/interception/interception.h > b/libsanitizer/interception/interceptio

Re: [PATCH] GCC 4.9 powerpc, fix insn type attribute for load/store insns

2013-02-14 Thread David Edelsohn
On Mon, Feb 11, 2013 at 9:36 PM, Pat Haugen wrote: > The following patch fixes the assignment of the insn "type" attribute for > loads and stores. Specifically, it will now appropriately assign update form > and update-indexed form type attributes which allows for better instruction > scheduling b

Re: [Ping^2] [Patch, AArch64] Set libgloss_dir for aarch64*-*-* targets

2013-02-14 Thread Yufeng Zhang
Ping^2 Originally posted here: http://gcc.gnu.org/ml/gcc-patches/2013-01/msg00554.html Thanks, Yufeng On 01/28/13 15:04, Yufeng Zhang wrote: Ping~ On 01/10/13 16:20, Yufeng Zhang wrote: Hi, This patch updates the top-level configuration files to explicitly set libgloss_dir to aarch64 for

Re: RFA: v3 PATCH to add on_quick_exit/quick_exit to std

2013-02-14 Thread Paolo Carlini
Hi Rainer, On 02/14/2013 04:45 PM, Rainer Orth wrote: Jason Merrill writes: While I was going over the C++11 status page, I noticed that quick_exit is implemented by glibc, it just needed to be added to the libstdc++ cstdlib header. The test fails on Solaris 9: FAIL: 18_support/quick_exit/q

Re: [Patch, AArch64] Set libgloss_dir for aarch64*-*-* targets

2013-02-14 Thread Richard Earnshaw
On 10/01/13 16:20, Yufeng Zhang wrote: Hi, This patch updates the top-level configuration files to explicitly set libgloss_dir to aarch64 for aarch64*-*-* targets. OK to commit? Thanks, Yufeng 2013-01-10 Yufeng Zhang * configure.ac: Set libgloss_dir for the aarch64*-*-* targets.

[PATCH,testsuite] Added test for PR 55987

2013-02-14 Thread Tilman Sauerbeck
Hi, here's a patch that adds a testcase for PR 55987. Is xfail the right thing to use here? I went with that since I guess the PR won't be fixed anytime soon ;) I haven't assigned copyright to the FSF -- is this patch small enough to go in without it? Thanks, Tilman 2013-02-14 Tilman Sauerbeck

Re:

2013-02-14 Thread Xinliang David Li
On Thu, Feb 14, 2013 at 10:18 AM, Matt wrote: > The attached patches do two things: > 1. Backports a fix from trunk that eliminates bogus warning traces. On my > current codebase which links ~40MB of C++ with LTO, the bogus warning traces > are literally hundreds of lines. > What is the trunk rev

Re: RFA: v3 PATCH to add on_quick_exit/quick_exit to std

2013-02-14 Thread Paolo Carlini
... or the below, just in case an interesting system provides the *quick_exit functions but doesn't define _GLIBCXX_USE_C99. Paolo. /// Index: testsuite/18_support/quick_exit/quick_exit.cc === --- testsuite/18_s

Re: [cxx-conversion] Add Record Builder Class

2013-02-14 Thread Lawrence Crowl
On 2/14/13, Richard Biener wrote: > On Tue, Feb 12, 2013 at 8:47 PM, Lawrence Crowl wrote: > > Add class record_builder to ease construction of records and unions. Use > > it > > in some appropriate places. > > tree > > -default_emutls_var_fields (tree type, tree *name ATTRIBUTE_UNUSED) >

Re:

2013-02-14 Thread Matt Hargett
On Feb 14, 2013, at 10:40 AM, Xinliang David Li wrote: > On Thu, Feb 14, 2013 at 10:18 AM, Matt wrote: >> The attached patches do two things: >> 1. Backports a fix from trunk that eliminates bogus warning traces. On my >> current codebase which links ~40MB of C++ with LTO, the bogus warning trac

C++ PATCH for c++/55232 (ICE on diagnostic in variadic template function)

2013-02-14 Thread Jason Merrill
We try to print typename types when dumping template bindings in order to be helpful. But we can't do that for typenames in pack expansions because we don't know which pack element we're interested in. Tested x86_64-pc-linux-gnu, applying to trunk. commit 91f6181cddda74ddfbae6e57454ab696598479

Re:

2013-02-14 Thread Xinliang David Li
Ok for the google branch -- please provide the patch details in svn commit message (note that ChangeLog is not needed any more for the branch). David On Thu, Feb 14, 2013 at 11:53 AM, Matt Hargett wrote: > On Feb 14, 2013, at 10:40 AM, Xinliang David Li wrote: > >> On Thu, Feb 14, 2013 at 10:

Re:

2013-02-14 Thread Matt
On Thu, 14 Feb 2013, Xinliang David Li wrote: Ok for the google branch -- please provide the patch details in svn commit message (note that ChangeLog is not needed any more for the branch). I don't have commit access (yet). Should I email overse...@gcc.gnu.org as mentioned at http://gcc.gnu.o

Re: [PATCH] Temporarily revert Steven's PCH changes for 4.8 (PR pch/54117)

2013-02-14 Thread Tom Tromey
> "Dave" == John David Anglin writes: Dave> I had looked at this a bit in the past. I don't think it's that Dave> difficult to add DWARF2 support Dave> to GCC on hppa. Although we don't support named sections, we can Dave> create named subspaces Dave> for the dwarf info. More of an issue i

Re: [PING^3] Re: [PATCH 1/2] Document HLE / RTM intrinsics

2013-02-14 Thread Andi Kleen
Andi Kleen writes: PING^3 I'm about to give up on this, concluding that there is no interest in improving the gcc documentation. -Andi > Andi Kleen writes: > > PING^2!! > >> Andi Kleen writes: >> >>> From: Andi Kleen >>> >>> The TSX HLE/RTM intrinsics were missing documentation. Add this to

Re: [patch, Fortran] Fix PR 56224

2013-02-14 Thread Thomas Koenig
Hi Tobias, OK. Thanks for the patch after fixing the nit below. Sorry for not noticing the review when you sent it. Here is the patch as I committed it as Revision 196058. 2013-02-14 Thomas Koenig PR fortran/56224 * gfortran.h (gfc_add_include_path): Add boolean argument

[RS6000] PR55341 linux unwind fixes

2013-02-14 Thread Alan Modra
PR55341 has two complaints, that powerpc gcc references a non-ABI symbol exported by glibc, and that the scheme used to find the aux vector can be broken by someone writing *environ = 0. Both true, but since this code is only exercised when running Linux kernels prior to 2.6.15 (7 years old!), I w

C++ PATCH for c++/55223 (ICE with lambda in default argument scope)

2013-02-14 Thread Jason Merrill
In this PR, when we go to substitute into LAMBDA_EXPR_EXTRA_SCOPE, we look for a local specialization of the parameter 'f', but there isn't one because we aren't in a function body. For this case, unlike uses in a trailing-return-type, we really need to look up the parameter in the function pa

Re: [PATCH,testsuite] Added test for PR 55987

2013-02-14 Thread Janis Johnson
On 02/14/2013 10:02 AM, Tilman Sauerbeck wrote: > Hi, > here's a patch that adds a testcase for PR 55987. > Is xfail the right thing to use here? I went with that since I guess the > PR won't be fixed anytime soon ;) > > I haven't assigned copyright to the FSF -- is this patch small enough to > go

C++ PATCH for c++/56323 (rejects valid inheriting constructors)

2013-02-14 Thread Jason Merrill
The standard says that using X::X always means inheriting constructors, even if X is a typedef. In templates, we also need to support this usage for template template parameters, not just type parameters. Tested x86_64-pc-linux-gnu, applying to trunk. commit 2b5203157486e00788228c2fe8572b5bbf4

C++ PATCH for c++/55220 (ICE with non-deducible parameter pack)

2013-02-14 Thread Jason Merrill
This testcase is well-formed, even though it doesn't do what the user was trying to accomplish. In Tuple the use of a pack expansion not at the end of the list makes the whole argument list a non-deduced context, so we should get out early before it confuses us. Tested x86_64-pc-linux-gnu, ap

Re: [Patch] Cleanup gcc.target/arm/interrupt-*.c for thumb mode

2013-02-14 Thread Janis Johnson
On 02/13/2013 06:39 AM, Greta Yorsh wrote: > The tests gcc.target/arm/interrupt-*.c are for ARM mode only. > This patch uses effective target arm_notthumb instead of __thumb_ predefine, > removes unreachable code, and fixes typos. > > Ok for trunk? > OK Janis > Thanks, > Greta > > ChangeLog >

[patch] give graphs from graph dump a name

2013-02-14 Thread Steven Bosscher
Hello, A user sent me a request to give names to the digraph in a graph dump. This name can be used as a key for the dump, for a tool that can generate graph metrics to see GCC transforms code as it passes through the pipeline. Another user requested the same thing for a hacked xdot that can plot

Re: [PATCH] Temporarily revert Steven's PCH changes for 4.8 (PR pch/54117)

2013-02-14 Thread Joel Brobecker
> >> AFAICT, for gcc+gas it should already work with binutils that include > >> the AdaCore patch for DWARF support. But this has apparently not been > >> tested with AIX ld, and there are AdaCore local patches pending. > >> http://sourceware.org/ml/binutils/2011-04/msg00250.html > >> http://www.so

RE: RFC: [MIPS] Add an option to disable ldc1/sdc1

2013-02-14 Thread Chao-Ying Fu
Richard Sandiford wrote: > Chao-Ying Fu writes: > > Hello All, > > > > Once in a while we got reports about programs (ex: > WebKit, FireFox) > > crash due to ldc1/sdc1 unaligned accesses on MIPS targets. The root > > cause is that programmers neglect the alignment issue and cast > > arbitrary

Re: [RS6000] PR55341 linux unwind fixes

2013-02-14 Thread David Edelsohn
On Thu, Feb 14, 2013 at 5:33 PM, Alan Modra wrote: > PR55341 has two complaints, that powerpc gcc references a non-ABI > symbol exported by glibc, and that the scheme used to find the aux > vector can be broken by someone writing *environ = 0. Both true, but > since this code is only exercised wh

C++ PATCH for c++/55003 (wrong error with auto template static data member)

2013-02-14 Thread Jason Merrill
Normally we defer instantiation of the initializer of a static data member of a template class until it is actually needed. If we need it for deducing the type of the variable, we can go ahead and instantiate it at that point. Tested x86_64-pc-linux-gnu, applying to trunk. commit fe74d7110cba

C++ PATCH for c++/54922 (constexpr and anonymous union)

2013-02-14 Thread Jason Merrill
When we're building up a CONSTRUCTOR to represent the initialization done by a constexpr constructor, initialization of a member of an anonymous union shows up as an assignment to a COMPONENT_REF of the main class object. We need to turn this into a CONSTRUCTOR for the anonymous union object i

Re: RFC: [MIPS] Add an option to disable ldc1/sdc1

2013-02-14 Thread Maciej W. Rozycki
On Thu, 14 Feb 2013, Richard Sandiford wrote: > What about 64-bit targets? We can sometimes access doubles using GPRs, > so on 64-bit targets we could end up using LD and SD to access a double > even when this option disables LDC1 and SDC1. I think we'd need to > patch the move patterns as well.

Re: RFC: [MIPS] Add an option to disable ldc1/sdc1

2013-02-14 Thread Andrew Pinski
On Thu, Feb 14, 2013 at 5:23 PM, Maciej W. Rozycki wrote: > On Thu, 14 Feb 2013, Richard Sandiford wrote: > >> What about 64-bit targets? We can sometimes access doubles using GPRs, >> so on 64-bit targets we could end up using LD and SD to access a double >> even when this option disables LDC1 a

Re: RFA: v3 PATCH to add on_quick_exit/quick_exit to std

2013-02-14 Thread Jason Merrill
On 02/14/2013 02:16 PM, Paolo Carlini wrote: ... or the below, just in case an interesting system provides the *quick_exit functions but doesn't define _GLIBCXX_USE_C99. It seems rather unlikely that the system would provide some C11 functions without the corresponding C99 ones. I'm just goin

Fix target/55941

2013-02-14 Thread Richard Henderson
During subreg1, we fail to split (insn 4 3 5 2 (set (reg:TI 63 [ x ]) (const_int 0 [0])) pr55941.c:2 85 {*movti_internal_rex64} (nil)) which leads to all the rest of the problems described in the PR. This happens because we read the mode from the CONST_INT, and unsurprisingly VOID

C++ PATCH for c++/52026 (use of enclosing constant var in lambda)

2013-02-14 Thread Jason Merrill
In this testcase, we see a use of a constant variable in a lambda (though the same thing can happen with a local class member function). We try to pull out the constant value in finish_id_expression, but because the initializer isn't a reduced constant yet, that fails and we end up just returni

Re: libsanitizer merge from upstream r175042

2013-02-14 Thread Konstantin Serebryany
On Thu, Feb 14, 2013 at 4:19 PM, Jakub Jelinek wrote: > On Thu, Feb 14, 2013 at 03:55:47PM +0400, Konstantin Serebryany wrote: >> The patch seems to work on a simple test. Let me digest it. >> I am trying to understand if there are problems with it other than the >> added complexity (which is what